nd/magic-pathspec exposes breakage in git-add--interactive on Windows

2013-08-29 Thread Johannes Sixt
With nd/magic-pathspec I get the following failure on Windows in t2016-checkout-patch.sh: expecting success: set_state dir/foo work head # the third n is to get out in case it mistakenly does not apply (echo y; echo n; echo n) | (cd dir git checkout -p foo)

Re: nd/magic-pathspec exposes breakage in git-add--interactive on Windows

2013-08-29 Thread Duy Nguyen
On Thu, Aug 29, 2013 at 1:54 PM, Johannes Sixt j.s...@viscovery.net wrote: With nd/magic-pathspec I get the following failure on Windows in t2016-checkout-patch.sh: expecting success: set_state dir/foo work head # the third n is to get out in case it mistakenly does not

Re: nd/magic-pathspec exposes breakage in git-add--interactive on Windows

2013-08-29 Thread Alex Riesen
On Thu, Aug 29, 2013 at 8:54 AM, Johannes Sixt j.s...@viscovery.net wrote: It looks like on Windows we disallow arguments that contain double-quote, colon, or asterisk, and otherwise wrap arguments in double-quotes if they contain space. Then pass them through qx{}, which I can only guess what