Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Junio C Hamano
Matthieu Moy writes: > There's an alternative: > > $ git rebase --edit-todo > # Make mistakes, save and quit > Your todo-list has the following issues: > - ... > Do you want to edit again (no aborts the rebase) [Y/n]? > > There's a precedent with the 'e' command of "git add -p". I have a > slight

Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Matthieu Moy
Remi Galan Alfonso writes: > Junio C Hamano writes: >> The place where an error can be introduced is (assuming that what >> "rebase -i" writes out itself is perfect ;-) where we allow the user >> to edit, so instead of checking before "--continue", I would expect >> a sane design would check imm

Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Remi Galan Alfonso
Matthieu Moy writes: > Remi Galan Alfonso writes: > > > Galan Rémi writes: > >> Shouldn't all the checking also be called in a 'rebase --continue', > >> considering that it can be called after a 'rebase --edit-todo' ? > >> (Right now it is only called after closing the editor in 'rebase -i') >

Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Junio C Hamano
Remi Galan Alfonso writes: > Galan Rémi writes: >> Shouldn't all the checking also be called in a 'rebase --continue', >> considering that it can be called after a 'rebase --edit-todo' ? >> (Right now it is only called after closing the editor in 'rebase -i') > > What's your opinion on it? > > S

Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Matthieu Moy
Remi Galan Alfonso writes: > Galan Rémi writes: >> Shouldn't all the checking also be called in a 'rebase --continue', >> considering that it can be called after a 'rebase --edit-todo' ? >> (Right now it is only called after closing the editor in 'rebase -i') > > What's your opinion on it? It w

Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Remi Galan Alfonso
Matthieu Moy writes: > Hi, > > Here are a few fixes to squash into the commits of the series. Other > than that, the series looks good to me. > > Junio: do you prefer a reroll or do you want to apply locally? > > Matthieu Moy (3): > fixup! git rebase -i: add static check for commands and SHA-

[PATCH 0/3] rebase -i: drop, missing commits and static checks

2015-06-30 Thread Matthieu Moy
Hi, Here are a few fixes to squash into the commits of the series. Other than that, the series looks good to me. Junio: do you prefer a reroll or do you want to apply locally? Matthieu Moy (3): fixup! git rebase -i: add static check for commands and SHA-1 fixup! git rebase -i: warn about rem

rebase -i: drop, missing commits and static checks

2015-06-29 Thread Galan Rémi
Changes between versions: In t3404: Changed 'test_rebase_end' to 'rebase_setup_and_clean'. Changed the indentation in 'rebase_setup_and_clean'. Changed the names of the branches created in my tests (avoid names like 'tmp'). Added 'test_might_fail' in front of 'git branch -D'. Remove 'test_config