Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-10-03 Thread Torsten Bögershausen
On 03.10.12 00:21, Junio C Hamano wrote: I think this should suffice. [snip] - test_must_fail git fsck --tags 2out - cat out - grep error in tag.*broken links out + test_must_fail git fsck --tags [snip] Thanks, and all TC passed in pu. /Torsten -- To unsubscribe from

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-10-02 Thread Torsten Bögershausen
On 09/19/2012 08:30 PM, Junio C Hamano wrote: Torsten Bögershausen tbo...@web.de writes: is a blob, not a commit is likely to come from validating of the tag 66f6581d that presumably point at 63499e4; it reads the tag, learns the name of the object that is tagged and the type of it, remembers

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-10-02 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: With help of Junio's comments I probably found the reason why the test behaves differently: The objects are checked in a certain order, based on the inode number. Which seems to be the same on most machines: when files are created in a certain

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-10-02 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: The last piece to expect error in tag.*broken links in the output is wrong. Probably we should remove the misguided check and end it with test_must_fail git fsck --tags. I think this should suffice. When we check tag T first, we make a mental note on

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-09-19 Thread Torsten Bögershausen
On 07/15/2012 11:08 AM, Jeff King wrote: On Sat, Jul 14, 2012 at 02:21:35PM +0200, Torsten Bögershausen wrote: I saw the problem first on pu, some time ago, but it dissappeared after cloning git.git into another directory. Now it appeared on next as well, so it's time to look a little bit

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-28 Thread Heiko Voigt
Hi, just to verify that this is unlikely just a hardware issue on one machine. I today experienced this failure on master as well. On Mon, Jul 16, 2012 at 06:06:26PM +0200, Torsten B?gershausen wrote: Am 16.07.2012 um 09:57 schrieb Thomas Rast: Torsten Bögershausen tbo...@web.de writes:

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-28 Thread Thomas Rast
Heiko Voigt hvo...@hvoigt.net writes: if (!git_index_file) { - git_index_file = xmalloc(strlen(git_dir) + 7); + git_index_file = xmalloc(strlen(git_dir) + 7 + 8); sprintf(git_index_file, %s/index, git_dir); } [...] - if

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-16 Thread Thomas Rast
Torsten Bögershausen tbo...@web.de writes: Now it appeared on next as well, so it's time to look a little bit deeper. This test case of t1450 fails: test_expect_success 'tag pointing to something else than its type' ' To debug more, I added an exit 0 here to inspect the file named out:

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-16 Thread Torsten Bögershausen
Am 16.07.2012 um 09:57 schrieb Thomas Rast: Torsten Bögershausen tbo...@web.de writes: Now it appeared on next as well, so it's time to look a little bit deeper. This test case of t1450 fails: test_expect_success 'tag pointing to something else than its type' ' To debug more, I added

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-15 Thread Jeff King
On Sat, Jul 14, 2012 at 02:21:35PM +0200, Torsten Bögershausen wrote: I saw the problem first on pu, some time ago, but it dissappeared after cloning git.git into another directory. Now it appeared on next as well, so it's time to look a little bit deeper. This test case of t1450 fails:

Re: t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-15 Thread Torsten Bögershausen
Peff, thanks for looking into this. My answers are inline and at the end. On 15.07.12 11:08, Jeff King wrote: On Sat, Jul 14, 2012 at 02:21:35PM +0200, Torsten Bögershausen wrote: I saw the problem first on pu, some time ago, but it dissappeared after cloning git.git into another

t1450-fsck (sometimes/often) failes on Mac OS X

2012-07-14 Thread Torsten Bögershausen
I saw the problem first on pu, some time ago, but it dissappeared after cloning git.git into another directory. Now it appeared on next as well, so it's time to look a little bit deeper. This test case of t1450 fails: test_expect_success 'tag pointing to something else than its type' ' To