Re: unused parameters in merge-recursive.c

On Fri, Oct 19, 2018 at 10:58:19AM -0700, Elijah Newren wrote: > > In most cases I've been trying to determine the "bug versus cruft" thing > > myself, but I fear that merge-recursive exceeds my abilities here. ;) > > These ones all look like cruft to me. I dug through them and tried > looking t

Re: unused parameters in merge-recursive.c

Hi Peff, On Fri, Oct 19, 2018 at 10:18 AM Jeff King wrote: > > Hi Elijah, > > Playing with -Wunused-parameters, I notice there are several functions > with unused parameters in merge-recursive.c. The patch below drops them > all. We know they're not being used, so it can&

unused parameters in merge-recursive.c

Hi Elijah, Playing with -Wunused-parameters, I notice there are several functions with unused parameters in merge-recursive.c. The patch below drops them all. We know they're not being used, so it can't make anything _worse_, but this is a good opportunity to confirm that they don&#