Re: verify_pack ignores return value of verify_fn

On Tue, Nov 17, 2015 at 07:31:55PM -0500, David Turner wrote: > In pack-check.c, line 129, a caller-supplied verification function is > called. The function returns an int, but that return value is ignored. > > The only caller of verify_pack is in builtin/fsck.c, whose verify_fn > *does* return

verify_pack ignores return value of verify_fn

In pack-check.c, line 129, a caller-supplied verification function is called. The function returns an int, but that return value is ignored. The only caller of verify_pack is in builtin/fsck.c, whose verify_fn *does* return a meaningful error code (which is then ignored). If it were not ignored,