Re: [PATCH 10/18] Put long code into a submodule

2013-06-06 Thread Eric Sunshine
On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr --- contrib/mw-to-git/git-remote-mediawiki.perl | 44 --- 1 file

Re: [PATCH 18/18] Clearly rewrite double dereference

2013-06-06 Thread Eric Sunshine
On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: @$var structures are re-written in the following way: @{ $var } It makes them more readable. Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr ---

Re: [PATCH 05/18] Turn double-negated expressions into simple expressions

2013-06-06 Thread Eric Sunshine
On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr --- contrib/mw-to-git/git-remote-mediawiki.perl |8 1 file changed, 4 insertions(+), 4

Re: [PATCH 11/18] Modify strings for a better coding-style

2013-06-06 Thread Eric Sunshine
On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: - strings which don't need interpolation are single-quoted for more clarity and slight gain of performance - interpolation is preferred over concatenation in many cases, for more clarity - variables are always

Re: [PATCH 02/18] Change style of some regular expressions to make them clearer

2013-06-06 Thread Eric Sunshine
On Thu, Jun 6, 2013 at 10:30 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: - if (my ($child, $parents) = $line =~ m/^-?([a-f0-9]+) ([a-f0-9 ]+)/) { - foreach my $parent (split(' ', $parents)) { +

Re: [PATCH 02/18] Change style of some regular expressions to make them clearer

2013-06-06 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Thu, Jun 6, 2013 at 10:30 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: - if (my ($child, $parents) = $line =~ m/^-?([a-f0-9]+) ([a-f0-9 ]+)/) { -

Re: [PATCH 10/18] Put long code into a submodule

2013-06-06 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr --- s/into a submodule/into a sub/; or subroutine.

Re: [PATCH] toposort: rename lifo field

2013-06-06 Thread Eric Sunshine
On Thu, Jun 6, 2013 at 7:25 PM, Junio C Hamano gits...@pobox.com wrote: When sorting commits topologically, the primary invariant is to emit all children before its parent is emitted. When traversing a forked history like this with git log C E: ABC \ DE we

[PATCH 0/3] Preparing for --date-order=author

2013-06-06 Thread Junio C Hamano
These three patches introduce a commit-queue API to manage a set of commits in a priority queue, with a caller-specified comparison function. The priority queue replaces the singly-listed commit_list in the topological sort function. The series applies on top of the commit-info-slab API sesries

[PATCH 3/3] sort-in-topological-order: use commit-queue

2013-06-06 Thread Junio C Hamano
Use the commit-queue data structure to implement a priority queue of commits sorted by committer date, when handling --date-order. The commit-queue structure can also be used as a simple LIFO stack, which is a good match for --topo-order processing. Signed-off-by: Junio C Hamano gits...@pobox.com

[PATCH 1/3] toposort: rename lifo field

2013-06-06 Thread Junio C Hamano
The primary invariant of sort_in_topological_order() is to emit all children before their parent is emitted. When traversing a forked history like this with git log C E: ABC \ DE we ensure that A is emitted after all of B, C, D, and E are done, B has to wait until C

[PATCH 2/3] commit-queue: LIFO or priority queue of commits

2013-06-06 Thread Junio C Hamano
Traditionally we used a singly linked list of commits to hold a set of in-flight commits while traversing history. The most typical use of the list is to insert commit that is newly discovered in it, keep it sorted by commit timestamp, pick up the newest one from the list, and keep digging. The

Re: [PATCH 1/3] toposort: rename lifo field

2013-06-06 Thread Eric Sunshine
On Fri, Jun 7, 2013 at 1:11 AM, Junio C Hamano gits...@pobox.com wrote: The primary invariant of sort_in_topological_order() is to emit all children before their parent is emitted. When traversing a forked s/parent is/parents are/ history like this with git log C E: ABC \

Re: [PATCH 1/3] toposort: rename lifo field

2013-06-06 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Fri, Jun 7, 2013 at 1:11 AM, Junio C Hamano gits...@pobox.com wrote: The primary invariant of sort_in_topological_order() is to emit all children before their parent is emitted. When traversing a forked s/parent is/parents are/ Hmm, not

Re: [PATCH 2/3] commit-queue: LIFO or priority queue of commits

2013-06-06 Thread Eric Sunshine
On Fri, Jun 7, 2013 at 1:11 AM, Junio C Hamano gits...@pobox.com wrote: Traditionally we used a singly linked list of commits to hold a set of in-flight commits while traversing history. The most typical use of the list is to insert commit that is newly discovered in it, keep s/commit/a

<    1   2