Re: Fwd: Error with git-svn pushing a rename

2013-12-25 Thread Roman Kagan
2013/12/25 Roman Kagan rka...@mail.ru:
 I've hit this problem too, and tracked it down to what I think is a
 bug in svn.
 [...]
 I'm going to submit a patch adding apr_pstrdup() to subversion folks.

http://thread.gmane.org/gmane.comp.version-control.subversion.devel/145186

Roman.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Fwd: Error with git-svn pushing a rename

2013-12-25 Thread Roman Kagan
2013/12/25 Roman Kagan rka...@mail.ru:
 2013/12/25 Roman Kagan rka...@mail.ru:
 I've hit this problem too, and tracked it down to what I think is a
 bug in svn.
 [...]
 I'm going to submit a patch adding apr_pstrdup() to subversion folks.

 http://thread.gmane.org/gmane.comp.version-control.subversion.devel/145186

FWIW the patch was accepted and committed in subversion trunk.

Nevertheless I'll submit the workaround to git-svn, too, as it's
harmless and may help some people (depending on the release cycles of
git and subversion).

Roman.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Fwd: Error with git-svn pushing a rename

2013-12-25 Thread Thomas Rast
Roman Kagan rka...@mail.ru writes:

 --- a/perl/Git/SVN/Editor.pm
 +++ b/perl/Git/SVN/Editor.pm
 @@ -304,8 +304,9 @@ sub C {
   my ($self, $m, $deletions) = @_;
   my ($dir, $file) = split_path($m-{file_b});
   my $pbat = $self-ensure_path($dir, $deletions);
 + my $upa = $self-url_path($m-{file_a});
   my $fbat = $self-add_file($self-repo_path($m-{file_b}), $pbat,
 - $self-url_path($m-{file_a}), $self-{r});
 + $upa, $self-{r});
   print \tC\t$m-{file_a} = $m-{file_b}\n unless $::_q;
   $self-chg_file($fbat, $m);
   $self-close_file($fbat,undef,$self-{pool});
 @@ -323,8 +324,9 @@ sub R {
   my ($self, $m, $deletions) = @_;
   my ($dir, $file) = split_path($m-{file_b});
   my $pbat = $self-ensure_path($dir, $deletions);
 + my $upa = $self-url_path($m-{file_a});
   my $fbat = $self-add_file($self-repo_path($m-{file_b}), $pbat,
 - $self-url_path($m-{file_a}), $self-{r});
 + $upa, $self-{r});
   print \tR\t$m-{file_a} = $m-{file_b}\n unless $::_q;
   $self-apply_autoprops($file, $fbat);
   $self-chg_file($fbat, $m);


 What it does is store the value to be passed to add_file() in a local
 variable, and rely on perl to keep it alive through the end of function
 scope, beyond the call to close_file() where it's actually used.

 I'm going to submit a patch adding apr_pstrdup() to subversion folks.
 Meanwhile if people find the above workarond a sensible thing to do in
 git, I can submit a properly formed patch here too.

If you go this way, please add a comment that explains why we need the
local variable.

-- 
Thomas Rast
t...@thomasrast.ch
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


german translation bug

2013-12-25 Thread Wolfgang Rohdewald
Arbeitsverzeichnis leer means
working directory empty which is obviously wrong.

It should say

Arbeitsverzeichnis sauber

wr@s5:~/src/linux$ git status
# Auf Zweig drm-intel-testing
Nichts zum Einreichen, Arbeitsverzeichnis leer
wr@s5:~/src/linux$ LANG=C git status
# On branch drm-intel-testing
nothing to commit, working directory clean



-- 
Wolfgang
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: german translation bug

2013-12-25 Thread Ralf Thielow
On Wed, Dec 25, 2013 at 8:53 PM, Wolfgang Rohdewald
wolfg...@rohdewald.de wrote:
 Arbeitsverzeichnis leer means
 working directory empty which is obviously wrong.

 It should say

 Arbeitsverzeichnis sauber

 wr@s5:~/src/linux$ git status
 # Auf Zweig drm-intel-testing
 Nichts zum Einreichen, Arbeitsverzeichnis leer
 wr@s5:~/src/linux$ LANG=C git status
 # On branch drm-intel-testing
 nothing to commit, working directory clean



This message is currently translated as nichts zu committen, Arbeitsverzeichnis
unverändert. Before it was translated as nichts einzutragen,
Arbeitsverzeichnis sauber.
According to the log of git.git, it was never translated as you wrote,
so it seems
that your system uses a different German translation than upstream Git.
What version of Git do you use? What distro in what version do you use?


 --
 Wolfgang
 --
 To unsubscribe from this list: send the line unsubscribe git in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: german translation bug

2013-12-25 Thread Wolfgang Rohdewald
Am Mittwoch, 25. Dezember 2013, 21:59:10 schrieb Ralf Thielow:
 What version of Git do you use? What distro in what version do you use?

freshly installed kubuntu 13.10. The package language-pack-de mentioned
at the end of this mail is installed.

I suppose I should open a KDE bug report?

i5:~ ((unknown)) git --version
git version 1.8.3.2

wr@s5:~/kajongg/src$ grep -a 'Nichts zum Einreichen' 
/usr/share/locale-langpack/de/LC_MESSAGES/git.mo 
Nichts zum Einreichen
Nichts zum Einreichen, Arbeitsverzeichnis leer

root@s5:~/kajongg/src# apt-file search /de/ | grep /git.mo
language-pack-de-base: /usr/share/locale-langpack/de/LC_MESSAGES/git.mo

root@s5:~/kajongg/src# LANG=C dpkg --info 
/var/cache/apt/archives/language-pack-de-base_1%3a13.10+20131012_all.deb
 new debian package, version 2.0.
 size 3346634 bytes: control archive=7323 bytes.
 955 bytes,19 lines  control  
   20278 bytes,   231 lines  md5sums  
 125 bytes, 9 lines   *  postinst #!/bin/sh
 121 bytes, 9 lines   *  postrm   #!/bin/sh
 Package: language-pack-de-base
 Version: 1:13.10+20131012
 Architecture: all
 Maintainer: Language pack maintainers language-pa...@ubuntu.com
 Installed-Size: 11247
 Pre-Depends: dpkg (= 1.10.27ubuntu1)
 Depends: locales (= 2.3.6), language-pack-de (= 1:13.10+20131012)
 Recommends: firefox-locale-de
 Conflicts: language-pack-de ( 1:13.10+20131012)
 Replaces: language-pack-de ( 1:13.10+20131012), language-pack-de-base ( 
1:13.10+20131012), language-pack-gnome-de ( 1:13.10+20131012), 
language-pack-gnome-de-base ( 1:13.10+20131012), language-pack-kde-de ( 
1:13.10+20131012), language-pack-kde-de-base ( 1:13.10+20131012)
 Section: translations
 Priority: optional
 Description: translations for language German
  Translation data for all supported packages for:
  German
  .
  This package provides the bulk of translation data and is updated
  only seldom. language-pack-de provides frequent
  translation updates, so you should install this as well.

-- 
Wolfgang
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: german translation bug

2013-12-25 Thread Wolfgang Rohdewald
Am Mittwoch, 25. Dezember 2013, 22:53:29 schrieb Wolfgang Rohdewald:
 I suppose I should open a KDE bug report?

I meant a ubuntu bug report of course.

-- 
Wolfgang
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v4 23/23] compat/mingw.h: Fix the MinGW and msvc builds

2013-12-25 Thread Erik Faye-Lund
On Sat, Dec 21, 2013 at 3:00 PM, Jeff King p...@peff.net wrote:
 From: Ramsay Jones ram...@ramsay1.demon.co.uk

 Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
 Signed-off-by: Junio C Hamano gits...@pobox.com
 Signed-off-by: Jeff King p...@peff.net
 ---
  compat/mingw.h | 1 +
  1 file changed, 1 insertion(+)

 diff --git a/compat/mingw.h b/compat/mingw.h
 index 92cd728..8828ede 100644
 --- a/compat/mingw.h
 +++ b/compat/mingw.h
 @@ -345,6 +345,7 @@ static inline char *mingw_find_last_dir_sep(const char 
 *path)
  #define PATH_SEP ';'
  #define PRIuMAX I64u
  #define PRId64 I64d
 +#define PRIx64 I64x


Please, move this before patch #8, and adjust the commit message.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: git fuse

2013-12-25 Thread Drew Northup
On Thu, Dec 19, 2013 at 4:15 PM, Thomas Koch tho...@koch.ro wrote:
 Hi,

 I'm thinking about using Git for web application deployment and thought that I
 wouldn't even need to checkout a worktree if I could access the bare git repo
 via fuse.

Thomas,
Given that gitweb (and more than a few other similar tools) doesn't
use FUSE and works on bare repositories I question why you think you'd
need (or want) to introduce the additional layer.

 What would be the performance impact? Once the files are in the filesystem 
 cache
 it shouldn't matter anymore, how fast the git fuse layer is, should it?

If your concern is caching, it should be implemented upon already
rendered / prepared objects whenever possible--frequently not a file
system level implementation. This is a design concern that has no
specific requirement whatsoever to do with FUSE (or for that matter,
with most of the VFS layer when accessing raw disk--as VFS itself is
highly optimized already).

I am not qualified to answer questions about FUSE use of the VFS cache.

I would strongly consider using a tool such as Varnish if you are
concerned about performance when serving static or semi-static content
(may it reside in a Git repo or elsewhere). The architectural concerns
of your web-app should probably guide your design in this sort of
direction anyway if it will be expected to sustain notable throughput
over time.

I hope that helps.

(If you want to discuss this further it would be worth considering if
your questions are Git questions or web-app design questions. The
latter should be taken elsewhere.)

-- 
-Drew Northup
--
As opposed to vegetable or mineral error?
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html