Re: [PATCH 2/4] t6030: explicitly test for bisection cleanup

On Wed, Jun 8, 2016 at 4:07 AM, Pranit Bauva wrote: > On Wed, Jun 8, 2016 at 4:51 AM, Eric Sunshine wrote: >> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >>> diff --git a/t/t6030-bisect-porcelain.sh

Re: [PATCH 3/4] dir: introduce file_size() to check the size of file

On Wed, Jun 8, 2016 at 3:57 AM, Pranit Bauva wrote: > On Wed, Jun 8, 2016 at 1:07 PM, Eric Sunshine wrote: >> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >>> dir: introduce file_size() to check the size of file >>>

Re: [PATCH v4 3/3] doc: more consistency in environment variables format

Johannes Sixt writes: > Also, you should investigate cases where "environment" is at the > beginning of a line, because then the variable name is most likely at > the end of the previous line. At the least, you missed an occurrence > of GIT_EXTERNAL_DIFF in diff-config.txt. In

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

Hey Eric, On Wed, Jun 8, 2016 at 1:32 PM, Eric Sunshine wrote: > On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote: >> On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine >> wrote: >>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit

Re: [PATCH 2/4] t6030: explicitly test for bisection cleanup

Hey Eric, On Wed, Jun 8, 2016 at 4:51 AM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> This is not an improvement in the test coverage but it helps in making >> it explicit as to what exactly would be the error as

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote: > On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine wrote: >> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >>> + struct string_list *refs = cb_data; >>> +

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: > Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` > subcommand to `git bisect--helper` to call it from git-bisect.sh . > > Using `bisect_reset` subcommand is a temporary measure to port shell >

Re: [PATCH 3/4] dir: introduce file_size() to check the size of file

Hey Eric, On Wed, Jun 8, 2016 at 1:07 PM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> dir: introduce file_size() to check the size of file >> >> At times we require to see if the file is empty and get the size of

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

Hey Eric, On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> Reimplement `bisect_clean_state` shell function in C and add a >> `bisect-clean-state` subcommand to `git bisect--helper` to

Re: [PATCH 3/4] dir: introduce file_size() to check the size of file

On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: > dir: introduce file_size() to check the size of file > > At times we require to see if the file is empty and get the size of the > file. By using stat we can get the file size without actually having to > open the file

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

Hi Pirate Praveen, On Tue, 7 Jun 2016, Pirate Praveen wrote: > On Tuesday 07 June 2016 04:00 PM, Johannes Schindelin wrote: > > Hi Pirate Praveen, > > > > On Tue, 7 Jun 2016, Pirate Praveen wrote: > > > >> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this > >> error (tests

Re: [PATCH v4 3/3] doc: more consistency in environment variables format

Am 08.06.2016 um 00:35 schrieb Tom Russello: Wrap with backticks (monospaced font) unwrapped or single-quotes wrapped (italic type) environment variables which are followed by the word "environment". It was obtained with: perl -pi -e "s/\'?(\\\$?[0-9A-Z\_]+)\'?(?= environment ?)/\`\1\`/g" *.txt

Re: [PATCH v4 3/3] doc: more consistency in environment variables format

Tom Russello writes: > Wrap with backticks (monospaced font) unwrapped or single-quotes wrapped > (italic type) environment variables which are followed by the word > "environment". It was obtained with: > > perl -pi -e "s/\'?(\\\$?[0-9A-Z\_]+)\'?(?= environment

Re: [PATCH 2/2] log: "--no-show-signature" commmand-line option

On Tue, Jun 7, 2016 at 12:20 AM, Junio C Hamano wrote: > Mehul Jain writes: > >> If "log.showSignature=true", then there is no way to override it using >> command line switch. >> >> Teach git-log and related commands about "--no-showSignature" command

<    1   2