Re: [PATCH 2/3] revision: exclude trees/blobs given commit

Jonathan Tan writes: > When the --objects argument is given to rev-list, an argument of the > form "^$tree" can be given to exclude all blobs and trees reachable from > that tree, but an argument of the form "^$commit" only excludes that > commit, not any blob or tree

Re: Typesafer git hash patch

On Tue, Feb 28, 2017 at 12:19 PM, brian m. carlson wrote: > > The bigger issue is the assumptions in the code base that assume a given > hash size. Absolutely. And I think those are going to be the "real" patches. I actually saw your status report about "After

Re: format-patch subject-prefix gets truncated when using the --numbered flag

Adrian Dudau writes: > I noticed that the --subject-prefix string gets truncated sometimes, > but only when using the --numbered flat. Here's an example: > > addu@sestofb11:/data/fb/addu/git$ export longm="very very very very > very very very very very very very very very

Re: SHA1 collisions found

Jeff King writes: > The first one is 98K. Mail headers may bump it over vger's 100K barrier. > It's actually the _least_ interesting patch of the 3, because it just > imports the code wholesale from the other project. But if it doesn't > make it, you can fetch the whole series

Re: 'git submodules update' ignores credential.helper config of the parent repository

On Tue, Feb 28, 2017 at 6:37 AM, Jeff King wrote: >> >> This would change the semantics of a config file as the attribute for >> each setting depends on the location (was attribute.FOO.read = >> {true, false} read before). > > I'm not enthused by this, just because there is a

Re: [PATCH] http: attempt updating base URL only if no error

On 02/28/2017 05:28 AM, Jeff King wrote: Right, your patch makes sense. A real HTTP error should take precedence over the url-update trickery. Acked-by: Jeff King Thanks! Running your included test, we get: fatal: unable to access 'http://127.0.0.1:5550/redir-to/502/':

Re: [PATCH 0/6] Use time_t

Am 28.02.2017 um 21:54 schrieb Johannes Schindelin: Hi Junio, On Tue, 28 Feb 2017, Junio C Hamano wrote: René Scharfe writes: Am 28.02.2017 um 15:28 schrieb Jeff King: It looks from the discussion like the sanest path forward is our own signed-64bit timestamp_t. That's

Re: SHA1 collisions found

Junio C Hamano writes: >> [1/3]: add collision-detecting sha1 implementation >> [2/3]: sha1dc: adjust header includes for git >> [3/3]: Makefile: add USE_SHA1DC knob > > I was lazy so I fetched the above and then added this on top before > I start to play with it. > > --

[PATCH] Travis: also test on 32-bit Linux

When Git v2.9.1 was released, it had a bug that showed only on Windows and on 32-bit systems: our assumption that `unsigned long` can hold 64-bit values turned out to be wrong. This could have been caught earlier if we had a Continuous Testing set up that includes a build and test run on 32-bit

Re: SHA1 collisions found

On Tue, Feb 28, 2017 at 11:07 AM, Junio C Hamano wrote: > > In a way similar to 8415558f55 ("sha1dc: avoid c99 > declaration-after-statement", 2017-02-24), we would want this on > top. There's a few other simplifications that could be done: (1) make the symbols static that

Re: SHA1 collisions found

On Tue, Feb 28, 2017 at 11:34 AM, Linus Torvalds wrote: > On Tue, Feb 28, 2017 at 11:07 AM, Junio C Hamano wrote: >> >> In a way similar to 8415558f55 ("sha1dc: avoid c99 >> declaration-after-statement", 2017-02-24), we would want this on >> top.

Re: [PATCH 0/6] Use time_t

René Scharfe writes: > Am 28.02.2017 um 15:28 schrieb Jeff King: > >> It looks from the discussion like the sanest path forward is our own >> signed-64bit timestamp_t. That's unfortunate compared to using the >> standard time_t, but hopefully it would reduce the number of knobs

Re: SHA1 collisions found

On Tue, Feb 28, 2017 at 11:07:37AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > >> [1/3]: add collision-detecting sha1 implementation > >> [2/3]: sha1dc: adjust header includes for git > >> [3/3]: Makefile: add USE_SHA1DC knob > > > > I was lazy so I

<    1   2