Re: Not understanding with git wants to copy one file to another

2017-08-10 Thread Harry Putnam
Stefan Beller writes: > On Thu, Aug 10, 2017 at 10:03 AM, Harry Putnam wrote: [...] Harry wrote: >> Here are two that are at least kind of similar but would never be seen >> as the same: >> >> < 192.168.1.43 m2.local.lan m2 #

Re: [PATCH v3 2/5] interpret-trailers: add an option to show only the trailers

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 11:28:52AM -0700, Stefan Beller wrote: > > +test_expect_success 'only trailers' ' > > + git config trailer.sign.command "echo config-value" && > > You may want to use 'test_config' here, which keeps the config > only for one test. The subsequent tests seem to

Re: [PATCH 0/5] make interpret-trailers useful for parsing

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 11:03 AM, Jeff King wrote: > On Thu, Aug 10, 2017 at 04:02:46AM -0400, Jeff King wrote: > >> On Wed, Aug 09, 2017 at 08:21:47AM -0400, Jeff King wrote: >> >> > This series teaches interpret-trailers to parse and output just the >> > trailers. So now you can

Re: Not understanding with git wants to copy one file to another

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 11:18 AM, Harry Putnam wrote: > Stefan Beller writes: > >> On Thu, Aug 10, 2017 at 10:03 AM, Harry Putnam wrote: > > [...] > > Harry wrote: >>> Here are two that are at least kind of similar but would never be

Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 11:47 AM, Kevin Willford wrote: > String formatting can be a performance issue when there are > hundreds of thousands of trees. When changing this for the sake of performance, could you give an example (which kind of repository you need for this to

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 02:36:41PM +0200, Mischa POSLAWSKY wrote: > Jeff King wrote: > > -#if LIBCURL_VERSION_NUM >= 0x071301 > > curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL); > > -#elif LIBCURL_VERSION_NUM >= 0x071101 > > curl_easy_setopt(result, CURLOPT_POST301, 1);

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 10:33 AM, Jeff King wrote: > On Thu, Aug 10, 2017 at 10:27:19AM -0700, Stefan Beller wrote: > >> > I'm not fond of that, as it's vague about which exact trailers we're >> > talking about. I also thought of something like --verbatim, but I'd >> > worry that

Re: fatal: Out of memory, getdelim failed under NFS mounts

2017-08-10 Thread Yaroslav Halchenko
Thank you Junio On Thu, 10 Aug 2017, Junio C Hamano wrote: > There is only one getdelim() call, which was introduced in v2.5.0 > timeframe, and it is used like this: > r = getdelim(>buf, >alloc, term, fp); > if (r > 0) { > sb->len = r; > return 0; >

[PATCH 9/9] Convert cache functions to size_t

2017-08-10 Thread Martin Koegler
From: Martin Koegler Signed-off-by: Martin Koegler --- cache-tree.c | 6 +++--- cache-tree.h | 2 +- cache.h | 6 +++--- convert.c | 18 +- environment.c | 4 ++-- read-cache.c | 18 +- 6 files

[PATCH 6/9] Use size_t for sha1

2017-08-10 Thread Martin Koegler
From: Martin Koegler Signed-off-by: Martin Koegler --- block-sha1/sha1.c | 2 +- block-sha1/sha1.h | 2 +- ppc/sha1.c| 2 +- ppc/sha1.h| 2 +- sha1dc_git.c | 2 +- sha1dc_git.h | 2 +- sha1dc_git_ext.h | 2 +- 7

[PATCH 8/9] Convert fsck.c & commit.c to size_t

2017-08-10 Thread Martin Koegler
From: Martin Koegler Signed-off-by: Martin Koegler --- builtin/replace.c | 2 +- commit.c | 14 +++--- commit.h | 8 fsck.c| 14 +++--- fsck.h| 2 +- 5 files changed, 20

[PATCH 5/9] Convert sha1_file.c to size_t

2017-08-10 Thread Martin Koegler
From: Martin Koegler Signed-off-by: Martin Koegler --- cache.h | 16 +++ sha1_file.c | 68 ++--- streaming.c | 2 +- 3 files changed, 43 insertions(+), 43 deletions(-)

Re: fatal: Out of memory, getdelim failed under NFS mounts

2017-08-10 Thread René Scharfe
Am 10.08.2017 um 16:43 schrieb Yaroslav Halchenko: > On Thu, 10 Aug 2017, René Scharfe wrote: >> Am 09.08.2017 um 19:39 schrieb Yaroslav Halchenko: >>> More context (may be different issue(s)) could be found at >>> http://git-annex.branchable.com/forum/git-annex_add_out_of_memory_error/ >>> but

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 12:39 PM, Christian Couder wrote: > On Thu, Aug 10, 2017 at 8:37 PM, Jeff King wrote: >> On Thu, Aug 10, 2017 at 11:35:00AM -0700, Stefan Beller wrote: >> >>> On Thu, Aug 10, 2017 at 1:03 AM, Jeff King wrote: >>>

Re: [PATCH 0/5] make interpret-trailers useful for parsing

2017-08-10 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Aug 10, 2017 at 11:03 AM, Jeff King wrote: >> On Thu, Aug 10, 2017 at 04:02:46AM -0400, Jeff King wrote: >> >>> On Wed, Aug 09, 2017 at 08:21:47AM -0400, Jeff King wrote: >>> >>> > This series teaches interpret-trailers to parse

Re: [PATCH] commit: skip discarding the index if there is no pre-commit hook

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 02:54:16PM -0400, Kevin Willford wrote: > If there is not a pre-commit hook, there is no reason to discard > the index and reread it. > > This change checks to presence of a pre-commit hook and then only > discards the index if there was one. Sounds like a smart

Re: [PATCH] t1200: remove t1200-tutorial.sh

2017-08-10 Thread Junio C Hamano
Johannes Schindelin writes: > Hi, > > On Wed, 9 Aug 2017, Stefan Beller wrote: > >> v1.2.0~121 (New tutorial, 2006-01-22) rewrote the tutorial such that the >> original intent of 2ae6c70674 (Adapt tutorial to cygwin and add test case, >> 2005-10-13) to test the

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-10 Thread Christian Couder
On Thu, Aug 10, 2017 at 8:37 PM, Jeff King wrote: > On Thu, Aug 10, 2017 at 11:35:00AM -0700, Stefan Beller wrote: > >> On Thu, Aug 10, 2017 at 1:03 AM, Jeff King wrote: >> > The point of "--only-trailers" is to give a caller an output >> > that's easy for them to

Re: [PATCH 4/5] interpret-trailers: add an option to normalize output

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 09:39:21PM +0200, Christian Couder wrote: > > If you prefer the normalized form (and the input was line-broken in a > > way that you don't like), then this would convert to your preferred > > form. I agree that you could potentially want the opposite (folding long > >

Re: [PATCH 0/4] dropping support for older curl

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 07:09:02PM -0400, Jeff King wrote: > The first is "should we eventually drop support for antiquated versions > of dependencies?". And the argument in favor is the one I was making > here: besides lowering maintenance cost, it is more honest to our users > about what to

Re: Dropping support for older perl

2017-08-10 Thread Tom G. Christensen
On 09/08/17 15:38, Ævar Arnfjörð Bjarmason wrote: RHEL/CentOS 5.x has perl 5.8.8, but it also has curl 7.15.5[1] which is obseleted by these curl patches. Maybe we'd want to be more conservative with perl for whatever reason, but I'd like to at least bump our requirenment of 5.8.0 to 5.8.8.

[PATCH] win32: plug memory leak on realloc() failure in syslog()

2017-08-10 Thread René Scharfe
If realloc() fails then the original buffer is still valid. Free it before exiting the function. Signed-off-by: Rene Scharfe --- compat/win32/syslog.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compat/win32/syslog.c b/compat/win32/syslog.c index 6c7c9b6053..161978d720

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-10 Thread Mischa POSLAWSKY
Jeff King wrote: > -#if LIBCURL_VERSION_NUM >= 0x071301 > curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL); > -#elif LIBCURL_VERSION_NUM >= 0x071101 > curl_easy_setopt(result, CURLOPT_POST301, 1); > -#endif This seems to be an unintended behavioural change: the second

<    1   2