[PATCH v2 2/3] config: respect `pager.config` in list/get-mode only

Similar to de121ffe5 (tag: respect `pager.tag` in list-mode only, 2017-08-02), use the DELAY_PAGER_CONFIG-mechanism to only respect `pager.config` when we are listing or "get"ing config. We have several getters and some are guaranteed to give at most one line of output. Paging all getters

Re: [PATCH 00/36] object_id part 12

"brian m. carlson" writes: > This is the twelfth in a series of patches to convert from unsigned char > [20] to struct object_id. This series is based on next. > > Included in this series are conversions for find_unique_abbrev and > lookup_replace_object, as well

Re: [PATCH v7 0/7] convert: add support for different encodings

> On 16 Feb 2018, at 19:55, Junio C Hamano wrote: > > Jeff King writes: > >> So a full proposal would support both cases: "check this out in the >> local platform's preferred encoding" and "always check this out in >> _this_ encoding". And Lars's proposal is

Re: [PATCH 2/2] ref-filter: get rid of goto

Olga Telezhnaya writes: > Get rid of goto command in ref-filter for better readability. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- >

Re: [PATCH 1/2] ref-filter: get rid of duplicate code

Olga Telezhnaya writes: > Make one function from 2 duplicate pieces and invoke it twice. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- >

Re: Duplicate safecrlf warning for racily clean index entry

Matt McCutchen writes: > ... may be an important optimization.) If the line endings are changed > without changing the size or post-conversion content, then no unstaged > change is reported. It does not appear that git saves the pre- > conversion content. Correct. The

Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values

Phillip Wood writes: > Keeping the permission bits makes sense (I'd not thought of them when > I created the patch) as we want to check that the file has the correct > permissions. As for the all-zero object name, is it really worth > leaving it in - if a file has been

Re: [PATCH] t/known-leaky: add list of known-leaky test scripts

Martin Ågren writes: > On 19 February 2018 at 22:29, Jeff King wrote: > ... >> Or alternatively, we could just not bother with checking this into the >> repository, and it becomes a local thing for people interested in >> leak-testing. What's the value in

RE: Stackdump from stash save on Windows 10 64-bit

Hi Tim, I re-Cc:ed the Git mailing list, as I do not like the pressure of being the only one you ask for help. On Wed, 21 Feb 2018, Tim Mayo wrote: > > Can you please test with v2.16.2 > > Is there a built version somewhere .. or do I have to build it myself? Yes, official Git for Windows

Re: Question about get_cached_commit_buffer()

On 2/20/2018 5:57 PM, Jeff King wrote: On Tue, Feb 20, 2018 at 05:12:50PM -0500, Derrick Stolee wrote: In rev-list, the "--header" option outputs a value and expects the buffer to be cached. It outputs the header info only if get_cached_commit_buffer() returns a non-null buffer, giving

Re: Duplicate safecrlf warning for racily clean index entry

On Wed, 2018-02-21 at 08:53 +0100, Torsten Bögershausen wrote: > I don't hava a pointer, but what should happen ? > 2 warnings for 2 "git add" should be OK, I think. > > 1 warning is part of the optimization, that Git does to handle > hundrets and thousands of files efficciently. > > Is the 1/2

Re: Duplicate safecrlf warning for racily clean index entry

On Tue, 2018-02-20 at 08:42 -0500, Matt McCutchen wrote: > In either case, if "git update-index --refresh" (or "git status") is > run before "git add", then "git add" does not print the warning. On > the other hand, if line endings in the working tree file are changed, > then git shows the file

Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-20 15:00 GMT-03:00 Junio C Hamano : > It would make more sense (if we were to add > an option to run any hook we currently do not run to the command) to > run pre-revert/revert-msg hooks instead, and then people who happen > to want to do the same thing in these hooks

[ANNOUNCE] Git Rev News edition 36

Hi everyone, The 36th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/02/21/edition-36/ Thanks a lot to all the contributors! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values

On 20/02/18 17:39, Junio C Hamano wrote: Phillip Wood writes: From: Phillip Wood Purge the index lines from diffs so we're not hard coding sha1 hash values in the expected output. The motivation of this patch is clear, but all-zero

Re: [PATCH v2 5/9] t3701: add failing test for pathological context lines

On 19/02/18 11:29, Phillip Wood wrote: From: Phillip Wood When a hunk is skipped by add -i the offsets of subsequent hunks are not adjusted to account for any missing insertions due to the skipped hunk. Most of the time this does not matter as apply uses the context

Re: [PATCH v2 3/9] t3701: use test_write_lines and write_script

On 20/02/18 17:19, Junio C Hamano wrote: Eric Sunshine writes: test_expect_success 'setup fake editor' ' - echo "#!$SHELL_PATH" >fake_editor.sh && - cat >>fake_editor.sh <<-\EOF && + FAKE_EDITOR="$(pwd)/fake-editor.sh" && + write_script

Re: Git should preserve modification times at least on request

On Tue, Feb 20, 2018 at 2:05 PM, Peter Backes wrote: > Hi Jeff, > > On Tue, Feb 20, 2018 at 04:16:34PM -0500, Jeff King wrote: >> I think there are some references buried somewhere in that wiki, but did >> you look at any of the third-party tools that store file metadata

test bare repository for unit tests

Hi. I want to the test-repo-git under https://github.com/apache/maven-wagon/tree/master/wagon-providers/wagon-scm/src/test/resources/ just like test-repo-cvs and test-repo-svn Which configuation options would suit that? I think core.compression 0 for human readable diffs. also, I need to force

<    1   2