Re: [PATCH 2/2] send-email: supply a --send-delay=1 by default

2018-03-25 Thread Junio C Hamano
"brian m. carlson" writes: > I'm not sure that this is going to have the effect you want it to have. > Let me give an example to demonstrate why. > ... > In short, I don't think this is going to be especially helpful because > it won't change the status quo for a

Re: [PATCH 2/2] send-email: supply a --send-delay=1 by default

2018-03-25 Thread Junio C Hamano
Eric Sunshine writes: > A minor point: Are you sure that it's git-format-patch that's being > careful about arranging Date: to display in the desired order, and not > git-send-email? Looking at old patches I still have hanging around > which were created with

Re: [PATCH v4 3/7] gc: add --keep-largest-pack option

2018-03-25 Thread Junio C Hamano
Duy Nguyen writes: >> This conflicts with master because of your own 7e1eeaa431 ("completion: >> use __gitcomp_builtin in _git_gc", 2018-02-09). I pushed out a >> avar-pclouds/gc-auto-keep-base-pack branch to github.com/avar/git which >> resolves it as: >> >> @@ -365,6

Re: [PATCH 00/10] Hash-independent tests (part 1)

2018-03-25 Thread Eric Sunshine
On Sun, Mar 25, 2018 at 3:20 PM, brian m. carlson wrote: > This is a series to make our tests hash-independent. Many tests have > hard-coded SHA-1 values in them, and it would be valuable to express > these items in a hash-independent way for our hash transitions. >

Re: [PATCH v2 00/36] Combine t/helper binaries into a single one

2018-03-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > v2 fixes a couple of typos in commit messages and use the cmd__ prefix > for test commands instead of test_, which avoids a naming conflict > with the existing function test_lazy_init_name_hash > > [the previous v2 send out was aborted because I

<    1   2