Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 19 +--
Documentation/config/alias.txt | 18 ++
2 files changed, 19 insertions(+), 18 deletions(-)
create mode 100644 Documentation/config/alias.txt
diff --git a/Documentation/config.txt
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt| 27 +--
Documentation/config/credential.txt | 26 ++
2 files changed, 27 insertions(+), 26 deletions(-)
create mode 100644 Documentation/config/credential.txt
diff
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 21 +
Documentation/config/gpg.txt | 20
2 files changed, 21 insertions(+), 20 deletions(-)
create mode 100644 Documentation/config/gpg.txt
diff --git a/Documentation/config.txt
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 25 +
Documentation/config/grep.txt | 24
2 files changed, 25 insertions(+), 24 deletions(-)
create mode 100644 Documentation/config/grep.txt
diff --git
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 22 +-
Documentation/config/blame.txt | 21 +
2 files changed, 22 insertions(+), 21 deletions(-)
create mode 100644 Documentation/config/blame.txt
diff --git
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt| 103 +---
Documentation/config/branch.txt | 102 +++
2 files changed, 103 insertions(+), 102 deletions(-)
create mode 100644 Documentation/config/branch.txt
diff
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 15 +--
Documentation/config/difftool.txt | 14 ++
2 files changed, 15 insertions(+), 14 deletions(-)
create mode 100644 Documentation/config/difftool.txt
diff --git a/Documentation/config.txt
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/config.txt | 272 +-
Documentation/config/http.txt | 271 +
2 files changed, 272 insertions(+), 271 deletions(-)
create mode 100644 Documentation/config/http.txt
diff
On Fri, Oct 26, 2018 at 09:20:56PM +0200, Ævar Arnfjörð Bjarmason wrote:
> >> I was thinking:
> >>
> >> $ git var -e GIT_WHATEVER_ENV
> >>
> >> [-e for environment].
> >>
> >> ... but that is really no different than git-config. ;-)
> >
> > Actually, "git var" already does pull bits from the
On Sat, Oct 27, 2018 at 09:09:55AM +0200, Nguyễn Thái Ngọc Duy wrote:
> static inline struct thread_local *get_thread_data(void)
> {
> -#ifndef NO_PTHREADS
> - if (threads_active)
> - return pthread_getspecific(key);
> - assert(!threads_active &&
> -"This should
On Sat, Oct 27, 2018 at 09:09:53AM +0200, Nguyễn Thái Ngọc Duy wrote:
> People seemed to support the idea of removing these #ifdef NO_PTHREADS [1]
> so this is a complete series. I left the #ifdef in run-command.c and
> transport-helper.c because those code looked complicated so perhaps we
>
On Sat, Oct 27, 2018 at 09:09:54AM +0200, Nguyễn Thái Ngọc Duy wrote:
> +/*
> + * macros instead of typedefs because pthread definitions may have
> + * been pulled in by some system dependencies even though the user
> + * wants to disable pthread.
> + */
> +#define pthread_t int
> +#define
On Sat, Oct 27, 2018 at 09:09:59AM +0200, Nguyễn Thái Ngọc Duy wrote:
> diff --git a/builtin/grep.c b/builtin/grep.c
> index d8508ddf79..29221e1003 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -34,7 +34,6 @@ static int recurse_submodules;
> #define GREP_NUM_THREADS_DEFAULT 8
>
On Sat, Oct 27, 2018 at 09:09:53AM +0200, Nguyễn Thái Ngọc Duy wrote:
> People seemed to support the idea of removing these #ifdef NO_PTHREADS [1]
> so this is a complete series. I left the #ifdef in run-command.c and
> transport-helper.c because those code looked complicated so perhaps we
>
SZEDER Gábor writes:
> On Mon, Oct 22, 2018 at 05:36:33PM +0200, Nguyễn Thái Ngọc Duy wrote:
>>
>> The current gettext() function just replaces all strings with
>> '# GETTEXT POISON #' including format strings and hides the things
>> that we should be allowed to grep (like branch names, or some
Johannes Schindelin writes:
> Just one thing^W^Wa couple of things:
>
> It would probably make more sense to `hashmap_get_from_hash()` and
> `strhash()` here (and `strhash()` should probably be used everywhere
> instead of `memhash(str, strlen(str))`).
hashmap_get_from_hash() certainly is much
On Sat, Oct 27, 2018 at 04:12:40PM +0900, Junio C Hamano wrote:
> > Yeah, I agree that would be fine, too. I think there are two dimensions
> > in which to look at the problem, like so:
> >
> > rev-list rev-parse
> > -
> > --globclearsclears
> > --all
Stefan Beller writes:
>>
>> * sb/strbuf-h-update (2018-09-29) 1 commit
>> (merged to 'next' on 2018-10-26 at e4ad935cb0)
>> + strbuf.h: format according to coding guidelines
>>
>> Code clean-up to serve as a BCP example.
>>
>> Will merge to 'master'.
>> Further clean-up patches may need to
On Sat, Oct 27, 2018 at 09:40:13AM +0200, Duy Nguyen wrote:
> > We expect to be able to store a void pointer here and get it back, which
> > should work even for a single thread. Do we need something like:
> >
> > extern void *pthread_specific_data;
> >
> > #define pthread_setspecific(key,
Derrick Stolee writes:
> In an effort to ensure new code is reasonably covered by the test
> suite, we now have contrib/coverage-diff.sh to combine the gcov output
> from 'make coverage-test ; make coverage-report' with the output from
> 'git diff A B' to discover _new_lines of code that are not
"brian m. carlson" writes:
> SHA-1 is weak and we need to transition to a new hash function. For
> some time, we have referred to this new function as NewHash. Recently,
> we decided to pick SHA-256 as NewHash.
Even if we have decided to not repeat the reasoning behind the need to
switch away
On Sat, Oct 27, 2018 at 10:15 AM Jeff King wrote:
>
> On Sat, Oct 27, 2018 at 09:40:13AM +0200, Duy Nguyen wrote:
>
> > > We expect to be able to store a void pointer here and get it back, which
> > > should work even for a single thread. Do we need something like:
> > >
> > > extern void
On Wed, Oct 24, 2018 at 4:55 PM Christophe Bliard
wrote:
>
> Hi,
>
> I observed an unexpected behavior while using git grep with both git
> 2.19.1 and 2.14.3.
Quick note. I confirm this is a bug in tree_entry_interesting()
perhaps being over-optimistic. It'll take me more time to familiarize
In an effort to ensure new code is reasonably covered by the test suite,
we now have contrib/coverage-diff.sh to combine the gcov output from
'make coverage-test ; make coverage-report' with the output from 'git
diff A B' to discover _new_lines of code that are not covered. This
report ignores
On Sat, Oct 27, 2018 at 11:34 AM Jeff King wrote:
> Taking one step back, the root problem in this thread is that stat() on
> non-existing files is slow (which makes has_sha1_file slow).
>
> One solution there is to cache the results of looking in .git/objects
> (or any alternate object store)
On Sat, Oct 27, 2018 at 10:13 AM Jeff King wrote:
>
> On Sat, Oct 27, 2018 at 09:09:53AM +0200, Nguyễn Thái Ngọc Duy wrote:
>
> > People seemed to support the idea of removing these #ifdef NO_PTHREADS [1]
> > so this is a complete series. I left the #ifdef in run-command.c and
> >
Signed-off-by: Nguyễn Thái Ngọc Duy
---
builtin/pack-objects.c | 26 ++
pack-objects.h | 6 --
2 files changed, 2 insertions(+), 30 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index b059b86aee..12edd6da16 100644
---
When built with NO_PTHREADS, the macros are used make the code build
even though pthreads header and library may be missing. The code can
still have different code paths for no threads support with
HAVE_THREADS variable.
There are of course impacts on no-pthreads builds:
- data structure may get
Signed-off-by: Nguyễn Thái Ngọc Duy
---
preload-index.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/preload-index.c b/preload-index.c
index 9e7152ab14..0e24886aca 100644
--- a/preload-index.c
+++ b/preload-index.c
@@ -7,17 +7,7 @@
#include "fsmonitor.h"
It was reported that when building with NO_PTHREADS=1,
-Wmaybe-uninitialized is triggered. Just initialize the variable from
the beginning to shut the compiler up (because this warning is enabled
in config.dev)
Signed-off-by: Nguyễn Thái Ngọc Duy
---
read-cache.c | 4 +---
1 file changed, 1
Signed-off-by: Nguyễn Thái Ngọc Duy
---
builtin/index-pack.c | 68
1 file changed, 18 insertions(+), 50 deletions(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index 2004e25da2..bbd66ca025 100644
--- a/builtin/index-pack.c
+++
The send-pack.c patch is dropped since it's tied to async code and
like transport-helper.c (or more cleanups in index-pack.c) could be
left for later.
I added one more patch to shut up -Wmaybe-uninitialized but since I
could not reproduce it, Jeff would need to verify if it works for him.
Nguyễn
Signed-off-by: Nguyễn Thái Ngọc Duy
---
read-cache.c | 49 ++---
1 file changed, 18 insertions(+), 31 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index d57958233e..ba870bc3fd 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1920,19 +1920,15
Signed-off-by: Nguyễn Thái Ngọc Duy
---
builtin/grep.c | 59 +++---
grep.c | 6 -
grep.h | 6 -
3 files changed, 22 insertions(+), 49 deletions(-)
diff --git a/builtin/grep.c b/builtin/grep.c
index d8508ddf79..6dd15dbaa2
Normally pthread_create() rarely fails and sometimes error handling
can be neglected. But with new pthreads wrapper, pthread_create() will
return ENOSYS on a system without thread support.
Threaded code _is_ protected by HAVE_THREADS and pthread_create()
should never run in the first place. But
Signed-off-by: Nguyễn Thái Ngọc Duy
---
name-hash.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/name-hash.c b/name-hash.c
index 1fcda73cb3..b3c9ac791d 100644
--- a/name-hash.c
+++ b/name-hash.c
@@ -7,6 +7,7 @@
*/
#define
Signed-off-by: Nguyễn Thái Ngọc Duy
---
attr.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/attr.c b/attr.c
index 60d284796d..eaece6658d 100644
--- a/attr.c
+++ b/attr.c
@@ -41,23 +41,17 @@ const char *git_attr_name(const struct git_attr *attr)
struct attr_hashmap {
use "GIT_HTTP_EXPORT_ALL" => "1" with a value for best compatiblity.
lighttpd 1.4.51 setenv.add-environment does add vars with empty value.
lighttpd setenv.set-environment does, but was only introduced in 1.4.46
git-http-backend may be found at /usr/libexec/git-core/git-http-backend
scope
Something fishy is going on but I don't think I'll spend time hunting
it down so I post here in case somebody else is interested. It might
also indicate a problem with poison gettext, not the test case too.
--
Duy
On 10/27/2018 9:55 AM, Junio C Hamano wrote:
Derrick Stolee writes:
Uncovered in mater not in master@{1}
Does this typo indicate that some part of the process to produce and
send out this report involve manual editing?
I kick off four builds with on
edit_todo_list() is changed to work on a todo_list, and to handle the
initial edition of the todo list (ie. making a backup of the todo
list).
It does not check for dropped commits yet, as todo_list_check() does not
take the commits that have already been processed by the rebase (ie. the
todo
This refactors sequencer_add_exec_commands() to work on a todo_list to
avoid redundant reads and writes to the disk.
An obvious way to do this would be to insert the `exec' command between
the other commands, and reparse it once this is done. This is not what
is done here. Instead, the command
This changes complete_action() to use edit_todo_list(), now that it can
handle the initial edit of the todo list.
Signed-off-by: Alban Gruin
---
sequencer.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index
This introduce a new function to recreate the text of a todo list from
its commands, and then to write it to the disk. This will be useful in
the future, the buffer of a todo list won’t be treated as a strict
mirror of the todo file by some of its functions once they will be
refactored.
This
complete_action() used functions that read the todo-list file, made some
changes to it, and wrote it back to the disk.
The previous commits were dedicated to separate the part that deals with
the file from the actual logic of these functions. Now that this is
done, we can call directly the
This refactors skip_unnecessary_picks() to work on a todo_list. The
file-handling logic is completely dropped here, as its only usage is
made by complete_action().
Instead of truncating the todo list’s buffer, the items are moved to
the beginning of the list, eliminating the need to reparse the
This refactors check_todo_list() to work on a todo_list to avoid
redundant reads and writes to the disk. The function is renamed
todo_list_check(). The parsing of the two todo lists is left to the
caller.
As rebase -p still need to check the todo list from the disk, a new
function is
This makes sequencer_make_script() write its script to a strbuf (ie. the
buffer of a todo_list) instead of a FILE. This reduce the amount of
read/write made by rebase interactive.
Signed-off-by: Alban Gruin
---
builtin/rebase--interactive.c | 13 +++-
sequencer.c | 38
This moves the writing of the comment "Rebase $shortrevisions onto
$shortonto ($command_count commands)" from complete_action() to
append_todo_help().
shortrevisions, shortonto, and command_count are passed as parameters to
append_todo_help().
During the initial edit of the todo list,
Just like complete_action(), edit_todo_list() used a
function (transform_todo_file()) that read the todo list from the disk
and wrote it back, resulting in useless disk accesses.
This changes edit_todo_list() to call directly todo_list_write_to_file()
instead.
Signed-off-by: Alban Gruin
---
As transform_todo_file() is only needed inside of rebase--interactive.c,
it is moved there from sequencer.c.
Signed-off-by: Alban Gruin
---
builtin/rebase--interactive.c | 20
sequencer.c | 20
sequencer.h | 1 -
3
This replaces a call to error() by a call to error_errno() after writing
the content of the todo list to the disk in transform_todo_file().
Signed-off-by: Alban Gruin
---
No changes since v1, was commit 14/15.
sequencer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This refactors rearrange_squash() to work on a todo_list to avoid
redundant reads and writes. The function is renamed
todo_list_rearrange_squash().
The old version created a new buffer, which was directly written to the
disk. This new version creates a new item list by just memcpying items
from
This clears the number of items of a todo_list before parsing it to
allow to parse the same list multiple times without issues. As its
items are not dynamically allocated, or don’t need to allocate memory,
no additionnal memory management is required here.
Furthermore, if a line is invalid, the
This refactors transform_todos() to work on a todo_list. The function
is renamed todo_list_transform().
As rebase -p still need to check the todo list from the disk, a new
function is introduced, transform_todo_file(). It is still used by
complete_action() and edit_todo_list() for now, but they
At the center of the "interactive" part of the interactive rebase lies
the todo list. When the user starts an interactive rebase, a todo list
is generated, presented to the user (who then edits it using a text
editor), read back, and then is checked and processed before the actual
rebase takes
This makes the structures todo_list and todo_item, and the functions
todo_list_release() and parse_insn_buffer(), accessible outside of
sequencer.c.
Signed-off-by: Alban Gruin
---
No changes since v1.
sequencer.c | 66 +
sequencer.h | 48
On Sat, Oct 27, 2018 at 09:27:21AM -0400, Derrick Stolee wrote:
> In an effort to ensure new code is reasonably covered by the test suite, we
> now have contrib/coverage-diff.sh to combine the gcov output from 'make
> coverage-test ; make coverage-report' with the output from 'git diff A B' to
>
101 - 158 of 158 matches
Mail list logo
