Test failures in t4034

2012-08-18 Thread Brian Gernhardt
I've been getting a couple of test failures and finally had the time to track them down. t4034-diff-words fails tests 22 diff driver 'bibtex' and 26 diff driver 'html'. Bisecting shows that the file started giving me errors in commit 8d96e72 t4034: bulk verify builtin word regex sanity, which

[PATCH 2/2] git-gui: remove .git/CHERRY_PICK_HEAD after committing

2012-08-18 Thread Beat Bolli
Adding __git_ps1() to one's bash prompt displays various repo status info after each command. After committing a git cherry-pick -n using git-gui, the prompt still contains the |CHERRY-PICKING flag. Delete the file causing this flag when cleaning up. Signed-off-by: Beat Bolli bbo...@ewanet.ch

[PATCH 1/2] git-gui: Fix a loose/lose mistake

2012-08-18 Thread Beat Bolli
No po update needed, as this string is untranslated. Signed-off-by: Beat Bolli bbo...@ewanet.ch --- git-gui/lib/commit.tcl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl index 0d81432..78c5eeb 100644 ---

Problems with git fetch confusing foo and foo.git repos

2012-08-18 Thread Richard Purdie
A while ago I reported a problem[1] where having: /somewhere/foo and /somewhere/foo.git as bare repositories and trying to clone them using alternates could cause git to confuse them. The conclusion was that I needed to do: git clone -s -n /somewhere/foo/ x to stop it looking at the .git

Re: [PATCH] test: some testcases failed if cwd is on a symlink

2012-08-18 Thread Michael Haggerty
Junio C Hamano gitster at pobox.com writes: Jiang Xin worldhello.net at gmail.com writes: Run command 'git rev-parse --git-dir' under subdir will return realpath of '.git' directory. Some test scripts compare this realpath against $TRASH_DIRECTORY, they are not equal if current working

Re: Problems with git fetch confusing foo and foo.git repos

2012-08-18 Thread Richard Purdie
On Sat, 2012-08-18 at 15:25 +0100, Richard Purdie wrote: A while ago I reported a problem[1] where having: /somewhere/foo and /somewhere/foo.git as bare repositories and trying to clone them using alternates could cause git to confuse them. The conclusion was that I needed to do:

[RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change

2012-08-18 Thread mhagger
From: Michael Haggerty mhag...@alum.mit.edu On 08/17/2012 01:29 AM, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: I like the general direction. Perhaps a long distant future direction could be to also use the same trick in the ref namespace so that we can have 'next' branch

[PATCH 0/2] Fix two minor problems in the docs for git-config

2012-08-18 Thread mhagger
From: Michael Haggerty mhag...@alum.mit.edu This is just something I stumbled across. Michael Haggerty (2): git-config.txt: properly escape quotation marks in example git-config.txt: fix example Documentation/git-config.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --

[PATCH 1/2] git-config.txt: properly escape quotation marks in example

2012-08-18 Thread mhagger
From: Michael Haggerty mhag...@alum.mit.edu In the example line as written, gitproxy=proxy-command for kernel.org the quotation marks are eaten by the config-file parser. From the history, it looks like this example wanted to have quotation marks in the actual configured value. So

[RFC 0/2] svn-fetch|push - an alternate approach

2012-08-18 Thread James R. McKaskill
This is sort of an RFC/ANN. There has been a whole bunch of traffic of late on git-svn, vcs-svn, the remote helper, etc. I would like to present an alternate solution that I've been playing with for a couple of weeks. I work in a team that uses a mixture of git-svn and svn proper. Whilst it works

[RFC 2/2] add tests for git svn-fetch|push

2012-08-18 Thread James R. McKaskill
From: James R. McKaskill ja...@foobar.co.nz Signed-off-by: James R. McKaskill ja...@foobar.co.nz --- t/lib-git-svn-fetch.sh | 131 +++ t/t9050-git-svn-fetch.sh| 85 +++ t/t9051-git-svn-fetch-branch.sh | 245 t/t9052-git-svn-push.sh |

[PATCH 2/2] git-config.txt: fix example

2012-08-18 Thread mhagger
From: Michael Haggerty mhag...@alum.mit.edu The --add option is required to add a new value to a multivalued configuration entry. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- Documentation/git-config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH/RFC v4 01/16] GSOC remote-svn

2012-08-18 Thread Florian Achleitner
On Friday 17 August 2012 21:16:59 Junio C Hamano wrote: Comments from mentors and people interested in remote helpers? I did minimum line wrapping, typofix and small compilation fixes and queued these on 'pu'; I think I saw one commit whose message I didn't quite get what it was trying to

Re: [RFC 1/5] GSOC: prepare svndump for branch detection

2012-08-18 Thread David Michael Barr
On Sat, Aug 18, 2012 at 6:40 AM, Florian Achleitner florian.achleitner.2.6...@gmail.com wrote: Hi! This patch series should prepare vcs-svn/svndump.* for branch detection. When starting with this feature I found that the existing functions are not yet appropriate for that. These rewrites the

Comparing the working tree with a commit should be independent of the index

2012-08-18 Thread Maaartin
I've already posted it to SO [1], but got no satisfactory answer. The command git diff mycommit compares the working tree against mycommit, so it should not depend on the index. But it does as this example shows: git init echo A A.txt; git add .; git commit -m A; git branch A echo B B.txt;

Re: [PATCH v3 2/2] git-svn.perl: keep processing all commits in parents_exclude

2012-08-18 Thread Sam Vilain
On 08/11/2012 10:14 AM, Steven Walter wrote: This fixes a bug where git finds the incorrect merge parent. Consider a repository with trunk, branch1 of trunk, and branch2 of branch1. Without this change, git interprets a merge of branch2 into trunk as a merge of branch1 into trunk.

Re: [PATCH 2/2] git-gui: remove .git/CHERRY_PICK_HEAD after committing

2012-08-18 Thread Junio C Hamano
Beat Bolli bbo...@ewanet.ch writes: Adding __git_ps1() to one's bash prompt displays various repo status info after each command. After committing a git cherry-pick -n using git-gui, the prompt still contains the |CHERRY-PICKING flag. Delete the file causing this flag when cleaning up.

Re: Problems with git fetch confusing foo and foo.git repos

2012-08-18 Thread Junio C Hamano
Richard Purdie richard.pur...@linuxfoundation.org writes: I'd add that I think the commit made for the original problem[1] has fixed this scenario since it now will prefer foo over foo.git also in the fetch case even if the / is removed from the url. OK. As understand it, these check various

Re: [PATCH] test: some testcases failed if cwd is on a symlink

2012-08-18 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: I can work around the problem by using --root=/run/shm. I do not necessarily think it is a work around. A low-impact approach may be to update the part that parses --root option to do root=$(...) root=$( cd $root /bin/pwd ) or

Re: [RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change

2012-08-18 Thread Junio C Hamano
mhag...@alum.mit.edu writes: Given that a flag day would anyway be required to add a d/f-tolerant system, I could live with a separate graveyard namespace as originally proposed by Jeff. However, I still think that as long as we are making a jump, we could try to land closer to the ultimate

Re: [PATCH 1/2] git-config.txt: properly escape quotation marks in example

2012-08-18 Thread Junio C Hamano
mhag...@alum.mit.edu writes: From: Michael Haggerty mhag...@alum.mit.edu In the example line as written, gitproxy=proxy-command for kernel.org the quotation marks are eaten by the config-file parser. From the history, it looks like this example wanted to have quotation marks in

Re: [PATCH v3 2/2] git-svn.perl: keep processing all commits in parents_exclude

2012-08-18 Thread Steven Walter
On Sat, Aug 18, 2012 at 3:51 PM, Sam Vilain s...@vilain.net wrote: On 08/11/2012 10:14 AM, Steven Walter wrote: This fixes a bug where git finds the incorrect merge parent. Consider a repository with trunk, branch1 of trunk, and branch2 of branch1. Without this change, git interprets a merge

Re: [PATCH 2/2] git-config.txt: fix example

2012-08-18 Thread Junio C Hamano
mhag...@alum.mit.edu writes: To add a new proxy, without altering any of the existing ones, use -% git config core.gitproxy 'proxy-command for example.com' +% git config --add core.gitproxy 'proxy-command for example.com' Sensible; thanks. -- To unsubscribe

Re: [RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change

2012-08-18 Thread Alexey Muranov
On 18 Aug 2012, at 22:39, Junio C Hamano wrote: Do we _know_ already what the ultimate destination looks like? If the answer is yes, then I agree, but otherwise, I doubt it is a good idea to introduce unnecessary complexity to the system that may have to be ripped out and redone. I

Re: Comparing the working tree with a commit should be independent of the index

2012-08-18 Thread Junio C Hamano
Maaartin graj...@seznam.cz writes: Instead I get deleted file. Adding the file to the index changes it. This is IMHO a bug. There are 7 interesting combinations for the state of a path. It either exists in or missing from the commit you are gving to git diff, it either exists in or missing

Re: Git feature request: --amend older commit

2012-08-18 Thread Junio C Hamano
Jared Hance jaredha...@gmail.com writes: [administrivia: do not deflect a direct response to you away by using mail-followup-to header, thanks] On Fri, Aug 17, 2012 at 11:47:49AM -0400, George Spelvin wrote: Something like git commit --fixup HEAD~3, where git commit --fixup HEAD would be

Re: Problems with git fetch confusing foo and foo.git repos

2012-08-18 Thread Richard Purdie
On Sat, 2012-08-18 at 13:33 -0700, Junio C Hamano wrote: Richard Purdie richard.pur...@linuxfoundation.org writes: I'd add that I think the commit made for the original problem[1] has fixed this scenario since it now will prefer foo over foo.git also in the fetch case even if the / is

Re: [PATCH v3 2/2] git-svn.perl: keep processing all commits in parents_exclude

2012-08-18 Thread Sam Vilain
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/18/2012 01:43 PM, Steven Walter wrote: How about a Signed-Off-By? Signed-Off-By: Sam Vilain s...@vilain.net Sam -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux)

Re: [PATCH 1/2] git-config.txt: properly escape quotation marks in example

2012-08-18 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: The bigger question is whether this example is improved by including quotation marks, or whether they are just a distraction from the main point. I abstain. Thanks for spelling that bigger question out. Given that the example is showing distinction

Re: [PATCH v3 2/2] git-svn.perl: keep processing all commits in parents_exclude

2012-08-18 Thread Junio C Hamano
Sam Vilain s...@vilain.net writes: On 08/18/2012 01:43 PM, Steven Walter wrote: How about a Signed-Off-By? Signed-Off-By: Sam Vilain s...@vilain.net I think you meant reviewed-by or acked-by? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change

2012-08-18 Thread Junio C Hamano
Alexey Muranov alexey.mura...@gmail.com writes: On 18 Aug 2012, at 22:39, Junio C Hamano wrote: Do we _know_ already what the ultimate destination looks like? If the answer is yes, then I agree, but otherwise, I doubt it is a good idea to introduce unnecessary complexity to the system