Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-05 Thread Duy Nguyen
On Sat, Jul 5, 2014 at 5:42 AM, Karsten Blees karsten.bl...@gmail.com wrote: 'git status' segfaults if a directory is longer than PATH_MAX, because processing .gitignore files in prep_exclude() writes past the end of a PATH_MAX-bounded buffer. Remove the limitation by using strbuf instead.

Re: t5150-request-pull.sh fails on newest master in Debian

2014-07-05 Thread Øyvind A . Holm
On 5 July 2014 03:58, David Turner dtur...@twopensource.com wrote: On Sat, 2014-07-05 at 02:09 +0200, Øyvind A. Holm wrote: snip The test works. Seems as there's something fishy about the use of --prefix in this specific commit (v2.0.1-472-g6f92e5f). Ok, now I can reproduce on my linode

Re: git fetch sha1

2014-07-05 Thread Shawn Pearce
On Sat, Jul 5, 2014 at 6:05 AM, Allan Gardner allanegard...@gmail.com wrote: On Fri, Jul 4, 2014 at 10:41 PM, Shawn Pearce spea...@spearce.org wrote: On Fri, Jul 4, 2014 at 10:51 AM, Allan Gardner allanegard...@gmail.com wrote: Currently fetching a sha1 fails on git.kernel.org: $ git

[PATCH] refs.c: handle REFNAME_REFSPEC_PATTERN at end of page

2014-07-05 Thread David Turner
When a ref crosses a memory page boundary, we restart the parsing at the beginning with the bytewise code. Pass the original flags to that code, rather than the current flags. Signed-off-by: David Turner dtur...@twitter.com --- refs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] t5000, t5003: simplify commit

2014-07-05 Thread René Scharfe
Add the whole directory of test files at once using git add instead of calling git update-index on each of them and use git commit instead of the plumbing commands write-tree, update-ref and commit-tree to build the commit. This simplifies the code considerably. Signed-off-by: Rene Scharfe

[BUG] Push fails with dumb http to SabreDAV

2014-07-05 Thread Abbaad Haider
Background: I'm trying to host a git repository at my Box.com account, which offers DAV access using a server called SabreDAV. I ran into a few issues along the way. The first is that Box.com apparently doesn't like it if a directory has a dot in the name. No big deal, just use foo instead of

[PATCH] http-push.c: make CURLOPT_IOCTLDATA a usable pointer

2014-07-05 Thread Abbaad Haider
Fixes a small bug affecting push to remotes which use some sort of multi-pass authentication. In particular the bug affected SabreDAV as configured by Box.com [1]. It must be a weird server configuration for the bug to have survived this long. Someone should write a test for it. [1]

Re: [PATCH 1/3] cache-tree: Create/update cache-tree on checkout

2014-07-05 Thread David Turner
On Tue, 2014-07-01 at 13:15 -0700, Junio C Hamano wrote: David Turner dtur...@twopensource.com writes: When git checkout checks out a branch, create or update the cache-tree so that subsequent operations are faster. Signed-off-by: David Turner dtur...@twitter.com ---

[PATCH v4 4/4] cache-tree: Write updated cache-tree after commit

2014-07-05 Thread David Turner
During the commit process, update the cache-tree. Write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Make all tests test the entire cache-tree, not just the root level. Signed-off-by: David Turner

[PATCH v4 3/4] cache-tree: subdirectory tests

2014-07-05 Thread David Turner
Add tests to confirm that invalidation of subdirectories nether over- nor under-invalidates. Signed-off-by: David Turner dtur...@twitter.com --- t/t0090-cache-tree.sh | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/t/t0090-cache-tree.sh

[PATCH v4 1/4] cache-tree: Create/update cache-tree on checkout

2014-07-05 Thread David Turner
When git checkout checks out a branch, create or update the cache-tree so that subsequent operations are faster. update_main_cache_tree learned a new flag, WRITE_TREE_REPAIR. When WRITE_TREE_REPAIR is set, portions of the cache-tree which do not correspond to existing tree objects are

[PATCH v4 2/4] test-dump-cache-tree: invalid trees are not errors

2014-07-05 Thread David Turner
Do not treat known-invalid trees as errors even when their count is incorrect. Because git already knows that these trees are invalid, nothing depends on the count field. Add a couple of comments. Signed-off-by: David Turner dtur...@twitter.com --- test-dump-cache-tree.c | 4 ++-- 1 file