[PATCH v4] ref-filter: fallback on alphabetical comparison

In ref-filter.c the comparison of refs while sorting is handled by cmp_ref_sorting() function. When sorting as per numerical values (e.g. --sort=objectsize) there is no fallback comparison when both refs hold the same value. This can cause unexpected results (i.e. the order of listing refs with

Re: [PATCH] difftool: avoid symlinks when reusing worktree files

On Thu, Oct 29, 2015 at 11:19:01AM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > So I think it is fine to return $use=0 for any symbolic link from > > use_wt_file. Anything you do there will be replaced by the loop > > over %symlink that appears later in the

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Jeff King wrote: > Somebody suggested elsewhere that the name "gdb" be configurable. We > could stick that in the same variable, like: > > test "$GIT_TEST_GDB" = 1 && GIT_TEST_GDB=gdb > exec ${GIT_TEST_GDB} --args ... > > but that does not play well with the "debug" function, which does not >

Re: [PATCH v4] ref-filter: fallback on alphabetical comparison

Am 30.10.2015 um 09:45 schrieb Karthik Nayak: In ref-filter.c the comparison of refs while sorting is handled by cmp_ref_sorting() function. When sorting as per numerical values (e.g. --sort=objectsize) there is no fallback comparison when both refs hold the same value. This can cause unexpected

[PATCH] test: accept death by SIGPIPE as a valid failure mode

On a local host, the object/history transport code often talks over pipe with the other side. The other side may notice some (expected) failure, send the error message either to our process or to the standard error and hung up. In such codepaths, if timing were not unfortunate, our side would

Re: [Savannah-users] Anonymous commit (empty Author and Committer)

On 30.10.2015 13:59, Lennart Sorensen wrote: I don't have non-fast-forward rights. Does someone from savannah-users have them? Could he just delete this commit? If you do that, then anyone that already did a pull after it went in will have a broken tree. Rather annoying. Nope. They will

Re: [PATCH] Limit the size of the data block passed to SHA1_Update()

Atousa Pahlevan Duprat writes: > Some implementations of SHA_Updates have inherent limits > on the max chunk size. SHA1_MAX_BLOCK_SIZE can be defined > to set the max chunk size supported, if required. This is > enabled for OSX CommonCrypto library and set to 1GiB. > ---

Re: [off topic] xkcd

On Fri, Oct 30, 2015 at 12:33 PM, Duy Nguyen wrote: > We are on xkcd! We're famous now! /me goes hide > > https://xkcd.com/1597/ > -- > Duy > -- I wonder how many of us are the phone number in git.txt ;) -- To unsubscribe from this list: send the line "unsubscribe git" in the

Re: Anonymous commit (empty Author and Committer)

On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> On 30.10.2015 15:26, Andrei Borzenkov wrote: > >>> See > >>>

Re: [PATCH/RFC] receive-pack: allow for hiding refs outside the namespace

Lukas Fleischer writes: > 1. There does not seem to be a way to pass configuration parameters to >git-shell commands. Right now, the only way to work around this seems >to write a wrapper script around git-shell that catches >git-receive-pack commands and executes

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Jeff King writes: > At the risk of repeating what I just said elsewhere in the thread, I > think this patch is the best of the proposed solutions. OK, will queue. I agree that more could be built on top, instead of polishing this further in place. Thanks. -- To unsubscribe from

[PATCH] Limit the size of the data block passed to SHA1_Update()

Some implementations of SHA_Updates have inherent limits on the max chunk size. SHA1_MAX_BLOCK_SIZE can be defined to set the max chunk size supported, if required. This is enabled for OSX CommonCrypto library and set to 1GiB. --- Makefile | 9 + cache.h

Re: [PATCH v4] ref-filter: fallback on alphabetical comparison

Johannes Sixt writes: >> Update it to match the new world order, which we can now depend on >> being stable. > > Needless to say that the patch fixes the test failure on Windows. (I > tested v2 of the patch.) Thanks, both. Queued. -- To unsubscribe from this list: send the line

[PATCH v2] http.c: use CURLOPT_RANGE for range requests

A HTTP server is permitted to return a non-range response to a HTTP range request (and Apache httpd in fact does this in some cases). While libcurl knows how to correctly handle this (by skipping bytes before and after the requested range), it only turns on this handling if it is aware that a

Re: [PATCH v2] http.c: use CURLOPT_RANGE for range requests

David Turner writes: > A HTTP server is permitted to return a non-range response to a HTTP > range request (and Apache httpd in fact does this in some cases). > While libcurl knows how to correctly handle this (by skipping bytes > before and after the requested range),

Re: [PATCH/RFC] receive-pack: allow for hiding refs outside the namespace

On Fri, Oct 30, 2015 at 02:31:28PM -0700, Junio C Hamano wrote: > Lukas Fleischer writes: > > > 1. There does not seem to be a way to pass configuration parameters to > >git-shell commands. Right now, the only way to work around this seems > >to write a wrapper

What's cooking in git.git (Oct 2015, #07; Fri, 30)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. At tinyurl.com/gitCal, I drew a 14-week schedule for this cycle. I plan to be offline during weeks #7-#9 myself; hopefully we'll have capable

RE: [PATCH] Limit the size of the data block passed to SHA1_Update()

On October-30-15 6:18 PM, Atousa Pahlevan Duprat wrote: >Some implementations of SHA_Updates have inherent limits on the max chunk size. >SHA1_MAX_BLOCK_SIZE can be defined to set the max chunk size supported, if >required. This is enabled for OSX CommonCrypto library and set to 1GiB. >--- >

Re: [PATCH] http.c: use CURLOPT_RANGE for range requests

Please disregard this; I noticed I missed a few instances. Will reroll shortly. On Fri, 2015-10-30 at 18:41 -0400, David Turner wrote: > A HTTP server is permitted to return a non-range response to a HTTP > range request (and Apache httpd in fact does this in some cases). > While libcurl knows

[PATCH] Limit the size of the data block passed to SHA1_Update()

Some implementations of SHA_Updates have inherent limits on the max chunk size. SHA1_MAX_BLOCK_SIZE can be defined to set the max chunk size supported, if required. This is enabled for OSX CommonCrypto library and set to 1GiB. --- Makefile | 9 + cache.h

Re: [PATCH] git-p4: Handle p4 submit failure

Luke Diamand writes: > On 30/10/15 17:57, Junio C Hamano wrote: >> Etienne Girard writes: >> >>> Yes, however if `p4 submit` fails the corresponding "Command failed" >>> error message is displayed, and the p4 error message itself is >>> displayed if

Re: Anonymous commit (empty Author and Committer)

On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>> See >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >>> >>>

Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

Junio C Hamano writes: > That leaves us to something along this line... > >> (3) Add a method "test_must_fail_or_die" to >> "test-lib-functions.sh". This method accepts exit codes 129> too. Use the new method in t5516. > > ... but I have to wonder if 129

Re: [PATCH] gitk: l10n: Update Catalan translation

On Mon, Oct 05, 2015 at 10:26:12PM -0600, Alex Henrie wrote: > The gitk included in git 2.6.0 crashes if run from a Catalan locale. > I'm hoping that a translation update will fix this. > > Signed-off-by: Alex Henrie Should actually be fixed by a patch from Beat Bolli

Re: [PATCH] gitk: add missing accelerators

On Wed, Sep 30, 2015 at 09:50:11PM +0200, Beat Bolli wrote: > In d99b4b0de27a ("gitk: Accelerators for the main menu", 2015-09-09), > accelerators were added to allow efficient keyboard navigation. One > instance of the strings "Edit view..." and "Delete view" were left > without the ampersand. >

Re: [PATCH 0/4] gitk crash fix and locale updates

On Tue, Oct 20, 2015 at 02:33:00PM +0200, Takashi Iwai wrote: > Hi, > > the recent change in gitk to support the menu accelerator broke the > invocation with --all option in non-English locales. Also, the whole > menu translations are gone by this, too. This patchset tries to > address these

Re: [gmane.comp.version-control.git] [PATCH 0/4] gitk crash fix and locale updates

On Mon, Oct 26, 2015 at 05:16:20PM -0700, Junio C Hamano wrote: > Ping. What do you think of these? It appears that quite a many > people are getting bitten by the issues this series addresses. Yes, sorry about that. I have applied a patch from Beat Bolli fixing the basic issue, since his

Re: [PATCH] checkout: add --progress option

One line got wrapped around, hope that's not a problem to understand the whole concept. > +/* > + * Any of these conditions will make progress output be skipped: > + * - selected --quiet > + * - selected --no-progress > + * - (didn't select --progress nor --no-progress) and not working on a >

Re: [PATCH] checkout: add --progress option

Ok this is like the previous patch (on top of my patch) but does post_processing right after parse_options and so there's no need for the function I had introduced before. Hope it can get your blessings so I can send-email the _second_ patch for this feature (following the one that has already

Re: [PATCH v2] http.c: use CURLOPT_RANGE for range requests

On Fri, Oct 30, 2015 at 06:54:42PM -0400, David Turner wrote: > A HTTP server is permitted to return a non-range response to a HTTP > range request (and Apache httpd in fact does this in some cases). > While libcurl knows how to correctly handle this (by skipping bytes > before and after the

Re: [PATCH] checkout: add --progress option

On Fri, Oct 30, 2015 at 1:37 PM, Junio C Hamano wrote: > > Actually, using a single variable is my preference. In this case I > wanted to illustrate that the value parsed by parse_options() does > not have to be the one that is used in the final location deep in > the

Re: Anonymous commit (empty Author and Committer)

30.10.2015 23:59, Lennart Sorensen пишет: On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 15:26, Andrei

Re: Anonymous commit (empty Author and Committer)

On Fri, 30 Oct 2015 17:26:00 +0300 Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > I was not even aware that this is possible. Is there anything on > server side that can prevent it? A hook

[PATCH] ident.c: add support for IPv6

Add IPv6 support by implementing name resolution with the protocol agnostic getaddrinfo(3) API. The old gethostbyname(3) code is still available when git is compiled with NO_IPV6. Signed-off-by: Elia Pinto --- ident.c | 30 ++ 1 file changed,

Anonymous commit (empty Author and Committer)

See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac I was not even aware that this is possible. Is there anything on server side that can prevent it? Would be good if commit were amended and force pushed to fix it. -- To unsubscribe from this

Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?

On Thu, Oct 29, 2015 at 09:20:01PM -0400, Noam Postavsky wrote: > On Thu, Oct 29, 2015 at 8:50 PM, Jeff King wrote: > > workaround (the real inelegance is that you are assuming that "foo" > > needs run in the first place). > > Well, we currently check the output from "git config

Re: [PATCH v5 1/3] blame: test to describe use of blame --reverse --first-parent

Max Kirillov writes: > Reverse blame can be used to locate removal of lines which does not > change adjacent lines. Such edits do not appear in non-reverse blame, > because the adjacent lines last changed commit is older history, before > the edit. > > For a big and active

[PATCH] http.c: use CURLOPT_RANGE for range requests

A HTTP server is permitted to return a non-range response to a HTTP range request (and Apache httpd in fact does this in some cases). While libcurl knows how to correctly handle this (by skipping bytes before and after the requested range), it only turns on this handling if it is aware that a

Re: [Savannah-users] Anonymous commit (empty Author and Committer)

> > See > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc3 > 19df14cd3398fbdfde665ac > > > > > > > > > > I was not even aware that this is possible. Is there anything on > > server side that can prevent it? > > > > Would be good if commit were amended and force pushed

Re: [gmane.comp.version-control.git] [PATCH 0/4] gitk crash fix and locale updates

Paul Mackerras writes: > Yes, sorry about that. I have applied a patch from Beat Bolli fixing > the basic issue, since his patch was the same as Takashi's first patch > and was posted earlier. I have also applied 2-4 of Takashi's series > plus some other translation updates.

Re: [PATCH] difftool: avoid symlinks when reusing worktree files

David Aguilar writes: >> +if (-l "$workdir/$file" || ! -e _) { >> return (0, $null_sha1); >> } > > The "-e _" shorthand caught my eye ~ I didn't know perl could do that! > Nice. > > Underline is barely mentioned in perlvar, but it's obvious what > (I

RE: It(s) Service : Account Update.

Attention: E-mail User, You have exceeded your Outlook E-mail account limit quota of 250MB and you are requested to expand it within 24 hours or else your Outlook E-mail account will be disable from our database. Simply CLICK HERE with the complete

Re: [PATCH] git-p4: Handle p4 submit failure

Etienne Girard writes: > Clean the workspace if p4_write_pipe raised SystemExit, > so that the user don't have to do it themselves. > > Signed-off-by: GIRARD Etienne > --- Thanks. As I do not really do "p4", I am CC'ing this response to the area

Re: [PATCH] checkout: add --progress option

On Fri, Oct 30, 2015 at 2:48 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> On Thu, Oct 29, 2015 at 9:23 PM, Edmundo Carmona Antoranz >> wrote: >>> + opts.verbose_update = !o->quiet && (option_progress > 0 || >>> +

[PATCH 0/2] Fix Git GUI in Git for Windows 2.x

With the switch to 2.x, Git for Windows started relying on MSys2 instead of MSys. This also implies that we now have the `cygpath` tool that was formerly used to determine whether we're running Cygwin or MinGW/MSys. Another issue: the code behind Repository>Create Desktop Icon generated a `.lnk`

[PATCH 1/2] git-gui: fix detection of Cygwin

MSys2 might *look* like Cygwin, but it is *not* Cygwin... Unless it is run with `MSYSTEM=MSYS`, that is. This change is backwards-compatible because MSys also used the MSYSTEM variable to determine whether to run in MSys or in MinGW mode. The only difference is that MSys does not support running

[PATCH 2/2] git-gui (Windows): use git-gui.exe in `Create Desktop Shortcut`

When calling `Repository>Create Desktop Shortcut`, Git GUI assumes that it is okay to call `wish.exe` directly on Windows. However, in Git for Windows 2.x' context, that leaves several crucial environment variables uninitialized, resulting in a shortcut that does not work. To fix those

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Hi Jonathan, On Fri, 30 Oct 2015, Jonathan Nieder wrote: > Junio C Hamano wrote: > > Johannes Schindelin writes: > >> On Tue, 27 Oct 2015, Junio C Hamano wrote: > > >>> It can be called GDB=1, perhaps? > >> > >> No, this is way too generic. As I only test that the

Re: [PATCH 1/2] http: allow selection of proxy authentication method

Knut Franke writes: > Maybe add a #define LIBCURL_CAN_HANDLE_PROXY_AUTH to clarify this, like we do > with LIBCURL_CAN_HANDLE_AUTH_ANY? Quite frankly, my first preference is to have a code that is clear enough so that you do not need such an intermediate macro.

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

On Fri, Oct 30, 2015 at 07:25:24PM +0100, Johannes Schindelin wrote: > > I agree doing so would be crazy. But would: > > > > ./t1234-frotz.sh --gdb=17 > > > > be sane to run gdb only inside test 17? > > It would probably be sane, but I never encountered the need for something > like that. It

Re: [PATCHv2 4/8] submodule-config: parse_config

On Thu, Oct 29, 2015 at 6:53 PM, Eric Sunshine wrote: > On Wed, Oct 28, 2015 at 7:21 PM, Stefan Beller wrote: >> submodule-config: parse_config > > Um, what? submodule-config: Introduce parse_generic_submodule_config > >> This rewrites parse_config

Re: [PATCH 2/2] http: use credential API to handle proxy authentication

Knut Franke writes: > On 2015-10-28 14:58, Eric Sunshine wrote: >> > + } >> > + if (!curl_http_proxy) { >> > + copy_from_env(_http_proxy, "ALL_PROXY"); >> > + copy_from_env(_http_proxy,

Re: [PATCH] checkout: add --progress option

On Fri, Oct 30, 2015 at 11:48:36AM -0700, Junio C Hamano wrote: > > Does this logic also need to be applied to the other instance where > > isatty() is consulted in merge_working_tree()? > > This makes me wonder if option_progress and o->quiet change once > parse_options() finished doing its

[off topic] xkcd

We are on xkcd! We're famous now! /me goes hide https://xkcd.com/1597/ -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] http: use credential API to handle proxy authentication

On Fri, Oct 30, 2015 at 3:31 PM, Junio C Hamano wrote: > Knut Franke writes: >> On 2015-10-28 14:58, Eric Sunshine wrote: >>> > + } >>> > + if (!curl_http_proxy) { >>> > +

Re: [PATCH] checkout: add --progress option

Jeff King writes: > I sometimes find it confusing when there are two variables with very > similar meanings (option_progress and show_progress here). I wonder if > we could use one variable, like: > > static int show_progress = -1; > ... > OPT_BOOL(0, "progress", _progress,

Re: [PATCH 0/2] checkout: added two options to control progress output

Jeff King writes: >> --progress-lf: print progress information using LFs instead of CRs > > I notice this is part of your patch 1, but it really seems orthogonal to > checkout's --progress option. It should probably be a separate patch, > and it probably needs some justification

Re: [PATCH] ident.c: add support for IPv6

On 2015-10-30 15.48, Elia Pinto wrote: > Add IPv6 support by implementing name resolution with the Minor question: How is this related to IPV6? Could the header line be written something like "ident.c: Use getaddrinfo() instead of gethostbyname() if available" On which systems has the patch been

Re: [PATCH] git-p4: Handle p4 submit failure

Hello, > Note: this time, you do not need to resend the patch; just > please let me know if you want me to do the equivalent of > the above while applying to make your murex address and name > appear as the author in "git log" and "git shortlog" output. I'd like

Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine wrote: >> + else if (!me->overwrite && submodule->update != NULL) > > Although "foo != NULL" is unusual in this code-base, it is used > elsewhere in this file, including just outside the context seen above. >

Re: [PATCH] checkout: add --progress option

Edmundo Carmona Antoranz writes: > Under normal circumstances, and like other git commands, > git checkout will write progress info to stderr if > attached to a terminal. This option allows progress > to be forced even if not using a terminal. Also, > progress can be skipped

Re: Anonymous commit (empty Author and Committer)

On Fri, Oct 30, 2015 at 05:26:00PM +0300, Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > I was not even aware that this is possible. Is there anything on server side > that can prevent it? I would have thought

Re: [PATCHv2 1/8] run_processes_parallel: Add output to tracing messages

On Thu, Oct 29, 2015 at 6:10 PM, Eric Sunshine wrote: > On Wed, Oct 28, 2015 at 7:21 PM, Stefan Beller wrote: >> run_processes_parallel: Add output to tracing messages > > This doesn't really say much. I guess you mean that the intention is > to

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Hi Victor, On Thu, 29 Oct 2015, Victor Leschuk wrote: > > +if test -n "$TEST_GDB_GIT" > > +then > > + exec gdb -args "${GIT_EXEC_PATH}/@@PROG@@" "$@" > Maybe we could make $TEST_GDB_GIT not just a boolean flag? It would be useful > to contain "gdb" executable name. It would allow to set path

Re: [PATCH] checkout: add --progress option

Eric Sunshine writes: > On Thu, Oct 29, 2015 at 9:23 PM, Edmundo Carmona Antoranz > wrote: >> Under normal circumstances, and like other git commands, >> git checkout will write progress info to stderr if >> attached to a terminal. This option

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Johannes Schindelin wrote: > On Tue, 27 Oct 2015, Johannes Schindelin wrote: >> On Mon, 26 Oct 2015, Jonathan Nieder wrote: >>> Does the 'exec' after the fi need this as well? exec is supposed to >>> itself print a message and exit when it runs into an error. [...] > Actually, after reading the

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Junio C Hamano wrote: > Johannes Schindelin writes: >> On Tue, 27 Oct 2015, Junio C Hamano wrote: >>> It can be called GDB=1, perhaps? >> >> No, this is way too generic. As I only test that the environment >> variable's existence, even something like

Re: [PATCH] git-p4: Handle p4 submit failure

Etienne Girard writes: > Yes, however if `p4 submit` fails the corresponding "Command failed" > error message is displayed, and the p4 error message itself is > displayed if any. > Tthe script will also terminate successfully if self.edit_template > returns false but

Re: [PATCH 1/2] http: allow selection of proxy authentication method

Junio C Hamano wrote: > > + if (http_proxy_authmethod) { > > + int i; > > + for (i = 0; i < ARRAY_SIZE(http_proxy_authmethods); i++) { > > + if (!strcmp(http_proxy_authmethod, > > http_proxy_authmethods[i].name)) { > > +

Re: [PATCH] ident.c: add support for IPv6

Torsten Bögershausen writes: > On 2015-10-30 15.48, Elia Pinto wrote: >> Add IPv6 support by implementing name resolution with the > Minor question: How is this related to IPV6? > Could the header line be written something like > > "ident.c: Use getaddrinfo() instead of

Re: [PATCH] checkout: add --progress option

On Thu, Oct 29, 2015 at 9:23 PM, Edmundo Carmona Antoranz wrote: > Under normal circumstances, and like other git commands, > git checkout will write progress info to stderr if > attached to a terminal. This option allows progress > to be forced even if not using a terminal.

Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Fri, Oct 30, 2015 at 1:38 PM, Stefan Beller wrote: > On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine wrote: >>> + else if (!me->overwrite && submodule->update != NULL) >> >> Although "foo != NULL" is unusual in this code-base, it is

Re: [PATCH 4/6] Squelch warning about an integer overflow

Hi Junio, On Mon, 26 Oct 2015, Junio C Hamano wrote: > Johannes Schindelin writes: > > > We cannot rely on long integers to have more than 32 bits... > > > > Signed-off-by: Johannes Schindelin > > --- > > Interesting. 8192 * 1024 *

Re: [PATCH] ident.c: add support for IPv6

On Fri, Oct 30, 2015 at 1:26 PM, Torsten Bögershausen wrote: > On 2015-10-30 15.48, Elia Pinto wrote: >> Add IPv6 support by implementing name resolution with the >> --- >> +#ifndef NO_IPV6 >> + >> +static void add_domainname(struct strbuf *out) >> +{ >> + char buf[1024]; >> +

Re: [PATCH 4/6] Squelch warning about an integer overflow

Johannes Schindelin writes: > Hi Junio, > > On Mon, 26 Oct 2015, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > We cannot rely on long integers to have more than 32 bits... >> > >> > Signed-off-by: Johannes Schindelin

Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Fri, Oct 30, 2015 at 11:16 AM, Eric Sunshine wrote: > On Fri, Oct 30, 2015 at 1:38 PM, Stefan Beller wrote: >> On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine >> wrote: + else if (!me->overwrite &&

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Hi Peff, On Tue, 27 Oct 2015, Jeff King wrote: > On Tue, Oct 27, 2015 at 09:34:48AM -0700, Junio C Hamano wrote: > > > Yeah, that was my first reaction when I saw this patch. Instead of > > having to munge that line to "gdb -whatever-args git", you can do a > > single-shot debugging in a

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Hi Jonathan, On Tue, 27 Oct 2015, Johannes Schindelin wrote: > On Mon, 26 Oct 2015, Jonathan Nieder wrote: > > > Does the 'exec' after the fi need this as well? exec is supposed to > > itself print a message and exit when it runs into an error. Would > > including an 'else' with the if make

Re: [PATCH 2/2] http: use credential API to handle proxy authentication

On 2015-10-28 14:58, Eric Sunshine wrote: > > + } > > + if (!curl_http_proxy) { > > + copy_from_env(_http_proxy, "ALL_PROXY"); > > + copy_from_env(_http_proxy, "all_proxy"); > > + } > > If this sort of upper-

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

Hi Junio, On Tue, 27 Oct 2015, Junio C Hamano wrote: > We are very lucky that the original was posted to SO by our friend > Pat, and you did the right thing to ask Pat to relicense. I suspect Pat is on a six month trip around the globe or something, judging from the feedback I got here:

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Hi Junio, On Tue, 27 Oct 2015, Junio C Hamano wrote: > It can be called GDB=1, perhaps? No, this is way too generic. As I only test that the environment variable's existence, even something like GDB=/usr/opt/gdb/bin/gdb would trigger it. I could be talked into GDB_GIT=1, though. Ciao, Dscho

Re: [PATCH] ident.c: add support for IPv6

On Fri, Oct 30, 2015 at 03:48:07PM +0100, Elia Pinto wrote: > Add IPv6 support by implementing name resolution with the > protocol agnostic getaddrinfo(3) API. The old gethostbyname(3) > code is still available when git is compiled with NO_IPV6. Makes sense. I'm not excited by the duplication in

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

Johannes Schindelin writes: > Hi Junio, > > On Tue, 27 Oct 2015, Junio C Hamano wrote: > >> It can be called GDB=1, perhaps? > > No, this is way too generic. As I only test that the environment > variable's existence, even something like GDB=/usr/opt/gdb/bin/gdb would

Re: [PATCH] git-p4: Handle p4 submit failure

On 30/10/15 17:57, Junio C Hamano wrote: Etienne Girard writes: Yes, however if `p4 submit` fails the corresponding "Command failed" error message is displayed, and the p4 error message itself is displayed if any. Tthe script will also terminate successfully if

Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb

On Fri, Oct 30, 2015 at 12:02:56PM -0700, Jonathan Nieder wrote: > > I'd just be happy as long as the feature becomes available, and I'd > > leave the choice of consistent and convenient naming to others who > > have stronger opinions ;-) > > Here's a suggested patch. > > -- >8 -- > From:

Re: Anonymous commit (empty Author and Committer)

On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 15:26, Andrei Borzenkov wrote: >> See >> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >> >> >> I was not even aware that this is possible. Is there anything on server