On Tue, Feb 23, 2016 at 10:49:34AM +0100, Stefan Frühwirth wrote:
> On 23.02.2016 at 06:02 Jeff King wrote:
> >>Let's wait and see how many "please don't"s we hear, perhaps, before
> >>deciding to go 3.?
> >
> >I'm guessing we won't see much either way. Even Stefan, the original
> >reporter, does
On Wed, Feb 24, 2016 at 08:28:59AM +0100, Dennis Kaarsemaker wrote:
> > So that's a "please don't" leave the code as-is but provide a
> > (transitional) solution that fixes the reported bug and has the best
> > chances of not causing any more headaches :)
>
> I am also actively using it. It's t
Commit 8bf4bec (add "ok=sigpipe" to test_must_fail and use
it to fix flaky tests, 2015-11-27) taught t5504 to handle
"git push" racily exiting with SIGPIPE rather than failing.
However, one of the tests checks the output of the command,
as well. In the SIGPIPE case, we will not have produced any
o
On Wed, Feb 24, 2016 at 12:30 AM, Junio C Hamano wrote:
> So, have we decided to wait, or we'd rather apply the band-aid in
> the meantime? I can go either way, just double checking as I
> noticed this thread while updating my leftover bits list.
Thanks for the follow-up, I was about to ask for
It is a pilot error to call `git config section.key value` outside of
any Git worktree.
Let's report that error instead of creating the .git/ directory and
writing a fresh config into it.
This addresses https://github.com/git-for-windows/git/issues/643 and
https://groups.google.com/forum/#!topic/
If a command is marked as test_must_fail but dies with a
signal, we consider that a problem and report the error to
stderr. However, we don't say _which_ signal; knowing that
can make debugging easier. Let's share as much as we know.
Signed-off-by: Jeff King
---
Not necessary for the fix, obvious
If the other side feeds us a bogus pack, index-pack (or
unpack-objects) may die early, before consuming all of its
input. As a result, the sideband demuxer may get SIGPIPE
(racily, depending on whether our data made it into the pipe
buffer or not). If this happens and we are compiled with
pthread s
When write_or_die() sees EPIPE, it treats it specially by
converting it into a SIGPIPE death. We obviously cannot
ignore it, as the write has failed and the caller expects us
to die. But likewise, we cannot just call die(), because
printing any message at all would be a nuisance during
normal opera
I got a spurious test failure on t5504 while running the test suite
today. This is the result of my quest through the SIGPIPE rabbit hole.
Since this is not the first time I've investigated tests failing under
load, I finally broke down and wrote a helper script. It probably needs
some adapting fo
On di, 2016-02-23 at 10:49 +0100, Stefan Frühwirth wrote:
> On 23.02.2016 at 06:02 Jeff King wrote:
> > > Let's wait and see how many "please don't"s we hear, perhaps,
> > > before
> > > deciding to go 3.?
> >
> > I'm guessing we won't see much either way. Even Stefan, the
> > original
> > reporte
Hi Junio,
On Tue, 23 Feb 2016, Junio C Hamano wrote:
> Matthieu Moy writes:
>
> > This allows repository browsers like GitHub to display the content of
> > the file nicely formatted.
> >
> > Signed-off-by: Matthieu Moy
> > ---
>
> To be honest, I have the most problem with this step in the wh
On Tue, Feb 23, 2016 at 10:30:04PM -0800, Junio C Hamano wrote:
> Fengguang Wu writes:
>
> > The necessary lines for the robot are
> >
> > base commit:
> > base patch-id:
> > or
> > base tree-id:
> > base patch-id:
>
> I will not repeat why a commit object name wo
Fengguang Wu writes:
> The necessary lines for the robot are
>
> base commit:
> base patch-id:
> or
> base tree-id:
> base patch-id:
I will not repeat why a commit object name would be more appropriate
than a tree object name here (please see my response to HPA).
"H. Peter Anvin" writes:
> Personally, as a maintainer, I would love to see the tree ID and
> ideally also the commit ID a series is based on. The commit ID is
> in some ways less useful since it is non-recreatable (and
> therefore will never match for anything but the first patch of a
> series)
On Tue, Feb 23, 2016 at 12:35:12PM -0800, Junio C Hamano wrote:
> ebied...@xmission.com (Eric W. Biederman) writes:
>
> > Junio C Hamano writes:
> >
> >> It is valuable for a testing organization to say "We tested this
> >> series on top of version X. We know it works, we have tested on a
> >> l
When reviewing a change in Gerrit, which also updates a submodule,
a common review practice is to download and cherry-pick the patch
locally to test it. However when testing it locally, the 'git
submodule update' may fail fetching the correct submodule sha1 as
the corresponding commit in the submod
When the callers of parallel processing machine are sloppy with their
messages, make sure the output is terminated with LF after one child
process is handled. This will not mess with the internal state of the
output, i.e. after all messages for one child process are process
including the callbacks
Expose possible parallelism either via the "--jobs" CLI parameter or
the "submodule.fetchJobs" setting.
By having the variable initialized to -1, we make sure 0 can be passed
into the parallel processing machine, which will then pick as many parallel
workers as there are CPUs.
Signed-off-by: Stef
This build on top of 163b9b1f919c762a4bfb693b3aa05ef1aa627fee
(origin/sb/submodule-parallel-update~3) and replaces the commits
origin/sb/submodule-parallel-update~2..
* Renamed inspect_clone_next_submodule to prepare_to_clone_next_submodule
and reordered the arguments thereof
* Comments for th
This introduces a new helper function in git submodule--helper
which takes care of cloning all submodules, which we want to
parallelize eventually.
Some tests (such as empty URL, update_mode=none) are required in the
helper to make the decision for cloning. These checks have been
moved into the C
We want to reuse the error reporting facilities in a later patch.
Signed-off-by: Stefan Beller
---
run-command.c | 18 +-
run-command.h | 19 +++
2 files changed, 28 insertions(+), 9 deletions(-)
diff --git a/run-command.c b/run-command.c
index 51fd72c..d03ecaa 1
Just pass it along to "git submodule update", which may pick reasonable
defaults if you don't specify an explicit number.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
Documentation/git-clone.txt | 6 +-
builtin/clone.c | 19 +--
t/t7406-submodu
On Tue, Feb 23, 2016 at 11:51:31AM -0800, Junio C Hamano wrote:
> Fengguang Wu writes:
>
> >> >> I have a mixed feeling about this one, primarily because this was
> >> >> already tried quite early in the life of "format-patch" command.
> >> >>
> >> >>
> >> >> http://thread.gmane.org/gmane.c
On Tue, Feb 23, 2016 at 04:31:35PM +0300, Dan Carpenter wrote:
> Blergh... You want it machine readable and I want it human readable. I
Yeah. It's kind of tasting which may differ among people. I'll leave
the judgments to Junio and others, and only add necessary comments to
your points.
> don't
Hi Eric,
On Tue, Feb 23, 2016 at 01:56:07PM -0600, Eric W. Biederman wrote:
>
> Fengguag Wu, Xiaolong Ye, have you attempted to use the truncated
> sha1 of the file the patch applies to? Git already places a file sha1
> at the top of a patch. See the index line?
>
> > diff --git a/fs/namespace
From: Felipe Gonçalves Assis
--find-renames= and --rename-threshold= should be aliases.
Signed-off-by: Felipe Gonçalves Assis
---
t/t3034-merge-recursive-rename-options.sh | 46 +++
1 file changed, 46 insertions(+)
diff --git a/t/t3034-merge-recursive-rename-option
From: Felipe Gonçalves Assis
Signed-off-by: Felipe Gonçalves Assis
---
t/t3034-merge-recursive-rename-options.sh | 28
1 file changed, 28 insertions(+)
diff --git a/t/t3034-merge-recursive-rename-options.sh
b/t/t3034-merge-recursive-rename-options.sh
index 51c2f87
Just a quick update incorporating Eric's latest comments.
Still based on
c443d39 (merge-recursive: find-renames resets threshold, 2016-02-21).
Felipe Gonçalves Assis (3):
t3034: add rename threshold tests
t3034: test option to disable renames
t3034: test deprecated interface
...s.sh => t3
From: Felipe Gonçalves Assis
10ae752 (merge-recursive: option to specify rename threshold,
2010-09-27) introduced this feature but did not include any tests.
The tests use the new option --find-renames, which replaces the then
introduced and now deprecated option --rename-threshold.
Also update
On 02/23/2016 01:49 PM, Eric W. Biederman wrote:
>
> So I could really respect a patch header line that said:
> tree abcdef0123456789...0123456789abcdef
>
> Where the numbers where the truncated tree hash before and after a patch
> was applied. That would seem to give a little bit of extra sanit
On Tue, Feb 23, 2016 at 4:33 PM, Junio C Hamano wrote:
> No, I do not think so.
Thanks. I will probably setup a pre-commit hook at the top level
project to update a submodule metadata file.
Not the prettiest but... :-)
m
--
martin.langh...@gmail.com
- ask interesting questions
- don't ge
On 23 February 2016 at 21:50, Eric Sunshine wrote:
> On Tue, Feb 23, 2016 at 6:48 PM, Felipe Gonçalves Assis
> wrote:
>> 10ae752 (merge-recursive: option to specify rename threshold,
>> 2010-09-27) introduced this feature but did not include any tests.
>>
>> The tests use the new option --find-re
Thanks Ilya and Stefan for your detailed responses.
In general I am trying to avoid having to work with patch sets/queues.
This may be acceptable as a replacement for the “testing-stage” repo.
But we don’t want to have the developer deal with patches or patch queues
in his workflow.
1. The devel
On Tue, Feb 23, 2016 at 7:50 PM, Eric Sunshine wrote:
> On Tue, Feb 23, 2016 at 6:48 PM, Felipe Gonçalves Assis
> wrote:
>> + if [ 50 -le "$th0" ]; then
>> + check_50=check_threshold_0
>> + elif [ 50 -le "$th1" ]; then
>> + check_50=check_threshold_1
>> +
On Tue, Feb 23, 2016 at 6:48 PM, Felipe Gonçalves Assis
wrote:
> 10ae752 (merge-recursive: option to specify rename threshold,
> 2010-09-27) introduced this feature but did not include any tests.
>
> The tests use the new option --find-renames, which replaces the then
> introduced and now deprecat
From: Felipe Gonçalves Assis
--find-renames= and --rename-threshold= should be aliases.
Signed-off-by: Felipe Gonçalves Assis
---
t/t3034-merge-recursive-rename-options.sh | 46 +++
1 file changed, 46 insertions(+)
diff --git a/t/t3034-merge-recursive-rename-option
From: Felipe Gonçalves Assis
10ae752 (merge-recursive: option to specify rename threshold,
2010-09-27) introduced this feature but did not include any tests.
The tests use the new option --find-renames, which replaces the then
introduced and now deprecated option --rename-threshold.
Also update
From: Felipe Gonçalves Assis
Signed-off-by: Felipe Gonçalves Assis
---
t/t3034-merge-recursive-rename-options.sh | 28
1 file changed, 28 insertions(+)
diff --git a/t/t3034-merge-recursive-rename-options.sh
b/t/t3034-merge-recursive-rename-options.sh
index fbec68c
Get rid of blatant bash-isms in favour of simple and portable constructions.
Felipe Gonçalves Assis (3):
t3034: add rename threshold tests
t3034: test option to disable renames
t3034: test deprecated interface
...s.sh => t3032-merge-recursive-space-options.sh} | 2 +-
t/t3034-merge-recur
Stefan Beller writes:
> On Tue, Feb 23, 2016 at 3:33 PM, Junio C Hamano wrote:
>> Junio C Hamano writes:
>>
>>> Looks good. I didn't notice these unnecessary blank lines while
>>> reading the previous rounds, and it is good to see them go.
>>>
>>> Let's wait for a few days and merge them to 'n
On Tue, Feb 23, 2016 at 3:33 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Looks good. I didn't notice these unnecessary blank lines while
>> reading the previous rounds, and it is good to see them go.
>>
>> Let's wait for a few days and merge them to 'next'. David's ref
>> backend to
Junio C Hamano writes:
> Looks good. I didn't notice these unnecessary blank lines while
> reading the previous rounds, and it is good to see them go.
>
> Let's wait for a few days and merge them to 'next'. David's ref
> backend topic textually depends on this, and we'd better give it a
> solid
Junio C Hamano writes:
> Jeff King writes:
>
>> On Fri, Feb 12, 2016 at 10:40:48PM +0100, SZEDER Gábor wrote:
>>
>>> * It would swallow even those errors that we are interested in,
>>>e.g. (note the missing quotes around $foo):
>>> [...]
>>> * I often find myself tracing/debugging the comp
Hi Luke,
Luke Diamand writes:
> I'm guessing that the reason for using a bare repo is so that changes
> can be pushed to it from several different git repos. This then saves
> doing the initial git-p4 clone multiple times.
I have created a Git repository acting as a bridge between Perforce and
p
On Tue, 23 Feb 2016 23:57:06 +0100,
Moritz Neeb wrote:
[...]
>> OK, I've followed this advice and looked at the dependency graphs in
>> gitk before and after rebasing, I've managed to obtain what I was
>> after. The repository now has two branches: master and topic.
>> However, Gitk reveals a p
On Tue, Feb 23, 2016 at 11:57:06PM +0100, Moritz Neeb wrote:
> On 02/23/2016 06:39 PM, Seb wrote:
> > On Sun, 21 Feb 2016 03:12:49 +0100,
> > Moritz Neeb wrote:
> >
> >> Hi Seb,
> >> On 02/20/2016 11:58 PM, Seb wrote:
> >>> Hello,
> >
> >>> I've recently learnt how to consolidate and clean up th
John Keeping writes:
> My original sed version was:
>
> sed -ne "/^author /p" -e "/^summary /p"
>
> which I think will work on all platforms (we already use it in
> t-basic.sh) but then I decided to be too clever :-(
>
> I still think sed is simpler than introducing a new function to wr
On 02/23/2016 06:39 PM, Seb wrote:
> On Sun, 21 Feb 2016 03:12:49 +0100,
> Moritz Neeb wrote:
>
>> Hi Seb,
>> On 02/20/2016 11:58 PM, Seb wrote:
>>> Hello,
>
>>> I've recently learnt how to consolidate and clean up the master
>>> branch's commit history. I've squashed/fixuped many commits think
Jeff King writes:
> On Sun, Feb 21, 2016 at 11:43:45PM +, John Keeping wrote:
>
>> On Sun, Feb 21, 2016 at 04:15:31PM -0500, Eric Sunshine wrote:
>> > On Sun, Feb 21, 2016 at 12:32 PM, John Keeping wrote:
>> > > GNU grep 2.23 detects the input used in this test as binary data so it
>> > > do
I'm experiencing an annoying issue which leaves the repository in a
weird, broken state. I am attempting a rather vanilla rebase, rebasing
the commits from a feature branch on top of the newest commits on
master.
So, I run a typical series of commands:
1. git checkout feature-branch
2. git rebase
On Tue, Feb 23, 2016 at 12:46 PM, H. Peter Anvin wrote:
> On February 23, 2016 12:35:12 PM PST, Junio C Hamano
> wrote:
>>ebied...@xmission.com (Eric W. Biederman) writes:
>>
>>> Junio C Hamano writes:
>>>
It is valuable for a testing organization to say "We tested this
series on top
Hi Saravanan,
Changes that rewrite history, including (but not limited to) deleted
commits,
can be pushed with the --force or --force-with-lease options, like this:
$ git push --force remote branch
--force pushes your changes unconditionally, which may overwrite changes
that someone else
"H. Peter Anvin" writes:
> On February 23, 2016 12:35:12 PM PST, Junio C Hamano
> wrote:
>>ebied...@xmission.com (Eric W. Biederman) writes:
>>
>>> Junio C Hamano writes:
>>>
It is valuable for a testing organization to say "We tested this
series on top of version X. We know it work
On Tue, Feb 23, 2016 at 1:30 PM, Saravanan Shanmugham (sarvi)
wrote:
>
>
> Hi Git Leads,
> I am looking for git capability/way to be able to remove commits
> from a public repository.
>
> Background:
> We are looking for a multi-stage commit process where commits get pushed
> into a public ³
Matthieu Moy writes:
> Junio C Hamano writes:
>
>> Matthieu Moy writes:
>>
>>> I have always wondered why diff.renames was not activated by default.
>>> I've had it to true in my configuration for 9 years, and I've been
>>> teaching newbies to set it for a while without issue. I think it's
>>>
Matthieu Moy writes:
> Junio C Hamano writes:
>
>> Having said that, I agree with the spirit of 4/5 and 5/5; but it is
>> sad that this line is not resurrected by 5/5 in some way.
>
> Do you mean something like this:
>
> diff --git a/README.md b/README.md
> index 40de78e..b1c89bd 100644
> --- a/
Martin Langhoff writes:
> Hi git list! long time no see! :-) Been missing you lots.
>
> Do we currently have any means to clone _history_ but not _blobs_ of a
> repo, or some approximation thereof?
>
> With a bit more context: If I have a top-level project using a couple
> dozen submodules, where
Hi Git Leads,
I am looking for git capability/way to be able to remove commits
from a public repository.
Background:
We are looking for a multi-stage commit process where commits get pushed
into a public ³testing-stage² repository.
Where we do testing of commits before they are pushed to a
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> diff --git a/builtin/log.c b/builtin/log.c
>> index 7f96c64..6e34df3 100644
>> --- a/builtin/log.c
>> +++ b/builtin/log.c
>> @@ -103,6 +103,7 @@ static int log_line_range_callback(const struct option
>> *option, const char *arg,
>> static void
On Tue, Feb 23, 2016 at 01:09:44PM -0800, Junio C Hamano wrote:
> I tentatively squashed this, which I think reads better.
>
> diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c
> index 9a3a7a3..6b00ee0 100644
> --- a/credential-cache--daemon.c
> +++ b/credential-cache--daemon.c
Jeff King writes:
> On Tue, Feb 23, 2016 at 01:06:10PM -0800, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > + /*
>> > + * We don't actually care what our cwd is; we chdir here just to
>> > + * be a friendly daemon and avoid tying up our original cwd.
>> > + * If this fails, it's O
On Tue, Feb 23, 2016 at 01:06:10PM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > + /*
> > +* We don't actually care what our cwd is; we chdir here just to
> > +* be a friendly daemon and avoid tying up our original cwd.
> > +* If this fails, it's OK to just continue withou
Jeff King writes:
> + /*
> + * We don't actually care what our cwd is; we chdir here just to
> + * be a friendly daemon and avoid tying up our original cwd.
> + * If this fails, it's OK to just continue without that benefit.
> + */
> + chdir(dir);
I fully do agree wit
The default behavior is well documented already in git-config(1), but
git-push(1) itself did not mention it at all. For users willing to learn
how "git push" works but not how to configure it, this makes the
documentation cumbersome to read.
Make the git-push(1) page self-contained by adding a sho
Hi git list! long time no see! :-) Been missing you lots.
Do we currently have any means to clone _history_ but not _blobs_ of a
repo, or some approximation thereof?
With a bit more context: If I have a top-level project using a couple
dozen submodules, where the submodules are huge, do I have a
"Philip Oakley" writes:
> Shouldn't this also update the 'push' man page to state what the new
> default is. @gerry's comment to the top answer
> http://stackoverflow.com/a/13148313/717355 highlights that the word
> 'simple' is not even mentioned in the 'push' man page.
This is more or less a di
Matthieu Moy writes:
> diff --git a/builtin/log.c b/builtin/log.c
> index 7f96c64..6e34df3 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -103,6 +103,7 @@ static int log_line_range_callback(const struct option
> *option, const char *arg,
> static void init_log_defaults()
> {
> i
On Sat, Feb 06, 2016 at 10:56:46PM +0100, Ole Tange wrote:
> git diff first looks for a file, then looks if it is a reference to a
> revision. If the file fails due to being too long, the diff fails:
>
> $ git init
> $ git diff
> 'HEAD^^
tbo...@web.de writes:
> From: Torsten Bögershausen
>
> Commit "convert.c: refactor crlf_action" unified the crlf_handling
> and introdused a bug for "git ls-files --eol".
> The "text" attribute was shown as "text eol=lf" or "text eol=crlf",
> depending on core.autpcrlf or core.eol.
> Correct this
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> "the stupid content tracker" was true in the early days of Git, but
>> hardly applicable these days. "fast, scalable, distributed" describes
>> Git more accuralety.
>>
>> Also, "stupid" can be seen as offensive by some people. Let's not use it
>
On February 23, 2016 12:35:12 PM PST, Junio C Hamano wrote:
>ebied...@xmission.com (Eric W. Biederman) writes:
>
>> Junio C Hamano writes:
>>
>>> It is valuable for a testing organization to say "We tested this
>>> series on top of version X. We know it works, we have tested on a
>>> lot more ha
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> I have always wondered why diff.renames was not activated by default.
>> I've had it to true in my configuration for 9 years, and I've been
>> teaching newbies to set it for a while without issue. I think it's
>> time to activate it by default,
From: "Matthieu Moy"
From: Matthieu Moy
The warning was purposely long, both to explain the situation properly
and to give a strong incentive to set push.default explicitly. This was
important before the 2.0 transition, and remained important for a while
after, so that new users get push.defau
ebied...@xmission.com (Eric W. Biederman) writes:
> Junio C Hamano writes:
>
>> It is valuable for a testing organization to say "We tested this
>> series on top of version X. We know it works, we have tested on a
>> lot more hardware than the original developer had, we know this is
>> good to g
Junio C Hamano writes:
> Fengguang Wu writes:
>
>>> >> I have a mixed feeling about this one, primarily because this was
>>> >> already tried quite early in the life of "format-patch" command.
>>> >>
>>> >>
>>> >> http://thread.gmane.org/gmane.comp.version-control.git/9694/focus=9757
>>> >
Fengguag Wu, Xiaolong Ye, have you attempted to use the truncated
sha1 of the file the patch applies to? Git already places a file sha1
at the top of a patch. See the index line?
> diff --git a/fs/namespace.c b/fs/namespace.c
> index eccd925c6e82..3c3f8172c734 100644
> --- a/fs/namespace.c
> ++
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> Signed-off-by: Matthieu Moy
>> ---
>> README.md | 19 +--
>> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> Makes sense, provided if we want to do Markdown.
I'd say it the other way around: declaring README as markdown c
Fengguang Wu writes:
>> >> I have a mixed feeling about this one, primarily because this was
>> >> already tried quite early in the life of "format-patch" command.
>> >>
>> >> http://thread.gmane.org/gmane.comp.version-control.git/9694/focus=9757
>> >>
>> >> Only the name is different (it w
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> This allows repository browsers like GitHub to display the content of
>> the file nicely formatted.
>>
>> Signed-off-by: Matthieu Moy
>> ---
>
> To be honest, I have the most problem with this step in the whole
> series.
>
> Markdown when rende
Junio C Hamano writes:
> The punchline of that question is:
>
> I can obviously set it to one of the values mentioned, but what do
> they mean? What's the difference between simple and matching?
>
> It tells us that "See 'git help config'" is not such an effective
> message to help such a
Matthieu Moy writes:
> I have always wondered why diff.renames was not activated by default.
> I've had it to true in my configuration for 9 years, and I've been
> teaching newbies to set it for a while without issue. I think it's
> time to activate it by default, but please let me know if I miss
Matthieu Moy writes:
> "the stupid content tracker" was true in the early days of Git, but
> hardly applicable these days. "fast, scalable, distributed" describes
> Git more accuralety.
>
> Also, "stupid" can be seen as offensive by some people. Let's not use it
> in the very first words of the R
Matthieu Moy writes:
> Signed-off-by: Matthieu Moy
> ---
> README.md | 19 +--
> 1 file changed, 13 insertions(+), 6 deletions(-)
Makes sense, provided if we want to do Markdown.
If I were pushing this topic (i.e. cater to those who browse at
GitHub, not with "less" in the sou
Matthieu Moy writes:
> This allows repository browsers like GitHub to display the content of
> the file nicely formatted.
>
> Signed-off-by: Matthieu Moy
> ---
To be honest, I have the most problem with this step in the whole
series.
Markdown when rendered may be easier to read, but plain text
Matthieu Moy writes:
> The warning is mostly seen by beginners, who have not set their
> push.default configuration (yet). For many of them, the warning is
> confusing because it talks about concepts that they have not learned and
> asks them a choice that they are not able to make yet. See for e
Hello.
Working with Git for Windows on git gui I noticed an issue on reading
initial message to git gui message prompt.
Steps to reproduce:
git init .
echo 'a' > a && git add . && git commit -m 'added A'
git checkout -b devel
echo 'b' > b && git add . && git commit -m 'added B (ęóąśłżźćń
On Sat, 2016-02-20 at 23:55 +, Eric Wong wrote:
> David Turner wrote:
> > +++ b/git-svn.perl
>
> > + if (defined $_ref_storage) {
> > + push @init_db, "--ref-storage=" .
> > $_ref_storage;
> > + }
>
> Minor nit: git-svn uses tabs for indentation.
> Otherwise
Rename detection is a very convenient feature, and new users shouldn't
have to dig in the documentation to benefit from it.
Potential objections to activating rename detection are that it
sometimes fail, and it is sometimes slow. But rename detection is
already activated by default in several case
Signed-off-by: Matthieu Moy
---
t/t4001-diff-rename.sh | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/t/t4001-diff-rename.sh b/t/t4001-diff-rename.sh
index 2f327b7..bfb364c 100755
--- a/t/t4001-diff-rename.sh
+++ b/t/t4001-diff-rename.
This is currently a wrapper around init_grep_defaults(), but will allow
adding more initialization in further patches.
Signed-off-by: Matthieu Moy
---
builtin/log.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 0d738d6..7
The description was misleading, since "set to any boolean value" include
"set to false", and diff.renames=false does not enable basic detection,
but actually disables it.
Signed-off-by: Matthieu Moy
---
Documentation/diff-config.txt | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
d
The underlying machinery is well-tested, but the configuration option
itself was tested only in t3400-rebase.sh.
Signed-off-by: Matthieu Moy
---
t/t4001-diff-rename.sh | 61 +-
1 file changed, 60 insertions(+), 1 deletion(-)
diff --git a/t/t4001-d
I have always wondered why diff.renames was not activated by default.
I've had it to true in my configuration for 9 years, and I've been
teaching newbies to set it for a while without issue. I think it's
time to activate it by default, but please let me know if I missed a
reason to keep it to false
"the stupid content tracker" was true in the early days of Git, but
hardly applicable these days. "fast, scalable, distributed" describes
Git more accuralety.
Also, "stupid" can be seen as offensive by some people. Let's not use it
in the very first words of the README.
The new formulation is tak
The explanations about why the name was chosen are secondary compared to
the description and link to the documentation.
Some consider these explanations as good computer scientists joke, but
other see it as needlessly offensive vocabulary.
This patch preserves the historical joke, but gives it le
This patch series was inspired by a discussion I had with Emma Jane
after Git Merge last year. It tries both to make the README file less
agressive and generally more pleasant to read.
To get a quick overview, compare the old one:
https://github.com/git/git#readme
and my proposal:
https://g
Signed-off-by: Matthieu Moy
---
README.md | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/README.md b/README.md
index 907eb3b..750fdda 100644
--- a/README.md
+++ b/README.md
@@ -20,17 +20,17 @@ License version 2 (some parts of it are under different
licen
On Sun, 21 Feb 2016 03:12:49 +0100,
Moritz Neeb wrote:
> Hi Seb,
> On 02/20/2016 11:58 PM, Seb wrote:
>> Hello,
>> I've recently learnt how to consolidate and clean up the master
>> branch's commit history. I've squashed/fixuped many commits thinking
>> these would propagate to the children bra
This allows repository browsers like GitHub to display the content of
the file nicely formatted.
Signed-off-by: Matthieu Moy
---
README => README.md | 6 +-
t/t7001-mv.sh | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
rename README => README.md (93%)
diff --git a/README b/R
The documentation available on git-scm.com is nicely formatted. It's
better to point users to it than to the source code of the
documentation.
Signed-off-by: Matthieu Moy
---
README.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/README.md b/README.md
index 750fdda..
1 - 100 of 151 matches
Mail list logo
