Re: [PATCH 06/10] rev-list: add --allow-partial option to relax connectivity checks

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 03:10:54PM -0500, Jeff Hostetler wrote: > > Even though I do very much like the basic "high level" premise to > > omit often useless large blobs that are buried deep in the history > > we would not necessarily need from the initial cloning and > > subsequent fetches, I

Re: [PATCH 04/10] upload-pack: add partial (sparse) fetch

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 05:37:59PM +, Jeff Hostetler wrote: > diff --git a/Documentation/technical/pack-protocol.txt > b/Documentation/technical/pack-protocol.txt > index c59ac99..0032729 100644 > --- a/Documentation/technical/pack-protocol.txt > +++

Re: [PATCH][GSoc] Changed signed flags to unsigned type

2017-03-08 Thread Christian Couder
On Thu, Mar 9, 2017 at 5:24 AM, Vedant Bassi wrote: > As part of my microproject : > > Use unsigned integral type for collection of bits: > Pick one field of a structure that (1) is of signed integral type and > (2) is used as a collection of multiple bits. Discuss if

Re: [PATCH 03/10] pack-objects: test for --partial-by-size --partial-special

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 05:37:58PM +, Jeff Hostetler wrote: > diff --git a/t/5316-pack-objects-partial.sh b/t/5316-pack-objects-partial.sh > [...] > +test_expect_success 'setup' ' > + perl -e "print \"a\" x 11;" > a && > + perl -e "print \"a\" x 1100;"> b && > + perl -e

Re: [PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 03:21:11PM -0500, Jeff Hostetler wrote: > > And not ."gitmodules"? > > > > What happens when we later add ".gitsomethingelse"? > > > > Do we have to worry about the case where the set of git "special > > files" (can we have a better name for them please, by the way?) > >

Re: [PATCH 01/10] pack-objects: eat CR in addition to LF after fgets.

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 05:37:56PM +, Jeff Hostetler wrote: > From: Jeff Hostetler > > Signed-off-by: Jeff Hostetler > --- > builtin/pack-objects.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/builtin/pack-objects.c

Re: [PATCH] t*: avoid using pipes

2017-03-08 Thread Prathamesh Chavan
I have created the required changes and submitted a single file patch. Also I tried my best to include each of the suggestions in that patch. https://public-inbox.org/git/0102015aae7b8536-00c57d0a-1d48-4153-a202-87c4ea9e0e19-000...@eu-west-1.amazonses.com/ On Wed, Mar 8, 2017 at 7:02 PM,

[PATCH][GSoc] Changed signed flags to unsigned type

2017-03-08 Thread Vedant Bassi
As part of my microproject : Use unsigned integral type for collection of bits: Pick one field of a structure that (1) is of signed integral type and (2) is used as a collection of multiple bits. Discuss if there is a good reason why it has to be a signed integral field and change it to an

[PATCH v2 03/11] submodule deinit: use most reliable url

2017-03-08 Thread Brandon Williams
The user could have configured the submodule to have a different URL from the one in the superproject's config. To account for this read what the submodule has configured for remote.origin.url and use that instead. Signed-off-by: Brandon Williams --- git-submodule.sh | 2 +-

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
> Then the next step (as outlined by Documentation/SubmittingPatches) > is to figure out how to best present this to the mailing list; I think the > best > way is to send out a patch series consisting of both of these 2 patches, > the "connect_work_tree_and_git_dir: safely create leading

[PATCH] Allow "-" as a short-hand for "@{-1}" in branch deletions

2017-03-08 Thread Shuyang Shi
The "-" shorthand that stands for "the branch we were previously on", like we did for "git merge -" sometime after we introduced "git checkout -". Now I am introducing this shorthand to branch delete, i.e. "git branch -d -". More reference:

[PATCH GSoC] Allow "-" as a short-hand for "@{-1}" in branch deletions

2017-03-08 Thread Shuyang Shi
The "-" shorthand that stands for "the branch we were previously on", like we did for "git merge -" sometime after we introduced "git checkout -". Now I am introducing this shorthand to branch delete, i.e. "git branch -d -". More reference:

Re: [PATCH v2 10/11] submodule--helper init: set submodule..active

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 5:23 PM, Brandon Williams wrote: > When initializing a submodule set the submodule..active config to > true to indicate that the submodule is active. So by this patch an init of a submodule performs both a "regular init" (copy URL and the update setting)

Re: [PATCH v2 07/11] submodule update: add `--init-active` switch

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 5:23 PM, Brandon Williams wrote: > The new switch `--init-active` initializes the submodules which are > configured in `submodule.active` instead of those given as > command line arguments before updating. In the first implementation this > is made

Re: [PATCH v2 03/11] submodule deinit: use most reliable url

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 5:23 PM, Brandon Williams wrote: > The user could have configured the submodule to have a different URL > from the one in the superproject's config. To account for this read > what the submodule has configured for remote.origin.url and use that >

[PATCH] read-tree: mark a file-local symbol as static

2017-03-08 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Stefan, If you need to re-roll your 'sb/checkout-recurse-submodules' branch, could you please squash this into the relevant patch (commit 97aadb19f1, "builtin/read-tree: add --recurse-submodules switch", 06-03-2017). ATB, Ramsay

[PATCH v2 08/11] clone: add --submodule-spec= switch

2017-03-08 Thread Brandon Williams
The new switch passes the pathspec to `git submodule update --init-active` which is called after the actual clone is done. Additionally this configures the submodule.active option to be the given pathspec, such that any future invocation of `git submodule update --init-active` will keep up with

[PATCH v2 10/11] submodule--helper init: set submodule..active

2017-03-08 Thread Brandon Williams
When initializing a submodule set the submodule..active config to true to indicate that the submodule is active. Signed-off-by: Brandon Williams --- builtin/submodule--helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/builtin/submodule--helper.c

[PATCH v2 07/11] submodule update: add `--init-active` switch

2017-03-08 Thread Brandon Williams
The new switch `--init-active` initializes the submodules which are configured in `submodule.active` instead of those given as command line arguments before updating. In the first implementation this is made incompatible with further command line arguments as it is unclear what the user means by

[PATCH v2 01/11] submodule--helper: add is_active command

2017-03-08 Thread Brandon Williams
There are a lot of places where an explicit check for submodule."".url is done to see if a submodule exists. In order to centralize this check introduce a helper which can be used to query if a submodule is active or not. Signed-off-by: Brandon Williams ---

[PATCH v2 06/11] submodule: decouple url and submodule existence

2017-03-08 Thread Brandon Williams
Currently the submodule..url config option is used to determine if a given submodule exists and is interesting to the user. This however doesn't work very well because the URL is a config option for the scope of a repository, whereas the existence of a submodule is an option scoped to the working

[PATCH v2 09/11] completion: clone can initialize specific submodules

2017-03-08 Thread Brandon Williams
Signed-off-by: Brandon Williams --- contrib/completion/git-completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 6721ff80f..4e473aa90 100644 ---

[PATCH v2 11/11] submodule add: respect submodule.active and submodule..active

2017-03-08 Thread Brandon Williams
In addition to adding submodule..url to the config, set submodule..active to true unless submodule.active is configured and the submodule's path matches the configured pathspec. Signed-off-by: Brandon Williams --- git-submodule.sh | 12

[PATCH v2 00/11] decoupling a submodule's existence and its url

2017-03-08 Thread Brandon Williams
Differences from v1: * Reordered some of the patches * added submodule..active boolean config option which can be used to do more fine grain selection of submodules while still decoupling the existence from the URL. * submodule..active has precedence over the pathspec stored in

[PATCH v2 04/11] submodule sync: use submodule--helper is-active

2017-03-08 Thread Brandon Williams
Signed-off-by: Brandon Williams --- git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-submodule.sh b/git-submodule.sh index 1c2064cc1..7ed1aaba3 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -1101,7 +1101,7 @@ cmd_sync()

[PATCH v2 02/11] submodule status: use submodule--helper is-active

2017-03-08 Thread Brandon Williams
Signed-off-by: Brandon Williams --- git-submodule.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 554bd1c49..19660b9c0 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -1000,14 +1000,13 @@ cmd_status()

[PATCH v2 05/11] submodule--helper clone: check for configured submodules using helper

2017-03-08 Thread Brandon Williams
Use the 'is_submodule_initialized()' helper to check for configured submodules instead of manually checking for the submodule's URL in the config. Signed-off-by: Brandon Williams --- builtin/submodule--helper.c | 15 +++ 1 file changed, 3 insertions(+), 12

[PATCH v3 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Valery Tolstov
Stefan Beller (1): connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov (1): submodule--helper.c: remove duplicate code builtin/submodule--helper.c | 22 ++ dir.c | 32 +--- submodule.c

Re: diff.ignoreSubmoudles config setting broken?

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 3:08 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Yeah the .gitmodules file is a good hint. And by that I meant that I am not sure if we're going down the right rabbit hole here. So before we take action maybe Sebastian can

[PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
Remove code fragment from module_clone that duplicates functionality of connect_work_tree_and_git_dir in dir.c Signed-off-by: Valery Tolstov --- builtin/submodule--helper.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git

[PATCH v3 1/2] connect_work_tree_and_git_dir: safely create leading directories

2017-03-08 Thread Valery Tolstov
From: Stefan Beller In a later patch we'll use connect_work_tree_and_git_dir when the directory for the gitlink file doesn't exist yet. This patch makes connect_work_tree_and_git_dir safe to use for both cases of either the git dir or the working dir missing. To do so, we

Re: What's cooking in git.git (Mar 2017, #03; Wed, 8)

2017-03-08 Thread Jonathan Tan
On 03/08/2017 03:47 PM, Junio C Hamano wrote: * jt/mark-tree-uninteresting-for-uninteresting-commit (2017-02-28) 3 commits - upload-pack: compute blob reachability correctly - revision: exclude trees/blobs given commit - revision: unify {tree,blob}_objects in rev_info The revision/object

Re: [PATCH v2 2/2] submodule--helper.c: remove duplicate code

2017-03-08 Thread Brandon Williams
On 03/09, Valery Tolstov wrote: > Remove code fragment from module_clone that duplicates functionality > of connect_work_tree_and_git_dir in dir.c > > Signed-off-by: Valery Tolstov Patch looks good all the tests pass when running this on top of Stefan's checkout series

Re: What's cooking in git.git (Mar 2017, #03; Wed, 8)

2017-03-08 Thread brian m. carlson
On Wed, Mar 08, 2017 at 03:47:20PM -0800, Junio C Hamano wrote: > * bc/object-id (2017-02-22) 19 commits > - wt-status: convert to struct object_id > - builtin/merge-base: convert to struct object_id > - Convert object iteration callbacks to struct object_id > - sha1_file: introduce an

Re: Re: [PATCH v2 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Valery Tolstov
> The usual protocol would be to rebase off of Stefan's series and build > on that (assuming you have a dependency against his series), indicating > that you are doing as such in your cover letter. So, should I send only my patch, or current format (patch and dependency) is acceptalbe? Regards,

More about blob reachability (while fetching arbitrary blobs)

2017-03-08 Thread Jonathan Tan
There has been some talk about fetching blobs from repos with missing objects [1] [2]. I took a further look at the issue of blob reachability. I have written earlier that there is a bug in rev-list when used to compute reachability [3], but someone pointed me to bitmaps, and I found out that

Re: [PATCH v2 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Brandon Williams
On 03/09, Valery Tolstov wrote: > > Then the next step (as outlined by Documentation/SubmittingPatches) > > is to figure out how to best present this to the mailing list; I think the > > best > > way is to send out a patch series consisting of both of these 2 patches, > > the

[PATCH v2 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Valery Tolstov
> Then the next step (as outlined by Documentation/SubmittingPatches) > is to figure out how to best present this to the mailing list; I think the > best > way is to send out a patch series consisting of both of these 2 patches, > the "connect_work_tree_and_git_dir: safely create leading

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 3:24 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> Also, >>> should I start new thread for new patch series? >> >> As you like. >> As far as I understand, it is very easy for Junio to take a whole >> (sub-)thread of patches

[PATCH v2 1/2] connect_work_tree_and_git_dir: safely create leading directories

2017-03-08 Thread Valery Tolstov
From: Stefan Beller In a later patch we'll use connect_work_tree_and_git_dir when the directory for the gitlink file doesn't exist yet. This patch makes connect_work_tree_and_git_dir safe to use for both cases of either the git dir or the working dir missing. To do so, we

[PATCH v2 2/2] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
Remove code fragment from module_clone that duplicates functionality of connect_work_tree_and_git_dir in dir.c Signed-off-by: Valery Tolstov --- builtin/submodule--helper.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git

What's cooking in git.git (Mar 2017, #03; Wed, 8)

2017-03-08 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. You can find the changes

Re: [PATCHv4] rev-parse: add --show-superproject-working-tree

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: > *this patch* > > * Documentation shamelessly stolen from Junio. You stole it, and then ... > +test_expect_success 'showing the superproject correctly' ' > + git rev-parse --show-superproject-working-tree >out && > + test_must_be_empty out

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: >> Also, >> should I start new thread for new patch series? > > As you like. > As far as I understand, it is very easy for Junio to take a whole > (sub-)thread of patches and apply that and make a branch with > multiple commits out of it as he has

Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: > Side-question: > Is there some doc (commit message), that explains the difference > between CE_REMOVE and CE_WT_REMOVE ? That's something you need to ask Duy, I think, as it was introduced at e663db2f ("unpack-trees(): add CE_WT_REMOVE to remove on

Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

2017-03-08 Thread Stefan Beller
On Tue, Mar 7, 2017 at 5:14 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> submodule_from_ce returns always NULL, when such flag is not given. >> From 10/18: >> >> +const struct submodule *submodule_from_ce(const struct cache_entry *ce) >> +{ >> +

[PATCHv4] rev-parse: add --show-superproject-working-tree

2017-03-08 Thread Stefan Beller
In some situations it is useful to know if the given repository is a submodule of another repository. Add the flag --show-superproject-working-tree to git-rev-parse to make it easy to find out if there is a superproject. When no superproject exists, the output will be empty. Signed-off-by:

Re: diff.ignoreSubmoudles config setting broken?

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: > Yeah the .gitmodules file is a good hint. > > Here is my understanding of the precedence: > > command line options > .git/config (in various forms) > .gitmodules > > where in the .git config we have precedence levels for different files > >

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 3:05 PM, Valery Tolstov wrote: >> Then the next step (as outlined by Documentation/SubmittingPatches) >> is to figure out how to best present this to the mailing list; I think the >> best >> way is to send out a patch series consisting of both of these 2

Re: [PATCH] branch & tag: Add a --no-contains option

2017-03-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > More notes about this patch: > > * I'm not really happy with the "special attention" documentation >example in git-branch.txt, but it follows logically from the >description for --contains just above it which I think is overly >

Re: diff.ignoreSubmoudles config setting broken?

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 12:54 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Wed, Mar 8, 2017 at 7:07 AM, Sebastian Schuberth >> wrote: >>> >>> + Jens >>> >> >> + Jacob Keller, who touched submodule diff display code last.

Re: [PATCH v3 0/9] Fix the early config

2017-03-08 Thread Junio C Hamano
Jeff King writes: >> Or are you discussing a more general issue, iow, anything that can >> work without repository (i.e. those who do _gently version of the >> setup and act on *nongit_ok) should pretend as if there were no >> (broken) repository and take the "no we are not in a

[PATCH] branch: honor --abbrev/--no-abbrev in --list mode

2017-03-08 Thread Junio C Hamano
When the "branch --list" command was converted to use the --format facility from the ref-filter API, we forgot to honor the --abbrev setting in the default output format and instead used a hardcoded "7". Signed-off-by: Junio C Hamano --- * This time with test. I am building

Re: diff.ignoreSubmoudles config setting broken?

2017-03-08 Thread Jacob Keller
On Wed, Mar 8, 2017 at 11:04 AM, Stefan Beller wrote: > On Wed, Mar 8, 2017 at 7:07 AM, Sebastian Schuberth > wrote: >> >> + Jens >> > > + Jacob Keller, who touched submodule diff display code last. > (I am thinking of fd47ae6a, diff: teach diff to

Re: [PATCH] t2027: avoid using pipes

2017-03-08 Thread Prathamesh Chavan
Whenever a test suite is executed, after finishing every test, after running all tests, the function test_done is called. You may find this function in test-lib.sh . This function displays the result of the test and also removes the trash created by running the test. On Wed, Mar 8, 2017 at 9:14

Re: [PATCHv3] rev-parse: add --show-superproject-working-tree

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: > +--show-superproject-working-tree > + Show the absolute path of the top-level directory of > + the superproject. A superproject is a repository that records > + this repository as a submodule. The top-level directory of the superproject's

Re: Crash on MSYS2 with GIT_WORK_TREE

2017-03-08 Thread Junio C Hamano
Brandon Williams writes: > Of course, I usually try to clear the parts of the mail I'm not > responding to...though there are times where I forget or am a bit lazy. > I'll definitely work on remembering to do that for the future! This cuts both ways. Sometimes it is very

Re: [PATCH] t2027: avoid using pipes

2017-03-08 Thread Prathamesh Chavan
But when I read the function carefully, it only removes the trash files created when test_failure is equal to zero. But as far as I know, I can see the files being removed even when a test_failure is non-zero for some test script. On Thu, Mar 9, 2017 at 3:08 AM, Prathamesh Chavan

Re: diff.ignoreSubmoudles config setting broken?

2017-03-08 Thread Junio C Hamano
Stefan Beller writes: > On Wed, Mar 8, 2017 at 7:07 AM, Sebastian Schuberth > wrote: >> >> + Jens >> > > + Jacob Keller, who touched submodule diff display code last. > (I am thinking of fd47ae6a, diff: teach diff to display submodule > difference with

Re: BUG Report: git branch ignore --no-abbrev flag

2017-03-08 Thread Junio C Hamano
Junio C Hamano writes: > Guillaume Wenzek writes: > >> After updating to git 2.12.0 on Monday I noticed that the "git branch" >> wasn't behaving as usual. > > Are you sure you are trying 2.12? v2.12.0 and before should behave > the same way and

Re: [PATCH 2/2] Fix callsites of real_pathdup() that wanted it to die on error

2017-03-08 Thread Junio C Hamano
Brandon Williams writes: >> > diff --git a/abspath.c b/abspath.c >> > index 2f0c26e0e2c..b02e068aa34 100644 >> > --- a/abspath.c >> > +++ b/abspath.c >> > @@ -214,12 +214,12 @@ const char *real_path_if_valid(const char *path) >> >return strbuf_realpath(, path, 0); >> > }

[PATCH 4/4] ignore backup files

2017-03-08 Thread Florian Schüller
--- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index d7ebcaf..a353270 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,4 @@ /GIT-TCLTK-VARS /gitk-wish +*~ +po/gitk.pot -- 2.9.3

[PATCH 2/4] Update of German translation

2017-03-08 Thread Florian Schüller
--- po/de.po | 681 ++- 1 file changed, 366 insertions(+), 315 deletions(-) diff --git a/po/de.po b/po/de.po index 5db3824..ab90c34 100644 --- a/po/de.po +++ b/po/de.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version:

[PATCH 0/4] Gitk Inotify support

2017-03-08 Thread Florian Schüller
Inotify Support Just automatically update gitk when working in a terminal on the same repo Features: * Detects inotify support if inotify is not detected the options is not available in the preferences * Enable/Disable auto update in the preferences *

[PATCH 1/4] Inotify Support

2017-03-08 Thread Florian Schüller
Just automatically update gitk when working in a terminal on the same repo Features: * Detects inotify support if inotify is not detected the options is not available in the preferences * Enable/Disable auto update in the preferences * Select "debounce" time for redraw i.e. the redraw will

[PATCH 3/4] Updated de-Translator

2017-03-08 Thread Florian Schüller
--- po/de.po | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/po/de.po b/po/de.po index ab90c34..193059b 100644 --- a/po/de.po +++ b/po/de.po @@ -4,13 +4,14 @@ # # Christian Stimming , 2007. # Frederik Schwarzer , 2008. +# Florian

[PATCH 05/10] fetch-pack: add partial-by-size and partial-special

2017-03-08 Thread git
From: Jeff Hostetler Teach fetch-pack to take --partial-by-size and --partial-special arguments and pass them via the transport to upload-pack to request that certain blobs be omitted from the resulting packfile. Signed-off-by: Jeff Hostetler ---

[PATCH 04/10] upload-pack: add partial (sparse) fetch

2017-03-08 Thread git
From: Jeff Hostetler Teach upload-pack to advertise the "partial" capability in the fetch-pack/upload-pack protocol header and to pass the value of partial-by-size and partial-special on to pack-objects. Update protocol documentation. This might be used in conjunction

[PATCH 06/10] rev-list: add --allow-partial option to relax connectivity checks

2017-03-08 Thread git
From: Jeff Hostetler Teach rev-list to optionally not complain when there are missing blobs. This is for use following a partial clone or fetch when the server omitted certain blobs. Signed-off-by: Jeff Hostetler --- builtin/rev-list.c | 22

[PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special

2017-03-08 Thread git
From: Jeff Hostetler Teach pack-objects to omit blobs from the generated packfile. When the --partial-by-size=n[kmg] argument is used, only blobs smaller than the requested size are included. When n is zero, no blobs are included. When the --partial-special argument is

[PATCH 10/10] ls-partial: created command to list missing blobs

2017-03-08 Thread git
From: Jeff Hostetler Added a command to list the missing blobs for a commit. This can be used after a partial clone or fetch to list the omitted blobs that the client would need to checkout the given commit/branch. Optionally respecting or ignoring the current

[PATCH 01/10] pack-objects: eat CR in addition to LF after fgets.

2017-03-08 Thread git
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- builtin/pack-objects.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index f294dcf..7e052bb 100644 --- a/builtin/pack-objects.c +++

[PATCH 07/10] index-pack: add --allow-partial option to relax blob existence checks

2017-03-08 Thread git
From: Jeff Hostetler Teach index-pack to optionally not complain when there are missing blobs. This is for use following a partial clone or fetch when the server omitted certain blobs. Signed-off-by: Jeff Hostetler --- builtin/index-pack.c | 20

[PATCH 09/10] clone: add partial-by-size and partial-special arguments

2017-03-08 Thread git
From: Jeff Hostetler Teach clone to accept --partial-by-size=n and --partial-special arguments to request that the server omit certain blobs from the generated packfile. Signed-off-by: Jeff Hostetler --- builtin/clone.c | 26

[PATCH 03/10] pack-objects: test for --partial-by-size --partial-special

2017-03-08 Thread git
From: Jeff Hostetler Some simple tests for pack-objects with the new --partial-by-size and --partial-special options. Signed-off-by: Jeff Hostetler --- t/5316-pack-objects-partial.sh | 72 ++ 1 file

[PATCH 08/10] fetch: add partial-by-size and partial-special arguments

2017-03-08 Thread git
From: Jeff Hostetler Teach fetch to accept --partial-by-size=n and --partial-special arguments and pass them to fetch-patch to request that the server certain blobs from the generated packfile. Signed-off-by: Jeff Hostetler --- builtin/fetch.c |

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 11:59 AM, Valery Tolstov wrote: >> Maybe we need to have 2293f77a081 >> (connect_work_tree_and_git_dir: safely create leading directories, >> part of origin/sb/checkout-recurse-submodules, also found at >>

Re: [PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special

2017-03-08 Thread Jeff Hostetler
On 3/8/2017 1:47 PM, Junio C Hamano wrote: Jeff Hostetler writes: From: Jeff Hostetler Teach pack-objects to omit blobs from the generated packfile. When the --partial-by-size=n[kmg] argument is used, only blobs smaller than the requested

[PATCH] branch & tag: Add a --no-contains option

2017-03-08 Thread Ævar Arnfjörð Bjarmason
Change the branch & tag commands to have a --no-contains option in addition to their longstanding --contains options. The use-case I have for this is mainly to find the last-good rollout tag given a known-bad . Right given a hypothetically bad commit v2.10.1-3-gcf5c7253e0 now you can find that

Re: [PATCH 06/10] rev-list: add --allow-partial option to relax connectivity checks

2017-03-08 Thread Jeff Hostetler
On 3/8/2017 1:55 PM, Junio C Hamano wrote: Jeff Hostetler writes: From: Jeff Hostetler Teach rev-list to optionally not complain when there are missing blobs. This is for use following a partial clone or fetch when the server omitted

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
> Maybe we need to have 2293f77a081 > (connect_work_tree_and_git_dir: safely create leading directories, > part of origin/sb/checkout-recurse-submodules, also found at > https://public-inbox.org/git/20170306205919.9713-8-sbel...@google.com/ ) > first before we can apply this patch. Thank you for

[PATCHv3] rev-parse: add --show-superproject-working-tree

2017-03-08 Thread Stefan Beller
In some situations it is useful to know if the given repository is a submodule of another repository. Add the flag --show-superproject-working-tree to git-rev-parse to make it easy to find out if there is a superproject. Signed-off-by: Stefan Beller --- > Looks more or less

Re: [PATCH 06/10] rev-list: add --allow-partial option to relax connectivity checks

2017-03-08 Thread Junio C Hamano
Jeff Hostetler writes: > From: Jeff Hostetler > > Teach rev-list to optionally not complain when there are missing > blobs. This is for use following a partial clone or fetch when > the server omitted certain blobs. This makes it impossible to

Re: diff.ignoreSubmoudles config setting broken?

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 7:07 AM, Sebastian Schuberth wrote: > > + Jens > + Jacob Keller, who touched submodule diff display code last. (I am thinking of fd47ae6a, diff: teach diff to display submodule difference with an inline diff, 2016-08-31), which is first release as

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Stefan Beller
On Wed, Mar 8, 2017 at 9:44 AM, wrote: > From: Valery Tolstov > > Remove code fragment from module_clone that duplicates functionality > of connect_work_tree_and_git_dir in dir.c > > Signed-off-by: Valery Tolstov > --- >>> I think we can

[PATCH 00/10] RFC Partial Clone and Fetch

2017-03-08 Thread git
From: Jeff Hostetler [RFC] Partial Clone and Fetch = This is a WIP RFC for a partial clone and fetch feature wherein the client can request that the server omit various blobs from the packfile during clone and fetch. Clients can later

Re: [PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special

2017-03-08 Thread Junio C Hamano
Jeff Hostetler writes: > From: Jeff Hostetler > > Teach pack-objects to omit blobs from the generated packfile. > > When the --partial-by-size=n[kmg] argument is used, only blobs > smaller than the requested size are included. When n is zero, >

Re: Crash on MSYS2 with GIT_WORK_TREE

2017-03-08 Thread Brandon Williams
On 03/08, Johannes Schindelin wrote: > I did take a quick glance, but did you have a look at the time of day I > sent this patch? You do not want to trust my judgement after that. Haha Yeah I did notice, and I trust your newer patch more than the one you sent at 2am :) > > Another thing: may I

Re: [PATCH 2/2] Fix callsites of real_pathdup() that wanted it to die on error

2017-03-08 Thread Brandon Williams
On 03/08, René Scharfe wrote: > Am 08.03.2017 um 16:43 schrieb Johannes Schindelin: > > In 4ac9006f832 (real_path: have callers use real_pathdup and > > strbuf_realpath, 2016-12-12), we changed the xstrdup(real_path()) > > pattern to use real_pathdup() directly. > > > > The only problem with this

Re: BUG Report: git branch ignore --no-abbrev flag

2017-03-08 Thread Junio C Hamano
Guillaume Wenzek writes: > After updating to git 2.12.0 on Monday I noticed that the "git branch" > wasn't behaving as usual. Are you sure you are trying 2.12? v2.12.0 and before should behave the same way and honor --no-abbrev as far as I know. On the other hand,

Re: [PATCH v3 0/9] Fix the early config

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 05:18:46PM +0100, Johannes Schindelin wrote: > On Wed, 8 Mar 2017, Jeff King wrote: > > > Another "non-gentle" thing I noticed here while looking at > > another thread: the repository-format version check uses the config > > parser, which will die() in certain

BUG Report: git branch ignore --no-abbrev flag

2017-03-08 Thread Guillaume Wenzek
Hi, After updating to git 2.12.0 on Monday I noticed that the "git branch" wasn't behaving as usual. As of today `git branch -vv --no-abbrev` outputs short hashes instead of long one (as requested by --no-abbrev)[1] git branch -vv --no-abbrev * (HEAD detached at 2.12.1)

Re: [PATCH 2/2] Fix callsites of real_pathdup() that wanted it to die on error

2017-03-08 Thread René Scharfe
Am 08.03.2017 um 16:43 schrieb Johannes Schindelin: > In 4ac9006f832 (real_path: have callers use real_pathdup and > strbuf_realpath, 2016-12-12), we changed the xstrdup(real_path()) > pattern to use real_pathdup() directly. > > The only problem with this change is that real_path() calls >

Re: [PATCH 0/6] deadlock regression in v2.11.0 with failed mkdtemp

2017-03-08 Thread Horst Schirmeier
On Tue, 07 Mar 2017, Jeff King wrote: > On Tue, Mar 07, 2017 at 12:14:06PM +0100, Horst Schirmeier wrote: > > On Tue, 07 Mar 2017, Horst Schirmeier wrote: > > > I observe a regression that seems to have been introduced between > > > v2.10.0 and v2.11.0. When I try to push into a repository on the

Re: [PATCH v3 0/9] Fix the early config

2017-03-08 Thread Jeff King
On Wed, Mar 08, 2017 at 09:09:31AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Good catch. Another "non-gentle" thing I noticed here while looking at > > another thread: the repository-format version check uses the config > > parser, which will die() in certain

[PATCH 09/10] clone: add partial-by-size and partial-special arguments

2017-03-08 Thread Jeff Hostetler
From: Jeff Hostetler Teach clone to accept --partial-by-size=n and --partial-special arguments to request that the server omit certain blobs from the generated packfile. Signed-off-by: Jeff Hostetler --- builtin/clone.c | 26

[PATCH 06/10] rev-list: add --allow-partial option to relax connectivity checks

2017-03-08 Thread Jeff Hostetler
From: Jeff Hostetler Teach rev-list to optionally not complain when there are missing blobs. This is for use following a partial clone or fetch when the server omitted certain blobs. Signed-off-by: Jeff Hostetler --- builtin/rev-list.c | 22

[PATCH 08/10] fetch: add partial-by-size and partial-special arguments

2017-03-08 Thread Jeff Hostetler
From: Jeff Hostetler Teach fetch to accept --partial-by-size=n and --partial-special arguments and pass them to fetch-patch to request that the server certain blobs from the generated packfile. Signed-off-by: Jeff Hostetler --- builtin/fetch.c |

[PATCH 04/10] upload-pack: add partial (sparse) fetch

2017-03-08 Thread Jeff Hostetler
From: Jeff Hostetler Teach upload-pack to advertise the "partial" capability in the fetch-pack/upload-pack protocol header and to pass the value of partial-by-size and partial-special on to pack-objects. Update protocol documentation. This might be used in conjunction

[PATCH 01/10] pack-objects: eat CR in addition to LF after fgets.

2017-03-08 Thread Jeff Hostetler
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- builtin/pack-objects.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index f294dcf..7e052bb 100644 --- a/builtin/pack-objects.c +++

  1   2   >