Re: t5551 hangs ?

Hello, Torsten. On Tue, Aug 22, 2017 at 07:10:59AM +0200, Torsten Bögershausen wrote: > Hej, > I found 2 threads about hanging t5551, one in 2016, and one question > from Junio somewhen in 2017. > I have it reproducable here: > - Debian 8, 64 bit > - SSD > - Half-modern processor ;-) I don't

t5551 hangs ?

Hej, I found 2 threads about hanging t5551, one in 2016, and one question from Junio somewhen in 2017. I have it reproducable here: - Debian 8, 64 bit - SSD - Half-modern processor ;-) The last thing I can see is: ok 29 - test allowanysha1inwant with unreachable --- A simplified ps -ef

Re: [PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

On Mon, Aug 21, 2017 at 04:48:42PM +0100, Ramsay Jones wrote: > > Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with > repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo' > field to the repository structure, without modifying the initializer > of the

Re: [Patch size_t V3 15/19] Convert archive functions to size_t

On Sun, Aug 20, 2017 at 11:42:35PM -0700, Junio C Hamano wrote: > Martin Koegler writes: > > > From: Martin Koegler > > > > Signed-off-by: Martin Koegler > > --- > > archive-tar.c | 16 > >

Re: [PATCH v2 3/3] merge: save merge state earlier

Michael J Gruber writes: > static void prepare_to_commit(struct commit_list *remoteheads) > { > struct strbuf msg = STRBUF_INIT; > @@ -767,6 +768,8 @@ static void prepare_to_commit(struct commit_list > *remoteheads) > strbuf_commented_addf(,

Re: [PATCH v2 2/3] merge: split write_merge_state in two

Michael J Gruber writes: > write_merge_state() writes out the merge heads, mode, and msg. But we > may want to write out heads, mode without the msg. So, split out heads > (+mode) into a separate function write_merge_heads() that is called by > write_merge_state(). > > No

Re: [PATCH v2 1/3] Documentation/git-merge: explain --continue

Michael J Gruber writes: > Currently, 'git merge --continue' is mentioned but not explained. > > Explain it. > > Signed-off-by: Michael J Gruber > --- > Documentation/git-merge.txt | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 3/3] read-cache: avoid allocating every ondisk entry when writing

Kevin Willford writes: > When writing the index for each entry an ondisk struct will be > allocated and freed in ce_write_entry. We can do better by > using a ondisk struct on the stack for each entry. > > This is accomplished by using a stack ondisk_cache_entry_extended

Re: [PATCH 2/3] read-cache: fix memory leak in do_write_index

Kevin Willford writes: > The previous_name_buf was never getting released when there > was an error in ce_write_entry or allow was false and execution > was returned to the caller. > > Signed-off-by: Kevin Willford > --- Thanks for spotting an old

[no subject]

Hello! I am Mrs Wang Ling, I work at Lloyds TSB pacific LTD, I have a business proposal, contact me so i will tell you all about this proposal . Kind Regards Mrs Wang Ling

Re: [PATCH v3 00/23] Move exported packfile funcs to its own file

Jonathan Tan writes: > On Sat, 19 Aug 2017 23:40:33 -0700 > Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> > I have to say that this was a painful topic to integrate. >> > >> > As you may know, the mk/use-size-t-in-zlib

Re: [PATCH] pull: respect submodule update configuration

Brandon Williams writes: >> > I tried to make it work here: >> > https://public-inbox.org/git/89ab8aa3-8e19-46ba-b169-d1ea4cf4a...@gmail.com/ >> >> (A) you need to set expect there as well, to have sub{2,4,5} be expected >> there as well. >> >> (B) That may hint at another

Re: Submodule regression in 2.14?

Stefan Beller writes: > On Fri, Aug 18, 2017 at 11:51 PM, Junio C Hamano wrote: > >> As long as we are talking about idealized future world (well, at >> least an idea of somebody's "ideal", not necessarily shared by >> everybody), I wonder if there is even

Re: [RFC PATCH 0/5] Add option to autostage changes when continuing a rebase

Phillip Wood writes: > ... I prefer > having to pass --autostage with --continue so that it is a concious > decision by the user to stage unstaged changes when they continue rather > than rebase just doing it each time it continues. In other words, instead of

Re: "Your branch is up-to-date ..." is incorrect English grammar

Martin Ågren writes: >> But “your branch is up-to-date” is INCORRECT. And, because it’s >> incorrect, it conveys an odd and unsettling experience to native >> English speakers whenever they read it. >> >> If you’re curious, you can find plenty of discussion of this point

[PATCH 1/3] perf: add test for writing the index

A performance test for writing the index to be able to determine if changes to allocating ondisk structure help. Signed-off-by: Kevin Willford --- Makefile| 1 + t/helper/test-write-cache.c | 23 +++ t/perf/p0007-write-cache.sh |

[PATCH 2/3] read-cache: fix memory leak in do_write_index

The previous_name_buf was never getting released when there was an error in ce_write_entry or allow was false and execution was returned to the caller. Signed-off-by: Kevin Willford --- read-cache.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[PATCH 3/3] read-cache: avoid allocating every ondisk entry when writing

When writing the index for each entry an ondisk struct will be allocated and freed in ce_write_entry. We can do better by using a ondisk struct on the stack for each entry. This is accomplished by using a stack ondisk_cache_entry_extended outside looping through the entries in do_write_index.

[PATCH 0/3] read-cache: use stack ondisk struct when writing index

When writing out the index, the ondisk struct was being allocated and freed within the loop of cache entries. A better way would be to use a ondisk struct on the stack and reuse it avoiding the alloc and free calls. A test has been added to measure the performance of writing the index

Re: [RFC PATCH 5/6] Integrate hash algorithm support with repo setup

On Sun, Aug 20, 2017 at 5:00 PM, brian m. carlson wrote: > In future versions of Git, we plan to support an additional hash > algorithm. Integrate the enumeration of hash algorithms with repository > setup, and store a pointer to the enumerated data in struct

Re: [RFC PATCH 4/6] Add structure representing hash algorithm

On Sun, Aug 20, 2017 at 5:00 PM, brian m. carlson wrote: > Since in the future we want to support an additional hash algorithm, add > a structure that represents a hash algorithm and all the data that must > go along with it. Add a constant to allow easy enumeration

[GSoC] Update: Week 14

SUMMARY OF MY PROJECT: Git submodule subcommands are currently implemented by using shell script 'git-submodule.sh'. There are several reasons why we'll prefer not to use the shell script. My project intends to convert the subcommands into C code, thus making them builtins. This will increase

Re: [RFC PATCH 0/6] Hash Abstraction

On Sun, Aug 20, 2017 at 5:00 PM, brian m. carlson wrote: > = Overview > > This is an RFC series proposing a basic abstraction for hash functions. > > As we get closer to converting the remainder of the codebase to use > struct object_id, we should think about the

Re: [PATCH] git-gui: Prevent double UTF-8 conversion

+cc git gui maintainer On Mon, Aug 21, 2017 at 4:53 AM, Łukasz Stelmach wrote: > With encoding on the file descriptor set to "binary" Tcl (8.6 in my case) > does double conversion which breaks e.g. author name in amended commits. > > For example "\305\201ukasz" (as

Re: [PATCH v3 00/23] Move exported packfile funcs to its own file

On Sat, 19 Aug 2017 23:40:33 -0700 Junio C Hamano wrote: > Junio C Hamano writes: > > > I have to say that this was a painful topic to integrate. > > > > As you may know, the mk/use-size-t-in-zlib topic is being retracted > > and getting rerolled as a

Re: [PATCH] pull: respect submodule update configuration

On 08/21, Stefan Beller wrote: > On Mon, Aug 21, 2017 at 10:20 AM, Lars Schneider > wrote: > > > >> On 21 Aug 2017, at 18:55, Stefan Beller wrote: > >> > >> On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: > >> > So I am a

Re: [PATCH 4/4] archive: queue directories for all types of pathspecs

On Sat, Aug 19, 2017 at 9:53 AM, René Scharfe wrote: > Am 19.08.2017 um 07:33 schrieb René Scharfe: >> When read_tree_recursive() encounters a directory excluded by a pathspec >> then it enters it anyway because it might contain included entries. It >> calls the callback function

hii5

Re: [PATCH] pull: respect submodule update configuration

On Mon, Aug 21, 2017 at 10:20 AM, Lars Schneider wrote: > >> On 21 Aug 2017, at 18:55, Stefan Beller wrote: >> >> On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: >> So I am a bit curious to learn which part of this change

[PATCH v2 4/4] ThreadSanitizer: add suppressions

Add a file .tsan-suppressions and list two functions in it: want_color() and transfer_debug(). Both of these use the pattern static int foo = -1; if (foo < 0) foo = bar(); where bar always returns the same non-negative value. This can cause ThreadSanitizer to

[PATCH v2 3/4] strbuf_setlen: don't write to strbuf_slopbuf

strbuf_setlen(., 0) writes '\0' to sb.buf[0], where buf is either allocated and unique to sb, or the global slopbuf. The slopbuf is meant to provide a guarantee that buf is not NULL and that a freshly initialized buffer contains the empty string, but it is not supposed to be written to. That

[PATCH v2 2/4] pack-objects: take lock before accessing `remaining`

When checking the conditional of "while (me->remaining)", we did not hold the lock. Calling find_deltas would still be safe, since it checks "remaining" (after taking the lock) and is able to handle all values. In fact, this could (currently) not trigger any bug: a bug could happen if `remaining`

[PATCH v2 1/4] convert: always initialize attr_action in convert_attrs

convert_attrs contains an "if-else". In the "if", we set attr_action twice, and the first assignment has no effect. In the "else", we do not set it at all. Since git_check_attr always returns the same value, we'll always end up in the "if", so there is no problem right now. But convert_attrs is

[PATCH v2 0/4] Some ThreadSanitizer-results

This is the second version of my series to try to address some issues noted by ThreadSanitizer. Thanks to all who took the time to provide input on the first version. The largest change is in the third patch, which moves the "avoid writing to slopbuf"-logic into strbuf_setlen, and compiles it

Re: [GSoC][PATCH 3/4] submodule: port set_name_rev() from shell to C

On Mon, Aug 21, 2017 at 10:17 PM, Heiko Voigt wrote: > On Mon, Aug 21, 2017 at 09:45:14PM +0530, Prathamesh Chavan wrote: >> Function set_name_rev() is ported from git-submodule to the >> submodule--helper builtin. The function get_name_rev() generates the >> value of the

Re: [PATCH] pull: respect submodule update configuration

> On 21 Aug 2017, at 18:55, Stefan Beller wrote: > > On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: > >>> So I am a bit curious to learn which part of this change you dislike >>> and why. >> >> I am also curious. Isn't this the same strategy we are

Re: [PATCH] pull: respect submodule update configuration

On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt wrote: >> So I am a bit curious to learn which part of this change you dislike >> and why. > > I am also curious. Isn't this the same strategy we are using in other > places? > I dislike it because the UX feels crude. When reading

Re: Submodule regression in 2.14?

Heiko Voigt writes: > So I think it is important that there are commits in the submodule so > its history makes sense independently for others. I was trying to push the "just like trees" to the logical conclusion in order to see see if it leads to an absurd conclusions, or

Re: [GSoC][PATCH 3/4] submodule: port set_name_rev() from shell to C

On Mon, Aug 21, 2017 at 09:45:14PM +0530, Prathamesh Chavan wrote: > Function set_name_rev() is ported from git-submodule to the > submodule--helper builtin. The function get_name_rev() generates the > value of the revision name as required, and the function > print_name_rev() handles the

Re: Submodule regression in 2.14?

On Fri, Aug 18, 2017 at 11:51 PM, Junio C Hamano wrote: > As long as we are talking about idealized future world (well, at > least an idea of somebody's "ideal", not necessarily shared by > everybody), I wonder if there is even any need to have commits in > submodules in such

Re: [PATCH v2 1/3] Documentation/git-merge: explain --continue

On 21 August 2017 at 14:53, Michael J Gruber wrote: > Currently, 'git merge --continue' is mentioned but not explained. > > Explain it. > > Signed-off-by: Michael J Gruber > --- > Documentation/git-merge.txt | 5 - > 1 file changed, 4 insertions(+), 1

Re: Submodule regression in 2.14?

On Mon, Aug 21, 2017 at 9:05 AM, Heiko Voigt wrote: > On Fri, Aug 18, 2017 at 11:51:13PM -0700, Junio C Hamano wrote: >> As long as we are talking about idealized future world (well, at >> least an idea of somebody's "ideal", not necessarily shared by >> everybody), I wonder if

Re: [PATCH] pull: respect submodule update configuration

On Fri, Aug 18, 2017 at 11:24:47PM -0700, Junio C Hamano wrote: > Stefan Beller writes: > > > From: Lars Schneider > > > > Do not override the submodule configuration in the call to update > > the submodules, but give a weaker default. > > > >

Re: Submodule regression in 2.14?

On Fri, Aug 18, 2017 at 11:51:13PM -0700, Junio C Hamano wrote: > As long as we are talking about idealized future world (well, at > least an idea of somebody's "ideal", not necessarily shared by > everybody), I wonder if there is even any need to have commits in > submodules in such a world. To

[PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo' field to the repository structure, without modifying the initializer of the 'the_repo' variable. This does not actually introduce a bug, since the '0'

Re: [PATCH] Add 'raw' blob_plain link in history overview

Add 'raw' blob_plain link in history overview Reviewed-by: Giuseppe Bilotta Signed-off-by: Job Snijders --- gitweb/gitweb.perl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index

Re: [PATCH] Add 'raw' blob_plain link in history overview

Hello, On Mon, Aug 21, 2017 at 12:44 PM, Job Snijders wrote: > On Mon, Aug 21, 2017 at 12:19:38PM +0200, Giuseppe Bilotta wrote: > Thank you for your feedback, good point. Please see below: This looks fine > --- > > Add a 'raw' blob_plain link in history overview > >

[PATCH v2/RFC] commit: change the meaning of an empty commit message

An "empty commit message" according to 'commit' has long been, A message that contains only empty lines and/or whitespaces and/or 'Signed-off-by' lines This is biased as a commit message that contains only other trailers like 'Helped-by: ', 'Tested-by: ' etc., could equally be considered

Re: [PATCH v2] branch: change the error messages to be more meaningful

Sorry, wrong thread :( Please ignore this. --- Kaartic

[PATCH v2] branch: change the error messages to be more meaningful

The error messages shown when the branch command is misused by supplying it wrong number of parameters wasn't meaningful. That's because it used the the phrase "too many branches" assuming all parameters to be "valid" branch names. It's not always the case as exemplified below, $ git

[PATCH v2] branch: change the error messages to be more meaningful

The error messages shown when the branch command is misused by supplying it wrong number of parameters wasn't meaningful. That's because it used the the phrase "too many branches" assuming all parameters to be "valid" branch names. It's not always the case as exemplified below, $ git

[PATCH v2 2/3] merge: split write_merge_state in two

write_merge_state() writes out the merge heads, mode, and msg. But we may want to write out heads, mode without the msg. So, split out heads (+mode) into a separate function write_merge_heads() that is called by write_merge_state(). No funtional change so far. Signed-off-by: Michael J Gruber

[PATCH v2 0/3] Keep merge during kills

So here's a little series. 1/3 I just noted along the way 2/3 splits the merge state writing into parts as a preparatory step. This is something we may want to carry further and get rid of some other places which write merge_msg unneccessarily so that merge performance does not suffer because of

[PATCH v2 3/3] merge: save merge state earlier

If the `git merge` process is killed while waiting for the editor to finish, the merge state is lost but the prepared merge msg and tree is kept. So, a subsequent `git commit` creates a squashed merge even when the user asked for proper merge commit originally. Save the merge state earlier (in

[PATCH v2 1/3] Documentation/git-merge: explain --continue

Currently, 'git merge --continue' is mentioned but not explained. Explain it. Signed-off-by: Michael J Gruber --- Documentation/git-merge.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/git-merge.txt b/Documentation/git-merge.txt index

[PATCH] git-gui: Prevent double UTF-8 conversion

With encoding on the file descriptor set to "binary" Tcl (8.6 in my case) does double conversion which breaks e.g. author name in amended commits. For example "\305\201ukasz" (as written by git cat-file) becomes "\303\205\302\201ukasz". Signed-off-by: Łukasz Stelmach ---

[PATCH] Retry acquiring reference locks for 100ms

The philosophy of reference locking has been, "if another process is changing a reference, then whatever I'm trying to do to it will probably fail anyway because my old-SHA-1 value is probably no longer current". But this argument falls down if the other process has locked the reference to do

git@vger.kernel.org please confirm

Hello Earlier, I sent you an email on git@vger.kernel.org please confirm if you got my message? Angy Omari Private Phone+447031903929 omaria...@yandex.com

[GSoC][PATCH 4/4] submodule: port submodule subcommand 'status' from shell to C

This aims to make git-submodule 'status' a built-in. Hence, the function cmd_status() is ported from shell to C. This is done by introducing three functions: module_status(), submodule_status() and print_status(). The function module_status() acts as the front-end of the subcommand. It parses

[GSoC][PATCH 1/4] submodule--helper: introduce get_submodule_displaypath()

Introduce function get_submodule_displaypath() to replace the code occurring in submodule_init() for generating displaypath of the submodule with a call to it. This new function will also be used in other parts of the system in later patches. Mentored-by: Christian Couder

[GSoC][PATCH 3/4] submodule: port set_name_rev() from shell to C

Function set_name_rev() is ported from git-submodule to the submodule--helper builtin. The function get_name_rev() generates the value of the revision name as required, and the function print_name_rev() handles the formating and printing of the obtained revision name. Mentored-by: Christian

[GSoC][PATCH 2/4] submodule--helper: introduce for_each_submodule_list()

Introduce function for_each_submodule_list() and replace a loop in module_init() with a call to it. The new function will also be used in other parts of the system in later patches. Mentored-by: Christian Couder Mentored-by: Stefan Beller

Re: [PATCH] Add 'raw' blob_plain link in history overview

On Mon, Aug 21, 2017 at 12:19:38PM +0200, Giuseppe Bilotta wrote: > >> This patch adds a 'raw' blob_plain link in history overview. > > Arguably, the addition of the 'raw' link should be done in the same > conditional that also adds the 'diff to current' link, before the diff > to current link. >

Re: [RFC PATCH 0/5] Add option to autostage changes when continuing a rebase

On 27/07/17 16:24, Junio C Hamano wrote: > Phillip Wood writes: > >>> On 26/07/17 23:12, Junio C Hamano wrote: I think you are already 80% there without adding a yet another option,... >>> ... >>> I'm interested in the 20% as it's about 100% of my rebase

Re: [PATCH] Add 'raw' blob_plain link in history overview

Hello, On Sun, Aug 20, 2017 at 8:03 PM, Job Snijders wrote: > bump? (As a side note, I have also noticed that gitweb patches tend to go unreviewed for long) > On Wed, Aug 02, 2017 at 08:59:01PM +0200, Job Snijders wrote: >> We often work with very large plain text files in

[PATCH] merge: save merge state earlier

If the `git merge` process is killed while waiting for the editor to finish, the merge state is lost but the prepared merge msg and tree is kept. So, a subsequent `git commit` creates a squashed merge even when the user asked for proper merge commit originally. Save the merge state earlier (in

Re: Git makes a merge commit but as a normal (non-merge) commit

hIpPy venit, vidit, dixit 19.08.2017 00:35: > While merging if I do certain actions then the merge commit is made > with the merge message but as a normal (non-merge) commit. > > Repro steps: > - Set GIT_MERGE_AUTOEDIT=yes (set other than "no") in .bashrc > - Make a merge commit with no

Re: "Your branch is up-to-date ..." is incorrect English grammar

The code base contains a few instances of "up-to-date" and "up to date". A tree wide sweep could be made to update user-visible strings in the code and in the documentation. Fixing source code comments seems like overkill. Could I count on you to review any changes I'd propose? (With respect to

"Your branch is up-to-date ..." is incorrect English grammar

Either of these two options is CORRECT: “Your branch is up to date …” “You have an up-to-date branch …” But “your branch is up-to-date” is INCORRECT. And, because it’s incorrect, it conveys an odd and unsettling experience to native English speakers whenever they read it. If you’re

Re: [RFC 0/3] imap-send curl tunnelling support

Le 16/08/2017 à 10:34, Jeff King a écrit : > On Wed, Aug 09, 2017 at 04:43:26PM +0200, Nicolas Morey-Chaisemartin wrote: > >> I have a few doubt on patch #2: >> - is socketpair working on all git supported system (windows ?) > I'm pretty sure the answer is no, after searching a bit for mingw and

Re: [RFC 0/3] imap-send curl tunnelling support

(Sent a reply from my phone while out of town but couldn't find it so here it is again) It's available on my github: https://github.com/nmorey/git/tree/dev/curl-tunnel The series had been stlighly changed since the patch were posted, mostly to add the proper ifdefs to handle older curl

Re: [Patch size_t V3 15/19] Convert archive functions to size_t

Martin Koegler writes: > From: Martin Koegler > > Signed-off-by: Martin Koegler > --- > archive-tar.c | 16 > archive-zip.c | 22 +++--- > 2 files changed, 19 insertions(+), 19

Re: [Patch size_t V3 16/19] Convert various things to size_t

Martin Koegler writes: > From: Martin Koegler > > Signed-off-by: Martin Koegler > --- > bisect.c| 2 +- > blame.c | 2 +- > builtin/fmt-merge-msg.c | 2 +- > builtin/mktag.c |

Re: How can I make a best dissertation paper?

If you really need a dissertation work so don't worry. Dissertation Firm provides students with professional dissertation services. Our dissertation writers UK are remarkably experienced and know the value of timely submissions. -- View this message in