Re: [PATCH v2 08/11] t1404: demonstrate two problems with reference transactions

On 09/09/2017 01:17 PM, Jeff King wrote: > On Fri, Sep 08, 2017 at 03:51:50PM +0200, Michael Haggerty wrote: > [...] > So if we get what we want, we execute ":" which should be a successful > exit code. I think the `:` is superfluous even if we care about the exit code of the `case`. I'll remove

Re: [PATCH 00/12] Clean up notes-related code around `load_subtree()`

On 09/09/2017 12:31 PM, Jeff King wrote: > On Sat, Aug 26, 2017 at 10:28:00AM +0200, Michael Haggerty wrote: > >> It turns out that the comment is incorrect, but there was nevertheless >> plenty that could be cleaned up in the area: >> >> * Make macro `GIT_NIBBLE` safer by adding some parentheses

Hello

Hello , This is to inform you that this bank has appointed a New managing Director and on this note informing you about your withheld fund $950,000 Dollars been held by pass administration. As the New appointed manager, collaboration with Benin republic government and governor central bank

Unexpected pass for t6120-describe.sh on cygwin

Hi Adam, I ran the test-suite on the 'pu' branch last night (simply because that was what I had built at the time!), which resulted in a PASS, but t6120 was showing a 'TODO passed' for #52. This is a test introduced by Michael's 'mg/name-rev-tests-with-short-stack' branch, which uses 'ulimit -s'

Re: Donation

Greetings To You, My Name is Mavis wanczyk , the winner of the Power ball jackpot of $ $758.7 million in the AUGUST 24, 2017, My jackpot was a gift from God to me hence my Entire family/foundation has AGREED to do this. My foundation is donating $500,000.00USD to you. please contac

Re: git diff doesn't quite work as documented?

2017-09-08 0:31 GMT+08:00 Olaf Klischat : > oklischat@oklischat:/tmp$ mkdir gittest > oklischat@oklischat:/tmp$ cd gittest/ > oklischat@oklischat:/tmp/gittest$ git init > Initialized empty Git repository in /private/tmp/gittest/.git/ > oklischat@oklischat:/tmp/gittest$

Re: [PATCH v2 00/11] Implement transactions for the packed ref store

On Fri, Sep 08, 2017 at 03:51:42PM +0200, Michael Haggerty wrote: > This is v2 of a patch series to implement reference transactions for > the packed refs-store. Thanks to Stefan, Brandon, Junio, and Peff for > your review of v1 [1]. I believe I have addressed all of your > comments. > > Changes

Re: [PATCH v2 08/11] t1404: demonstrate two problems with reference transactions

On Fri, Sep 08, 2017 at 03:51:50PM +0200, Michael Haggerty wrote: > +test_expect_failure 'no bogus intermediate values during delete' ' > + prefix=refs/slow-transaction && > + # Set up a reference with differing loose and packed versions: > + git update-ref $prefix/foo $C && > +

Re: [PATCH v4 0/4] Rerolling ma/split-symref-update-fix

On Sat, Sep 09, 2017 at 08:57:14AM +0200, Martin Ågren wrote: > > I'll take Peff's hint, tweak/add comments for correctness and symmetry > > with the previous patch and add an if-BUG for symmetry. > > Here's a reroll of ma/split-symref-update-fix. The first three patches > are v3 plus Michael's

Re: [PATCH 00/12] Clean up notes-related code around `load_subtree()`

On Sat, Aug 26, 2017 at 10:28:00AM +0200, Michael Haggerty wrote: > It turns out that the comment is incorrect, but there was nevertheless > plenty that could be cleaned up in the area: > > * Make macro `GIT_NIBBLE` safer by adding some parentheses > * Remove some dead code > * Fix some memory

Funds

I am Henry Ivan Loo,an Attorney at law have a Next of Kin Proposal for you. A deceased client of mine left a total sum of ($50,600,000.00 USD) without any next of Kin as regards his funds. This totally legal with all documents to back you up as the next of kin. for more details if interested,

[PATCH v4 0/4] Rerolling ma/split-symref-update-fix

> I'll take Peff's hint, tweak/add comments for correctness and symmetry > with the previous patch and add an if-BUG for symmetry. Here's a reroll of ma/split-symref-update-fix. The first three patches are v3 plus Michael's Reviewed-By. The fourth is the conceptual fix of adding `refname`

[PATCH v4 4/4] refs/files-backend: add `refname`, not "HEAD", to list

An earlier patch rewrote `split_symref_update()` to add a copy of a string to a string list instead of adding the original string. That was so that the original string could be freed in a later patch, but it is also conceptually cleaner, since now all calls to `string_list_insert()` and

[PATCH v4 3/4] refs/files-backend: correct return value in lock_ref_for_update

In one code path we return a literal -1 and not a symbolic constant. The value -1 would be interpreted as TRANSACTION_NAME_CONFLICT, which is wrong. Use TRANSACTION_GENERIC_ERROR instead (that is the only other return value we have to choose from). Noticed-by: Michael Haggerty

[PATCH v4 2/4] refs/files-backend: fix memory leak in lock_ref_for_update

After the previous patch, none of the functions we call hold on to `referent.buf`, so we can safely release the string buffer before returning. Reviewed-by: Michael Haggerty Signed-off-by: Martin Ågren --- refs/files-backend.c | 31

[PATCH v4 1/4] refs/files-backend: add longer-scoped copy of string to list

split_symref_update() receives a string-pointer `referent` and adds it to the list of `affected_refnames`. The list simply holds on to the pointers it is given, it does not copy the strings and it does not ever free them. The `referent` string in split_symref_update() belongs to a string buffer in

Re: "git shortlog -sn --follow -- " counts all commits to entire repo

On Sat, Sep 09, 2017 at 02:37:20AM +0900, Junio C Hamano wrote: > > That said, I don't think we can go wrong by making shortlog's traversal > > more like log's. Any changes we make to --follow will be aimed at and > > tested with git-log, so the more code they share the more likely it is > > that

Re: [PATCH v4 00/16] Fix git-gc losing objects in multi worktree

On 08/23/2017 02:36 PM, Nguyễn Thái Ngọc Duy wrote: > "git gc" when used in multiple worktrees ignore some per-worktree > references: object references in the index, HEAD and reflog. This > series fixes it by making the revision walker include these from all > worktrees by default (and the series

Re: [PATCH v4 16/16] refs.c: reindent get_submodule_ref_store()

On 08/23/2017 02:37 PM, Nguyễn Thái Ngọc Duy wrote: > With the new "if (!submodule) return NULL;" code added in the previous > commit, we don't need to check if submodule is not NULL anymore. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > refs.c | 12 +--- > 1 file

Re: [PATCH v4 15/16] refs.c: remove fallback-to-main-store code get_submodule_ref_store()

On 08/23/2017 02:37 PM, Nguyễn Thái Ngọc Duy wrote: > At this state, there are three get_submodule_ref_store() callers: > > - for_each_remote_ref_submodule() > - handle_revision_pseudo_opt() > - resolve_gitlink_ref() > > The first two deal explicitly with submodules (and we should never fall

Re: [PATCH v4 12/16] files-backend: make reflog iterator go through per-worktree reflog

On 08/23/2017 02:37 PM, Nguyễn Thái Ngọc Duy wrote: > refs/bisect is unfortunately per-worktree, so we need to look in > per-worktree logs/refs/bisect in addition to per-repo logs/refs. The > current iterator only goes through per-repo logs/refs. > > Use merge iterator to walk two ref stores at

Re: [PATCH v4 11/16] revision.c: --all adds HEAD from all worktrees

On 08/23/2017 02:36 PM, Nguyễn Thái Ngọc Duy wrote: > [...] > diff --git a/revision.c b/revision.c > index 8d04516266..0e98444857 100644 > --- a/revision.c > +++ b/revision.c > @@ -2133,6 +2133,14 @@ static int handle_revision_pseudo_opt(const char > *submodule, > int argcount; > >