> I see you've "standardized" to drop "extern" from the declarations
> in the header; I have an impression that our preference however is
> to go in the other direction.
OK, absolutely not a problem, I will return them. Do I need to write
"extern" further in function declarations? And why did ever
On Fri, Dec 08, 2017 at 12:16:36AM -0500, Jeff King wrote:
> Commit 84ff053d47 (pretty.c: delimit "%(trailers)" arguments
> with ",", 2017-10-01) switched the syntax of the trailers
> placeholder, but forgot to update the documentation in
> pretty-formats.txt.
>
> There's need to mention the old sy
Hi Alexei,
On 09/12/2017 03:18, Alexei Lozovsky wrote:
>
> > Chris reported in this very topic[1] that sometimes, due to
> > conflicts with later commits, "checkout > commit > [checkout >]
> > rebase --onto" is "much easier to do", where "commit --fixup >
> > rebase -i" "breaks" (does not apply c
Let us make business together.
I am in-charge of transferring out funds our village generated from
the sales of our local mined gold. I have some left over fund in the
bank that I alone is aware and can transfer it out.
My village that mines gold, has mandated me for sales of our raw Gold,
and its
On Dec 9, 2017, at 01:54, Igor Djordjevic wrote:
> On 08/12/2017 17:24, Junio C Hamano wrote:
>> I'd rather do a quick fix-up on top (which ensures that at least the
>> fix-up works in the context of the tip), and then "rebase -i" to
>> move it a more appropriate place in the history (during which
On Fri, Dec 08, 2017 at 03:21:23PM -0800, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > That endgame allows us not force people to grab an essential part of
> > the codebase as an external dependency from another place, which
> > feels quite bad, especially when their primary interest is
On 08/12/2017 17:24, Junio C Hamano wrote:
>
> > To get back on track, and regarding what`s already been said,
> > would having something like this(1) feel useful?
> >
> > (1) git commit --onto
>
> Are you asking me if _I_ find it useful? It is not a very useful
> question to ask, as I've taken
On Fri, Dec 08 2017, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason writes:
>
>> Instead the Makefile will emit an error if the contents of the
>> submodule aren't checked out (line-wrapped. GNU make emits this all on
>> one line):
>>
>> Makefile:1031: *** The sha1collisiondetection subm
Junio C Hamano writes:
> That endgame allows us not force people to grab an essential part of
> the codebase as an external dependency from another place, which
> feels quite bad, especially when their primary interest is not in
> dogfooding submodule but in building a working version of Git.
>
>
On Fri, Dec 08 2017, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason writes:
>
>> Include the sha1collisiondetection submodule when running "make
>> dist". Even though we've been shipping the sha1collisiondetection
>> submodule[1] and using it by default if it's checked out[2] anyone
>> downl
Ævar Arnfjörð Bjarmason writes:
> Instead the Makefile will emit an error if the contents of the
> submodule aren't checked out (line-wrapped. GNU make emits this all on
> one line):
>
> Makefile:1031: *** The sha1collisiondetection submodule is not
> checked out. Please make it availabl
Ævar Arnfjörð Bjarmason writes:
> Include the sha1collisiondetection submodule when running "make
> dist". Even though we've been shipping the sha1collisiondetection
> submodule[1] and using it by default if it's checked out[2] anyone
> downloading git as a tarball would just get an empty
> sha1
-Original Message-
On December 8, 2017 5:29 PM Junio C Hamano wrote:
>"Randall S. Becker" writes:
>> One request to Junio: Would it be possible to tag the commits to align
>> with the tags in the main repo? That way, I can build a nice little
>> Jenkins job to automatically fetch the cor
A subsequent change will change the semantics of DC_SHA1_SUBMODULE in
a way that would require moving these checks around, so start by
moving them around without any functional changes to reduce the size
of the subsequent patch.
Signed-off-by: Ævar Arnfjörð Bjarmason
---
sha1dc_git.h | 6 +++---
Include the sha1collisiondetection submodule when running "make
dist". Even though we've been shipping the sha1collisiondetection
submodule[1] and using it by default if it's checked out[2] anyone
downloading git as a tarball would just get an empty
sha1collisiondetection/ directory.
Doing this au
Change the build process so that instead of needing to supply
DC_SHA1_SUBMODULE=YesPlease to use the sha1collisiondetection
submodule instead of the copy of the same code shipped in the sha1dc
directory, it uses the submodule by default unless
NO_DC_SHA1_SUBMODULE=NoThanks is supplied.
This revers
Fix a logic error in the initial introduction of DC_SHA1_EXTERNAL. If
git.git has a sha1collisiondetection submodule checked out the logic
to set DC_SHA1_SUBMODULE=auto would interact badly with the check for
whether DC_SHA1_SUBMODULE was set.
It would error out, meaning that there's no way to bui
On 12/08, Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> This is V7 of part 3 of partial clone. It builds upon V7 of part 2
> (which builds upon V6 of part 1).
>
> This version adds additional tests, fixes test errors on the MAC version,
> and squashes some fixup commits.
>
> It also restore
Here's v2 as promised. Comments per-patch.
Ævar Arnfjörð Bjarmason (5):
Makefile: don't error out under DC_SHA1_EXTERNAL if
DC_SHA1_SUBMODULE=auto
Fixed indenting.
Makefile: under "make dist", include the sha1collisiondetection
submodule
NEW: Change "make dist" to include the sha1co
"Randall S. Becker" writes:
> One request to Junio: Would it be possible to tag the commits to
> align with the tags in the main repo? That way, I can build a nice
> little Jenkins job to automatically fetch the correct commit for
> man pages when packaging up a release.
Sorry, I missed this due
I'll queue this on top so that 'pu' would have one fewer breakage at
Travis.
diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
index 4668f0058e..3e3fb462a0 100755
--- a/t/t6120-describe.sh
+++ b/t/t6120-describe.sh
@@ -341,7 +341,7 @@ test_expect_success 'describe directly tagged blob' '
tes
On Fri, Dec 08, 2017 at 04:08:19PM +0100, Johannes Schindelin wrote:
> > Yes, but test-lib.sh sources GIT-BUILD-OPTIONS, which we
> > built during the first "make". And that overrides the
> > environment, giving us the original SHELL_PATH again.
>
> ... and we could simply see whether the environ
On Fri, Dec 08, 2017 at 12:39:55PM -0800, Stefan Beller wrote:
> > If you add --raw, you can see that both commits introduce that blob, and
> > it never "goes away". That's because that happened in a merge, which we
> > don't diff in a default log invocation.
>
> We should when --raw is given.
>
On Fri, Dec 08, 2017 at 10:37:08AM -0800, Junio C Hamano wrote:
> > The two modes (dup/nodup) make string_list code tricky. Not sure
> > how far we'd get with something simpler (e.g. an array of char pointers),
> > but having the caller do all string allocations would make the code
> > easier to
On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine wrote:
> On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano wrote:
>> Jonathan Nieder writes:
@@ -413,6 +414,7 @@ int cmd_version(int argc, const char **argv, const
char *prefix)
if (build_options) {
printf("s
On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano wrote:
> Jonathan Nieder writes:
>>> @@ -413,6 +414,7 @@ int cmd_version(int argc, const char **argv, const char
>>> *prefix)
>>>
>>> if (build_options) {
>>> printf("sizeof-long: %d\n", (int)sizeof(long));
>>> +printf
On Fri, Dec 08, 2017 at 06:29:34PM +0100, René Scharfe wrote:
> > By the way, I think there's another quite subtle leak in this function.
> > We do this:
> >
> >format_commit_message(commit, "%s", &sb, &ctx);
> >strbuf_ltrim(&sb);
> >
> > and then only use "sb" if sb.len is non-zero. But
On Wed, Dec 06 2017, Ævar Arnfjörð Bjarmason jotted:
> On Wed, Dec 6, 2017 at 7:56 PM, Daniel Jacques wrote:
>> On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote:
>>>
>>> Johannes Sixt writes:
>>>
>>> > The updated series works for me now. Nevertheless, I suggest to squash
>>> > in the foll
Stefan Beller writes:
>>> +
>>> + if ((DIFF_FILE_VALID(p->one) &&
>>> + oidset_contains(options->blobfind, &p->one->oid)) ||
>>> + (DIFF_FILE_VALID(p->two) &&
>>> + oidset_contains(options->blobfind, &p->two->oid))) {
>>
>> Shouldn't t
On Fri, Dec 08, 2017 at 06:29:31PM +0100, René Scharfe wrote:
> Am 07.12.2017 um 22:27 schrieb Jeff King:
> > Grepping for "list_append.*detach" shows a few other possible cases in
> > transport-helper.c, which I think are leaks.
>
> -- >8 --
> Subject: [PATCH] transport-helper: plug strbuf and s
>> +
>> + if ((DIFF_FILE_VALID(p->one) &&
>> + oidset_contains(options->blobfind, &p->one->oid)) ||
>> + (DIFF_FILE_VALID(p->two) &&
>> + oidset_contains(options->blobfind, &p->two->oid))) {
>
> Shouldn't this make sure that !DIFF_PAIR_U
Jeff King writes:
> On Thu, Dec 07, 2017 at 02:31:38PM -0800, Junio C Hamano wrote:
>
>> If this goes on top as a standalone patch, then the reason why it is
>> separate from the other users of _default() is not because the way
>> it uses the null return is special, but because it was written by
Johannes Schindelin writes:
> We might want to consider using a saner Continuous Testing workflow, to
> avoid re-testing (and re-finding) breakages in individual patch series
> just because completely unrelated patch got updated.
>
> I mean, yes, it seemed like a good idea a long time ago to have
On 12/05, Jonathan Nieder wrote:
> Hi,
>
> Thomas Gummerer wrote:
>
> > We generally no longer include copyright notices in new test scripts.
> > However t/README still mentions it as something to include at the top of
> > every new script.
>
> Where can I read more about this change? Was it a
On Fri, Dec 8, 2017 at 12:19 PM, Jeff King wrote:
> On Fri, Dec 08, 2017 at 04:28:23PM +, Ramsay Jones wrote:
>
>> On 08/12/17 09:34, Jeff King wrote:
>> > On Thu, Dec 07, 2017 at 04:24:47PM -0800, Stefan Beller wrote:
>> [snip]
>> >> Junio hinted at a different approach of solving this proble
Olga Telezhnaya writes:
> archive.c | 1 +
> builtin/notes.c | 2 +-
> builtin/reset.c | 2 +-
> builtin/show-branch.c | 2 +-
> combine-diff.c| 1 +
> commit.c | 1 +
> commit.h | 80 --
>
From: "Ulrich Windl"
Hi Philip!
I'm unsure what you are asking for...
Ulrich
Hi Ulrich,
I was doing a retrospective follow up (of the second kind [1]).
In your initial email
https://public-inbox.org/git/5a1d70fd02a100029...@gwsmtp1.uni-regensburg.de/
you said
"I wanted to delete the t
Johannes Schindelin writes:
> On Wed, 6 Dec 2017, Junio C Hamano wrote:
> ...
>> I vaguely recalled and feared that we on purpose kept this program
>> separate from the rest of the system for a reason, but my mailing
>> list search is coming up empty.
>
> I only recall that we kept it in the bin/
On 12/07, Junio C Hamano wrote:
> Brandon Williams writes:
>
> > +static struct protocol_capability *get_capability(const char *key)
> > +{
> > + int i;
> > +
> > + if (!key)
> > + return NULL;
> > +
> > + for (i = 0; i < ARRAY_SIZE(capabilities); i++) {
> > + struct pro
On Fri, Dec 08, 2017 at 04:28:23PM +, Ramsay Jones wrote:
> On 08/12/17 09:34, Jeff King wrote:
> > On Thu, Dec 07, 2017 at 04:24:47PM -0800, Stefan Beller wrote:
> [snip]
> >> Junio hinted at a different approach of solving this problem, which this
> >> patch implements. Teach the diff machin
On 12/06, Junio C Hamano wrote:
> Brandon Williams writes:
>
>
> EXPECTING_DONE sounded like we are expecting to see 'done' packet
> sent from the other side, but I was mistaken. It is the state
> where we are "done" expecting anything ;-).
>
> Having an (unconditional) assignment to 'state' i
Jeff Hostetler writes:
> From: Jeff Hostetler
>
> First draft of design document for partial clone feature.
>
> Signed-off-by: Jeff Hostetler
> Signed-off-by: Jonathan Tan
> ---
Thanks.
> +Non-Goals
> +-
> +
> +Partial clone is independent of and not intended to conflict with
> +shal
On 12/06, Junio C Hamano wrote:
> Brandon Williams writes:
>
> > In order to allow for code sharing with the server-side of fetch in
> > protocol-v2 convert upload-pack to be a builtin.
> >
> > Signed-off-by: Brandon Williams
> > ---
>
> This looks obvious and straight-forward to a cursory look
On 12/07, Junio C Hamano wrote:
> Brandon Williams writes:
>
> > While we could wrap the preamble into a function it sort of defeats the
> > purpose since you want to be able to call different functions based on
> > the protocol version you're speaking. That way you can have hard
> > separations
Am 08.12.2017 um 19:44 schrieb Junio C Hamano:
> René Scharfe writes:
>
>> Am 07.12.2017 um 22:27 schrieb Jeff King:
>>> Grepping for "list_append.*detach" shows a few other possible cases in
>>> transport-helper.c, which I think are leaks.
>>
>> -- >8 --
>> Subject: [PATCH] transport-helper: plu
On 12/07, Stefan Beller wrote:
> On Mon, Dec 4, 2017 at 3:58 PM, Brandon Williams wrote:
> > One of the design goals of protocol-v2 is to improve the semantics of
> > flush packets. Currently in protocol-v1, flush packets are used both to
> > indicate a break in a list of packet lines as well as
From: Jeff Hostetler
This patch contains a design document that Jonathan Tan and I have
been working on that describes the partial clone feature currently
under development.
Since edits to this document are independent of the code, I did not
include in the part 1,2,3 patch series.
Please let us
From: Jeff Hostetler
First draft of design document for partial clone feature.
Signed-off-by: Jeff Hostetler
Signed-off-by: Jonathan Tan
---
Documentation/technical/partial-clone.txt | 240 ++
1 file changed, 240 insertions(+)
create mode 100644 Documentation/tech
On Fri, Dec 8, 2017 at 8:21 AM, Olga Telezhnaya
wrote:
> Write some docs for functions in pretty.h.
> Take it as a first draft, they would be changed later.
>
> Signed-off-by: Olga Telezhnaia
> Mentored-by: Christian Couder
> Mentored by: Jeff King
> ---
> diff --git a/pretty.h b/pretty.h
> @@
On Fri, Dec 08, 2017 at 10:21:19AM -0800, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > tbo...@web.de writes:
> >
> >> From: Torsten Bögershausen
> >>
> >> Replace `git commit -m "comment" ""` with `git commit -m "comment"` to
> >> remove the empty path spec.
> >>
> >> Signed-off-by: Tors
René Scharfe writes:
> Am 07.12.2017 um 22:27 schrieb Jeff King:
>> Grepping for "list_append.*detach" shows a few other possible cases in
>> transport-helper.c, which I think are leaks.
>
> -- >8 --
> Subject: [PATCH] transport-helper: plug strbuf and string_list leaks
>
> Transfer ownership of
René Scharfe writes:
>> I'm not sure it's string-list's fault. Many callers (including this one)
>> ...
> The two modes (dup/nodup) make string_list code tricky. Not sure
> how far we'd get with something simpler (e.g. an array of char pointers),
> but having the caller do all string allocations
Jeff Hostetler writes:
> On 12/8/2017 12:58 PM, Junio C Hamano wrote:
>> Jeff Hostetler writes:
>>
>>> From: Jeff Hostetler
>>>
>>> This is V7 of part 3 of partial clone. It builds upon V7 of part 2
>>> (which builds upon V6 of part 1).
>>
>> Aren't the three patches at the bottom sort-of dupl
Junio C Hamano writes:
> tbo...@web.de writes:
>
>> From: Torsten Bögershausen
>>
>> Replace `git commit -m "comment" ""` with `git commit -m "comment"` to
>> remove the empty path spec.
>>
>> Signed-off-by: Torsten Bögershausen
>> ---
>> t/t0027-auto-crlf.sh | 2 +-
>> 1 file changed, 1 inser
tbo...@web.de writes:
> From: Torsten Bögershausen
>
> Replace `git commit -m "comment" ""` with `git commit -m "comment"` to
> remove the empty path spec.
>
> Signed-off-by: Torsten Bögershausen
> ---
> t/t0027-auto-crlf.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This looks a
On 12/07, Stefan Beller wrote:
> On Mon, Dec 4, 2017 at 3:58 PM, Brandon Williams wrote:
> > Sometimes it is advantageous to be able to peek the next packet line
> > without consuming it (e.g. to be able to determine the protocol version
> > a server is speaking). In order to do that introduce 's
On Fri, Dec 8, 2017 at 8:21 AM, Olga Telezhnaya
wrote:
> Create header for pretty.c to make formatting interface more structured.
> This is a middle point, this file would be merged futher with other
s/futher/further/
> files which contain formatting stuff.
>
> Signed-off-by: Olga Telezhnaia
>
On 12/8/2017 12:58 PM, Junio C Hamano wrote:
Jeff Hostetler writes:
From: Jeff Hostetler
This is V7 of part 3 of partial clone. It builds upon V7 of part 2
(which builds upon V6 of part 1).
Aren't the three patches at the bottom sort-of duplicate from the
part 2 series?
oops. yes, y
On 12/07, Stefan Beller wrote:
> On Mon, Dec 4, 2017 at 3:58 PM, Brandon Williams wrote:
>
> > diff --git a/pkt-line.h b/pkt-line.h
> > index 3dad583e2..f1545929b 100644
> > --- a/pkt-line.h
> > +++ b/pkt-line.h
> > @@ -60,8 +60,16 @@ int write_packetized_from_buf(const char *src_in, size_t
> >
On Fri, Dec 8, 2017 at 10:18 AM, Daniel Bensoussan
wrote:
> doc: reword gitworflows for neutrality
s/gitworflows/gitworkflows/
> Changed 'he' to 'them' to be more neutral in "gitworkflows.txt".
>
> See discussion at:
> https://public-inbox.org/git/xmqqvahieeqy@gitster.mtv.corp.google.com/
>
Jeff Hostetler writes:
> From: Jeff Hostetler
>
> This is V7 of part 3 of partial clone. It builds upon V7 of part 2
> (which builds upon V6 of part 1).
Aren't the three patches at the bottom sort-of duplicate from the
part 2 series?
Jonathan Nieder writes:
>> We need to be careful, though, to report when the current commit cannot be
>> determined, e.g. when building from a tarball without any associated Git
>> repository.
>
> This means that on Debian, it would always print
>
> built from commit: (unknown)
>
> Maybe I
From: Torsten Bögershausen
Replace `git commit -m "comment" ""` with `git commit -m "comment"` to
remove the empty path spec.
Signed-off-by: Torsten Bögershausen
---
t/t0027-auto-crlf.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crl
From: Torsten Bögershausen
The new MIX tests don't pass under Windows, adapt them
to use the correct native line ending.
Signed-off-by: Torsten Bögershausen
---
Sorry for the breakage.
This needs to go on top of tb/check-crlf-for-safe-crlf
t/t0027-auto-crlf.sh | 17 +
1 fi
Jonathan Nieder writes:
>> @@ -390,6 +390,7 @@ const char *help_unknown_cmd(const char *cmd)
>>
>> int cmd_version(int argc, const char **argv, const char *prefix)
>> {
>> +static char build_platform[] = GIT_BUILD_PLATFORM;
>> int build_options = 0;
>> const char * const usage[]
Olga Telezhnaya writes:
> -extern void get_commit_format(const char *arg, struct rev_info *);
> -extern const char *format_subject(struct strbuf *sb, const char *msg,
> - const char *line_separator);
> -extern void userformat_find_requirements(const char *fmt, struct
On Friday 08 December 2017 04:44 AM, Junio C Hamano wrote:
Junio C Hamano writes:
Somehow this fell underneath my radar horizon. I see v4 and v5 of
4/4 but do not seem to find 1-3/4. Is this meant to be a standalone
patch, or am I expected to already have 1-3 that we already are
committed to
Am 08.12.2017 um 11:14 schrieb Jeff King:
> On Thu, Dec 07, 2017 at 01:47:14PM -0800, Junio C Hamano wrote:
>
>>> diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c
>>> index 22034f87e7..8e8a15ea4a 100644
>>> --- a/builtin/fmt-merge-msg.c
>>> +++ b/builtin/fmt-merge-msg.c
>>> @@ -377,7
Am 07.12.2017 um 22:27 schrieb Jeff King:
> Grepping for "list_append.*detach" shows a few other possible cases in
> transport-helper.c, which I think are leaks.
-- >8 --
Subject: [PATCH] transport-helper: plug strbuf and string_list leaks
Transfer ownership of detached strbufs to string_lists of
Hi,
Johannes Schindelin wrote:
> In particular when local tags are used (or tags that are pushed to some
> fork) to build Git, it is very hard to figure out from which particular
> revision a particular Git executable was built.
Hm, can you say more about how this comes up in practice? I wonder
Hi,
Johannes Schindelin wrote:
> From: Adric Norris
>
> When asking for bug reports to include the output of `git version
> --build-options`, the idea is that we get a better idea of the
> environment where said bug occurs. In this context, it is useful to
> distinguish between 32 and 64-bit bui
Junio C Hamano writes:
> Stefan Beller writes:
> ...
>> @@ -2883,6 +2884,8 @@ int prepare_revision_walk(struct rev_info *revs)
>> simplify_merges(revs);
>> if (revs->children.name)
>> set_children(revs);
>> +if (revs->diffopt.blobfind)
>> +revs->sim
From: Adric Norris
When asking for bug reports to include the output of `git version
--build-options`, the idea is that we get a better idea of the
environment where said bug occurs. In this context, it is useful to
distinguish between 32 and 64-bit builds.
We start by distinguishing between x86
In particular when local tags are used (or tags that are pushed to some
fork) to build Git, it is very hard to figure out from which particular
revision a particular Git executable was built.
Let's just report that in our build options.
We need to be careful, though, to report when the current co
In Git for Windows, we ask users to paste the output of said command
into their bug reports, with the idea that this frequently helps
identify where the problems are coming from.
There are some obvious missing bits of information in said output,
though, and this patch series tries to fill the gaps
Jeff King writes:
> On Fri, Dec 08, 2017 at 03:10:34AM -0500, Eric Sunshine wrote:
>
>> On Fri, Dec 8, 2017 at 12:16 AM, Jeff King wrote:
>> > Commit 84ff053d47 (pretty.c: delimit "%(trailers)" arguments
>> > with ",", 2017-10-01) switched the syntax of the trailers
>> > placeholder, but forgot
Jeff King writes:
> Commit 84ff053d47 (pretty.c: delimit "%(trailers)" arguments
> with ",", 2017-10-01) switched the syntax of the trailers
> placeholder, but forgot to update the documentation in
> pretty-formats.txt.
>
> There's need to mention the old syntax; it was never in a
> released vers
On 08/12/17 09:34, Jeff King wrote:
> On Thu, Dec 07, 2017 at 04:24:47PM -0800, Stefan Beller wrote:
[snip]
>> Junio hinted at a different approach of solving this problem, which this
>> patch implements. Teach the diff machinery another flag for restricting
>> the information to what is shown. F
Igor Djordjevic writes:
> To get back on track, and regarding what`s already been said, would
> having something like this(1) feel useful?
>
> (1) git commit --onto
Are you asking me if _I_ find it useful? It is not a very useful
question to ask, as I've taken things that I do not find useful
From: Jeff Hostetler
Teach upload-pack to negotiate object filtering over the protocol and
to send filter parameters to pack-objects. This is intended for partial
clone and fetch.
The idea to make upload-pack configurable using uploadpack.allowFilter
comes from Jonathan Tan's work in [1].
[1]
From: Jonathan Tan
Teach sha1_file to fetch objects from the remote configured in
extensions.partialclone whenever an object is requested but missing.
The fetching of objects can be suppressed through a global variable.
This is used by fsck and index-pack.
However, by default, such fetching is
From: Jonathan Tan
Teach rev-list to support termination of an object traversal at any
object from a promisor remote (whether one that the local repo also has,
or one that the local repo knows about because it has another promisor
object that references it).
This will be used subsequently in gc
From: Jeff Hostetler
Fixup fetch-pack to accept --no-filter to be consistent with
rev-list and pack-objects.
Signed-off-by: Jeff Hostetler
---
builtin/fetch-pack.c | 4
1 file changed, 4 insertions(+)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index 7957807..cbf5035 100644
From: Jonathan Tan
Separate out the calculation of remotes to be fetched from and the
actual fetching. This will allow us to include an additional step before
the actual fetching in a subsequent commit.
Signed-off-by: Jonathan Tan
---
builtin/fetch.c | 14 --
1 file changed, 8 inse
From: Jeff Hostetler
Signed-off-by: Jeff Hostetler
---
builtin/fetch-pack.c | 4
fetch-pack.c | 13 +
fetch-pack.h | 2 ++
transport-helper.c | 5 +
transport.c | 4
transport.h | 5 +
6 files changed, 33 insertions(+)
diff
From: Jonathan Tan
Created tests to verify fetch-pack and upload-pack support
for excluding large blobs using --filter=blobs:limit=
parameter.
Signed-off-by: Jonathan Tan
Signed-off-by: Jeff Hostetler
---
t/t5500-fetch-pack.sh | 27 +++
upload-pack.c | 13 +
From: Jeff Hostetler
Create get and set routines for "partial clone" config settings.
These will be used in a future commit by clone and fetch to
remember the promisor remote and the default filter-spec.
Signed-off-by: Jeff Hostetler
---
cache.h | 1 +
config.c
From: Jeff Hostetler
Additional end-to-end tests for partial clone.
Signed-off-by: Jeff Hostetler
---
t/t5616-partial-clone.sh | 96
1 file changed, 96 insertions(+)
create mode 100755 t/t5616-partial-clone.sh
diff --git a/t/t5616-partial-clon
From: Jeff Hostetler
Teach (partial) fetch to inherit the filter-spec used by
the partial clone. Extend --no-filter to override this
inheritance.
Signed-off-by: Jeff Hostetler
---
builtin/fetch-pack.c | 2 +-
builtin/fetch.c | 56 +++
From: Jeff Hostetler
Add test to t5616 to bulk fetch missing objects following
a partial fetch. A technique like this could be used in
a pre-command hook for example.
Signed-off-by: Jeff Hostetler
---
t/t5616-partial-clone.sh | 32 +++-
1 file changed, 31 insertion
From: Jonathan Tan
Signed-off-by: Jonathan Tan
Signed-off-by: Jeff Hostetler
---
builtin/clone.c | 22 --
t/t5601-clone.sh | 49 +
2 files changed, 69 insertions(+), 2 deletions(-)
diff --git a/builtin/clone.c b/builtin/clon
From: Jonathan Tan
When running checkout, first prefetch all blobs that are to be updated
but are missing. This means that only one pack is downloaded during such
operations, instead of one per missing blob.
This operates only on the blob level - if a repository has a missing
tree, they are stil
From: Jonathan Tan
In fetch-pack, the global variable save_commit_buffer is set to 0, but
not restored to its original value after use.
In particular, if show_log() (in log-tree.c) is invoked after
fetch_pack() in the same process, show_log() will return before printing
out the commit message (b
From: Jeff Hostetler
Teach fetch to support filters. This is only allowed for the remote
configured in extensions.partialcloneremote.
Signed-off-by: Jonathan Tan
---
builtin/fetch.c | 23 +--
connected.c | 2 ++
remote-curl.c | 6 ++
t/t5500-fe
From: Jonathan Tan
Teach gc to stop traversal at promisor objects, and to leave promisor
packfiles alone. This has the effect of only repacking non-promisor
packfiles, and preserves the distinction between promisor packfiles and
non-promisor packfiles.
Signed-off-by: Jonathan Tan
Signed-off-by:
From: Jeff Hostetler
This is V7 of part 3 of partial clone. It builds upon V7 of part 2
(which builds upon V6 of part 1).
This version adds additional tests, fixes test errors on the MAC version,
and squashes some fixup commits.
It also restores functionality accidentally dropped from the V6 s
Christian Couder writes:
> On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote:
>
>
>> * cc/skip-to-optional-val (2017-12-07) 7 commits
>> - t4045: test 'diff --relative' for real
>> - t4045: reindent to make helpers readable
>> - diff: use skip-to-optional-val in parsing --relative
>> - di
Elazar Leibovich writes:
> ignore unused information, such as commit
> 2cb45e95438c113871fbbea5b4f629f9463034e7
> which ignores st_dev, because it doesn't actually matter, or
I do not think it ignores because "it doesn't matter". st_dev is
known not to be stable (e.g. across reboots and reconne
On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote:
> * cc/skip-to-optional-val (2017-12-07) 7 commits
> - t4045: test 'diff --relative' for real
> - t4045: reindent to make helpers readable
> - diff: use skip-to-optional-val in parsing --relative
> - diff: use skip_to_optional_val_default
From: Jonathan Tan
Teach fsck to not treat missing promisor objects provided on the CLI as
an error when extensions.partialclone is set.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 2 ++
t/t0410-partial-clone.sh | 13 +
2 files changed, 15 insertions(+)
diff --git
1 - 100 of 134 matches
Mail list logo