Re: [PATCH 0/4] doc improvements for config includes

On Thu, May 11, 2017 at 11:09 AM, Jeff King <p...@peff.net> wrote: > On Thu, May 11, 2017 at 03:54:37AM -0400, Jeff King wrote: > >> On Thu, May 11, 2017 at 09:49:09AM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> > > I don't like this because it

[PATCH v4 2/2] perf: add test showing exponential growth in path globbing

this is a test to see whether Git suffers from the issue noted in an article Russ Cox posted today about common bugs in various glob implementations: https://research.swtch.com/glob Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p0100-globbing.s

[PATCH v4 0/2] perf: show that wildmatch() regressed for pathological cases in v2.0

Fixes a brainfart in v3. I thought I'd fixed that subshell cd issue, but turns out I didn't, actually fix that. Ævar Arnfjörð Bjarmason (2): perf: add function to setup a fresh test repo perf: add test showing exponential growth in path globbing t/perf/README| 1 + t/perf/p0100

[PATCH v4 1/2] perf: add function to setup a fresh test repo

ions or files, which I'm about to add in a subsequent commit. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/README | 1 + t/perf/perf-lib.sh | 19 +++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/t/perf/README b/t/perf/README index

[PATCH 17/29] perf: add a performance comparison of fixed-string grep

test of grep -G, -E and -P", 2017-04-19) for details on the machine the above test run was executed on. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p7821-grep-engines-fixed.sh | 27 +++ 1 file changed, 27 insertions(+) create mode 10075

[PATCH 20/29] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments

he initial introduction of git-grep in commit 5010cb5fcc ("built-in "git grep"", 2006-04-30). Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/grep.c b/grep.c index 59ae7809f2..bf6c249

[PATCH 26/29] pack-objects & index-pack: add test for --threads warning

-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t5300-pack-object.sh | 34 ++ 1 file changed, 34 insertions(+) diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 43a672c345..1629fa80b0 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack

[PATCH 22/29] grep: change the internal PCRE macro names to be PCRE1

code and the USE_LIBPCRE Makefile argument was added in commit 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09). At the time there was no indication that the PCRE project would release an entirely new & incompatible API around 3 years later. Signed-off-by: Ævar Arnfjörð Bjarmason

[PATCH 23/29] grep: change internal *pcre* variable & function names to be *pcre1*

, 2017-04-07) elaborates on the motivations behind this change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 52 ++-- grep.h | 8 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/grep.c b/grep.c index

Re: [PATCH 18/29] grep: catch a missing enum in switch statement

On Thu, May 11, 2017 at 10:40 PM, Stefan Beller <sbel...@google.com> wrote: > On Thu, May 11, 2017 at 1:08 PM, Brandon Williams <bmw...@google.com> wrote: >> On 05/11, Ævar Arnfjörð Bjarmason wrote: >>> Add a die(...) to a default case for the switch statement sele

Re: [PATCH 26/29] pack-objects & index-pack: add test for --threads warning

On Thu, May 11, 2017 at 10:17 PM, Brandon Williams <bmw...@google.com> wrote: > On 05/11, Ævar Arnfjörð Bjarmason wrote: >> Add a test for the warning that's emitted when --threads or >> pack.threads is provided under NO_PTHREADS=YesPlease. This uses the >>

[PATCH/RFC 5/6] grep: support regex patterns containing \0 via PCRE v2

. 1. ("grep: factor test for \0 in grep patterns into a function", 2017-05-08) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 24 t/t7008-grep-binary.sh | 74 ++ 2 files ch

Re: [PATCH 07/29] grep: change non-ASCII -i test to stop using --debug

On Thu, May 11, 2017 at 8:31 PM, Brandon Williams wrote: > On 05/11, Ęvar Arnfjörš Bjarmason wrote: >> Change a non-ASCII case-insensitive test case to stop using --debug, >> and instead simply test for the expected results. >> >> The test coverage remains the same with this

[PATCH/RFC 2/6] Makefile & compat/pcre2: add dependency on pcre2_convert.c

2107 Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 1 + compat/pcre2/get-pcre2.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/Makefile b/Makefile index b18867196e..e437fa011c 100644 --- a/Makefile +++ b/Makefile @@ -1541,6 +1541,

[PATCH/RFC 6/6] grep: use PCRE v2 under the hood for -G & -E for amazing speedup

Change the underlying engine powering POSIX basic & extended patterns to be PCRE v2 under the hood. This relies on an experimental SVN-trunk only PCRE v2 API which Philip Hazel (the PCRE maintainer) wrote up in response to a feature request I filed1[1]. This allows us to use

[PATCH/RFC 0/6] Speed up git-grep by using PCRE v2 as a backend

. 1. <20170511170142.15934-8-ava...@gmail.com> (https://public-inbox.org/git/20170511170142.15934-8-ava...@gmail.com/) Ævar Arnfjörð Bjarmason (6): Makefile & compat/pcre2: add ability to build an embedded PCRE Makefile & compat/pcre2: add dependency on pcre2_convert.c co

[PATCH/RFC 1/6] Makefile & compat/pcre2: add ability to build an embedded PCRE

on newlines for us already, so this probably works on Windows as-is, but needs testing. 1. https://lists.exim.org/lurker/thread/20170507.223619.fbee8f00.en.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 52 ++

[PATCH/RFC 4/6] test-lib: add LIBPCRE1 & LIBPCRE2 prerequisites

Add LIBPCRE1 and LIBPCRE2 prerequisites which are true when git is compiled with USE_LIBPCRE1=YesPlease or USE_LIBPCRE2=YesPlease, respectively. There are various edge cases or version-specific features that need to be tested for. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com>

Re: [PATCH] fetch-pack: always allow fetching of literal SHA1s

On Wed, May 10, 2017 at 6:46 AM, Mike Hommey wrote: > On Wed, May 10, 2017 at 12:33:44AM -0400, Jeff King wrote: >> On Tue, May 09, 2017 at 09:22:11PM -0700, Shawn Pearce wrote: >> >> > > Hmm. That makes sense generally, as the request should succeed. But it >> > > seems like

Re: [Query] Override sendemail.tocmd

On Wed, May 10, 2017 at 12:43 PM, Viresh Kumar wrote: > On 10-05-17, 16:04, Viresh Kumar wrote: >> On 10-05-17, 12:18, Ćvar Arnfjörđ Bjarmason wrote: >> > On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar >> > wrote: >> > > Hi, >> > > >> > > I have

Re: [PATCH] fixup! use perl instead of sed

On Tue, May 9, 2017 at 10:43 PM, Johannes Sixt <j...@kdbg.org> wrote: > Am 09.05.2017 um 19:00 schrieb Ævar Arnfjörð Bjarmason: >> >> Finally, you can just use -i like you did with sed, no need for the >> tempfile: > > > Nope. Some implementations of perl at

Re: [PATCH 0/2] Make diff plumbing commands respect the indentHeuristic.

On Tue, May 9, 2017 at 5:16 AM, Jeff King <p...@peff.net> wrote: > On Mon, May 01, 2017 at 12:34:38PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > I don't know if we would want to be extra paranoid about patch-ids. >> > There is no helping: >> > >> >

Re: [PATCH v2 1/3] usability: don't ask questions if no reply is required

l in >> error, please notify the sender immediately and destroy it. As its integrity >> cannot be secured on the Internet, the Atos group liability cannot be >> triggered for the message content. Although the sender endeavours to >> maintain a computer virus-free network, the

Re: [PATCH] fixup! use perl instead of sed

On Tue, May 9, 2017 at 6:45 PM, Jonathan Tan wrote: > Signed-off-by: Jonathan Tan > --- > > Thanks - I didn't realize the existence of the test lint. Here's a > fixup. Let me know if you prefer a full reroll. > > I had to use perl because

Re: [PATCH] fixup! use perl instead of sed

On Wed, May 10, 2017 at 12:38 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> On Tue, May 9, 2017 at 6:45 PM, Jonathan Tan <jonathanta...@google.com> >> wrote: >> ... >>> # Tw

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

On Tue, May 9, 2017 at 12:40 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi, > > On Tue, 9 May 2017, brian m. carlson wrote: > >> On Tue, May 09, 2017 at 02:00:18AM +0200, Ævar Arnfjörð Bjarmason wrote: >> > On Tue, May 9, 2017 at 1:3

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

On Tue, May 9, 2017 at 2:37 AM, brian m. carlson <sand...@crustytoothpaste.net> wrote: > On Tue, May 09, 2017 at 02:00:18AM +0200, Ævar Arnfjörð Bjarmason wrote: >> On Tue, May 9, 2017 at 1:32 AM, brian m. carlson >> <sand...@crustytoothpaste.net> wrote: >> > PC

Re: [PATCH v2 21/29] grep: factor test for \0 in grep patterns into a function

On Mon, May 15, 2017 at 8:24 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Factor the test for \0 in grep patterns into a function. Since commit >> 9eceddeec6 ("Use kwset in grep", 2011-08-21) any

Re: [PATCH/RFC] The new IncludeIf facility doesn't DWIM when the repo is symlinked

On Mon, May 15, 2017 at 5:20 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > I have a ~/git_tree in my homedir that's symlinked to an external > drive, and doing "gitdir:~/git_tree/" doesn't work, because instead of > matching against ~/git_tree it's matched

[PATCH] config: match both symlink & realpath versions in IncludeIf.gitdir:*

aren't utterly confused. 1. commit 3efd0bedc6 ("config: add conditional include", 2017-03-01) 2. commit 86f9515708 ("config: resolve symlinks in conditional include's patterns", 2017-04-05) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Here's a non

Re: [PATCH v2 27/29] pack-objects: fix buggy warning about threads

On Mon, May 15, 2017 at 10:59 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Fix a buggy warning about threads under NO_PTHREADS=YesPlease. Due to >> re-using the delta_search_threads variable for both the

Re: [PATCH v2 18/29] grep: catch a missing enum in switch statement

On Mon, May 15, 2017 at 7:50 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Add a die(...) to a default case for the switch statement selecting >> between grep pattern types under --recurse-submodules. >&

Re: [PATCH v2 04/29] log: add exhaustive tests for pattern style options & config

On Mon, May 15, 2017 at 6:57 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> + echo 2e >expect && >> + # In PCRE \d in [\d] is like saying "0-9", and matches the 2 >> +

Re: [PATCH v2 20/29] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments

On Mon, May 15, 2017 at 8:14 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Remove redundant assignments to the "regflags" variable. There are no >> code paths that have previously set th

Re: [PATCH/RFC 0/3] Use sha1collisiondetection as a submodule

On Wed, May 17, 2017 at 8:52 PM, Stefan Beller <sbel...@google.com> wrote: > On Wed, May 17, 2017 at 4:38 AM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> On Wed, May 17, 2017 at 9:09 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> Ævar Arnfj

Re: [PATCH] tests: add an optional test to test git-annex

On Wed, May 17, 2017 at 12:19 PM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >>> Well, it is one thing to place git-annex under CI to make sure its >>> latest and greatest works together well with our

Re: Is it possible to use new conditional includes outside of git dir?

On Mon, May 15, 2017 at 8:09 PM, Mihails Strasuns wrote: > I was very excited to try out new conditional include feature but have > quickly found out that it doesn't work with some of my custom scripts > because of the following behaviour: > > # .gitconfig > [includeIf

Re: Git just passed Subversion on openhub.net

On Mon, May 15, 2017 at 5:54 PM, Øyvind A. Holm wrote: > openhub.net has a comparion of the number of public repositories on the > net, based on searching public hosting services on the net. Git just > passed Subversion after the number of Git repositories has exploded >

Re: [PATCH] sha1dc: fix issues with a big endian platform

On Wed, May 17, 2017 at 7:39 AM, Junio C Hamano wrote: > From: Marc Stevens > > Some big-endian platforms define _BIG_ENDIAN, which the test at the > beginning of file has missed. Also, when the input is not aligned, > some platforms trigger SIGBUS. > >

Re: [PATCH] tests: add an optional test to test git-annex

On Wed, May 17, 2017 at 4:45 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Add an optional test to test git-annex. It's guarded by a new >> EXTERNAL_TESTS environment variable. Running this test takes me 10

Re: reversion in GIT_COMMON_DIR refs path

On Tue, May 16, 2017 at 7:10 PM, Joey Hess wrote: > Bisecting this test suite failure > https://git-annex.branchable.com/git-annex_in_nixpkgs_fails_with_git-2.13.0/ > I landed on commit f57f37e2e1bf11ab4cdfd221ad47e961ba9353a0 to git. That links's broken for me. Looking at your

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

On Tue, May 16, 2017 at 3:55 PM, 赵小强 wrote: > > >> 在 2017年5月16日，20:10，Jan Viktorin 写道： >> >> Hello, >> >> with this patch applied to git 2.12, I could see: >> >> Use of uninitialized value $batch_size in numeric eq (==) at >>

[PATCH/RFC 0/3] Use sha1collisiondetection as a submodule

On Wed, May 17, 2017 at 9:09 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> On Wed, May 17, 2017 at 7:39 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> From: Marc Stevens <m...@marc-stevens.nl

[PATCH/RFC 1/3] sha1dc: update from my fork of upstream

allows us to in the future just use the upstream code as-is, without any local modifications. Now all the local modifications we've done in this directory (see the git history of sha1dc/) are done either with defines, or via the newly added sha1dc_git.[ch] files. Signed-off-by: Ævar Arnfjörð

[PATCH/RFC 2/3] sha1dc: use sha1collisiondetection as a submodule

/sha1collisiondetection master branch instead. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- .gitmodules| 4 Makefile | 8 hash.h | 2 +- sha1collisiondetection | 1 + 4 files changed, 10 insertions(+), 5 deletions(-) creat

Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config

On Fri, May 12, 2017 at 12:50 PM, Johannes Schindelin wrote: > On Windows, `(1|2)` is not a valid file name, and therefore the tag > cannot be created as expected by the new test. > > So simply skip this test on Windows. Thanks for the hotfix. I'll fix this in my v2,

Re: [PATCH 11/29] grep: add a test helper function for less verbose -f \0 tests

On Fri, May 12, 2017 at 7:06 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Add a helper function to make the tests which check for patterns with >> \0 in them more succinct. Right now this isn't a big

Re: [PATCH] doc: use https link to Wikipeai to avoid http redirect

On Sat, May 13, 2017 at 11:54 AM, Sven Strickroth wrote: Spelling error: Wikipeai Looks good, but let's change these too while we're at it: $ git grep http://en.wikip Documentation/gitweb.txt:87:http://en.wikipedia.org/wiki/Query_string#URL_encoding[]), the difference

Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config

On Sat, May 13, 2017 at 1:44 AM, Jonathan Nieder wrote: > Johannes Schindelin wrote: > >> On Windows, `(1|2)` is not a valid file name, and therefore the tag >> cannot be created as expected by the new test. >> >> So simply skip this test on Windows. >> >> Signed-off-by:

Re: [PATCH] Use https links to Wikipedia to avoid http redirects

On Sat, May 13, 2017 at 11:54 AM, Sven Strickroth <em...@cs-ware.de> wrote: > Signed-off-by: Sven Strickroth <em...@cs-ware.de> Thanks! FWIW: Reviewed-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> > --- > Documentation/gitweb.txt | 2 +- > bisect.c

Re: [PATCH] compat/regex: fix compilation on Windows

On Sat, May 13, 2017 at 8:30 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Ævar, > > I originally replied in a very verbose manner, going step by step through > the "one-liner", but decided to rephrase everything. > > So here goes. >

Re: [PATCH 09/29] grep: amend submodule recursion test for regex engine testing

On Fri, May 12, 2017 at 6:59 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Amend the submodule recursion test to prepare it for subsequent tests >> of whether it passes along the grep.pattern

Re: [PATCH 04/29] log: add exhaustive tests for pattern style options & config

On Fri, May 12, 2017 at 6:48 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Add exhaustive tests for how the different grep.patternType options & >> the corresponding command-line options affect git-log. &

Re: [PATCH v4 03/12] t/test-lib-functions.sh: allow to specify the tag name to test_commit

On Tue, Feb 12, 2013 at 11:17 AM, Brandon Casey wrote: > The part of test_commit() may not be appropriate for a tag name. > So let's allow test_commit to accept a fourth argument to specify the tag > name. [Kind of late to notice, I know] I see nobody spotted in four rounds

Re: [PATCH] interpret-trailers: obey scissors lines

On Sun, May 14, 2017 at 5:39 AM, Brian Malehorn wrote: > If a commit message is being editted as "verbose", it will contain a Typo, should be "edited": https://en.wiktionary.org/wiki/editted

[PATCH v2 10/29] grep: add tests for grep pattern types being passed to submodules

long correctly. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7814-grep-recurse-submodules.sh | 49 ++ 1 file changed, 49 insertions(+) diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh index 1472855e1

[PATCH v2 12/29] grep: prepare for testing binary regexes containing rx metacharacters

mp; non-ASCII data. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7008-grep-binary.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh index 70e7868829..e7754c3946 100755 --- a/t/t7008-grep-binary.sh +++

[PATCH v2 11/29] grep: add a test helper function for less verbose -f \0 tests

Add a helper function to make the tests which check for patterns with \0 in them more succinct. Right now this isn't a big win, but subsequent commits will add a lot more of these tests. The helper is based on the match() function in t3070-wildmatch.sh. Signed-off-by: Ævar Arnfjörð Bjarmason

[PATCH v2 03/29] test-lib: rename the LIBPCRE prerequisite to PCRE

e general name to make it clear that they work on both library versions. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/README| 4 ++-- t/t7810-grep.sh | 28 ++-- t/t7812-grep-icase-non-ascii.sh | 4 ++-- t/t78

[PATCH v2 05/29] grep: add a test asserting that --perl-regexp dies when !PCRE

--perl-regexp or -P. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 4 +++- t/t7810-grep.sh | 12 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index e522a2fcd5..9680dfe400 100755 --- a/t/t4202-

[PATCH v2 07/29] grep: change non-ASCII -i test to stop using --debug

wsset when -F is specified", 2016-06-25). It was asserting that the regex must be compiled with compile_fixed_regexp(), instead test for the expected results, allowing the underlying implementation to change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7812-grep-ic

[PATCH v2 09/29] grep: amend submodule recursion test for regex engine testing

tests for pattern style options & config", 2017-04-07). The pattern "(.|.)[\d]" will match this content differently under fixed/basic/extended & perl. This test code was originally added in commit 0281e487fd ("grep: optionally recurse into submodules", 2016-1

[PATCH v2 01/29] Makefile & configure: reword inaccurate comment about PCRE

ere they make less sense is the pattern everything else follows in that file. I'm not going to war against that as part of this change, just following the existing pattern. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 6 -- configure.ac | 12

[PATCH v2 04/29] log: add exhaustive tests for pattern style options & config

matching method than the one it's told to use. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 94 +- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index f57

[PATCH v2 00/29] Easy to review grep & pre-PCRE changes

; fixes" series. Thanks a lot for the review everyone. This fixes all the issues raised. Changes noted below, with names prefixed by the person who raised the issue. Ævar Arnfjörð Bjarmason (29): Makefile & configure: reword inaccurate comment about PCRE grep & rev-list doc: stop

[PATCH v2 06/29] grep: add a test for backreferences in PCRE patterns

Add a test for backreferences such as (.)\1 in PCRE patterns. This test ensures that the PCRE_NO_AUTO_CAPTURE option isn't turned on. Before this change turning it on would break these sort of patterns, but wouldn't break any tests. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com>

[PATCH v2 13/29] grep: add tests to fix blind spots with \0 patterns

the a previous commit in this series ("grep: add tests to fix blind spots with \0 patterns", 2017-04-21) for further details & rationale. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7008-grep-binary.sh | 71 ++

[PATCH v2 19/29] grep: remove redundant regflags assignment under PCRE

ot;wait this is used under PCRE how?" confusion when reading the code, than to to save ourselves trivial CPU cycles by removing one assignment. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/grep.c b/grep.c index 47

[PATCH v2 02/29] grep & rev-list doc: stop promising libpcre for --perl-regexp

lar expression support. By wording the documentation differently and not promising any specific version of PCRE or even PCRE at all we have more wiggle room to change the implementation. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/git-grep.txt | 7 +--

[PATCH v2 08/29] grep: add tests for --threads=N and grep.threads

t --threads=N without pthreads still returns expected results. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7810-grep.sh | 16 1 file changed, 16 insertions(+) diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index daa906b9b0..561709ef6a 100755 --- a/t/t7

[PATCH v2 18/29] grep: catch a missing enum in switch statement

trigger in practice, but if a new pattern type were to be added this catches an otherwise silent bug during development. See commit 0281e487fd ("grep: optionally recurse into submodules", 2016-12-16) for the initial addition of this code. Signed-off-by: Ævar Arnfjörð Bjarmason <ava

[PATCH v2 16/29] perf: add a performance comparison test of grep -G, -E and -P

.t[^ ]*|v.ry) rare 0.88(5.82+0.35) 7820.17: basic grep m\(ú\|u\)lt.b\(æ\|y\)te 0.29(1.26+0.48) 7820.18: extended grep m(ú|u)lt.b(æ|y)te 0.29(1.36+0.39) 7820.19: perl grep m(ú|u)lt.b(æ|y)te 0.32(1.61+0.43) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.c

[PATCH v2 15/29] perf: emit progress output when unpacking & building

what's going on and what revision is being tested as the output scrolls by. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/run | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/perf/run b/t/perf/run index b61024a830..beb4acc0e4 100755 --- a/t/perf/run +++ b/

[PATCH v2 14/29] perf: add a GIT_PERF_MAKE_COMMAND for when *_MAKE_OPTS won't do

Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 3 +++ t/perf/README | 19 +-- t/perf/run| 11 +-- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index eedadb8056..d1587452f1 100644 --- a/Makefile

[PATCH v2 7/7] grep: add support for PCRE v2

makes the code look nicer. 1. https://lists.exim.org/lurker/message/20150105.162835.0666407a.en.html 2. https://lists.exim.org/lurker/thread/20170419.172322.833ee099.en.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 30 +--- configure.ac | 77 ++

[PATCH v2 0/7] PCRE v2, PCRE v1 JIT, log -P & fixes

noted below & reply to who noted the issue: Ævar Arnfjörð Bjarmason (7): grep: don't redundantly compile throwaway patterns under threading Brandon: Added a few paragraphs to the commit message about why this change is being made, i.e. for ease of understanding the code, not optimization

[PATCH v2 1/7] grep: don't redundantly compile throwaway patterns under threading

before the first thread is started. 1. http://sljit.sourceforge.net/pcre.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c index b1095362fb..12

[PATCH v2 2/7] grep: skip pthreads overhead when using one thread

tirely when 1 thread is requested. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/grep.c b/builtin/grep.c index 12e62fcbf3..bd008cb100 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -1238,6 +1238,

[PATCH v2 5/7] grep: un-break building with PCRE < 8.32

rsions. 1. http://www.pcre.org/original/changelog.txt ("28. Introducing a native interface for JIT. Through this interface, the compiled[...]") 2. https://bugs.exim.org/show_bug.cgi?id=2121 Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 8

[PATCH v2 6/7] grep: un-break building with PCRE < 8.20

han 7.5 as I'm confident that if the build breaks on those older versions it's not because of my JIT change. See the "un-break" change in this series ("grep: un-break building with PCRE < 8.32", 2017-05-10) for why this isn't squashed into the main PCRE JIT commit. Signed

[PATCH v2 4/7] grep: add support for the PCRE v1 JIT API

's no graceful fallback if pcre_jit_stack_alloc() fails under PCRE_CONFIG_JIT, instead the program will simply abort. I don't think this is worth handling gracefully, it'll only fail in cases where malloc() doesn't work, in which case we're screwed anyway. Signed-off-by: Ævar Arnfjörð Bjarmason <

[PATCH v2 3/7] log: add -P as a synonym for --perl-regexp

ment, as the log command already uses that for -G. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/rev-list-options.txt | 1 + revision.c | 2 +- t/t4202-log.sh | 12 3 files changed, 14 insertions

[PATCH v2 26/29] pack-objects & index-pack: add test for --threads warning

-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t5300-pack-object.sh | 34 ++ 1 file changed, 34 insertions(+) diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 43a672c345..1629fa80b0 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack

[PATCH v2 24/29] grep: move is_fixed() earlier to avoid forward declaration

Move the is_fixed() function which are currently only used in compile_regexp() earlier so it can be used in the PCRE family of functions in a later change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 24 1 file changed, 12 insertions(

[PATCH v2 20/29] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments

he initial introduction of git-grep in commit 5010cb5fcc ("built-in "git grep"", 2006-04-30). Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/grep.c b/grep.c index 59ae7809f2..bf6c249

[PATCH v2 25/29] test-lib: add a PTHREADS prerequisite

Add a PTHREADS prerequisite which is false when git is compiled with NO_PTHREADS=YesPlease. There's lots of custom code that runs when threading isn't available, but before this prerequisite there was no way to test it. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Ma

[PATCH v2 29/29] grep: assert that threading is enabled when calling grep_{lock,unlock}

n unless we're spawning threads. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c index 3c721b75a5..b1095362fb 100644 --- a/builtin/grep.c +++ b/builtin/gre

[PATCH v2 28/29] grep: given --threads with NO_PTHREADS=YesPlease, warn

able via pack.threads, and have long warned about the same under NO_PTHREADS=YesPlease. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 13 + t/t7810-grep.sh | 18 ++ 2 files changed, 31 insertions(+) diff --git a/builtin/grep.c b/builti

[PATCH v2 27/29] pack-objects: fix buggy warning about threads

uot;pack.threads" & --threads. Solve this bug by resetting the delta_search_threads variable in git_pack_config(), it might then be set by --threads again and be subsequently warned about, as the test I'm changing here asserts. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com

[PATCH v2 23/29] grep: change internal *pcre* variable & function names to be *pcre1*

, 2017-04-07) elaborates on the motivations behind this change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 52 ++-- grep.h | 8 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/grep.c b/grep.c index

[PATCH v2 22/29] grep: change the internal PCRE macro names to be PCRE1

code and the USE_LIBPCRE Makefile argument was added in commit 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09). At the time there was no indication that the PCRE project would release an entirely new & incompatible API around 3 years later. Signed-off-by: Ævar Arnfjörð Bjarmason

[PATCH v2 21/29] grep: factor test for \0 in grep patterns into a function

nform to the style guide, i.e. add an opening "/*\n". Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/grep.c b/grep.c index bf6c2494fd..79eb681c6e 100644 --- a/grep.c

[PATCH v2 17/29] perf: add a performance comparison of fixed-string grep

test of grep -G, -E and -P", 2017-04-19) for details on the machine the above test run was executed on. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p7821-grep-engines-fixed.sh | 26 ++ 1 file changed, 26 insertions(+) create mode 10075

Re: [PATCH] fixup! log: add exhaustive tests for pattern style options & config

On Tue, May 16, 2017 at 2:46 AM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> On Mon, 15 May 2017, Junio C Hamano wrote: >> >>> My knee-jerk reaction matched Dscho's, but grep is about contents, >>> and we should be able to test this if

Re: [PATCH 00/11] Start retiring .git/remotes/ and .git/branches/ for good

On Tue, May 16, 2017 at 11:06 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> This and many other discussions on-list basically come down to: >> >> 1. Someone wants to change X. >> 2. This woul

Re: [PATCH 00/11] Start retiring .git/remotes/ and .git/branches/ for good

On Tue, May 16, 2017 at 2:37 AM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> On Fri, 12 May 2017, Junio C Hamano wrote: >> >>> Is it really hurting us having to support these old information >>> sources we treat as read-only? >> >>

[PATCH v2] config: match both symlink & realpath versions in IncludeIf.gitdir:*

utterly confused. 1. commit 3efd0bedc6 ("config: add conditional include", 2017-03-01) 2. commit 86f9515708 ("config: resolve symlinks in conditional include's patterns", 2017-04-05) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Thanks.

[PATCH/RFC] The new IncludeIf facility doesn't DWIM when the repo is symlinked

I have a ~/git_tree in my homedir that's symlinked to an external drive, and doing "gitdir:~/git_tree/" doesn't work, because instead of matching against ~/git_tree it's matched against /mnt/some-other-storage/. Here's a WIP patch that makes this work for me, any reason I shouldn't finish this up

Re: Would this tool be useful - encoding repository data into single URL

On Tue, May 9, 2017 at 2:48 PM, Sebastian Gniazdowski wrote: > Hello > I wonder about usability of following tool. Quick-start: > > giturl https://github.com/zdharma/giturl -r devel -p > lib/coding_functions.cpp > > Protocol: https > Site: github.com >

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

On Tue, May 9, 2017 at 4:22 PM, demerphq <demer...@gmail.com> wrote: > On 9 May 2017 at 13:12, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: >> On Tue, May 9, 2017 at 2:37 AM, brian m. carlson >> <sand...@crustytoothpaste.net> wrote: >>> On Tue, May 0

<    3   4   5   6   7   8   9   10   11   12   >