[PATCH v3 20/30] grep: catch a missing enum in switch statement

in practice, but if a new pattern type were to be added this catches an otherwise silent bug during development. See commit 0281e487fd ("grep: optionally recurse into submodules", 2016-12-16) for the initial addition of this code. Signed-off-by: Ævar Arnfjörð Bjarmason <ava

[PATCH v3 17/30] perf: add a comparison test of grep regex engines

820.15: perl grep -i '(e.t[^ ]*|v.ry) rare' 1.44(6.88+0.44) 7820.17: basic grep -i 'm\(ú\|u\)lt.b\(æ\|y\)te' 0.66(2.67+0.44) 7820.18: extended grep -i 'm(ú|u)lt.b(æ|y)te' 0.66(2.67+0.43) 7820.19: perl grep -i 'm(ú|u)lt.b(æ|y)te' 0.59(2.31+0.37) Signed-off-by: Ævar A

[PATCH v3 04/30] log: add exhaustive tests for pattern style options & config

matching method than the one it's told to use. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 98 +- 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index f57

[PATCH v3 08/30] grep: change non-ASCII -i test to stop using --debug

wsset when -F is specified", 2016-06-25). It was asserting that the regex must be compiled with compile_fixed_regexp(), instead test for the expected results, allowing the underlying implementation to change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7812-grep-ic

[PATCH v3 06/30] grep: add a test asserting that --perl-regexp dies when !PCRE

--perl-regexp or -P. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 4 +++- t/t7810-grep.sh | 12 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 547f4c19a7..dbed3efeee 100755 --- a/t/t4202-

[PATCH v3 00/30] Easy to review grep & pre-PCRE changes

mp; notes about that version. What changed this time around? See below: Ævar Arnfjörð Bjarmason (30): Makefile & configure: reword inaccurate comment about PCRE grep & rev-list doc: stop promising libpcre for --perl-regexp test-lib: rename the LIBPCRE prerequisite to PCRE No changes. l

[PATCH v3 02/30] grep & rev-list doc: stop promising libpcre for --perl-regexp

lar expression support. By wording the documentation differently and not promising any specific version of PCRE or even PCRE at all we have more wiggle room to change the implementation. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/git-grep.txt | 7 +--

[PATCH v3 07/30] grep: add a test for backreferences in PCRE patterns

Add a test for backreferences such as (.)\1 in PCRE patterns. This test ensures that the PCRE_NO_AUTO_CAPTURE option isn't turned on. Before this change turning it on would break these sort of patterns, but wouldn't break any tests. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com>

[PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

fixed, which was the only patternType that was tested for before in combination with those options. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- revision.c | 1 + t/t4202-log.sh | 60 +- 2 files changed, 56 insertion

[PATCH v3 01/30] Makefile & configure: reword inaccurate comment about PCRE

ere they make less sense is the pattern everything else follows in that file. I'm not going to war against that as part of this change, just following the existing pattern. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 6 -- configure.ac | 12

[PATCH v3 12/30] grep: add a test helper function for less verbose -f \0 tests

Add a helper function to make the tests which check for patterns with \0 in them more succinct. Right now this isn't a big win, but subsequent commits will add a lot more of these tests. The helper is based on the match() function in t3070-wildmatch.sh. Signed-off-by: Ævar Arnfjörð Bjarmason

[PATCH v3 19/30] perf: add a comparison test of log --grep regex engines

e it wasn't properly supported under PCRE. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p4220-log-grep-engines.sh | 44 1 file changed, 44 insertions(+) create mode 100755 t/perf/p4220-log-grep-engines.sh diff --git a/t/perf/p4220-lo

[PATCH v3 28/30] pack-objects: fix buggy warning about threads

uot;pack.threads" & --threads. Solve this bug by resetting the delta_search_threads variable in git_pack_config(), it might then be set by --threads again and be subsequently warned about, as the test I'm changing here asserts. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com

[PATCH v3 24/30] grep: change internal *pcre* variable & function names to be *pcre1*

, 2017-04-07) elaborates on the motivations behind this change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 52 ++-- grep.h | 8 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/grep.c b/grep.c index

[PATCH v3 03/30] test-lib: rename the LIBPCRE prerequisite to PCRE

e general name to make it clear that they work on both library versions. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/README| 4 ++-- t/t7810-grep.sh | 28 ++-- t/t7812-grep-icase-non-ascii.sh | 4 ++-- t/t78

Re: Options to avoid docs generation/installation

On Sun, May 21, 2017 at 4:56 AM, Neil Cafferkey wrote: > The INSTALL file says that docs are not built by default, but that's not my > experience. "make all" results in the generation of several Perl man pages, > e.g. "Git.3pm". Is it the case that the behaviour documented

Re: [PATCH v3 15/30] perf: add a GIT_PERF_MAKE_COMMAND for when *_MAKE_OPTS won't do

On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> diff --git a/t/perf/README b/t/perf/README >> index 49ea4349be..b3d95042a8 100644 >> --- a/t/perf/README >> +++ b/t/per

Re: [PATCH v5] send-email: --batch-size to work around some SMTP server limit

On Sun, May 21, 2017 at 2:59 PM, xiaoqiang zhao wrote: > Some email servers (e.g. smtp.163.com) limit the number emails to be > sent per session(connection) and this will lead to a faliure when > sending many messages. This OK to me, the nits I had are addressed by Junio's

Re: git-2.13.0: log --date=format:%z not working

On Fri, May 26, 2017 at 8:33 PM, Ulrich Mueller wrote: > The following commands work as expected (using commit b06d364310 > in the git://git.kernel.org/pub/scm/git/git.git repo as test case): > > $ export TZ=Europe/Berlin > $ git --no-pager log -1 --pretty="%ad" --date=iso

Re: [RFC/PATCH] recognize pathspec magic without "--" disambiguation

On Thu, May 25, 2017 at 5:27 PM, Jeff King wrote: > git log :/foo.*bar Another option would be to deprecate the :/rx syntax over some period in favor of ^{/rx}. I think it's too ugly to live, and really useless. It's equivalent to "--grep= --all". Does anyone use this and

[RFC/PATCH] WIP: add deprecation & experimental process/interface

vb0qyah76_+pjtkjsco3rht0xryktf2h1ds4...@mail.gmail.com/ 2. https://public-inbox.org/git/CACBZZX5oVKGZLKgS4aF0=xxtho67yns+zxsopdn9erjgzv9...@mail.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- GIT-VERSION-GEN | 1 + Makefile| 5 + deprecate.c | 34 +

Re: git-2.13.0: log --date=format:%z not working

On Sat, May 27, 2017 at 11:46 PM, Jeff King <p...@peff.net> wrote: > On Sat, May 27, 2017 at 06:57:08PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> There's another test which breaks if we just s/gmtime/localtime/g. As >> far as I can tell to make the non-local case work we

Re: [PATCH v3 1/4] stash: add test for stash create with no files

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Ensure the command gives the correct return code > > Signed-off-by: Joel Teichroeb > --- > t/t3903-stash.sh | 8 > 1 file changed, 8 insertions(+) > > diff --git a/t/t3903-stash.sh

Re: [PATCH v3 3/4] close the index lock when not writing the new index

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Signed-off-by: Joel Teichroeb > --- > builtin/add.c | 3 ++- > builtin/mv.c | 8 +--- > builtin/rm.c | 3 ++- > merge-recursive.c | 8 +--- > 4 files changed, 14 insertions(+),

Re: [PATCH v3 0/4] Implement git stash as a builtin command

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > I've rewritten git stash as a builtin c command. All tests pass, > and I've added two new tests. Test coverage is around 95% with the > only things missing coverage being error handlers. Worth noting, with your patches

Re: [PATCH v3 2/4] stash: add test for stashing in a detached state

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Signed-off-by: Joel Teichroeb > --- > t/t3903-stash.sh | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh > index aaae221304..b86851ef46 100755

Re: [PATCH v3 4/4] stash: implement builtin stash

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Implement all git stash functionality as a builtin command First thanks for working on this, it's great. Applied it locally, passes all tests for me. A couple of comments Christian didn't cover > + info->has_u =

Re: [PATCH v3 4/4] stash: implement builtin stash

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Implement all git stash functionality as a builtin command > > Signed-off-by: Joel Teichroeb > --- General note on this that I missed in my first E-Mail, you have ~20 calls to argv_array_init() but

Re: [PATCH] branch test: fix invalid config key access

On Sun, May 28, 2017 at 7:12 PM, Sahil Dua wrote: > Fixes the test by changing "branch.s/s/dummy" to "branch.s/s.dummy" which is > the right way of accessing config key "branch.s/s.dummy". Purpose of > this test is to confirm that this key doesn't exist after the branch >

Re: [Bug] setup_git_env called without repository

On Mon, May 29, 2017 at 1:45 PM, Zero King wrote: > After upgrading to Git 2.13.0, I'm seeing the following error message > when running `git am -h`. > >$ git am -h >fatal: BUG: setup_git_env called without repository > > And with Git built from the next branch: > >

Re: [PATCH v4 00/10] The final building block for a faster rebase -i

On Mon, May 29, 2017 at 12:51 PM, Johannes Schindelin wrote: > Hi René, > > On Sat, 27 May 2017, René Scharfe wrote: > >> Am 26.05.2017 um 05:15 schrieb Liam Beguin: >> > I tried to time the execution on an interactive rebase (on Linux) but >> > I did not notice a

Re: [PATCH v3 4/4] stash: implement builtin stash

On Mon, May 29, 2017 at 8:18 PM, Joel Teichroeb wrote: > Once I have all those leaks fixed, is there a way to make sure I'm not > missing any? I tried using valgrind with leak-check enabled, but there > are too many leaks from other git commands. I just used: valgrind

Re: [PATCH 1/2] mingw: verify that paths are not mistaken for remote nicknames

On Mon, May 29, 2017 at 10:25 PM, Johannes Sixt wrote: > Am 26.05.2017 um 05:35 schrieb Junio C Hamano: >> When asked to open/fopen a path, e.g. "a/b:/c", which does not exist >> on the filesystem, Windows (correctly) fails to open it but sets >> EINVAL to errno because the

Re: [PATCH v2 7/7] grep: add support for PCRE v2

On Wed, May 24, 2017 at 8:23 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Add support for v2 of the PCRE API. This is a new major version of >> PCRE that came out in early 2015[1]. >> >>

Re: [PATCH v2 1/7] grep: don't redundantly compile throwaway patterns under threading

On Wed, May 24, 2017 at 6:42 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Rather, it's just to make the code easier to reason about. It's >> confusing to debug this under threading & non-threadi

Re: [PATCH v2 0/2] Update sha1dc from upstream & optionally make it a submodule

On Tue, May 23, 2017 at 3:06 PM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Seems like it would be useful to have a way to ex-post-facto say "past >> history should use these URLs". i.e. if all git.

Re: [PATCH 2/3] sha1dc: use sha1collisiondetection as a submodule

On Sat, May 20, 2017 at 1:13 PM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Replace the forked sha1dc directory with a copy of the upstream code >> imported as a submodule. This is the exact same code

Re: [PATCH v2 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman

On Thu, May 18, 2017 at 10:13 PM, Ben Peart wrote: > This hook script integrates the new fsmonitor capabilities of git with > the cross platform Watchman file watching service. To use the script: > > Download and install Watchman from https://facebook.github.io/watchman/ > and

Re: [PATCH v2 1/7] grep: don't redundantly compile throwaway patterns under threading

On Fri, May 26, 2017 at 2:58 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> I think it's a pointless distraction to start speculating in this >> commit message what we're going to do with --debug it if i

Re: Hide decorations in git log

On Wed, May 24, 2017 at 4:22 PM, Robert Dailey wrote: > Is it possible to hide decorated refs in `git log` even if they are > reachable from the refs I'm actually interested in seeing the logs of? > > For example, if I do `git log --graph --decorate --oneline --branches

Re: [PATCH v2 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman

On Wed, May 24, 2017 at 3:12 PM, Christian Couder wrote: > On Thu, May 18, 2017 at 10:13 PM, Ben Peart wrote: >> This hook script integrates the new fsmonitor capabilities of git with >> the cross platform Watchman file watching service. To use the

[PATCH 3/3] sha1dc: remove the unused sha1dc/ directory

This has been made obsolete by the sha1collisiondetection submodule. See the preceding change for details. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- sha1dc/LICENSE.txt | 30 - sha1dc/sha1.h | 110 sha1dc/ubc_check.c

[PATCH 2/3] sha1dc: use sha1collisiondetection as a submodule

project. The upstream project has accepted my code changes to allow us to use their code as-is, see the preceding commit for details. So import the code as a submodule instead, this will make it easier to keep up-to-date with any upstream fixes or improvements. Signed-off-by: Ævar Arnfjörð

[PATCH 1/3] sha1dc: update from upstream

ion/commit/33a694a9ee1b79c24be45f9eab5ac0e1aeeaf271 3. "Git 2.13.0 segfaults on Solaris SPARC due to DC_SHA1=YesPlease being on by default" (https://public-inbox.org/git/cacbzzx6nmkk8af0-upjckwv4r+hv-uk2xwxva5u+_uq3vxu...@mail.gmail.com/) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile

[PATCH 0/3] Update sha1dc from upstream & optionally make it a submodule

This series: Ævar Arnfjörð Bjarmason (3): sha1dc: update from upstream * Fixes the Big-Endian detection on Solaris SPARC (and probably others) which broke the build as of 2.13.0 due to sha1dc being the dauflt. * Includes a patch from upstream fixing unaligned access

Re: [PATCH] tag: duplicate mention of --contains should mention --no-contains

On Mon, May 15, 2017 at 2:23 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > Fix a duplicate mention of --contains in the SYNOPSIS to mention > --no-contains. > > This fixes an error introduced in my commit ac3f5a3468 ("ref-filter: > add --no-contains option

Re: BUG: The .gitignore rules can't be made to cross submodule boundaries

On Tue, May 23, 2017 at 11:17 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Ævar, > > On Mon, 22 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> When I was adding the sha1collisiondetection submodule to git.git I >> noticed that building

Re: [PATCH v2 4/7] grep: add support for the PCRE v1 JIT API

On Wed, May 24, 2017 at 7:17 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> diff --git a/grep.c b/grep.c >> index 1157529115..49e9aed457 100644 >> --- a/grep.c >> +++ b/grep.c >> @@ -351,6 +

[PATCH] tests: add an optional test to test git-annex

t_bug/ Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- On Tue, May 16, 2017 at 7:59 PM, Joey Hess <i...@joeyh.name> wrote: > Ævar Arnfjörð Bjarmason wrote: >> On Tue, May 16, 2017 at 7:10 PM, Joey Hess <i...@joeyh.name> wrote: >> I have no idea what this

Re: clone vs submodule operation with HTTP cURL

On Tue, May 16, 2017 at 8:15 PM, Jean-Francois Bouchard wrote: > Hello, > > Anyone can help with this ? The workaround is hardly possible in a > medium environment as it needs editing and adding env to everyone and > in every clone. According to git-config anyauth is the

Re: [PATCH/RFC] branch: add tests for new copy branch feature

On Mon, May 29, 2017 at 12:56 AM, Sahil Dua wrote: > New feature - copying a branch along with its config section. > > Aim is to have an option -c for copying a branch just like -m option for > renaming a branch. > > This commit adds a few basic tests for getting any

Re: Feature request: "git status" highlights files that are larger than 500kb.

On Fri, May 26, 2017 at 2:24 AM, Zhomart Mukhamejanov wrote: > So it will be easy to track that we don't accidentally commit huge files. Isn't doing this via a pre-commit or pre-receive hook both more reliable & actually a 1=1 mapping to what you really care about?

[PATCH] wildmatch test: cover a blind spot in "/" matching

Add a test which covers a blindspot in how these tests should assert that negated character classes are allowed or not allowed to match "/" in certain circumstances. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t3070-wildmatch.sh | 2 ++ 1 file changed, 2 ins

Re: [PATCH] wildmatch test: remove redundant duplicate test

On Mon, May 29, 2017 at 2:54 AM, Junio C Hamano wrote: > Thanks. Did you run "sort | uniq -c" on it or something ;-)? I've been writing a new backend for wildmatch(). Was wondering what the difference in these two failing tests was, turns out there was none. > Will apply.

Re: [RFC/PATCH] WIP: add deprecation & experimental process/interface

On Mon, May 29, 2017 at 3:09 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN >> index 4f94fc7574..c76bbedf86 100755 >> --- a/GIT-VERSION-GEN >> +++

Re: [RFC/PATCH] WIP: add deprecation & experimental process/interface

On Mon, May 29, 2017 at 12:23 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sat, May 27, 2017 at 6:10 PM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> This is the WIP start of a deprecation & experimental interface to >> git. The goal is to formali

Re: [WIP/RFC 00/23] repository object

On Mon, May 29, 2017 at 12:36 PM, Duy Nguyen wrote: > On Tue, May 23, 2017 at 2:35 AM, Jeff King wrote: >> On Thu, May 18, 2017 at 04:21:11PM -0700, Brandon Williams wrote: >> >>> When I first started working on the git project I found it very difficult to >>>

Re: [PATCH v4 00/10] The final building block for a faster rebase -i

On Tue, May 30, 2017 at 5:44 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Ævar, > > On Mon, 29 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> On Mon, May 29, 2017 at 12:51 PM, Johannes Schindelin >> <johannes.schinde...@gmx.de> wrote: >>

[PATCH 6.5?/8] version: move --build-options to a test helper

Move the undocumented --build-options argument to a test helper. It's purely used for testing git itself, so it belongs in a test helper instead of something that's part of the public plumbing. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- On Tue, May 30, 2017 at 7:17 AM

Re: [PATCH/RFC] branch: add tests for new copy branch feature

On Mon, May 29, 2017 at 10:41 PM, Sahil Dua <sahildua2...@gmail.com> wrote: > On Mon, May 29, 2017 at 1:30 AM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> On Mon, May 29, 2017 at 12:56 AM, Sahil Dua <sahildua2...@gmail.com> wrote: >>> New feature -

Re: [PATCHv4 2/2] Documentation/clone: document ignored configuration variables

On Tue, May 30, 2017 at 9:12 AM, SZEDER Gábor wrote: > Due to limitations/bugs in the current implementation, some > configuration variables specified via 'git clone -c var=val' (or 'git > -c var=val clone') are ignored during the initial fetch and checkout. > > Let the

Re: FORMAT_PATCH_NAME_MAX increase

On Mon, May 29, 2017 at 10:49 AM, Laszlo Ersek wrote: > Hi, > > would it be possible to > > - increase the FORMAT_PATCH_NAME_MAX macro from 64 to, say, 128? > > - Or else to introduce a new git-config knob for it? > > I have a small review-helper / interdiff script that matches

Re: FORMAT_PATCH_NAME_MAX increase

On Tue, May 30, 2017 at 2:33 PM, Laszlo Ersek wrote: > (apologies for the self-followup:) > > On 05/30/17 14:28, Laszlo Ersek wrote: > >> Note that in such an incremental review, I specifically wish to compare >> patches against each other (i.e., I'd like to see diffs of diffs,

Re: FORMAT_PATCH_NAME_MAX increase

On Tue, May 30, 2017 at 3:37 PM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Just curious do you know about https://github.com/trast/tbdiff ? If >> not it might have a high overlap with what you're doing

Re: How to avoid "Please tell me who you are..."?

On Fri, Jun 2, 2017 at 9:15 AM, Junio C Hamano wrote: > Jeffrey Walton writes: > >> Is there no switch? Its the most efficient way to accomplish the task. > > This is a safety to help normal human users from hurting themselves, > and it does not make any

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: > Martin Ågren writes: > >> I looked into this some more. It turns out it is possible to trigger >> undefined behavior on "next". Here's what I did: >> ... >> >> This "fixes" the problem: >> ... >>

[WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

9) 0.11(0.08+0.12) +175.0% 7519.5: status -uall 0.29(0.11+0.18) 0.40(0.16+0.19) +37.9% Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- On Fri, Jun 2, 2017 at 2:40 AM, Ben Peart <peart...@gmail.com> wrote: > Any chance you can provide me with a bash script

[PATCH] perf: work around the tested repo having an index.lock

When the tested repo has an index.lock file it should be removed. This file may be present if e.g. git-status previously crashed in that repo, and it will make a lot of git commands fail. Let's try harder and remove the lock. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> ---

Re: git-gui ignores core.hooksPath

On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan wrote: > Hi git devs, > > First off, thanks for your awesome work! > > I've been unhappy for quite a while that I had to configure the hooks > manually for each of my repos - until I found out recently that there is > the

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 4:46 PM, Liam R. Howlett wrote: > * ?var Arnfj?r? Bjarmason [170602 04:53]: >> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: >> > Martin Ågren writes: >> > >> >> I looked into

Re: [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes

On Fri, Jun 2, 2017 at 6:10 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi, > > On Fri, 2 Jun 2017, Junio C Hamano wrote: > >> Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: >> >> > See <20170525200528.22037-1-ava...@gmai

Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

On Sat, Jun 3, 2017 at 12:05 AM, Ben Peart <peart...@gmail.com> wrote: > > > On 6/2/2017 6:28 AM, Ævar Arnfjörð Bjarmason wrote: >> >> Add a performance test for the new core.fsmonitor facility using the >> sample query-fsmonitor hook. >> >> This is WI

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren <martin.ag...@gmail.com> wrote: > On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: >> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> Martin Ågren <mar

Re: [PATCH] perf: work around the tested repo having an index.lock

On Fri, Jun 2, 2017 at 8:45 PM, Jeff King <p...@peff.net> wrote: > On Fri, Jun 02, 2017 at 10:33:30AM +0000, Ævar Arnfjörð Bjarmason wrote: > >> When the tested repo has an index.lock file it should be removed. This >> file may be present if e.g. git-status previously

Re: pushing for a new hash, was Re: [PATCH 2/3] rebase: Add tests for console output

On Fri, Jun 2, 2017 at 7:54 PM, Jonathan Nieder wrote: > Hi Dscho, > > Johannes Schindelin wrote: >> On Thu, 1 Jun 2017, Stefan Beller wrote: > >>> We had a discussion off list how much of the test suite is in bad shape, >>> and "$ git grep ^index" points out a lot of places

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 10:17 PM, demerphq <demer...@gmail.com> wrote: > On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: >> On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren <martin.ag...@gmail.com> wrote: >>> On 2 June 2017 at 10:51, Ævar

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 10:11 PM, Martin Ågren <martin.ag...@gmail.com> wrote: > On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: >> On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren <martin.ag...@gmail.com> wrote: >>> On 2 June 2017 at

Re: [PATCH v4 0/6] Fast git status via a file system watcher

On Thu, Jun 1, 2017 at 5:50 PM, Ben Peart wrote: > Changes from V3 include: > - update test script based on feedback > - update template hook proc with better post-processing code and make >it executable I have watchman running finally, so aside from issues applying

Re: [PATCH v4 0/6] Fast git status via a file system watcher

On Thu, Jun 1, 2017 at 10:51 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > On Thu, Jun 1, 2017 at 5:50 PM, Ben Peart <peart...@gmail.com> wrote: >> Changes from V3 include: >> - update test script based on feedback >> - update template hook proc

Re: [PATCH v4 2/8] grep: skip pthreads overhead when using one thread

On Thu, Jun 1, 2017 at 11:20 PM, Stefan Beller <sbel...@google.com> wrote: > On Thu, Jun 1, 2017 at 11:20 AM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: > >> + if (num_threads == 1) >> + num_threads = 0; > > I would think that

Re: [PATCH v4 0/6] Fast git status via a file system watcher

On Thu, Jun 1, 2017 at 11:06 PM, Ben Peart <peart...@gmail.com> wrote: > On 6/1/2017 3:57 PM, Ævar Arnfjörð Bjarmason wrote: >> >> On Thu, Jun 1, 2017 at 5:50 PM, Ben Peart <peart...@gmail.com> wrote: >>> >>> Changes from V3 include: >>>

Re: [PATCH v4 2/8] grep: skip pthreads overhead when using one thread

On Thu, Jun 1, 2017 at 11:36 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > On Thu, Jun 1, 2017 at 11:20 PM, Stefan Beller <sbel...@google.com> wrote: >> On Thu, Jun 1, 2017 at 11:20 AM, Ævar Arnfjörð Bjarmason >> <ava...@gmail.com> wrote: &g

Re: [PATCH] git-p4: remove obsolete version check

On Sat, Jun 3, 2017 at 3:31 PM, Jakub Wilk wrote: > The file is syntactically correct only in Python >= 2.6, so the > version check never does anything. [CC-ing Eric who added that check] Your commit message doesn't give an example of this, but with e.g. python 2.0 you get:

Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

On Fri, Jun 2, 2017 at 11:44 PM, David Turner wrote: > BTW, a medium-sized (~250k files across 40k dirs) synthetic repo is available > over bittorrent at: > http://bitmover.com/2015-04-03-1M-git-bare.tar.bz2.torrent Can you seed this please? I've been trying to

Re: [PATCH] perf: work around the tested repo having an index.lock

On Sat, Jun 3, 2017 at 1:52 AM, Junio C Hamano wrote: > Jeff King writes: > >> But I think a more compelling case is that there may be an ongoing >> operation in the original repo (e.g., say you are in the middle of >> writing a commit message) when we do a

Re: [PATCH] perf: work around the tested repo having an index.lock

On Sun, Jun 4, 2017 at 9:37 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Sun, Jun 4, 2017 at 2:00 AM, Junio C Hamano <gits...@pobox.com> wrote: >> Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: >> >>>> My feeling exactly. Di

Re: [PATCH] test-lib: add ability to cap the runtime of tests

On Sun, Jun 4, 2017 at 2:31 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Speeding up the test suite by simply cataloging and skipping tests >> that take longer than N seconds is a hassle to maintain, and enti

Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

On Sun, Jun 4, 2017 at 3:59 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> This is WIP code for the reasons explained in the setup comments, >> unfortunately the perf code doesn't easily allow you

Re: [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes

On Wed, Jun 7, 2017 at 5:50 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi, > > On Mon, 5 Jun 2017, Junio C Hamano wrote: > >> Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: >> >> > On Fri, Jun 2, 2017 at 6:10 PM, Johannes Schindel

Re: send-email: Net::SMTP::SSL failure

On Wed, Jun 7, 2017 at 7:00 PM, Liam Breck wrote: > On Tue, Jun 6, 2017 at 10:47 PM, Liam Breck wrote: >> >> This is configured to send via a gmail account >> git send-email --to-cover --cc-cover >> >> I See >> Attempt to reload IO/Socket/SSL.pm

Re: send-email: Net::SMTP::SSL failure

On Wed, Jun 7, 2017 at 8:04 PM, Liam Breck <l...@networkimprov.net> wrote: > Thanks for your help! > > On Wed, Jun 7, 2017 at 10:16 AM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> On Wed, Jun 7, 2017 at 7:00 PM, Liam Breck <l...@networkimprov.net> wro

Re: send-email: Net::SMTP::SSL failure

On Wed, Jun 7, 2017 at 9:39 PM, Liam Breck <l...@networkimprov.net> wrote: > On Wed, Jun 7, 2017 at 12:30 PM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> On Wed, Jun 7, 2017 at 8:04 PM, Liam Breck <l...@networkimprov.net> wrote: >>> Thanks for

Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

On Wed, Jun 7, 2017 at 9:51 PM, Ben Peart <peart...@gmail.com> wrote: > > > On 6/2/2017 7:06 PM, Ævar Arnfjörð Bjarmason wrote: >> >> >> I don't have time to update the perf test now or dig into it, but most >> of what you're describing in this mail doesn't

Re: [PATCH v4 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman

On Thu, Jun 1, 2017 at 5:51 PM, Ben Peart wrote: > +if [ $1 -eq 1 ] Tiny nit: Needs quoting: $ .git/hooks/query-fsmonitor .git/hooks/query-fsmonitor: 15: [: -eq: unexpected operator

Re: What's cooking in git.git (Jun 2017, #03; Mon, 5)

On Wed, Jun 7, 2017 at 8:28 PM, Stefan Beller wrote: > On Tue, Jun 6, 2017 at 3:05 PM, Jacob Keller wrote: >> On Tue, Jun 6, 2017 at 2:50 AM, Michael Haggerty >> wrote: >>> On Mon, Jun 5, 2017 at 8:23 PM, Stefan Beller

Re: [PATCH v4 00/10] The final building block for a faster rebase -i

On Tue, May 30, 2017 at 10:22 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > On Tue, May 30, 2017 at 5:44 PM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> pu does not build for me: >> >> 2017-05-30T11:38:50.0089681Z libgit.a(grep.o):

Re: bug: `git log --grep ... --invert-grep --author=...` negates / ignores --author

: When you provide --invert-grep the --author filter is completely discarded. This is a bug. I.e. on git.git: OK: $ git log --grep=bar --author=Ævar --pretty=format:%an -100 origin/pu |sort|uniq -c|sort -nr 5 Ævar Arnfjörð Bjarmason $ git log --author=Ævar --pretty=format:%an -100 origin/p

Re: [PATCH 6.5?/8] version: move --build-options to a test helper

On Wed, May 31, 2017 at 5:46 PM, Johannes Schindelin wrote: > Hi Peff, > > On Wed, 31 May 2017, Jeff King wrote: > >> On Wed, May 31, 2017 at 05:27:21PM +0200, Johannes Schindelin wrote: >> >> > > My intent in putting it into the actual git binary was that it could >>

Re: What's cooking in git.git (May 2017, #08; Mon, 29)

On Mon, May 29, 2017 at 8:23 AM, Junio C Hamano wrote: > * ab/pcre-v2 (2017-05-26) 7 commits > - grep: add support for PCRE v2 > - grep: un-break building with PCRE < 8.20 > - grep: un-break building with PCRE < 8.32 > - grep: add support for the PCRE v1 JIT API > - log:

Re: Unaligned accesses in sha1dc

On Thu, Jun 1, 2017 at 12:26 PM, Martin Ågren wrote: > On 1 June 2017 at 12:08, Andreas Schwab wrote: >> On Jun 01 2017, Junio C Hamano wrote: >> >>> Depending on the model of "ARM" (or "SPARC") emulated with QEMU, and >>> depending on

<    5   6   7   8   9   10   11   12   13   14   >