Re: Exclude a file from a pull request‏

2015-10-07 Thread Andreas Schwab
do that? Create a branch that does not include the file. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "

Re: Three dot notion used inconsitent?

2015-11-18 Thread Andreas Schwab
, which are set operations on the revision history. That git diff accepts this syntax is only for convenience. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To un

Re: Git's inconsistent command line options

2015-08-26 Thread Andreas Schwab
Jacob Keller jacob.kel...@gmail.com writes: if you really mean to create a tag named create, use git tag -- create master In all other uses of -- refs must be put on the *left* side. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: glibc mutex deadlock in signal handler

2015-09-03 Thread Andreas Schwab
See <http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03> for the complete list of functions you may safely call from a signal handler. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 827

[PATCH] Documentation/config: fix formatting for branch.*.rebase and pull.rebase

2015-09-12 Thread Andreas Schwab
Don't format the second paragraph as a literal block. Signed-off-by: Andreas Schwab <sch...@linux-m68k.org> --- Documentation/config.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 0c351b9..e0bd703

Re: Single brackets matching in .gitignore rules

2015-09-27 Thread Andreas Schwab
> *] a]true > -- > > Here Git does not give up on parsing, treats unmatched ']' character > literally, and doesn't dislike that it is an "unmatched" end of a broken > character group. > Why? ] by itself is not special in a glob. Andreas. -- Andreas Sch

Re: [ANNOUNCE] Git v2.6.0-rc1

2015-09-09 Thread Andreas Schwab
Junio C Hamano <gits...@pobox.com> writes: > * After "git am" without "-3" stops, running "git am -" pays attention Is this a typo for ---> "git am -3"? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fi

Re: Show total commit count of two authors or more authors into first author

2015-12-06 Thread Andreas Schwab
r email address was spelled differently. If the file .mailmap exists at the toplevel of the repository, or at the location pointed to by the mailmap.file or mailmap.blob configuration options, it is used to map author and committer names and email addresses to canonical real nam

Re: git bisect with temporary commits

2015-12-14 Thread Andreas Schwab
ks the originally checked out commit except by being pointed to by HEAD. Also, testing a different commit as the one suggested by git can be useful when skipping over commits that are known to fail for unrelated reasons (see "Avoiding testing a commit" in git-bisect(1)). Andreas. -- An

Re: git bisect with temporary commits

2015-12-14 Thread Andreas Schwab
ood and does not compile > > Is this intended behaviour? Shouldn't git either do a reset to the > commit we're currently bisecting, or warn the user as it was probably > unintended to add new commits? You should instead tell git that HEAD^ is good, since that is what git asked you to

Re: [PATCH] prune: keep files created after process start

2016-06-19 Thread Andreas Schwab
) > + if (st.st_mtime > expire || st.st_ctime >= start) That will also mean objects created (or their inode changed) up to a second before the start of prune will not be removed. For example, objects ejected out of a pack by a previous repack may be affected. Andreas. -- Andreas Schwab

Re: unable to pull from remote if commit date is in the future

2016-06-20 Thread Andreas Schwab
Norbert Kiesel <nkie...@gmail.com> writes: > For the record: the faulty commit is > https://github.com/seandepagnier/weather_routing_pi/commit/23c07cc5d2be7ce68349f4b3719b6fa6fe90e0bf That commit is part of master. Are you sure you don't have it already? Andreas. -- Andreas

Re: [PATCH v4 05/12] ref-filter: introduce parsing functions for each valid atom

2016-02-07 Thread Andreas Schwab
Karthik Nayak <karthik@gmail.com> writes: > + if ((( arg && len == arg - sp) || > +(!arg && len == ep - sp )) && len == (arg ? arg : ep) - sp && Andreas. -- Andreas Schwab, sch...@linux-m

Re: fast-import fails in read-only tree

2016-01-30 Thread Andreas Schwab
us: > mkfifo in out > (exec git cat-file --batch out) & > exec 8>in > exec 9 echo $sha >&8 > read mode type size <&9 coproc CAT_FILE git cat-file --batch echo $sha >&${CAT_FILE[1]} read mode type size <&${CAT_FILE[0]} Andrea

Re: git show -m with a parent number

2016-03-30 Thread Andreas Schwab
Anatoly Borodin <anatoly.boro...@gmail.com> writes: > It's not like `git diff X^2 X` is a big problem, but too much of a > copypaste. Brace expansion helps a bit: git diff X{^2,} Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01

Re: Timestamp of zero in reflog considered invalid

2016-04-05 Thread Andreas Schwab
t; + errno == ERANGE) || You need to set errno = 0 before calling strtoul, to distinguish the valid return of ULONG_MAX (which would keep errno intact) and a real overflow. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276

Re: Git clone sends first an empty authorization header

2016-03-05 Thread Andreas Schwab
way to implement HTTP authentication. The client won't know which authentication method to use until the server tells it. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely differen

Re: [PATCH] git-prompt: make colors available in custom prompts

2016-05-02 Thread Andreas Schwab
al width), when browsing the command history. If you want to include control characters in the prompt that don't contribute to the length you have to enclose them in \[ \]. The problem is that \[ \] are processed before embedded command substitutions are expanded, thus they cannot produce such control characte

Re: [BUG] git rev-parse :/ "regex" syntax not really regex?

2016-04-17 Thread Andreas Schwab
quoting feature). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a messag

Re: history damage in linux.git

2016-04-21 Thread Andreas Schwab
or dates, eg 8cad489261c564d4ee1db4de4ac365af56807d8a or 281baf7a702693deaa45c98ef0c5161006b48257. That will probably cause git describe --contains to take a different path through the history. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And

Re: git rebase -i without altering the committer date

2016-04-20 Thread Andreas Schwab
unchanged, is there > any chance that this functionality could please be implemented? The easiest way to implement that is to add a graft to redirect the parent of the second commit to the inserted commit, then use git filter-branch to make the graft permanent. Andreas. -- Andreas Schwab,

Re: t6044 broken on pu

2016-05-07 Thread Andreas Schwab
0,7 +20,7 @@ test_description="merges with unrelated index changes" > # Commit E: renames a->subdir/a, adds subdir/e > > test_expect_success 'setup trivial merges' ' > - seq 1 10 >a && > + printf 1 2 3 4 5 7 8 9 10 >a && $ printf 1 2 3

Re: [ANNOUNCE] Git v2.9.1

2016-07-12 Thread Andreas Schwab
", diff), diff); > + Q_("%" PRIuMAX " second ago", "%" PRIuMAX " seconds > ago", diff), diff); PRIuMAX isn't compatible with time_t. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 175

Re: [PATCH 1/2] mailinfo: extract is_from_line from mailsplit

2016-07-24 Thread Andreas Schwab
|| > + !isdigit(colon[ 2])) > + return 0; > + > + /* year */ > + if (strtol(colon+3, NULL, 10) <= 90) > + return 0; > + > + /* Ok, close enough */ > + return 1; > +} Should this be made more strict, like by checking for

Re: [PATCH 1/2] mailinfo: extract is_from_line from mailsplit

2016-07-24 Thread Andreas Schwab
Johannes Schindelin <johannes.schinde...@gmx.de> writes: > Hi Andreas, > > On Sun, 24 Jul 2016, Andreas Schwab wrote: > >> Eric Wong <e...@80x24.org> writes: >> >> > diff --git a/mailinfo.c b/mailinfo.c >> > index 9f19ca1..0ebd

Re: [ANNOUNCE] Git v2.9.1

2016-07-12 Thread Andreas Schwab
Johannes Schindelin <schinde...@wisc.edu> writes: >> PRIuMAX isn't compatible with time_t. > > That statement is wrong. No, it isn't. PRIuMAX is for uintmax_t, and time_t is not uintmax_t (even if they happen to have the same representation). Andreas. -- Andreas Schwab, sch

Re: [ANNOUNCE] Git v2.9.1

2016-07-12 Thread Andreas Schwab
Johannes Schindelin <johannes.schinde...@gmx.de> writes: > Hi Andreas, > > On Tue, 12 Jul 2016, Andreas Schwab wrote: > >> Johannes Schindelin <schinde...@wisc.edu> writes: >> >> >> PRIuMAX isn't compatible with time_t. >> > &g

Re: [ANNOUNCE] Git v2.9.1

2016-07-14 Thread Andreas Schwab
7. Feb 07:28:15 CET 2106 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a m

Re: [ANNOUNCE] Git v2.9.1

2016-07-12 Thread Andreas Schwab
Jeff King <p...@peff.net> writes: > In case it wasn't clear, I was mostly guessing there. So I dug a bit > further, and indeed, I am wrong. Linux never bumped to a 64-bit time_t > on i386 because of the ABI headaches. This is being worked on. Andreas. -- Andreas Schwab, sch...

Re: [ANNOUNCE] Git v2.9.1

2016-07-11 Thread Andreas Schwab
uot; >actual && # test_cmp expect actual This is outside the range of 32bit time_t. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely differen

Re: split directories into branches

2016-07-04 Thread Andreas Schwab
shawn wilson <ag4ve...@gmail.com> writes: > $ git filter-branch --tree-filter "shopt -s extglob && mkdir -p > cookbooks/base_sys && mv !(cookbooks) cookbooks/base_sys" extglob changes the parser, you need to set that on a separate line. Andreas. -- And

Re: Fwd: git rm

2016-07-06 Thread Andreas Schwab
y that it preserves the most data. The data is still preserved. You can restore it with "git checkout HEAD ". Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Fwd: git rm

2016-07-10 Thread Andreas Schwab
Peter <peter...@gmail.com> writes: > So if I do: > > touch abc > git add abc > > > And after that I do: > > git rm abc error: the following file has changes staged in the index: abc (use --cached to keep the file, or -f to force removal) Andreas. -- Andr

Re: Fwd: git rm

2016-07-10 Thread Andreas Schwab
Peter <peter...@gmail.com> writes: > Ah, ok, I see now. But are there any other situations where the "-f" > switch is not needed? When the file is unmodified and matches the index. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942

Re: Odd git overrflow bug?

2016-07-10 Thread Andreas Schwab
d39d490b59bdfbbdd2cf5b54c0521 is the first bad commit commit de4fa746271d39d490b59bdfbbdd2cf5b54c0521 fatal: you want to use way too much memory Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To u

Re: Minor bug: git config ignores empty sections

2016-08-15 Thread Andreas Schwab
that have been put there on purpose. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git"

Re: Minor bug: git config ignores empty sections

2016-08-15 Thread Andreas Schwab
on, it should go when section goes. > - if it is a more generic comment about this configuration file, >it should stay. The comment may not be related to the surrounding keys, but just a commented-out config key that you want to keep around for reference. Andreas. -- Andreas Schwab, sc

Re: Confusing git messages when disk is full.

2017-02-16 Thread Andreas Schwab
d (might be worth calling out the > bitwise-OR, though, just to make it clear it's not a typo). Since the order of evaluation is unspecified, it would be better to force sequencing ferror before fclose. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: git format-patch --break-rewrites broken in 2.9.3

2016-08-19 Thread Andreas Schwab
t; >> What must be done now to get a usable patch? > > As an aside, the range can be shortened to > > 95fa0405c5991726e06c08ffcd8ff872f7fb4f2d^! In the context of format-patch you can also use -1 to select the topmost commit from the list. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG

Re: Most recent revision that contains a string

2016-08-21 Thread Andreas Schwab
On Aug 20 2016, Josh Triplett <j...@joshtriplett.org> wrote: > If you want to find a change that introduces or removes a particular > string, you could use "git log -S". That doesn't allow regexes, It does, actually, see --pickaxe-regex. Andreas. -- Andreas Schwab, sch

Re: Bug: git-add .* errors out

2016-09-11 Thread Andreas Schwab
roduce > it in my machine with `git add ".*"` and it didn't error out. Probably you were running it in a subdirectory. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH] reset: --unmerge

2016-10-27 Thread Andreas Schwab
zable. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

[PATCH] t6026-merge-attr: don't fail if sleep exits early

2016-11-08 Thread Andreas Schwab
Commit 5babb5bdb3 ("t6026-merge-attr: clean up background process at end of test case") added a kill command to clean up after the test, but this can fail if the sleep command exits before the cleanup is executed. Ignore the error from the kill command. Signed-off-by: Andreas S

Re: [PATCH] t6026-merge-attr: don't fail if sleep exits early

2016-11-09 Thread Andreas Schwab
sted by looking for the pid file. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH v2] t6026-merge-attr: don't fail if sleep exits early

2016-11-10 Thread Andreas Schwab
existence of the pid file to test that the merge driver was actually called. Signed-off-by: Andreas Schwab <sch...@suse.de> --- t/t6026-merge-attr.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/t/t6026-merge-attr.sh b/t/t6026-merge-attr.sh index 7a6e33e673..03d13d00b

Re: git clone --bare --origin incompatible?

2016-10-23 Thread Andreas Schwab
directly to local branches, without any remote-tracking branches, --origin doesn't make sense. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Test failures when Git is built with libpcre and grep is built without it

2017-01-09 Thread Andreas Schwab
h directory.t7810-grep # git grep -G -F -P -E > a\x{2b}b\x{2a}c ab >actual You need to quote the regexp argument, see the line starting with "test_must_fail" above. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH v3] am: add am.signoff add config variable

2016-12-28 Thread Andreas Schwab
On Dez 28 2016, Eduardo Habkost <ehabk...@redhat.com> wrote: > @@ -32,10 +32,12 @@ OPTIONS > If you supply directories, they will be treated as Maildirs. > > -s:: > ---signoff:: > +--[no-]-signoff:: That's one dash too much. Andreas. -- Andreas Schwab, sch..

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Andreas Schwab
re-date] [--ignore-space-change | --ignore-whitespace] >[--whitespace=] [-C] [-p] [--directory=] > @@ -32,10 +32,12 @@ OPTIONS > If you supply directories, they will be treated as Maildirs. > > -s:: > ---signoff:: > +--[no]-signoff:: That should be --[no-]

Re: BUG: Renaming a branch checked out in a different work tree

2017-03-29 Thread Andreas Schwab
t work tree then reports > itself being on the "initial commit" with all files being in the > staging area. Fixed since 2.8.3. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: git-describe --contains

2017-08-11 Thread Andreas Schwab
you see that the branch containing the above commit was merged into a branch that follows v4.9-rc2, which eventually was merged into v4.10-rc1. > BTW, what are the numbers 154^2~44^2~178 that follow the tag name? See git-rev-parse(1). '~N' means to go back N parents, ^N means to pick parent N

Re: Git on macOS shows committed files as untracked

2017-07-14 Thread Andreas Schwab
irectory). >> > Thanks for testing - > Normal and Normal ;-) > For me the 6th code point does look strange > The "box" with 04142F: This is actually 1244f (CUNEIFORM NUMERIC SIGN ONE BAN2). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint

Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()

2017-07-09 Thread Andreas Schwab
On Jul 09 2017, René Scharfe <l@web.de> wrote: > [2] http://pubs.opengroup.org/onlinepubs/009695399/functions/memchr.html You are using an old revision. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5

Re: [PATCH] strbuf: use designated initializers in STRBUF_INIT

2017-07-10 Thread Andreas Schwab
s may be supported, but not > a guarantee (e.g., gcc had designated initializers before > C99 existed). Note that the GNU C designated initializers initially used a different syntax than the one C99 adopted. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1

Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()

2017-07-08 Thread Andreas Schwab
On Jul 08 2017, René Scharfe <l@web.de> wrote: > Am 08.07.2017 um 13:08 schrieb Andreas Schwab: >> On Jul 08 2017, René Scharfe <l@web.de> wrote: >> >>> Avoid running over the end of another -- a C string whose length we >>> don't k

Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()

2017-07-08 Thread Andreas Schwab
ever reads past the differing characters. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

2017-04-25 Thread Andreas Schwab
----------- That doesn't explain the point of the option. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

2017-04-25 Thread Andreas Schwab
neline of this commit > ... > > instead of: > pick deadbee The oneline of this commit > ... > > Using a single character command-name allows the lines to remain > aligned, making the whole set more readable. Perhaps there should rather be an option to tell rebase to align th

Re: Bug: wrong documentation for git-fast-import's option command

2017-04-30 Thread Andreas Schwab
o the docs for feature), and explain this > is meant to allow other consumers of the fast import format. > > Looks like this bug existed since the option command was added in > 9c8398f in 2009. Am I the first one who tried to use it? ;-) > > Cheers, > > Tomi > Andreas. -- A

Re: [RFC] imap-send: escape backslash in password

2017-08-04 Thread Andreas Schwab
g string = quoted / ... quoted = DQUOTE *QUOTED-CHAR DQUOTE QUOTED-CHAR = / "\" quoted-specials quoted-specials = DQUOTE / "\" Thus the quoting applies to any element that is a string (and a double quote needs to be quoted as well). Andreas. -- Andreas Sc

Re: [PATCH] tests: don't give unportable ">" to "test" built-in, use -gt

2017-08-07 Thread Andreas Schwab
t tag --contains HEAD >actual && > test_cmp expect actual && > run_with_limited_stack git tag --no-contains HEAD >actual && > - test_line_count ">" 10 actual > + test_line_count "-gt" 10 actual Maybe also remove the q

Re: Migration from CVS to Git looses merges

2017-06-25 Thread Andreas Schwab
se -M 'Merge branch ([-\w]+)' to match it. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Unaligned accesses in sha1dc

2017-06-01 Thread Andreas Schwab
SHA1COMPRESS_FULL_ROUND2_STEP(e, a, b, c, d, W, 26, temp); Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: Unaligned accesses in sha1dc

2017-06-01 Thread Andreas Schwab
This is git 2.13.0. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: Unaligned accesses in sha1dc

2017-06-01 Thread Andreas Schwab
On Jun 01 2017, "brian m. carlson" <sand...@crustytoothpaste.net> wrote: > On Thu, Jun 01, 2017 at 10:28:52AM +0200, Andreas Schwab wrote: >> The sh1dc implementation is making unaligned accesses, which will crash >> on some architectures, others h

Re: Unaligned accesses in sha1dc

2017-06-01 Thread Andreas Schwab
SHA1DCUpdate calls sha1_process with buf being unaligned. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: Unaligned accesses in sha1dc

2017-06-01 Thread Andreas Schwab
quot;software unaligned-access > emulation" our userland may not see a SIGBUS. Even if the architecture implements unaligned accesses in hardware, it is still undefined behaviour, and the compiler will (eventually) take advantage of it. Andreas. -- Andreas Schwab, SUSE Labs, sch...@su

Re: [PATCH v2 1/2] git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL

2017-06-10 Thread Andreas Schwab
On Jun 09 2017, Jonathan Nieder <jrnie...@gmail.com> wrote: > That way side-effectful callers like FREEZ(func() ? a : b) would > work. Except that you cannot take the address of a non-lvalue. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D

Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list

2017-09-20 Thread Andreas Schwab
ch_string_list_item(item, list) > ... > else > ... > >making it a non-starter. That can be fixed with a dangling else. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list

2017-09-21 Thread Andreas Schwab
On Sep 21 2017, Junio C Hamano <gits...@pobox.com> wrote: > Now you make me curious. How would that variant be different from > option C. in Jonathan's message? Only in the parity of the condition. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54

Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list

2017-09-20 Thread Andreas Schwab
On Sep 20 2017, Jonathan Nieder <jrnie...@gmail.com> wrote: > Andreas Schwab wrote: >> On Sep 19 2017, Jonathan Nieder <jrnie...@gmail.com> wrote: > >>> B. #define for_each_string_list_item(item, list) \ >>> if (list->items) \ >>>

Re: Consider escaping special characters like 'less' does

2017-10-15 Thread Andreas Schwab
; diff --git a/some_file b/some_file >> new file mode 100644 >> index 000..357323f >> --- /dev/null >> +++ b/some_file >> @@ -0,0 +1 @@ >> +?Hello >> \ No newline at end of file > > It is your terminal, not git's fault that you get a ? rendered. It'

Re: Consider escaping special characters like 'less' does

2017-10-16 Thread Andreas Schwab
sing? Or blobs with embedded escape sequences? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Minor man page weirdness?

2017-10-17 Thread Andreas Schwab
On Okt 17 2017, Jeff King <p...@peff.net> wrote: > On Tue, Oct 17, 2017 at 06:29:59PM +0200, Andreas Schwab wrote: > >> On Okt 16 2017, Jeff King <p...@peff.net> wrote: >> >> > I get: >> > >> > Reset to if exists already\

Re: Minor man page weirdness?

2017-10-17 Thread Andreas Schwab
ady\&. Without \fB\-f\fR\fIgit branch\fR refuses to change an existing branch\&. In combination with This is with asciidoc 8.6.9. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Minor man page weirdness?

2017-10-17 Thread Andreas Schwab
On Okt 17 2017, Jeff King <p...@peff.net> wrote: > On Tue, Oct 17, 2017 at 07:25:28PM +0200, Andreas Schwab wrote: > >> >> I see this in git-branch.1: >> >> >> >> Reset to if exists already\&. >> >> Without >> >&

Re: Minor man page weirdness?

2017-10-17 Thread Andreas Schwab
ite (removes extra spaces). An easy workaround would be to add a comma between `-f` and 'git branch'. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Minor man page weirdness?

2017-10-17 Thread Andreas Schwab
anch\&. In combination with Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH v4 0/2] launch_editor(): indicate that Git waits for user input

2017-11-30 Thread Andreas Schwab
flush()ing stderr actually does something. >> >> I agree with the "unbuffered" statement. I am surprised that you expect >> fflush() >> to do nothing in that situation... but I am no expert in that area. Can you >> point me to some documentation? > >

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

2017-12-01 Thread Andreas Schwab
single-quotes? As far as POSIX is concerned, semicolons are not special, but can be used to separate commands instead of newlines. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCHv2 6/7] builtin/describe.c: describe a blob

2017-11-02 Thread Andreas Schwab
blob? (I would prefer B2...) What if B3 renames or copies the blob? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: Why does fetch-pack not works over http?

2017-10-27 Thread Andreas Schwab
ck" > using "https" procotol. Example of a trace below: > > 12:03:07.512558 git.c:344   trace: built-in: git 'fetch- > pack' '--stateless-rpc' '--stdin' '--lock-pack' '--thin' 'https://githu > b.com/git/git/' With --stateless-rpc, fetch-pack doesn't do the connect i

Re: [BUG] git remote prune removes local tags, depending on fetch config

2018-01-16 Thread Andreas Schwab
remote tracking branches are put in a separate name space. If you fetch the remote tags into a separate name space (eg. refs/remote/tags/*:refs/tags/*) then there is no conflict. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 827

Re: [PATCH] enable core.fsyncObjectFiles by default

2018-01-17 Thread Andreas Schwab
On Jan 17 2018, Christoph Hellwig <h...@lst.de> wrote: > I've lost data on development machines with various times countless > times due to the lack of this option, and now lost trees on a Too many times. :-) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint

Re: [PATCH 05/14] packed-graph: implement construct_graph()

2018-01-26 Thread Andreas Schwab
On Jan 26 2018, Junio C Hamano <gits...@pobox.com> wrote: > Also, would >>32 be a problem if commit.date is an uint32 (and > shifting all its bits out to the right)? It would be undefined. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D

Re: contrib/completion/git-completion.bash: declare -g is not portable

2018-02-03 Thread Andreas Schwab
`local' command. The `-g' option suppresses this behavior. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: git: CVE-2018-1000021: client prints server sent ANSI escape codes to the terminal, allowing for unverified messages to potentially execute arbitrary commands

2018-02-07 Thread Andreas Schwab
a output - really. I'm sure it seemed like a good idea at the time, > but I can see how it could have been used for evil. Do you also want to block "+++AT"? :-) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: git broken for AIX somewhere between 2.13.2 and 2.13.3

2018-07-29 Thread Andreas Schwab
e farm <http://gcc.gnu.org/wiki/CompileFarm> has a machine running AIX, and is free to use for anyone working on free software. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Git Bash Completion Not Working In Emacs

2018-04-16 Thread Andreas Schwab
ommand in Emacs. If you use M-x shell then Emacs handles special keys like TAB itself (and the started shell usually disables its own command line editing). If you use M-x term then Emacs emulates a terminal and lets the running process handle all special keys. Andreas. -- Andreas Schwab, sch...@lin

Re: man page for "git remote set-url" seems confusing/contradictory

2018-04-16 Thread Andreas Schwab
efer to the same > place". how can they be set differently yet still must refer to the > same place? They could be using different transport methods. For example, for fetching the unauthenticated git: method could be used, but for pushing an authenticated method like ssh: is usually n

.gitattributes lookup doesn't respect GIT_WORK_TREE

2018-04-15 Thread Andreas Schwab
store is a git repository. It sets up a diff attribute that decrypts the contents, but that works only if the command is issued while inside the repository. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now fo

Re: .gitattributes lookup doesn't respect GIT_WORK_TREE

2018-04-15 Thread Andreas Schwab
s to the top level of the working tree, git log/show don't appear to do that. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Any way to make git-log to enumerate commits?

2018-12-05 Thread Andreas Schwab
On Dez 05 2018, Elijah Newren wrote: > Or, just use name-rev so it works with non-linear histories too: > > git log | git name-rev --refs=$(git symbolic-ref HEAD) --stdin | less That wouldn't work for a detached HEAD, though, and you need to use --no-abbrev. Andreas. -- Andreas Sc

<    1   2   3