[PATCH v1 4/4] perf/run: add calls to get_var_from_env_or_config()

2017-07-13 Thread Christian Couder
These calls make it possible to have the make command or the make options in a config file, instead of in environment variables. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/perf/run b/t/perf/run

[PATCH v1 3/4] perf/run: add GIT_PERF_DIRS_OR_REVS

2017-07-13 Thread Christian Couder
ries whose Git versions should be tested. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/perf/run b/t/perf/run index 41580ac6df..ad442fe64a 100755 --- a/t/perf/run +++ b/t/perf/run

[PATCH v1 1/4] perf/run: add '--config' option to the 'run' script

2017-07-13 Thread Christian Couder
. This variable is not used yet. It will be used in a following commit. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index beb4acc0e4..1e7c2a59e4 100755 --- a/t/perf/run +

[PATCH v1 2/4] perf/run: add get_var_from_env_or_config()

2017-07-13 Thread Christian Couder
the default value. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/perf-lib.sh | 3 --- t/perf/run | 21 + 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index b50211b259..2f88fc12a9

[PATCH v1 0/4] Teach 'run' perf script to read config files

2017-07-13 Thread Christian Couder
. But this can be added later, and the current series can already be useful as is. Links ~ This patch series is also available here: https://github.com/chriscool/git/commits/perf-conf Christian Couder (4): perf/run: add '--config' option to the 'run' script perf/run: add get_var_from_e

Re: [PATCH v2 2/3] trailers: export action enums and corresponding lookup functions

2017-07-13 Thread Christian Couder
On Thu, Jul 13, 2017 at 12:21 AM, Paolo Bonzini wrote: > diff --git a/trailer.h b/trailer.h > index e90ba1270..f306bf059 100644 > --- a/trailer.h > +++ b/trailer.h > @@ -1,11 +1,33 @@ > #ifndef TRAILER_H > #define TRAILER_H > > +enum action_where { > + WHERE_END, > +

Re: [PATCH 0/3] interpret-trailers: add --where, --if-exists, --if-missing

2017-07-12 Thread Christian Couder
On Wed, Jul 12, 2017 at 3:46 PM, Paolo Bonzini wrote: > > These options are useful to experiment with "git interpret-trailers" > without having to tinker with .gitconfig. It can also be useful in the > oddball case where you want a different placement for the trailer. > > The

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-07-08 Thread Christian Couder
On Fri, Jul 7, 2017 at 8:35 PM, Junio C Hamano wrote: > Ben Peart writes: > >> On 6/14/2017 2:36 PM, Junio C Hamano wrote: >>> Ben Peart writes: >>> > Having said all that, I think you are using this ONLY on windows; > perhaps

Re: [RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-07-01 Thread Christian Couder
On Sat, Jul 1, 2017 at 10:33 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >>> I think it would be good to ensure the >>> interface is robust and performant enough to actually replace the current >>

Re: [RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-07-01 Thread Christian Couder
On Sat, Jul 1, 2017 at 9:41 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Fri, Jun 23, 2017 at 8:24 PM, Ben Peart <peart...@gmail.com> wrote: >> The fact that "git clone is taught a --initial-refspec" option" indicates >> th

Re: [RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-07-01 Thread Christian Couder
On Fri, Jun 23, 2017 at 8:24 PM, Ben Peart <peart...@gmail.com> wrote: > > > On 6/20/2017 3:54 AM, Christian Couder wrote: >> To be able to better handle some kind of objects, for example big >> blobs, it would be nice if Git could store its objects in other object >

Re: [PATCH v5 0/7] Fast git status via a file system watcher

2017-06-27 Thread Christian Couder
On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart wrote: > Changes from V4 include: ... I took a look at this patch series except the last patch ([PATCH v5 7/7] fsmonitor: add a performance test) as Junio reviewed it already, and had only a few comments on patches 3/7 and 4/7. I am

Re: [PATCH v5 4/7] fsmonitor: add test cases for fsmonitor extension

2017-06-27 Thread Christian Couder
On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart wrote: > +# fsmonitor works correctly with or without the untracked cache > +# but if it is available, we'll turn it on to ensure we test that > +# codepath as well. > + > +test_lazy_prereq UNTRACKED_CACHE ' > + { git

Re: [PATCH v5 3/7] fsmonitor: teach git to optionally utilize a file system monitor to speed up detecting new or changed files.

2017-06-27 Thread Christian Couder
On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart wrote: > +int read_fsmonitor_extension(struct index_state *istate, const void *data, > + unsigned long sz) > +{ > + const char *index = data; > + uint32_t hdr_version; > + uint32_t ewah_size; > + int

Re: [GSoC][PATCH 6/6 v2] submodule: port submodule subcommand 'deinit' from shell to C

2017-06-27 Thread Christian Couder
On Tue, Jun 27, 2017 at 1:11 AM, Prathamesh Chavan wrote: > +static void deinit_submodule(const struct cache_entry *list_item, > +void *cb_data) > +{ > + struct deinit_cb *info = cb_data; > + const struct submodule *sub; > + char

Re: [GSoC][PATCH 5/6 v2] submodule: port submodule subcommand sync from shell to C

2017-06-27 Thread Christian Couder
On Tue, Jun 27, 2017 at 1:11 AM, Prathamesh Chavan wrote: > +static char *get_up_path(const char *path) > +{ > + int i = count_slashes(path); > + int l = strlen(path); Nit: "l" is quite similar to "i" in many fonts, so maybe use "len" instead of "l", but see

Re: [GSoC][PATCH 2/6 v2] submodule: port subcommand foreach from shell to C

2017-06-27 Thread Christian Couder
On Tue, Jun 27, 2017 at 1:11 AM, Prathamesh Chavan wrote: > + > + if (!is_submodule_populated_gently(list_item->name, NULL)) > + goto cleanup; > + > + prepare_submodule_repo_env(_array); > + /* For the purpose of executing in the submodule, > +

Re: [PATCH v2 1/3] read-cache: use shared perms when writing shared index

2017-06-24 Thread Christian Couder
On Sat, Jun 24, 2017 at 12:02 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: >> Because of that, on repositories created with `git init --shared=all` >> and using the split index feature, one gets an er

Re: [PATCH v2 3/3] t1700: make sure split-index respects core.sharedrepository

2017-06-24 Thread Christian Couder
On Sat, Jun 24, 2017 at 12:20 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Add a few tests to check that both the split-index file and the >> shared-index file are created using the right permissions when &

[PATCH v3 2/3] t1301: move modebits() to test-lib-functions.sh

2017-06-24 Thread Christian Couder
As the modebits() function can be useful outside t1301, let's move it into test-lib-functions.sh, and while at it let's rename it test_modebits(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1301-shared-repo.sh | 18 +++--- t/test-lib-functions.sh | 5 ++

[PATCH v3 3/3] t1700: make sure split-index respects core.sharedrepository

2017-06-24 Thread Christian Couder
Add a few tests to check that both the split-index file and the shared-index file are created using the right permissions when core.sharedrepository is set. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 30 ++ 1 file c

[PATCH v3 1/3] read-cache: use shared perms when writing shared index

2017-06-24 Thread Christian Couder
/sharedindex.a52f910b489bc462f187ab572ba0086f7b5157de: index file open failed: Permission denied when another user performs any operation that reads the shared index. Call adjust_shared_perm() on the temporary file created by mks_tempfile() ourselves to adjust the permission bits. Signed-off-by: Christian Couder <chr

Crash in t3507-cherry-pick-conflict.sh with GIT_TEST_SPLIT_INDEX set

2017-06-24 Thread Christian Couder
Git from the master branch currently segfaults when running t3507-cherry-pick-conflict.sh with GIT_TEST_SPLIT_INDEX set: expecting success: pristine_detach initial && test_must_fail git cherry-pick -s picked-signed && git commit -a -s && test $(git show -s |grep -c

[PATCH v2 2/3] t1301: move modebits() to test-lib-functions.sh

2017-06-23 Thread Christian Couder
As the modebits() function can be useful outside t1301, let's move it into test-lib-functions.sh, and while at it let's rename it test_modebits(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1301-shared-repo.sh | 18 +++--- t/test-lib-functions.sh | 5 ++

[PATCH v2 3/3] t1700: make sure split-index respects core.sharedrepository

2017-06-23 Thread Christian Couder
Add a few tests to check that both the split-index file and the shared-index file are created using the right permissions when core.sharedrepository is set. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 17 + 1 file changed, 17 inse

[PATCH v2 1/3] read-cache: use shared perms when writing shared index

2017-06-23 Thread Christian Couder
it is passed. So let's just call adjust_shared_perm() by ourselves. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 8 1 file changed, 8 insertions(+) diff --git a/read-cache.c b/read-cache.c index bc156a133e..66f85f8d58 100644 --- a/read-cache.c +++ b/read-c

Re: [PATCH 1/3] read-cache: use shared perms when writing shared index

2017-06-23 Thread Christian Couder
On Thu, Jun 22, 2017 at 9:51 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: >> Let's fix that by using create_tempfile() instead of mks_tempfile() >> to create the shared index file. >> >> ...

Re: [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-23 Thread Christian Couder
On Fri, Jun 23, 2017 at 1:09 AM, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > > > On 22/06/17 20:52, Junio C Hamano wrote: >> Christian Couder <christian.cou...@gmail.com> writes: >> >>> As the movebits() function can be useful outside t1301, &g

Re: [PATCH 3/3] t1700: make sure split-index respects core.sharedrepository

2017-06-22 Thread Christian Couder
On Thu, Jun 22, 2017 at 10:25 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> We use "git config core.sharedrepository 0666" at the beginning of >> this test, so it will only apply to the shar

Re: [PATCH 3/3] t1700: make sure split-index respects core.sharedrepository

2017-06-22 Thread Christian Couder
On Thu, Jun 22, 2017 at 9:53 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Add a test to check that both the split-index file and the >> shared-index file are created using the right permissions >&g

[PATCH 3/3] t1700: make sure split-index respects core.sharedrepository

2017-06-22 Thread Christian Couder
Add a test to check that both the split-index file and the shared-index file are created using the right permissions when core.sharedrepository is set. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 12 1 file changed, 12 insertions(+)

[PATCH 1/3] read-cache: use shared perms when writing shared index

2017-06-22 Thread Christian Couder
/sharedindex.a52f910b489bc462f187ab572ba0086f7b5157de: index file open failed: Permission denied when another user performs any operation that reads the shared index. Let's fix that by using create_tempfile() instead of mks_tempfile() to create the shared index file. Signed-off-by: Christian Couder <chrisc...@tuxfamily.

[PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-22 Thread Christian Couder
As the movebits() function can be useful outside t1301, let's move it into test-lib-functions.sh, and while at it let's rename it test_movebits(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1301-shared-repo.sh | 18 +++--- t/test-lib-functions.sh | 5 ++

Re: [GSoC][PATCH 2/6] submodule--helper: introduce get_submodule_displaypath and for_each_submodule_list

2017-06-22 Thread Christian Couder
On Mon, Jun 19, 2017 at 11:50 PM, Prathamesh Chavan wrote: > +static char *get_submodule_displaypath(const char *path, const char *prefix) > +{ > + const char *super_prefix = get_super_prefix(); > + > + if (prefix && super_prefix) { > + BUG("cannot

Re: [GSoC][PATCH 5/6] submodule: port submodule subcommand sync from shell to C

2017-06-22 Thread Christian Couder
On Mon, Jun 19, 2017 at 11:50 PM, Prathamesh Chavan wrote: > +static char *get_up_path(const char *path) > +{ > + int i = count_slashes(path); > + struct strbuf sb = STRBUF_INIT; > + > + while (i--) > + strbuf_addstr(, "../"); > + > + /* >

Re: [RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-06-20 Thread Christian Couder
On Tue, Jun 20, 2017 at 9:54 AM, Christian Couder <christian.cou...@gmail.com> wrote: > > Future work > ~~~ > > First sorry about the state of this patch series, it is not as clean > as I would have liked, butI think it is interesting to get feedback > from the

[RFC/PATCH v4 04/49] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

2017-06-20 Thread Christian Couder
This will make it possible to reuse packet reading and writing functions in other test scripts. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 71 ++ 1 file changed, 71 insertions(+) create mode 10064

[RFC/PATCH v4 07/49] Git/Packet.pm: add packet_initialize()

2017-06-20 Thread Christian Couder
Add a function to initialize the communication. And use this function in 't/t0021/rot13-filter.pl'. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 13 + t/t0021/rot13-filter.pl | 8 +--- 2 files changed, 14 insertions(+), 7 del

[RFC/PATCH v4 08/49] Git/Packet: add capability functions

2017-06-20 Thread Christian Couder
Add functions to help read and write capabilities. Use these functions in 't/t0021/rot13-filter.pl'. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 33 + t/t0021/rot13-filter.pl | 9 ++--- 2 files chang

[RFC/PATCH v4 10/49] external odb foreach

2017-06-20 Thread Christian Couder
From: Jeff King --- external-odb.c | 14 ++ external-odb.h | 6 ++ odb-helper.c | 15 +++ odb-helper.h | 4 4 files changed, 39 insertions(+) diff --git a/external-odb.c b/external-odb.c index 1ccfa99a01..42978a3298 100644 ---

[RFC/PATCH v4 11/49] t0400: add 'put' command to odb-helper script

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh index fe85413725..6c6da5cf4f 100755 --- a/t/t0400-external-odb.sh +++ b/t

[RFC/PATCH v4 17/49] lib-httpd: pass config file to start_httpd()

2017-06-20 Thread Christian Couder
This makes it possible to start an apache web server with different config files. This will be used in a later patch to pass a config file that makes apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh | 6 -- 1 file chan

[RFC/PATCH v4 44/49] odb-helper: add have_object_process()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 103 --- 1 file changed, 91 insertions(+), 12 deletions(-) diff --git a/odb-helper.c b/odb-helper.c index 2e5d8af526..01cd6a713c 100644 --- a/odb-helper.c

[RFC/PATCH v4 23/49] t0420: add test with HTTP external odb

2017-06-20 Thread Christian Couder
This tests that an apache web server can be used as an external object database and store files in their native format instead of converting them to a Git object. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0420-transfer-http-e-odb.sh

[RFC/PATCH v4 36/49] odb-helper: add read_packetized_git_object_to_fd()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 84 +++- 1 file changed, 78 insertions(+), 6 deletions(-) diff --git a/odb-helper.c b/odb-helper.c index 0017faa36e..a27208463c 100644 --- a/odb-helper.c +++

[RFC/PATCH v4 21/49] odb-helper: add 'store_plain_objects' to 'struct odb_helper'

2017-06-20 Thread Christian Couder
() is renamed odb_helper_fetch_git_object() and a new odb_helper_fetch_plain_object() is introduce to deal with external objects that are not in Git format. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 2 + odb-helper.c

[RFC/PATCH v4 25/49] external-odb: add external_odb_fault_in_object()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 21 - external-odb.h | 1 + odb-helper.c | 7 +++ odb-helper.h | 1 + 4 files changed, 25 insertions(+), 5 deletions(-) diff --git a/external-odb.c b/external-odb.c index 0b6e

[RFC/PATCH v4 09/49] Add initial external odb support

2017-06-20 Thread Christian Couder
From: Jeff King <p...@peff.net> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Makefile| 2 + cache.h | 9 ++ external-odb.c | 115 +++ external-odb.h | 8 ++ odb-helper.c

[RFC/PATCH v4 22/49] pack-objects: don't pack objects in external odbs

2017-06-20 Thread Christian Couder
Objects managed by an external ODB should not be put into pack files. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/pack-objects.c | 4 1 file changed, 4 insertions(+) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index f672225def..e423f685ff

[RFC/PATCH v4 39/49] odb-helper: add write_object_process()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 76 +--- 1 file changed, 73 insertions(+), 3 deletions(-) diff --git a/odb-helper.c b/odb-helper.c index b2d86a7928..e21113c0b8 100644 --- a/odb-helper.c +++

[RFC/PATCH v4 28/49] contrib: add long-running-read-object/example.pl

2017-06-20 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- contrib/long-running-read-object/example.pl | 114 1 file changed, 114 insertions(+) create m

[RFC/PATCH v4 20/49] lib-httpd: add apache-e-odb.conf

2017-06-20 Thread Christian Couder
This is an apache config file to test external object databases. It uses the upload.sh and list.sh cgi that have been added previously to make apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd/apache-e-odb.conf

[RFC/PATCH v4 35/49] Add t0460 to test passing git objects

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0460-read-object-git.sh | 29 t/t0460/read-object-git| 67 ++ 2 files changed, 96 insertions(+) create mode 100755 t/t0460-read-object-git.sh create mode

[RFC/PATCH v4 24/49] odb-helper: start fault in implementation

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 24 ++-- odb-helper.c | 30 -- odb-helper.h | 8 +++- t/t0400-external-odb.sh| 2 ++ t/t0410-tran

[RFC/PATCH v4 45/49] clone: add initial param to write_remote_refs()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index 370a233d22..bd690576e6 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -572,7

[RFC/PATCH v4 46/49] clone: add --initial-refspec option

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index bd690576e6..dda0ad360b 100644 --- a/builtin/c

[RFC/PATCH v4 43/49] odb-helper: advertise 'put' capability

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/odb-helper.c b/odb-helper.c index 2cd1f25e83..2e5d8af526 100644 --- a/odb-helper.c +++ b/odb-helper.c @@ -67,7 +67,11 @@ stat

[RFC/PATCH v4 48/49] Add test for 'clone --initial-refspec'

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t5616-clone-initial-refspec.sh | 48 1 file changed, 48 insertions(+) create mode 100755 t/t5616-clone-initial-refspec.sh diff --git a/t/t5616-clone-initial-refspec.sh b/t/t5616

[RFC/PATCH v4 41/49] external-odb: add external_odb_do_fetch_object()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 52 ++-- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/external-odb.c b/external-odb.c index 8c2570b2e7..c39f207dd3 100644 --- a/external-odb.c

[RFC/PATCH v4 49/49] t: add t0430 to test cloning using bundles

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0430-clone-bundle-e-odb.sh | 91 +++ 1 file changed, 91 insertions(+) create mode 100755 t/t0430-clone-bundle-e-odb.sh diff --git a/t/t0430-clone-bundle-e-odb.sh b/t/t0430-clone-bu

[RFC/PATCH v4 42/49] odb-helper: advertise 'have' capability

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/odb-helper.c b/odb-helper.c index e21113c0b8..2cd1f25e83 100644 --- a/odb-helper.c +++ b/odb-helper.c @@ -67,7 +67,7 @@ static int start_read_obj

[RFC/PATCH v4 47/49] clone: disable external odb before initial clone

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/builtin/clone.c b/builtin/clone.c index dda0ad360b..a0d7b2bd2f 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -933,6 +933,7 @@ int cmd_clo

[RFC/PATCH v4 34/49] odb-helper: fix odb_helper_fetch_object() for read_object

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/odb-helper.c b/odb-helper.c index 910c87a482..0017faa36e 100644 --- a/odb-helper.c +++ b/odb-helper.c @@ -584,15 +584,19

[RFC/PATCH v4 31/49] external-odb: add external_odb_get_capabilities()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 ++- odb-helper.c | 23 +++ odb-helper.h | 1 + 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/external-odb.c b/external-odb.c index 2efa805d12..8c2570b2e7

[RFC/PATCH v4 30/49] odb-helper: add read_object_process()

2017-06-20 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 202 --- odb-helper.h | 5 ++ sha1_file.c | 33 +

[RFC/PATCH v4 19/49] lib-httpd: add list.sh

2017-06-20 Thread Christian Couder
This cgi script can list Git objects that have been uploaded as files to an apache web server. This script can also retrieve the content of each of these files. This will help make apache work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> ---

[RFC/PATCH v4 40/49] Add t0480 to test "have" capability and plain objects

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0480-read-object-have-http-e-odb.sh | 123 + t/t0480/read-object-plain-have | 116 +++ 2 files changed, 239 insertions(+) create mode 100755 t/t0480-read-

[RFC/PATCH v4 37/49] odb-helper: add read_packetized_plain_object_to_fd()

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 119 ++- 1 file changed, 118 insertions(+), 1 deletion(-) diff --git a/odb-helper.c b/odb-helper.c index a27208463c..b2d86a7928 100644 --- a/odb-helper.c +++

[RFC/PATCH v4 29/49] Add t0410 to test read object mechanism

2017-06-20 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0450-read-object.sh | 30 +++ t/t0450/read-object| 56 +++

[RFC/PATCH v4 38/49] Add t0470 to test passing plain objects

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0470-read-object-http-e-odb.sh | 123 ++ t/t0470/read-object-plain | 93 2 files changed, 216 insertions(+) create mode 100755 t/t0470-read-object-

[RFC/PATCH v4 27/49] Documentation: add read-object-protocol.txt

2017-06-20 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/technical/read-object-protocol.txt | 102 +++ 1 file changed, 102 insertions(+)

[RFC/PATCH v4 33/49] odb-helper: call odb_helper_lookup() with 'have' capability

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/odb-helper.c b/odb-helper.c index a6bf81af8d..910c87a482 100644 --- a/odb-helper.c +++ b/odb-helper.c @@ -142,19 +

[RFC/PATCH v4 26/49] odb-helper: add script_mode

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 4 odb-helper.h | 1 + t/t0400-external-odb.sh| 2 ++ t/t0410-transfer-e-odb.sh | 2 ++ t/t0420-transfer-http-e-odb.sh | 7 ++- 5 files changed, 15 inse

[RFC/PATCH v4 32/49] t04*: add 'get_cap' support to helpers

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh| 4 t/t0410-transfer-e-odb.sh | 8 t/t0420-transfer-http-e-odb.sh | 4 3 files changed, 16 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh

[RFC/PATCH v4 12/49] external odb: add write support

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 +++ external-odb.h | 2 ++ odb-helper.c | 41 + odb-helper.h | 3 +++ sha1_file.c| 2 ++ 5 files changed, 59 insertions(+), 4 deletions(-) diff

[RFC/PATCH v4 18/49] lib-httpd: add upload.sh

2017-06-20 Thread Christian Couder
This cgi will be used to upload objects to, or to delete objects from, an apache web server. This way the apache server can work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh| 1 + t/lib-httpd/upload.s

[RFC/PATCH v4 14/49] t0400: add test for external odb write support

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh index 6c6da5cf4f..3c868cad4c 100755 --- a/t/t0400-external-odb.sh +++ b/t/t0400-external-

[RFC/PATCH v4 16/49] Add t0410 to test external ODB transfer

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0410-transfer-e-odb.sh | 136 ++ 1 file changed, 136 insertions(+) create mode 100755 t/t0410-transfer-e-odb.sh diff --git a/t/t0410-transfer-e-odb.sh b/t/t0410-transfer-e-odb.

[RFC/PATCH v4 01/49] builtin/clone: get rid of 'value' strbuf

2017-06-20 Thread Christian Couder
This makes the code simpler by removing a few lines, and getting rid of one variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index a2ea

[RFC/PATCH v4 03/49] t0021/rot13-filter: improve 'if .. elsif .. else' style

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index d6411ca523..1fc581c814 100644 --- a/t/t0021

[RFC/PATCH v4 00/49] Add initial experimental external ODB support

2017-06-20 Thread Christian Couder
hub.com/chriscool/git/commits/external-odb Version 1, 2 and 3 are here: https://github.com/chriscool/git/commits/gl-external-odb12 https://github.com/chriscool/git/commits/gl-external-odb22 https://github.com/chriscool/git/commits/gl-external-odb61 Ben Peart (4): Documentation: add read-objec

[RFC/PATCH v4 02/49] t0021/rot13-filter: refactor packet reading functions

2017-06-20 Thread Christian Couder
To make it possible in a following commit to move packet reading and writing functions into a Packet.pm module, let's refactor these functions, so they don't handle printing debug output and exiting. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.p

[RFC/PATCH v4 06/49] Git/Packet.pm: improve error message

2017-06-20 Thread Christian Couder
Try to give a bit more information when we die() because there is no new line at the end of something we receive. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/perl/Git/Packet.pm b/pe

[RFC/PATCH v4 15/49] Add GIT_NO_EXTERNAL_ODB env variable

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h| 9 + environment.c | 4 external-odb.c | 6 ++ sha1_file.c| 3 +++ 4 files changed, 22 insertions(+) diff --git a/cache.h b/cache.h index 391a69e9c5..6047755629 100644 --- a/cache.h +++ b/c

[RFC/PATCH v4 13/49] external-odb: accept only blobs for now

2017-06-20 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 4 1 file changed, 4 insertions(+) diff --git a/external-odb.c b/external-odb.c index 893937a7d4..6d4fdd0bc1 100644 --- a/external-odb.c +++ b/external-odb.c @@ -133,6 +133,10 @@ int external_odb_write_

[RFC/PATCH v4 05/49] t0021/rot13-filter: use Git/Packet.pm

2017-06-20 Thread Christian Couder
After creating Git/Packet.pm from part of t0021/rot13-filter.pl, we can now simplify this script by using Git/Packet.pm. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 51 +++-- 1 file changed, 3 inse

[PATCH] sub-process: fix comment about api-sub-process.txt

2017-06-14 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- sub-process.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sub-process.h b/sub-process.h index 7d451e1cde..d9a45cd359 100644 --- a/sub-process.h +++ b/sub-process.h @@ -7,7 +7,7 @@ /* * G

[PATCH] builtin/clone: get rid of 'value' strbuf

2017-06-14 Thread Christian Couder
This makes the code simpler by removing a few lines, and getting rid of one variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/clone.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index a2ea

[ANNOUNCE] Git Rev News edition 28

2017-06-14 Thread Christian Couder
Hi everyone, The 28th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/06/14/edition-28/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Draft of Git Rev News edition 28

2017-06-12 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-28.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: 'pu' broken at t5304 tonight

2017-06-10 Thread Christian Couder
On Sat, Jun 10, 2017 at 9:05 PM, Kevin Daudt wrote: > On Sat, Jun 10, 2017 at 02:48:36PM +0200, Kevin Daudt wrote: >> For me, this bisects to the latest merge: >> >> 2047eebd3 (Merge branch 'bw/repo-object' into pu, 2017-06-10), but >> neither of the parent of the merge break

Re: [PATCH 1/2] git-compat-util: add a freez() wrapper around free(x); x = NULL

2017-06-09 Thread Christian Couder
On Fri, Jun 9, 2017 at 10:53 AM, Ævar Arnfjörð Bjarmason wrote: > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -787,6 +787,7 @@ extern char *xstrdup(const char *str); > extern void *xmalloc(size_t size); > extern void *xmallocz(size_t size); > extern void

Re: [GSoC][PATCH v2 2/2] submodule: port submodule subcommand status

2017-06-05 Thread Christian Couder
On Mon, Jun 5, 2017 at 10:25 PM, Prathamesh Chavan wrote: > --- > In this new version of patch, function print_status is introduced. > > The functions for_each_submodule_list and get_submodule_displaypath > are found to be the same as those in the ported submodule subcommand >

Re: [PATCH] perf: work around the tested repo having an index.lock

2017-06-05 Thread Christian Couder
On Mon, Jun 5, 2017 at 4:02 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> On Sun, Jun 4, 2017 at 2:00 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> Ævar Arnfjörð Bjarmason <ava...@gmail

Re: [PATCH] test-lib: add ability to cap the runtime of tests

2017-06-04 Thread Christian Couder
On Mon, Jun 5, 2017 at 3:55 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Realistically I'm going to submit this patch, I'm not going to take >> the much bigger project of refactoring the entire test suite so that >> no test runs under N

Re: Git Merge 2017 Videos

2017-06-04 Thread Christian Couder
On Sun, Jun 4, 2017 at 7:36 PM, Kevin Daudt wrote: > On Sun, Jun 04, 2017 at 11:24:17AM +0100, Philip Oakley wrote: >> While looking at the recent .gitignore issue (the need to use `**`) I came >> up against a comment in >>

Re: [PATCH] perf: work around the tested repo having an index.lock

2017-06-04 Thread Christian Couder
On Sun, Jun 4, 2017 at 2:00 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >>> My feeling exactly. Diagnosing and failing upfront saying "well you >>> made a copy but it is not suitable for testing" sounds more sensible >>> at lesat to me. >>

Re: [PATCH v3 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman

2017-05-31 Thread Christian Couder
On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: > templates/hooks--query-fsmonitor.sample | 37 > + > 1 file changed, 37 insertions(+) > create mode 100644 templates/hooks--query-fsmonitor.sample Please make this file executable like the

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-31 Thread Christian Couder
On Thu, May 25, 2017 at 3:55 PM, Ben Peart <peart...@gmail.com> wrote: > > On 5/24/2017 6:54 AM, Christian Couder wrote: >>> >>> A new git hook (query-fsmonitor) must exist and be enabled >>> (core.fsmonitor=true) that takes a time_t formatted as a str

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-31 Thread Christian Couder
Yeah, they could be encoded in the integration script, but it could be better if it was possible to just configure a generic command line. For example if the directory that should be watched for filesystem changes could be passed as well as the time since the last changes,

<    3   4   5   6   7   8   9   10   11   12   >