Formatting and patch naming fixes from Junio. No substantive changes.
David Turner (8):
index-helper: log warnings
unpack-trees: preserve index extensions
watchman: add a config option to enable the extension
index-helper: kill mode
index-helper: don't run if already running
From: Nguyễn Thái Ngọc Duy
Later, we will introduce git index-helper to share this memory with
other git processes.
We only unmap it when we discard the index (although the kernel may of
course choose to page it out).
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
n Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/technical/index-format.txt | 22 ++
cache.h | 4 ++
dir.h| 3 +
read-cache.c | 117 ++-
4 files changed,
From: Nguyễn Thái Ngọc Duy
The previous patch has the logic to clear bits in 'WAMA' bitmap. This
patch has logic to set bits as told by watchman. The missing bit,
_using_ these bits, are not here yet.
A lot of this code is written by David Turner originally, mostly from
[1]. I'
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
Documentation/git-update-index.txt | 6 ++
builtin/update-index.c | 16
3 files changed, 25 insertions(+)
diff --git a
For installations that have centrally-managed configuration, it's
easier to set a config once than to run update-index on every
repository.
Signed-off-by: David Turner
---
.gitignore| 1 +
Documentation/config.txt | 4
Makefile | 1 +
ting. That kind of list can be kept in index-helper.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 6 +
cache.h| 2 +
dir.c | 23 +++-
dir.h
Soon, we'll want to automatically start index-helper, so we need
a mode that silently exits if it can't start up (either because
it's not in a git dir, or because another one is already running).
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 4
ne.org/gmane.comp.version-control.git/247268/focus=248771
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
Signed-off-by: Ramsay Jones
---
.gitignore | 1 +
Documentation/git-index-helper.txt | 50 +++
Makefile | 5 +
cach
Instead of writing warnings to stderr, write them to a log. Later, we'll
probably be daemonized, so writing to stderr will be pointless.
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
index-helper.c | 32 --
Add a config option to populate the untracked cache.
For installations that have centrally-managed configuration, it's
easier to set a config once than to run update-index on every
repository.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
read-cache.c
Introduce a new config option, indexhelper.autorun, to automatically
run git index-helper before starting up a builtin git command. This
enables users to keep index-helper running without manual
intervention.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
read-cache.c
Signed-off-by: David Turner
---
index-helper.c | 7 +++
t/t7900-index-helper.sh | 9 +
2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index 4ed1610..b275f6e 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -458,6 +458,13 @@ int main(int
: 0.004052343 s: write index, changed mask
= 2
trace.c:420 performance: 0.048365509 s: git command: './git'
'status'
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
diff-lib.c | 4
dir.c| 2 ++
name-hash.c
t;) and before
verify_shm() detects an error.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 9 +++
cache.h| 1 +
index-helper.c | 48 +++
On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote:
> Hmmm, I seem to be getting
>
> $ cat t/trash*7900*/err
> fatal: Already running
>
> after running t7900 and it fails at #5, after applying
> "index-helper: optionally automatically run"
It still passes for me (with or without USE
On Mon, 2016-05-09 at 15:32 -0700, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > David Turner writes:
> >
> > > On Mon, 2016-05-09 at 14:40 -0700, Junio C Hamano wrote:
> > > > Hmmm, I seem to be getting
> > > >
> > > >
Will do, thanks.
On Tue, 2016-05-10 at 12:13 +0200, SZEDER Gábor wrote:
> This patch adds a new plumbing command, which then will show up in
> completion after 'git '. Could you please squash in this
> oneliner to exclude index-helper from porcelain commands in the
> completion script?
>
>
> --
From: Nguyễn Thái Ngọc Duy
Later, we will introduce git index-helper to share this memory with
other git processes.
We only unmap it when we discard the index (although the kernel may of
course choose to page it out).
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
ld be permitted to die without disrupting
clients.
Signed-off-by: David Turner
---
pkt-line.c | 18 ++
pkt-line.h | 2 ++
2 files changed, 20 insertions(+)
diff --git a/pkt-line.c b/pkt-line.c
index 62fdb37..f964446 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -91,6 +91,12 @@
Add a new command (and command-line arg) to allow index-helpers to
exit cleanly.
This is mainly useful for tests.
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
index-helper.c | 31 ++-
t/t7900-index-helper.sh
From: Nguyễn Thái Ngọc Duy
The previous patch has the logic to clear bits in 'WAMA' bitmap. This
patch has logic to set bits as told by watchman. The missing bit,
_using_ these bits, are not here yet.
A lot of this code is written by David Turner originally, mostly from
[1]. I'
t;) and before
verify_shm() detects an error.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 9 +++
cache.h| 1 +
index-helper.c | 48 +++
Introduce a new config option, indexhelper.autorun, to automatically
run git index-helper before starting up a builtin git command. This
enables users to keep index-helper running without manual
intervention.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
read-cache.c
From: Nguyễn Thái Ngọc Duy
We detach after creating and opening the socket, because otherwise
we might return control to the shell before index-helper is ready to
accept commands. This might lead to flaky tests.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
ting. That kind of list can be kept in index-helper.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 6 +
cache.h| 2 +
dir.c | 23 +++-
dir.h
packet_write was causing the sigpipes (by calling write_or_die, which
intentionally overrides the caller's preferences about signal handling).
This version fixes that. I didn't test on a virtual machine, but I did
test by adding a sleep().
David Turner (9):
pkt-line: add gentle
Soon, we'll want to automatically start index-helper, so we need
a mode that silently exits if it can't start up (either because
it's not in a git dir, or because another one is already running).
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 4
the untracked cache were entirely invalidated by such an
operation, the user has signaled their intention to have such a cache,
and we don't want to throw it away.
The same logic applies to the watchman state.
Signed-off-by: David Turner
---
cache.h | 1 +
read-ca
: 0.004052343 s: write index, changed mask
= 2
trace.c:420 performance: 0.048365509 s: git command: './git'
'status'
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
diff-lib.c | 4
dir.c| 2 ++
name-hash.c
Add a config option to populate the untracked cache.
For installations that have centrally-managed configuration, it's
easier to set a config once than to run update-index on every
repository.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
read-cache.c
n Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/technical/index-format.txt | 22 ++
cache.h | 4 ++
dir.h| 3 +
read-cache.c | 117 ++-
4 files changed,
For installations that have centrally-managed configuration, it's
easier to set a config once than to run update-index on every
repository.
Signed-off-by: David Turner
---
.gitignore| 1 +
Documentation/config.txt | 4
Makefile | 1 +
From: Nguyễn Thái Ngọc Duy
This allows signal handlers and atexit functions to realize this
situation and not clean up.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
builtin/gc.c | 2 +-
cache.h | 2 +-
daemon.c | 2 +-
setup.c | 4 +++-
4 files changed, 6
Instead of writing warnings to stderr, write them to a log. Later, we'll
probably be daemonized, so writing to stderr will be pointless.
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
index-helper.c | 12 +++-
2 files change
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
Documentation/git-update-index.txt | 6 ++
builtin/update-index.c | 16
3 files changed, 25 insertions(+)
diff --git a
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
read-cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/read-cache.c b/read-cache.c
index d9fb78b..16cc487 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1345,7 +1345,7
Signed-off-by: David Turner
---
index-helper.c | 7 +++
t/t7900-index-helper.sh | 9 +
2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index a1b33e4..7b893a0 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -435,6 +435,13 @@ int main(int
ne.org/gmane.comp.version-control.git/247268/focus=248771
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
Signed-off-by: Ramsay Jones
---
.gitignore | 1 +
Documentation/git-index-helper.txt | 50 ++
Makefile
On Fri, 2016-05-13 at 00:10 +0100, Ramsay Jones wrote:
>
> On 12/05/16 21:20, David Turner wrote:
> > From: Nguyễn Thái Ngọc Duy
> [snip]
>
> >
> > +/* in ms */
> > +#define WATCHMAN_TIMEOUT 1000
> > +
> > +static int poke_and_wait_fo
ting. That kind of list can be kept in index-helper.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Can we just replace this one patch?
Documentation/git-index-helper.txt | 6 +
cache.h| 2 +
dir.c | 23 +++-
dir.
listing. That kind of list can be kept in index-helper.
Helped-by: Ramsay Jones
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Right, let's try this one instead.
The actual segfault that Ramsay points out will not happen in ordinary
usage (since we control both client and
On Sun, 2016-05-15 at 16:43 +0700, Duy Nguyen wrote:
> On Fri, May 13, 2016 at 3:20 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > Add a config option to populate the untracked cache.
> >
> > For installations that have centrally-managed configuration, i
On Mon, 2016-05-16 at 20:22 -0700, Stefan Beller wrote:
> When using automated tools to find memory leaks, it is hard to
> distinguish
> between actual leaks and intentional non-cleanups at the end of the
> program,
> such that the actual leaks hide in the noise.
valgrind on git rev-parse HEAD sho
On Wed, 2016-05-04 at 13:13 -0700, Junio C Hamano wrote:
> Stefan Beller writes:
>
> > Later on when we introduce the version 2 transport protocol, the
> > capabilities will not be transported in one lone string but each
>
> s/lone/long/, I think.
>
> > capability will be carried in its own pkt
Do folks have any more comments on this version? Do I need to re-roll
to replace 11/20 as I proposed and drop 20/20?
Thanks.
On Thu, 2016-05-12 at 16:19 -0400, David Turner wrote:
> packet_write was causing the sigpipes (by calling write_or_die, which
> intentionally overrides the ca
On Thu, 2016-05-19 at 13:11 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > Do folks have any more comments on this version?
>
> Not from me at the moment.
>
> > Do I need to re-roll
> > to replace 11/20 as I proposed and drop 20/20?
>
>
automatically-run index-helpers, so I fixed that (with a new patch at
the end of the series).
Everything else is the same as the updated version of v11.
David Turner (9):
pkt-line: add gentle version of packet_write
index-helper: log warnings
unpack-trees: preserve index extensions
watchman
From: Nguyễn Thái Ngọc Duy
Later, we will introduce git index-helper to share this memory with
other git processes.
We only unmap it when we discard the index (although the kernel may of
course choose to page it out).
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
From: Nguyễn Thái Ngọc Duy
We detach after creating and opening the socket, because otherwise
we might return control to the shell before index-helper is ready to
accept commands. This might lead to flaky tests.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
read-cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/read-cache.c b/read-cache.c
index d9fb78b..16cc487 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1345,7 +1345,7
From: Nguyễn Thái Ngọc Duy
This allows signal handlers and atexit functions to realize this
situation and not clean up.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
builtin/gc.c | 2 +-
cache.h | 2 +-
daemon.c | 2 +-
setup.c | 4 +++-
4 files changed, 6
ld be permitted to die without disrupting
clients.
Signed-off-by: David Turner
---
pkt-line.c | 18 ++
pkt-line.h | 2 ++
2 files changed, 20 insertions(+)
diff --git a/pkt-line.c b/pkt-line.c
index 62fdb37..f964446 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -91,6 +91,12 @@
t;) and before
verify_shm() detects an error.
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 9 +++
cache.h| 1 +
index-helper.c | 48 +++
the untracked cache were entirely invalidated by such an
operation, the user has signaled their intention to have such a cache,
and we don't want to throw it away.
The same logic applies to the watchman state.
Signed-off-by: David Turner
---
cache.h | 1 +
read-ca
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
Documentation/git-update-index.txt | 6 ++
builtin/update-index.c | 16
3 files changed, 25 insertions(+)
diff --git a
listing. That kind of list can be kept in index-helper.
Helped-by: Ramsay Jones
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 6 +
cache.h| 2 +
dir.c | 23 +++-
dir.
Introduce a new config option, indexhelper.autorun, to automatically
run git index-helper before starting up a builtin git command. This
enables users to keep index-helper running without manual
intervention.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
read-cache.c
: 0.004052343 s: write index, changed mask
= 2
trace.c:420 performance: 0.048365509 s: git command: './git'
'status'
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
---
diff-lib.c | 4
dir.c| 2 ++
name-hash.c
For installations that have centrally-managed configuration, it's
easier to set a config once than to run update-index on every
repository.
Signed-off-by: David Turner
---
.gitignore| 1 +
Documentation/config.txt | 4
Makefile | 1 +
Instead of writing warnings to stderr, write them to a log. Later, we'll
probably be daemonized, so writing to stderr will be pointless.
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
index-helper.c | 12 +++-
2 files change
Signed-off-by: David Turner
---
index-helper.c | 7 +++
t/t7900-index-helper.sh | 9 +
2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index 4a171e6..ddc641a 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -438,6 +438,13 @@ int main(int
Add a new command (and command-line arg) to allow index-helpers to
exit cleanly.
This is mainly useful for tests.
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 3 +++
index-helper.c | 31 ++-
t/t7900-index-helper.sh
ne.org/gmane.comp.version-control.git/247268/focus=248771
Signed-off-by: Nguyễn Thái Ngọc Duy
Signed-off-by: David Turner
Signed-off-by: Ramsay Jones
---
.gitignore | 1 +
Documentation/git-index-helper.txt | 50 ++
Makefile
Soon, we'll want to automatically start index-helper, so we need
a mode that silently exits if it can't start up (either because
it's not in a git dir, or because another one is already running).
Signed-off-by: David Turner
---
Documentation/git-index-helper.txt | 4
From: Nguyễn Thái Ngọc Duy
The previous patch has the logic to clear bits in 'WAMA' bitmap. This
patch has logic to set bits as told by watchman. The missing bit,
_using_ these bits, are not here yet.
A lot of this code is written by David Turner originally, mostly from
[1]. I'
n Thái Ngọc Duy
Signed-off-by: David Turner
---
Documentation/technical/index-format.txt | 22 ++
cache.h | 4 ++
dir.h| 3 +
read-cache.c | 117 ++-
4 files changed,
high value.
Signed-off-by: David Turner
---
Documentation/config.txt | 4
index-helper.c | 2 ++
t/t7900-index-helper.sh | 8
3 files changed, 14 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 385ea66..336d5a2 100644
--- a
June 3rd will be my last day at Twitter. I hope that my new job
(starting in July after a month of vacation) will give me time to work
on Git, but I don't know exactly what parts I'll be working on, or on
what schedule.
As a result, some of my patchsets may get significantly less of my
attention.
I was looking at this again today, and noticed that it doesn't really
address the HTTP case.
The central problem is that protocol v2 goes like this:
server: I have capabilities w,x,y, and z
client: I want capabilities x and z.
But HTTP goes like this:
client: [request]
server: [response]
I tried
On Wed, 2016-05-25 at 06:03 +0700, Duy Nguyen wrote:
> On Wed, May 25, 2016 at 5:46 AM, David Turner <
> dtur...@twopensource.com> wrote:
> > I was looking at this again today, and noticed that it doesn't
> > really
> > address the HTTP case.
> >
> &g
On Wed, 2016-05-25 at 09:23 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > I was looking at this again today, and noticed that it doesn't
> > really
> > address the HTTP case.
> >
> > The central problem is that protocol v2 goes like this:
>
On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
> +struct dir_iterator_level {
> + int initialized;
> +
> + DIR *dir;
> +
> + /*
> + * The length of the directory part of refname at this level
"refname"? Isn't this was for directories?
> + if (lsta
On Wed, 2016-06-01 at 17:45 +0700, Nguyễn Thái Ngọc Duy wrote:
> Current mark_reachable_objects() only marks objects from index from
> _current_ worktree as reachable instead of all worktrees. Because
> this
> function is used for pruning, there is a chance that objects
> referenced
> by other work
On Wed, 2016-06-01 at 03:42 -0400, Jeff King wrote:
> 2. Do caching tricks for strbufs used in tight loops. For example,
> have strbuf_release() throw its buffer into a last-used cache,
> and
> let the next strbuf_grow() use that cache entry. This cuts
> malloc()
> out of the loop.
On Wed, 2016-06-01 at 16:09 -0400, Jeff King wrote:
> On Wed, Jun 01, 2016 at 03:50:29PM -0400, David Turner wrote:
>
> > On Wed, 2016-06-01 at 03:42 -0400, Jeff King wrote:
> > > 2. Do caching tricks for strbufs used in tight loops. For
> > > example,
> > &g
On Fri, 2016-06-03 at 14:33 +0200, Michael Haggerty wrote:
> This is v2 of a patch series to implement iteration over references
> via iterators. Thanks to Ramsay, Eric, Junio, and David for their
> feedback about v1 [1]. I think I have addressed all of the points
> that
> were raised.
In case I d
On Tue, 2016-05-24 at 15:22 -0400, David Turner wrote:
> - Protocol v2: I would like to get a new draft of Stefan's series out
> before I leave, but no promises. It's turned out to be a bit more
> complicated than I expected to support HTTP. At worst, I'll toss my
> WI
On Fri, 2016-06-10 at 10:14 +0200, Michael Haggerty wrote:
> /*
> + * Check whether the REF_HAVE_OLD and old_oid values stored in update
> + * are consistent with the result read for the reference. error is
> + * true iff there was an error reading the reference; otherwise, oid
"error" is not a
> > - if (really && cache_errno == EINVAL) {
> > + if (really || cache_errno == EINVAL) {
> > /* If we are doing --really-refresh that
> > * means the index is not valid anymore.
> >
On Wed, 2016-08-17 at 17:49 +0700, Duy Nguyen wrote:
> On Mon, Aug 15, 2016 at 5:46 AM, Junio C Hamano wrote:
> > * dt/index-helper (2016-07-06) 21 commits
> >
> > A new "index-helper" daemon has been introduced to give newly
> > spawned Git process a quicker access to the data in the index, and
ances) and will
> also serve as the vtable for ref_store instances of that type.
>
> As yet, the backends cannot do anything.
>
> Signed-off-by: Ronnie Sahlberg
> Signed-off-by: David Turner
> Signed-off-by: Junio C Hamano
> Signed-off-by: Jeff King
> Signed-off-by:
On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote:
> +/* A linked list of ref_stores for submodules: */
> +static struct ref_store *submodule_ref_stores;
I don't like the per-submodule stores being in a linked list, which
requires a linear search. Stefan has, I think, been doing a bunch
On Mon, 2016-09-05 at 05:53 +0200, Michael Haggerty wrote:
> On 09/04/2016 10:40 PM, David Turner wrote:
> > On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote:
> >
> >> +/* A linked list of ref_stores for submodules: */
> >> +static struct ref_store *submo
Other than the duplicated sign-offs, this series looks good to me
("Don't act surprised, you guys, cuz I wrote 'em").
Kind of a funny place to cut it off, but I guess it makes sense.
On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote:
> From: David Turner
>
From: David Turner
Instead of dying when fsck hits a malformed tree object, log the error
like any other and continue. Now fsck can tell the user which tree is
bad, too.
Signed-off-by: David Turner
---
fsck.c | 18 +++--
t/t1450-fsck.sh
uot;, which makes it
seem like the data bit-rotted on disk. Our sha1 check would
already have found that. These errors are ones of data that
is malformed in the first place.
Signed-off-by: David Turner
Signed-off-by: Jeff King
---
t/t1007-hash-object.sh | 15 +--
t/t1007/tr
means that I'm going to continue corresponding from
nova...@novalis.org, but will send patches with the @twosigma.com
address in the author line.
Email address note 2: I'm not subscribed to the mailing list these
days, so please CC me (at nova...@novalis.org) on replies.
David Turner (1):
On Mon, 2016-09-26 at 12:43 -0700, Junio C Hamano wrote:
> David Turner writes:
>
> > The first patch is a re-roll of Peff's patch from 2014 -- here's
> > the archive message:
> >
> > http://git.661346.n2.nabble.com/PATCH-tree-walk-be-more-specific-
uot;, which makes it
seem like the data bit-rotted on disk. Our sha1 check would
already have found that. These errors are ones of data that
is malformed in the first place.
Signed-off-by: David Turner
Signed-off-by: Jeff King
---
t/t1007-hash-object.sh | 15 +--
t/t1007/
Instead of dying when fsck hits a malformed tree object, log the error
like any other and continue. Now fsck can tell the user which tree is
bad, too.
Signed-off-by: David Turner
---
fsck.c | 18 +++--
t/t1450-fsck.sh
From: David Turner
Signed-off-by: David Turner
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 9441a54..9cc33e9 100644
--- a/.mailmap
+++ b/.mailmap
@@ -48,6 +48,7 @@ David KÃ¥gedal
David Reiss
David S. Miller
David Turner
+David Turner
Sorry for the bad subject line, this is of course v2 of the series.
On Mon, 2016-09-26 at 20:11 -0400, David Turner wrote:
> From: David Turner
>
> Signed-off-by: David Turner
> ---
> .mailmap | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.mailmap b/
On Tue, 2016-09-27 at 01:14 -0400, Jeff King wrote:
> I also wonder if $bin_sha1 should actually be more like:
>
> hex_sha1=$(echo foo | git hash-object --stdin -w)
> bin_sha1=$(echo $hex_sha1 | perl -ne 'printf "\\%3o", ord for /./g')
>
> so that it's a real sha1 (or maybe it is in your orig
uot;, which makes it
seem like the data bit-rotted on disk. Our sha1 check would
already have found that. These errors are ones of data that
is malformed in the first place.
Signed-off-by: David Turner
Signed-off-by: Jeff King
---
t/t1007-hash-object.sh | 21 +++--
tree-walk.c
From: David Turner
Signed-off-by: David Turner
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 9441a54..9cc33e9 100644
--- a/.mailmap
+++ b/.mailmap
@@ -48,6 +48,7 @@ David Kågedal
David Reiss
David S. Miller
David Turner
+David Turner
Instead of dying when fsck hits a malformed tree object, log the error
like any other and continue. Now fsck can tell the user which tree is
bad, too.
Signed-off-by: David Turner
---
fsck.c | 18 -
t/t1450-fsck.sh | 16 +--
tree-walk.c | 83
On Tue, 2016-09-27 at 01:27 -0400, Jeff King wrote:
> > -static void decode_tree_entry(struct tree_desc *desc, const char *buf,
> > unsigned long size)
> > +static int decode_tree_entry(struct tree_desc *desc, const char *buf,
> > unsigned long size, struct strbuf *err)
> > {
>
> I know we used
Instead of dying when fsck hits a malformed tree object, log the error
like any other and continue. Now fsck can tell the user which tree is
bad, too.
Signed-off-by: David Turner
---
fsck.c | 18 -
t/t1450-fsck.sh | 16 +--
tree-walk.c | 83
uot;, which makes it
seem like the data bit-rotted on disk. Our sha1 check would
already have found that. These errors are ones of data that
is malformed in the first place.
Signed-off-by: David Turner
Signed-off-by: Jeff King
---
t/t1007-hash-object.sh | 25 +++-
501 - 600 of 1518 matches
Mail list logo
