On Mon, Nov 16, 2015 at 6:50 PM, Eric Sunshine wrote:
> Also, shouldn't --list-aliases (or --dump-aliases) be mutually
> exclusive with many of the other options? New tests would check such
> exclusivity as well.
In fact, while I agree with Szeder that it makes sense to re-us
On Mon, Nov 16, 2015 at 8:29 PM, Edmundo Carmona Antoranz
wrote:
> blame: avoid checking if a file exists on the working tree
> if a revision is provided
This subject is a bit long; try to keep it to about 72 characters or less.
More importantly, though, it doesn't give us a high level overview
On Tue, Nov 17, 2015 at 12:10:35AM +, Keller, Jacob E wrote:
> On Mon, 2015-11-16 at 18:50 -0500, Eric Sunshine wrote:
> > It should be possible to extract the alias within the shell itself
> > without a separate process. For instance:
> >
> > read alias rest
&g
On Mon, Nov 16, 2015 at 7:29 PM, Jacob Keller wrote:
> Add an option "dump-aliases" which changes the default behavior of
It would be easier to understand that this is a new command-line
option (as opposed to a configuration or other option) if you spelled
it --dump-aliases (with the leading dash
On Mon, Nov 16, 2015 at 7:29 PM, Jacob Keller wrote:
> Using the new --dump-alias-names option from git-send-email, add completion
s/dump-alias-names/dump-aliases/
> for --to, --cc, and --bcc with the available configured aliases.
"--from" is missing from this list.
> Signed-off-by: Jacob Kell
On Tue, Nov 17, 2015 at 3:28 AM, Lars Schneider
wrote:
> On 16 Nov 2015, at 22:14, Eric Sunshine wrote:
>> On Sun, Nov 15, 2015 at 8:08 AM, wrote:
>>> From: Lars Schneider
>>>
>>> In rare cases kill/cleanup operations in tests fail. Retry these
>>&g
On Tue, Nov 17, 2015 at 4:34 AM, Luke Diamand wrote:
>>> While implementing it I thought more about it. P4D is only
>>> supported on platforms that support the date function. That means
>>> these tests will only run on platforms that support the date
>>> function. Consequently I wondered if this w
On Tue, Nov 17, 2015 at 5:48 PM, Jeff King wrote:
> On Tue, Nov 17, 2015 at 12:11:25AM -0500, Eric Sunshine wrote:
>> > blame content even if the path provided does match an existing
>> > blob on said revision.
>>
>> git-blame documentation does not advertise &
On Thu, Nov 19, 2015 at 11:20 AM, René Scharfe wrote:
> Signed-off-by: Rene Scharfe
> ---
> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
> @@ -176,6 +176,18 @@ test_expect_success 'integer overflow in timestamps is
> reported' '
> +test_expect_success 'commit with NUL in header' '
> + gi
On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt wrote:
> Some time ago, I had to dig into t9300-fast-import and found it quite
> unhelpful that it does not follow our modern best-practices. This series
> brings it up-to-date. I thought I submit it now while it is quiet in
> the area.
>
> The larger
On Tue, Nov 17, 2015 at 6:22 PM, Jeff King wrote:
> On Tue, Nov 17, 2015 at 06:01:25PM -0500, Eric Sunshine wrote:
>> On Tue, Nov 17, 2015 at 5:48 PM, Jeff King wrote:
>> > Hmm. Out of curiosity I tried:
>> >
>> > git blame v2.4.0 -- t/t6031-merge-recursive
On Sat, Nov 21, 2015 at 2:36 AM, Torsten Bögershausen wrote:
> When working in a cross-platform environment, a user wants to
> check if text files are stored normalized in the repository and if
> .gitattributes are set appropriately.
>
> Make it possible to let Git show the line endings in the ind
On Mon, Nov 23, 2015 at 2:45 PM, Sebastian Schuberth
wrote:
> On Mon, Nov 23, 2015 at 6:05 PM, Torsten Bögershausen wrote:
>> git ls-files -o --eol
>> i/ w/binaryattr/ zlib.o
>
> I see, somewhat convincing I have to agree.
>
> On another note, how about making the pr
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Introduce a parsing function for each atom in valid_atom. Using this
> we can define special parsing functions for each of the atoms. Since
> we have a third field in valid_atom structure, we now fill out missing
> cmp_type values.
I don't g
On Tue, Nov 17, 2015 at 5:01 PM, John Keeping wrote:
> These configuration variables specify the paths to commands so we should
> support tilde-expansion for files inside a user's home directory.
Hmm, I don't see anything in the documentation which says that these
are paths to commands, and the c
On Wed, Nov 18, 2015 at 10:06 AM, Hans Ginzel wrote:
> I have added the --recursive alias for the -r option to the rm command.
When sending a patch, separate the patch itself from the above
commentary with a scissor line (--- 8< ---) so that git-am can extract
the patch automatically. Alternately
On Wed, Nov 25, 2015 at 1:53 AM, Christian Couder
wrote:
> Documentation/git-update-index: add missing opts to synopsys
s/synopsys/synopsis/
> Untracked cache and split index related options should appear
> in the 'SYNOPSIS' section.
>
> These options are already documented in the 'OPTIONS' sect
On Wed, Nov 25, 2015 at 7:10 AM, Karthik Nayak wrote:
> On Tue, Nov 24, 2015 at 5:14 AM, Eric Sunshine
> wrote:
>> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
>>> Introduce a parsing function for each atom in valid_atom. Using this
>>> we can define spec
On Sat, Nov 28, 2015 at 10:07 AM, Torsten Bögershausen wrote:
> diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> @@ -213,7 +238,20 @@ checkout_files () {
> git -c core.eol=$eol checkout $src$f.txt
> fi
> done
> -
> + test_expect_succe
On Thu, Nov 26, 2015 at 9:44 AM, James wrote:
> From: James Rouzier
>
> Specify a file to read for exclude patterns.
> ---
> diff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt
> @@ -8,7 +8,7 @@ git-clean - Remove untracked files from the working tree
> SYNOPSIS
>
>
On Fri, Nov 27, 2015 at 9:08 AM, Daniele Varrazzo
wrote:
> I was trying to rewrite history in a small repos and replace
> indentation tabs with spaces. Steps to reproduce:
>
> git clone https://github.com/dvarrazzo/suponoff.git
> git checkout -b gitbug
> git config core.whitespace
> trailing-space
On Mon, Nov 16, 2015 at 8:11 AM, Victor Leschuk
wrote:
> "git grep" can now be configured (or told from the command line)
> how many threads to use when searching in the working tree files.
>
> Changes to default behavior: number of threads now doesn't depend
> on online_cpus(), e.g. if specifi
On Tue, Dec 1, 2015 at 4:36 PM, James Rouzier wrote:
> Eric thank you for the feedback.
[re-adding git@vger.kernel.org to recipient list since this response
was likely intended to be public]
> On Sun, Nov 29, 2015 at 9:24 PM, Eric Sunshine
> wrote:
>> On Thu, Nov 26, 2015 at
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Introduce the 'used_array' structure which would replace the existing
I guess you meant s/used_array/used_atom/ or something?
Also, s/which would/to/
> implementation of 'used_array' (which a list of atoms). This helps us
s/which a/which
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Signed-off-by: Karthik Nayak
A bit of explanation about why this change is desirable would be
welcome. I'm guessing it's because a future patch is going to make
calls to match_atom_name() with the '*' deref indicator still attached
to the n
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Introduce color_atom_parser() which will parse a "color" atom and
> store its color in the "use_atom" structure for further usage in
s/use_atom/used_atom/
> 'populate_value()'.
>
> Signed-off-by: Karthik Nayak
> ---
> diff --git a/ref-filt
On Mon, Nov 30, 2015 at 6:40 AM, SZEDER Gábor wrote:
> The error message after a failing commit_lock_file() call sometimes
> looks like this, causing confusion:
>
> $ git remote add remote g...@server.com/repo.git
> error: could not commit config file .git/config
> # Huh?!
> # I didn't wan
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> The current implementation of 'strbuf_split_buf()' includes the
> terminator at the end of each strbuf post splitting. Include an option
s/Include an/Add an/
> wherein we can drop the terminator if required. In this context
s/required/desi
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Introduce align_atom_parser() which will parse 'align' atoms and store
> the required width and position into the 'used_atom' structure. While
> we're here, add support for the usage of 'width=' and 'position=' when
> using the 'align' atom (
On Wed, Dec 2, 2015 at 2:13 PM, Nguyễn Thái Ngọc Duy wrote:
> .git/info/config.worktree is a pattern list that splits .git/config in
> to sets: the worktree set matches the patterns, the commmon set does
> not.
>
> In normal worktrees, both sets are stored in .git/config. The
> config.worktree has
On Wed, Dec 2, 2015 at 2:13 PM, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt
> @@ -147,6 +147,19 @@ to `/path/main/.git/worktrees/test-next` then a file
> named
> `test-next` entry from bei
On Sun, Dec 6, 2015 at 11:12 AM, Edmundo Carmona Antoranz
wrote:
> And, another thing, I had sent the fifth version of my patch about
> progress for blame where I took care of all the comments hat Junio
> stated before and I got no comments since. I hoped that patch would be
> listed sometime but
On Sun, Dec 6, 2015 at 7:25 AM, Giuseppe Bilotta
wrote:
> On my HiDPI monitor, most elements in gitk are correctly rendered, with two
> exceptions:
>
> * when using ttk, some elements do not use the same fonts as gitk would use
> without, and since ttk picks _unscaled_ sizes this is very noticea
On Mon, Dec 07, 2015 at 11:09:48AM +1300, David Ware wrote:
> My group has run into a bug with "git-subtree split". Under some
> circumstances a split created from a descendant of another earlier
> split is not a descendant of that earlier split (thus blocking
> pushes). [...]
I'm not a git-subtre
On Sun, Dec 6, 2015 at 3:38 PM, Torsten Bögershausen wrote:
> When working in a cross-platform environment, a user wants to
> check if text files are stored normalized in the repository and if
> .gitattributes are set appropriately.
> [...]
> Signed-off-by: Torsten Bögershausen
> ---
> diff --git
On Monday, December 7, 2015, Torsten Bögershausen wrote:
> When working in a cross-platform environment, a user wants to
> check if text files are stored normalized in the repository and if
> .gitattributes are set appropriately.[...]
A few style comments this time around...
> Hel
On Sun, Dec 6, 2015 at 9:58 AM, James wrote:
> From: James Rouzier
This would be a good place to explain how you are modernizing the test
script. Right now, you're just updating to take advantage of
test_path_is_foo(), but some other modernizations you could do
include:
* using '>' rather than
On Mon, Dec 7, 2015 at 4:40 PM, Junio C Hamano wrote:
> James writes:
>> @@ -46,15 +46,15 @@ test_expect_success 'git clean' '
>> mkdir -p build docs &&
>> touch a.out src/part3.c docs/manual.txt obj.o build/lib.so &&
>> git clean &&
>> - test -f Makefile &&
>> - test -f
In addition to Peff's and Junio's review comments...
On Sun, Dec 6, 2015 at 9:58 AM, James wrote:
> From: James Rouzier
>
> Specify a file to read for exclude patterns.
Missing Signed-off-by:.
> ---
> diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
> @@ -628,6 +628,66 @@ test_expect_success '
On Mon, Dec 7, 2015 at 3:50 PM, Dave Ware wrote:
> [PATCH] contrib/subtree: fix "subtree split" skipped-merge bug.
As an aid for reviewers, please indicate the version of this patch
submission. For instance, this is the second attempt, so the subject
would be decorated as [PATCH v2], and the next
On Tue, Nov 24, 2015 at 11:36 PM, Edmundo Carmona Antoranz
wrote:
> * created struct progress_info in builtin/blame.c
> this struct holds the information used to display progress so
> that only one additional parameter is passed to
> found_guilty_entry().
Commit messages typically are compo
On Tue, Dec 8, 2015 at 7:19 PM, Dave Ware wrote:
> 'git subtree split' can incorrectly skip a merge even when both parents
> act on the subtree, provided the merge results in a tree identical to
> one of the parents. Fix by copying the merge if at least one parent is
> non-identical, and the non-i
On Wed, Dec 9, 2015 at 11:20 PM, Edmundo Carmona Antoranz
wrote:
> On Tue, Dec 8, 2015 at 2:22 AM, Eric Sunshine wrote:
>> On Tue, Nov 24, 2015 at 11:36 PM, Edmundo Carmona Antoranz
>> wrote:
>>> +--[no-]progress::
>>> + Progress status is repo
On Sat, Dec 12, 2015 at 6:57 PM, Edmundo Carmona Antoranz
wrote:
> --progress can't be used with --incremental or
> porcelain formats.
>
> git-annotate inherits the option as well
>
> Helped-by: Eric Sunshine
> Signed-off-by: Edmundo Carmona Antoranz
> ---
Ri
On Sat, Dec 12, 2015 at 7:30 PM, Edmundo Carmona Antoranz
wrote:
> On Sat, Dec 12, 2015 at 6:17 PM, Eric Sunshine
> wrote:
>> The 'show_progress = 0' seems unnecessary. What if you did something
>> like this instead?
>>
>>
On Sat, Dec 12, 2015 at 7:36 PM, Edmundo Carmona Antoranz
wrote:
> On Sat, Dec 12, 2015 at 6:30 PM, Edmundo Carmona Antoranz
> wrote:
> H if the code in assign_blame changed to this, it would be
> possible to allow the -1 to go through:
>
> if (show_progress > 0)
> pi.progress = start
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
> and '%(push)' atoms and store information into the 'used_atom'
> structure based on the modifiers used along with the corresponding
> atom.
>
> Signed-off-by: Karthik Nay
On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
> Introduce contents_atom_parser() which will parse the '%(contents)'
> atom and store information into the 'used_atom' structure based on the
> modifiers used along with the atom.
>
> Signed-off-by: Karthik Nayak
> ---
> diff --git a/ref-filt
On Sat, Dec 12, 2015 at 10:10 PM, Eric Sunshine wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
>> +void contents_atom_parser(struct used_atom *atom)
>> +{
>> + const char * buf;
>> +
>> + if (match_atom_name(atom->str, "
On Wed, Nov 25, 2015 at 8:44 AM, Karthik Nayak wrote:
> Introduce objectname_atom_parser() which will parse the
> '%(objectname)' atom and store information into the 'used_atom'
> structure based on the modifiers used along with the atom.
>
> Signed-off-by: Karthik Nayak
> ---
> diff --git a/ref-
On Fri, Dec 11, 2015 at 5:49 PM, Junio C Hamano wrote:
> Karthik Nayak writes:
>> ref-filter: introduce a parsing function for each atom in valid_atom
>> ref-filter: introduce struct used_atom
>> ref-fitler: bump match_atom() name to the top
>> ref-filter: skip deref specifier in match_at
On Thu, Dec 3, 2015 at 8:35 AM, Karthik Nayak wrote:
> On Wed, Dec 2, 2015 at 4:57 AM, Eric Sunshine wrote:
>> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
>>> @@ -833,11 +846,10 @@ static void populate_value(struct ref_array_item *ref)
>>>
On Sun, Dec 13, 2015 at 1:02 AM, Karthik Nayak wrote:
> On Sun, Dec 13, 2015 at 6:23 AM, Eric Sunshine
> wrote:
>> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak wrote:
>>> + if (!num_ours && !num_theirs)
>>> + *s = &quo
On Sun, Dec 13, 2015 at 3:32 AM, Karthik Nayak wrote:
>> On Sun, Dec 13, 2015 at 6:23 AM, Eric Sunshine
>> wrote:
>>> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak
>>> wrote:
>>>> Introduce remote_ref_atom_parser() which will parse the '
On Sun, Dec 13, 2015 at 10:17 AM, Victor Leschuk wrote:
> "git grep" can now be configured (or told from the command line)
> how many threads to use when searching in the working tree files.
>
> Changes to default behavior: number of threads now doesn't depend
> on online_cpus(), e.g. if speci
On Sun, Dec 13, 2015 at 4:31 AM, Karthik Nayak wrote:
> On Sun, Dec 13, 2015 at 11:10 AM, Eric Sunshine
> wrote:
>> If the intention is to rid that inner loop of much of the expensive
>> processing, then wouldn't we want to introduce an enum of valid atoms
>> which
On Monday, December 14, 2015, Philip Oakley wrote:
> The git gui's recent repo list may become contaminated with duplicate
> entries. The git gui would barf when attempting to remove one entry.
> Remove them all - there is no option within 'git config' to selectively
> remove one of the entries.
>
On Mon, Dec 14, 2015 at 10:09 AM, Philip Oakley wrote:
> The gui.recentrepo list may be longer than the maxrecent setting.
> Allow extra space to show any extra entries.
>
> In an ideal world, the git gui would limit the number of entries
> to the maxrecent setting, however the recentrepo config l
On Mon, Dec 14, 2015 at 2:37 PM, Stefan Beller wrote:
> From the man page:
> EAGAIN The file descriptor fd refers to a file other than a socket
>and has been marked nonblocking (O_NONBLOCK), and the read
>would block.
>
> EAGAIN or EWOULDBLOCK
>The file descriptor fd refers
On Mon, Dec 14, 2015 at 2:37 PM, Stefan Beller wrote:
> Provide a wrapper to read(), similar to xread(), that restarts on
> EINTR but not EAGAIN (or EWOULDBLOCK). This enables the caller to
> handle polling itself, possibly polling multiple sockets or performing
> some other action.
>
> Signed-off
On Mon, Dec 14, 2015 at 6:03 PM, Eric Sunshine wrote:
> On Mon, Dec 14, 2015 at 2:37 PM, Stefan Beller wrote:
>> Provide a wrapper to read(), similar to xread(), that restarts on
>> EINTR but not EAGAIN (or EWOULDBLOCK). This enables the caller to
>> handle polling its
On Mon, Dec 14, 2015 at 2:37 PM, Stefan Beller wrote:
> The new call will read from a file descriptor into a strbuf once. The
> underlying call xread_nonblock is meant to execute without blocking if
> the file descriptor is set to O_NONBLOCK. It is a bug to call
> strbuf_read_once on a file descri
On Tue, Dec 15, 2015 at 3:06 PM, Junio C Hamano wrote:
> Victor Leschuk writes:
>> Subject: Re: [PATCH 1/2] Introduce grep threads param
>
> I'll retitle this to something like
>
> grep: add --threads= option and grep.threads configuration
>
> while queuing (which I did for v7 earlier).
>
> I
On Sat, Dec 12, 2015 at 7:51 PM, Edmundo Carmona Antoranz
wrote:
> --progress can't be used with --incremental or
> porcelain formats.
>
> git-annotate inherits the option as well
>
> Helped-by: Eric Sunshine
> Signed-off-by: Edmundo Carmona Antoranz
> ---
This
On Wednesday, December 16, 2015, Johannes Schindelin
wrote:
> On Windows, when writing to a pipe fails, errno is always
> EINVAL. However, Git expects it to be EPIPE.
>
> According to the documentation, there are two cases in which write()
> triggers EINVAL: the buffer is NULL, or the length is od
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> strbuf: introduce strbuf_split_str_without_term()
s/without/omit/
> The current implementation of 'strbuf_split_buf()' includes the
> terminator at the end of each strbuf post splitting. Add an option
> wherein we can drop the terminator i
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> Introduce the 'used_array' structure which would replace the existing
> implementation of 'used_array' (which a list of atoms). This helps us
> parse atom's before hand and store required details into the
> 'used_array' for future usage.
Al
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> In upcoming patches we make calls to match_atom_name() with the '*'
> deref specifier still attached to the atom name. This causes
> undesirable errors, hence, if present skip over the '*' deref
> specifier in the atom name.
I'd drop the se
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> Introduce color_atom_parser() which will parse a "color" atom and
> store its color in the "use_atom" structure for further usage in
Same comment as last time: s/use_atom/used_atom/
> 'populate_value()'.
s/'//g
More below...
> Helped-by
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> Introduce align_atom_parser() which will parse an "align" atom and
> store the required alignment position and width in the "use_atom"
> structure for further usage in 'populate_value()'.
>
> Helped-by: Ramsay Jones
> Signed-off-by: Karthik
On Wed, Dec 16, 2015 at 6:41 PM, Philip Oakley wrote:
> From: "Eric Sunshine"
>> On Monday, December 14, 2015, Philip Oakley wrote:
>>> The git gui's recent repo list may become contaminated with duplicate
>>> entries. The git gui would barf when attem
A rather superficial review...
On Wed, Dec 16, 2015 at 7:26 PM, Stefan Beller wrote:
> This reimplements the helper function `resolve_relative_url` in shell
s/This reimplements/Reimplement/
> in C. This functionality is needed in C for introducing the groups
> feature later on. When using group
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> ref-filter: introduce prefixes for the align atom
The prefixes are actually for the arguments to the 'align' atom, not
for the atom itself. However, it might be better to describe this at a
bit higher level. Perhaps:
ref-filter: align:
On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak wrote:
> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
> and '%(push)' atoms and store information into the 'used_atom'
> structure based on the modifiers used along with the corresponding
> atom.
>
> Helped-by: Ramsay Jones
On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak wrote:
> Introduce contents_atom_parser() which will parse the '%(contents)'
> atom and store information into the 'used_atom' structure based on the
> modifiers used along with the atom.
>
> Helped-by: Ramsay Jones
> Signed-off-by: Karthik Nayak
>
On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak wrote:
> Introduce align_atom_parser() which will parse an "align" atom and
> store the required alignment position and width in the "use_atom"
> structure for further usage in 'populate_value()'.
>
> Helped-by: Ramsay Jones
> Signed-off-by: Karthik
On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak wrote:
> Introduce objectname_atom_parser() which will parse the
> '%(objectname)' atom and store information into the 'used_atom'
> structure based on the modifiers used along with the atom.
>
> Helped-by: Ramsay Jones
> Signed-off-by: Karthik Naya
On Mon, Dec 21, 2015 at 1:19 AM, Jeff King wrote:
> The main entry point to the pack-revindex code is
> find_pack_revindex(). This calls revindex_for_pack(), which
> lazily computes and caches the revindex for the pack.
>
> We store the cache in a very simple hash table. It's created
> by init_pac
On Monday, December 21, 2015, Julian Andres Klode wrote:
> Introduce an option to deny unsigned tags from entering
> a repository. This is useful in teams where members forget
> to sign their release tags.
>
> It does not actually check whether the signature is actually
> complete or valid, it jus
On Mon, Dec 21, 2015 at 2:55 PM, Stephen & Linda Smith wrote:
> On Sunday, December 20, 2015 06:27:56 PM Stephen & Linda Smith wrote:
>> I've been looking over the git source tree to see if there is some place
>> where I can
>> contribute. It appears that there are some suggestions at the botto
On Mon, Dec 21, 2015 at 9:09 PM, Stephen P. Smith wrote:
> There are several places in the documentation that
> the term shallow clone is used. Defining the term
> enables its use elsewhere with a known definition.
>
> Signed-off-by: Stephen P. Smith
> ---
> diff --git a/Documentation/glossary-co
On Mon, Dec 21, 2015 at 9:09 PM, Stephen P. Smith wrote:
> Add a section to the users manual documenting shallow clones.
For the subject, prefix by section/module you're touching; drop
capitalization; drop full-stop (period).
> The todo section previously noted that documentation of shallow clon
On Tue, Dec 22, 2015 at 10:53 PM, Stephen P. Smith wrote:
> Rather than merely pointing readers at the 1.5 release notes to
> learn about shallow clones, document them formally.
Thanks, this version looks better. A few comment below...
> Signed-off-by: Stephen P. Smith
> ---
Right here, below
On Wed, Nov 25, 2015 at 10:10 AM, Jack Nagel wrote:
> When compiling git on OS X (where APPLE_COMMON_CRYPTO=1 is the
> default) and specifying NO_OPENSSL=1, the resulting git uses the
> BLK_SHA1 implementation rather than the functions available in
> CommonCrypto.
>
> $ make NO_OPENSSL=1
> [...]
>
On Wed, Dec 23, 2015 at 4:37 AM, Jeff King wrote:
> Subject: [PATCH] avoid SIGPIPE warnings for aliases
>
> When git executes an alias that specifies an external
> command, it will complain if the alias dies due to a signal.
> This is usually a good thing, as signal deaths are
> unexpected. Howeve
On Wed, Dec 23, 2015 at 8:51 AM, Michael Haggerty wrote:
> On 12/03/2015 01:35 AM, David Turner wrote:
>> + if (refs_backend_type && *refs_backend_type) {
>> + argv_array_push(&cp.args, "--refs-backend-type");
>> + argv_array_push(&cp.args, refs_backend_type);
>> +
On Wed, Dec 23, 2015 at 4:03 PM, Christian Couder
wrote:
> Factor out code into new_untracked_cache(), which will be used
> multiple times in a later commit.
Odd indentation: s/^\s+//
> Signed-off-by: Christian Couder
> ---
> diff --git a/dir.c b/dir.c
> @@ -1938,16 +1938,20 @@ void add
On Fri, Dec 25, 2015 at 8:44 AM, Karthik Nayak wrote:
> On Fri, Dec 18, 2015 at 11:54 AM, Eric Sunshine
> wrote:
>> On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak
>> wrote:
>>> +static void objectname_atom_parser(struct used_atom *atom)
>>
On Sun, Dec 27, 2015 at 10:43:16AM +0700, Nguyễn Thái Ngọc Duy wrote:
> The current update_linked_gitdir() has a bug that can create "gitdir"
> file in non-multi-worktree setup. Instead of fixing this, we step back a
> bit. The original design was probably not well thought out. For now, if
> the us
On Tue, Dec 29, 2015 at 1:36 AM, Jeff King wrote:
> The byte-swapping code automatically decides, based on the
> platform, whether it is sensible to cast an do a potentially
s/an/and/ or something?
> unaligned ntohl(), or to pick individual bytes out of an
> array.
>
> It can be handy to overrid
On Tue, Dec 29, 2015 at 8:55 AM, Duy Nguyen wrote:
> On Mon, Dec 28, 2015 at 1:22 PM, Eric Sunshine
> wrote:
>> On Sun, Dec 27, 2015 at 10:43:16AM +0700, Nguyễn Thái Ngọc Duy wrote:
>>> If you move a linked working tree to another file system, or
>>> -within a fil
On Wed, Dec 30, 2015 at 8:20 AM, Torsten Bögershausen wrote:
> I got 2 failures on pu under Mac OS, (Linux is OK)
> I did some very basic debugging, it seems as if grep doesn't find
> a needed string.
> Does anybody have an idea here ?
I'm unable to reproduce these failures on Mac.
> ---
On Tue, Dec 29, 2015 at 2:20 AM, Jeff King wrote:
> We want to chomp newlines off the end of the "value" string.
> But because it's const, we must track its length rather than
> writing a NUL. This leads to us having to tweak that length
> later, to account for moving the pointer forward.
>
> Sinc
On Tue, Dec 29, 2015 at 2:22 AM, Jeff King wrote:
> Some sites that otherwise would use skip_prefix cannot do
> so, because it has no way to do case-insensitive
> comparisons. Such sites usually get around this by using
> strncasecmp, at the cost of having to use magic numbers.
> We can help them
On Tue, Dec 29, 2015 at 2:27 AM, Jeff King wrote:
> Because we must match both "Author" and "author" here, we
> could not use skip_prefix, and had to hand-code a partial
> case-insensitive match. Now that we have skip_prefix_case,
s/skip_prefix_case/skip_prefix_icase/
> we can use it. This is te
On Tue, Dec 29, 2015 at 2:29 AM, Jeff King wrote:
> When gathering the author and oneline subject for each
> commit, we hand-parse the commit headers to find the
> "author" line, and then continue past to the blank line at
> the end of the header.
>
> We can replace this tricky hand-parsing by sim
ce or --not.
> [...]
>
> Helped-by: Duy Nguyen
> Helped-By: Eric Sunshine
s/By/by/
> Helped-By: Junio C Hamano
Ditto.
> Signed-off-by: Dongcan Jiang
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-opti
On Tue, Dec 29, 2015 at 2:35 AM, Jeff King wrote:
> Shortlog always groups commits by the author field. It can
> be interesting to group by other fields, as well. The
> obvious other identity in each commit is the committer
> field. This might be interesting if your project follows a
> workflow wh
On Tue, Dec 29, 2015 at 2:50 AM, Jeff King wrote:
> This doesn't leave us many syntactic "outs" for adding new ident types
> in the future (nor can you match a trailer called "Author"). I guess we
> could call this "--ident=trailer:reviewed-by" to be more precise, but
> it's more annoying to type.
On Mon, Jan 4, 2016 at 11:40 PM, David Greene wrote:
> This test merges an external tree in as a subtree, makes some commits
> on top of it and splits it back out. In the process the added commits
> are lost. This is marked to expect failure so that we don't forget to
> fix it.
>
> Signed-off-by
1201 - 1300 of 3976 matches
Mail list logo
