nces.
Signed-off-by: Michael J Gruber
Signed-off-by: Eric Wong
---
t/t9100-git-svn-basic.sh | 2 --
t/t9158-git-svn-mergeinfo.sh | 2 --
t/t9160-git-svn-preserve-empty-dirs.sh | 1 -
3 files changed, 5 deletions(-)
diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-ba
ref: https://public-inbox.org/git/20160606230248.ga15...@dcvr.yhbt.net/T/#u
Signed-off-by: Eric Wong
---
builtin/mailsplit.c | 32 +---
mailinfo.c | 31 +++
mailinfo.h | 1 +
pretty.c| 16 ++
Junio C Hamano wrote:
> Eric Wong writes:
> > I'm hoping "cd /" in the test will always succeed;
> > but I suppose non-*nix systems might fail, here.
>
> How about digging a few levels of directory hierarchy, exporting
> GIT_CEILING_DIRECTORIES s
Johannes Sixt wrote:
> The previous commit introduced the first use of ENOTSOCK. This macro is
> not available on Windows. Define it as WSAENOTSOCK because that is the
> corresponding error value reported by the Windows versions of socket
> functions.
Thanks. I thought compat/poll/poll.c alread
Johannes Schindelin wrote:
> The common work-around is to install Info-Zip on FreeBSD, into
> /usr/local/bin/.
>
> Signed-off-by: Johannes Schindelin
Thanks, t5003 now works out-of-the-box.
Tested with Info-ZIP unzip installed and uninstalled.
Tested-by: Eric Wong
--
To unsubscri
Johannes Schindelin wrote:
> Hi Eric,
>
> On Wed, 20 Jul 2016, Eric Wong wrote:
>
> > diff --git a/config.mak.uname b/config.mak.uname
> > index a88f139..6c29545 100644
> > --- a/config.mak.uname
> > +++ b/config.mak.uname
> > @@
Duy Nguyen wrote:
> On Tue, Jul 19, 2016 at 12:54 AM, Eric Wong wrote:
> > Oops, forgot to Cc some folks who worked on this :x
> >
> > Filesystem is ufs and it fails regardless of whether
> > soft-updates is enabled or not.
>
> Nothing stands out to my eyes, so
Perl has not been part of the base system since FreeBSD 5.0:
https://www.freebsd.org/releases/5.0R/relnotes-i386.html
Signed-off-by: Eric Wong
---
Does anybody still run git on FreeBSD 4.x or earlier?
4.11 was released a few months before git in 2005:
https
Checking the version of the installed SVN libraries should not
require a git repository at all. This matches the behavior of
"git --version".
Add a test for "git svn help" for the same behavior while we're
at it, too.
Signed-off-by: Eric Wong
---
I'm hoping
This has always been supported since we read config variables
based on the command-line option parser. Document it explicitly
since users usually want to maintain the same program across
invocations.
Signed-off-by: Eric Wong
---
Pushed to master of bogomips.org/git-svn.git, but I might
have
Junio C Hamano wrote:
> Jeff King writes:
> > On Mon, Jul 18, 2016 at 09:19:07AM +0000, Eric Wong wrote:
> >> Johannes Schindelin wrote:
> >> > On Sun, 17 Jul 2016, n...@dad.org wrote:
> >> > > 'git diff' outputs escape characters which clu
Oops, forgot to Cc some folks who worked on this :x
Filesystem is ufs and it fails regardless of whether
soft-updates is enabled or not.
Eric Wong wrote:
> Not sure what's going on, below is the relevant output when
> run with -i -v --tee (the rest succeeds without -i):
>
>
Not sure what's going on, below is the relevant output when
run with -i -v --tee (the rest succeeds without -i):
ok 26 - untracked cache correct after status
expecting success:
avoid_racy &&
: >../trace &&
GIT_TRACE_UNTRACKED_STATS="$TRASH_DIRECTORY/trace" \
git s
Junio C Hamano wrote:
> Eric Wong writes:
> > Junio C Hamano wrote:
> >> +test_lazy_prereq UNZIP_AUTOTEXT '
> >> + (
> >> + mkdir unzip-autotext &&
> >> + cd unzip-autotext
> >> + "$GIT_UNZIP
Junio C Hamano wrote:
> +test_lazy_prereq UNZIP_AUTOTEXT '
> + (
> + mkdir unzip-autotext &&
> + cd unzip-autotext
> + "$GIT_UNZIP" -a "$TEST_DIRECTORY"/t5003/infozip-text.zip &&
> + test -f text
> + )
/usr/bin/unzip actually takes -a on Fre
We need to test linkage of pthread_create and pthread_join,
as pthread_mutex_* and pthread_key_* functions do not need
extra linkage under FreeBSD 10.3, leading to a false-positive
of the empty case.
Signed-off-by: Eric Wong
---
configure.ac | 5 +
1 file changed, 5 insertions(+)
diff
on common GNU/Linux
systems.
So take the safe route and assume anybody still using more(1)
today can live with monochrome output, but acknowledge 'R'
in the MORE environment variable if it was set by the user.
Signed-off-by: Eric Wong
---
environment.c | 2 +-
pager.c | 11
/usr/local/bin/unzip (via "pkg install unzip") to pass t5003.
This Info-ZIP version exits with "0" when given "-v",
so limit the prereq to only versions which return 0 on "-v".
[1]
https://www.freebsd.org/cgi/man.cgi?query=unzip&sektion=1&manpath=Fr
In inetd mode, we are not guaranteed stdin or stdout is a
socket; callers could filter the data through a pipe
or be testing with regular files.
This prevents t5802 from polluting syslog.
Signed-off-by: Eric Wong
---
daemon.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff
Alexandre Bique wrote:
> Hi,
>
> I did by mistake report the bug here:
>
> https://github.com/git/git-scm.com/issues/807#issuecomment-233200404
>
> In short this is a backtrace of git svn rebase crashing in perl, and
> likely because of an out of memory issue. It crashed on my laptop but
> not
Eric Sunshine wrote:
> On Sat, Jul 16, 2016 at 8:25 PM, Eric Wong wrote:
> > Eric Wong wrote:
> >> I also wonder where we use sys/queue.h, since I use
> >> LIST_HEAD from ccan/list/list.h in a different project
> >> without conflicts...
> >
> >
Eric Wong wrote:
> Lars Schneider wrote:
> > It looks like as if this topic breaks the OS X build because
> > it defines LIST_HEAD. LIST_HEAD is already defined in
> > /usr/include/sys/queue.h.
>
> Oops, I suppose GIT_LIST_HEAD is an acceptable name?
> (look
Lars Schneider wrote:
> > On 13 Jul 2016, at 18:56, Junio C Hamano wrote:
> > * ew/http-walker (2016-07-12) 3 commits
> > - http-walker: reduce O(n) ops with doubly-linked list
> > - http: avoid disconnecting on 404s for loose objects
> > - http-walker: remove unused parameter from fetch_object
>
Konstantin Khomoutov wrote:
> Ben Peart wrote:
> > > Lars Schneider wrote:
> > >
> > > We could dynamically load libraries but this would force us to
> > > freeze the ABI as mentioned by Duy:
> > > http://article.gmane.org/gmane.comp.version-control.git/298463
> > >
> >
> > I wouldn’t be too q
Jeff King wrote:
> Otherwise, we'll have to skip the test, perhaps with something like the
> patch below. I suspect the problem is actually the size of "unsigned
> long", not time_t, as we use that internally for a bunch of time
> computation.
We should probably be using int64_t for time calculat
track of all live object requests in O(1) average time.
Signed-off-by: Eric Wong
---
http-walker.c | 35 +++
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git a/http-walker.c b/http-walker.c
index 0b24255..8d27707 100644
--- a/http-walker.c
+++ b/http-wal
This parameter has not been used since commit 1d389ab65dc6
("Add support for parallel HTTP transfers") back in 2005
Signed-off-by: Eric Wong
---
http-walker.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/http-walker.c b/http-walker.c
index 2c721f0..9f28
list (2016-07-11 20:25:51
+)
----
Eric Wong (3):
http-walker: remove unused parameter from fetch_object
http: avoid disconnecting on 404s for loose objects
http-walker: reduce O(n) ops with doubly-linked l
additional pointer per object
request, but this is offset by reduced overhead on queue
operations leading to improved performance and shorter queue
depths.
Signed-off-by: Eric Wong
---
http-walker.c | 42 ++-
list.h| 164 +++
404s are common when fetching loose objects on static HTTP
servers, and reestablishing a connection for every single
404 adds additional latency.
Signed-off-by: Eric Wong
---
http-walker.c | 9 +
http.c| 16 ++--
2 files changed, 23 insertions(+), 2 deletions
x27;t think this will introduce new breakage for users of
alternative libc implementations.
Signed-off-by: Eric Wong
---
config.mak.uname | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config.mak.uname b/config.mak.uname
index a88f139..22958a8 100644
--- a/config.mak.uname
+++ b/
At least for me, this improves the readability of xread and
xwrite; hopefully allowing missing "continue" statements to
be spotted more easily.
Signed-off-by: Eric Wong
Signed-off-by: Jeff King
---
Jeff King wrote:
> On Sun, Jul 10, 2016 at 03:47:36AM +0000, Eric Wong wrote:
Eric Wong wrote:
> https://public-inbox.org/.temp/git.vger.kernel.org-6c38c917e55c.gz
> (362M)
>
> git init --bare mirror.git
> curl $FAST_EXPORT_GZ_URL | git --git-dir=mirror.git fast-import
Oops, that is missing zcat:
curl $FAST_EXPORT_GZ_U
Jeff King wrote:
> On Sat, Jul 09, 2016 at 11:45:18PM +0000, Eric Wong wrote:
> > Junio C Hamano wrote:
> > > * sb/submodule-parallel-fetch (2016-06-27) 2 commits
> > > (merged to 'next' on 2016-07-06 at de5fd35)
> > > + xwrite: poll on non-bl
Very much a work-in-progress, but NNTP and HTTP/HTTPS sorta work
based on stuff that is on gmane and stuff I'm accumulating by
being a subscriber.
The first two Tor hidden service onions are actually on better
hardware than the non-hidden public-inbox.org one:
nntp://hjrcffqmbrq6wope.onion/inbox.
Junio C Hamano wrote:
> * sb/submodule-parallel-fetch (2016-06-27) 2 commits
> (merged to 'next' on 2016-07-06 at de5fd35)
> + xwrite: poll on non-blocking FDs
> + xread: retry after poll on EAGAIN/EWOULDBLOCK
>
> Fix a recently introduced codepaths that are involved in parallel
> submodule
Michael J Gruber wrote:
> 2016-07-06 22:15 GMT+02:00 Jacob Keller :
> > On Wed, Jul 6, 2016 at 6:16 AM, Johannes Schindelin
> > wrote:
> ...
> >>> It is not unheard of that a MUA can collapse and expand properly quoted
> >>> parts on request...
> >>
> >> Sure. Show me some kick-ass, scriptable ma
is missing (2016-07-09
22:53:54 +)
Christopher Layne (1):
git-svn: clone: Fail on missing url argument
Eric Wong (1):
git-svn: warn instead of dying when commit data is missing
git-svn.perl| 5 -
perl/Git/SVN.
This parameter has not been used since commit 1d389ab65dc6
("Add support for parallel HTTP transfers") back in 2005
Signed-off-by: Eric Wong
---
I might followup in a few days/weeks with further updates in
this area, but at least should be trivially correct :)
http-walker.c | 4 ++
he '* ' and space prefix from the version I've
applied since it's not the convention around here.
> Signed-off-by: Christopher Layne
Signed-off-by: Eric Wong
And pushed to "master" of git://bogomips.org/git-svn
(I'll request for Junio to pull with
Christian Couder wrote:
> On Fri, Jun 24, 2016 at 10:06 PM, Eric Wong wrote:
> > Jacob Godserv wrote:
> >> > Christian (Cc-ed) also noticed the problem a few weeks ago
> >> > and took a more drastic approach by having git-svn die
> >> > instead of wa
Stefan Beller wrote:
> @@ -513,6 +531,17 @@ int send_pack(struct send_pack_args *args,
> strbuf_release(&req_buf);
> strbuf_release(&cap_buf);
>
> + if (use_push_options) {
> + struct string_list_item *item;
> + struct strbuf sb = STRBUF_INIT;
> +
> +
Johannes Schindelin wrote:
> P.S.: If it is not too much of a problem, may I ask you to simply delete
> remainders of my patches when replying and not commenting on them? I just
> deleted 226 lines after verifying that you really did not respond to any
> part of it in the unhelpful Alpine client (
Christian Couder wrote:
> Design discussion about performance
> ~~~
>
> Yeah, it is not efficient to fork/exec a command to just read or write
> one object to or from the external ODB. Batch calls and/or using a
> daemon and/or RPC should be used instead to be able
ioannis.kap...@rbs.com wrote:
> Fortunately, a patch has already been submitted to subversion
> with (github) revision
> a074af86c8764404b28ce99d0bedcb668a321408 (at
> https://github.com/apache/subversion/commit/a074af86c8764404b28ce99d0bedcb668a321408
> ) on the trunk to handle this and a couple o
Jeff King wrote:
> On Mon, Jun 27, 2016 at 05:49:48PM -0400, Jeff King wrote:
>
> > So in general I would say that handing non-blocking descriptors to git
> > is not safe.
Indeed. This also makes me wonder if our output to stdout/stderr
suffer from the same theoretical problems if given non-blo
the missing "continue".
Maybe the following optional patch on top of this series
improves readability:
--8<
Subject: [PATCH 3/2] hoist out io_wait function for xread and xwrite
At least for me, this improves the readability of xread and
xwrite; hopefully allowing
Jeff King wrote:
> On Sun, Jun 26, 2016 at 11:21:11PM +0000, Eric Wong wrote:
>
> > We should continue to loop after EAGAIN/EWOULDBLOCK as the
> > intent of xread is to read as much as possible until an
> > EOF or real error occurs.
>
> BTW, a minor nit here. xrea
David Turner wrote:
> On 06/26/2016 04:53 AM, Eric Wong wrote:
> >David Turner wrote:
> >>On 06/25/2016 10:33 AM, Duy Nguyen wrote:
> >>>>+ /*
> >>>>+* Our connection to the client is blocking since a client
> >&
-pack.
Followup-to: 1079c4be0b720 ("xread: poll on non blocking fds")
Signed-off-by: Eric Wong
---
wrapper.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/wrapper.c b/wrapper.c
index f1155d0..d973f86 100644
--- a/wrapper.c
+++ b/wrap
We should continue to loop after EAGAIN/EWOULDBLOCK as the
intent of xread is to read as much as possible until an
EOF or real error occurs.
Fixes: 1079c4be0b720 ("xread: poll on non blocking fds")
Signed-off-by: Eric Wong
---
wrapper.c | 1 +
1 file changed, 1 insertion(+)
di
pied the branch from xread
into xwrite without the "continue" and was greeted with a
failed clone.
Eric Wong (2):
xread: retry after poll on EAGAIN/EWOULDBLOCK
xwrite: poll on non-blocking FDs
wrapper.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(
David Turner wrote:
> On 06/25/2016 10:33 AM, Duy Nguyen wrote:
> >>+ /*
> >>+* Our connection to the client is blocking since a client
> >>+* can always be killed by SIGINT or similar.
> >>+*/
> >>+ set_socket_blocking_fl
This matches the documentation and allows gc.autoPackLimit=1
to maintain a single pack without attempting a repack on every
"git gc --auto" invocation.
Signed-off-by: Eric Wong
---
builtin/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/gc.c b/builtin/
Jeff King wrote:
> On Sat, Jun 25, 2016 at 01:14:50AM +0000, Eric Wong wrote:
>
> > I'm not sure if this is the best approach, or if changing
> > too_many_packs can be done without causing problems for
> > hosts of big repos.
> >
> > --
- return gc_auto_pack_limit <= cnt;
+ return gc_auto_pack_limit < cnt;
However, changing gc itself at this time may cause problems
for people who are already using gc.autoPackLimit=2 and
expect bitmaps to work for them.
Signed-off-by: Eric Wong
---
Documentation/config.txt |
Please don't drop Cc:, re-adding git@vger and Christian
Jacob Godserv wrote:
> > Christian (Cc-ed) also noticed the problem a few weeks ago
> > and took a more drastic approach by having git-svn die
> > instead of warning:
> > http://mid.gmane.org/1462604323-18545-1-git-send-email-chrisc...@tuxfa
Jacob Godserv wrote:
> On Tue, Sep 22, 2015 at 2:48 PM, Jacob Godserv wrote:
> > I found a specific case in which git-svn improperly aborts:
> >
> > 1. I created a git-svn repository, named "git-svn repo", by cloned an
> > svn repository via the git-svn tool.
> > 2. I created a normal git reposit
svk::parents can be
expensive and pointless.
Reported-by: Александр Овчинников
http://mid.gmane.org/4094761466408...@web24o.yandex.ru
Signed-off-by: Eric Wong
---
The following changes since commit ab7797dbe95fff38d9265869ea367020046db118:
Start the post-2.9 cycle (2016-06-20 11:06:
Junio C Hamano wrote:
> On Wed, Jun 22, 2016 at 12:00 PM, Eric Wong wrote:
> >
> > Just wondering, who updates
> > https://kernel.org/pub/software/scm/git/docs/
> > and why hasn't it been updated in a while?
> > (currently it says Last updated 2015-06-06
Jonathan Nieder wrote:
> I'd rather use an up-to-date https link for the rendered
> documentation, but I wasn't able to find one. According to the 'todo'
> branch, prebuilt documentation is pushed to
>
> 1. https://kernel.googlesource.com/pub/scm/git/git-htmldocs
> 2. git://repo.or.cz/git-html
I noticed "fatal: The remote end hung up unexpectedly" in server
logs from shallow clones. Totally reproducible in the test
cases, too. The following change shows it:
diff --git a/t/t5561-http-backend.sh b/t/t5561-http-backend.sh
index 90e0d6f..cfa55ce 100755
--- a/t/t5561-http-backend.sh
+++ b/
+Cc: a bunch of folks who may know better how mergeinfo works in git-svn
Александр Овчинников wrote:
> Why git svn fetch try to handle mergeinfo changes when
> no-follow-parent is enabled?
It probably should not... --no-follow-parent isn't a common
config, though. Can you try the patch below?
Andreas Schwab wrote:
> Eric Wong writes:
>
> > @@ -21,7 +22,7 @@ static int prune_tmp_file(const char *fullpath)
> > struct stat st;
> > if (lstat(fullpath, &st))
> > return error("Could not stat '%s'", fullpath);
>
Junio C Hamano wrote:
> Eric Wong writes:
> > I'm somewhat surprised this check didn't already exist;
> > but maybe nobody else runs prune manually, anymore.
>
> The only time an end user would run "git prune" in their
> repositories with working tr
"
in a different terminal, and ensuring the loose object remains
after "git prune" completes.
Signed-off-by: Eric Wong
---
I'm somewhat surprised this check didn't already exist;
but maybe nobody else runs prune manually, anymore.
builtin/prune.c | 6 --
1 file ch
Leo Gaspard wrote:
> First, sorry for not having this message threaded: I'm not subscribed to
> the list and haven't found a way to get a Message-Id from gmane.
Appending "/raw" to the gmane URL will get you the raw message
with full headers:
article.gmane.org/gmane.comp.version-control.git/$N
Alfred Perlstein wrote:
> Add example usage to the git-svn documentation.
>
> Reported-by: Joseph Pecoraro
> Signed-off-by: Alfred Perlstein
> ---
>
> Junio, Pranit, + all,
>
> A week ago I was requested to provide documentation for the
> 'svn propset' command. I have attached a diff off of
Samuel GROOT wrote:
> On 06/09/2016 02:21 AM, Eric Wong wrote:
> >Samuel GROOT wrote:
> >>Email::Simple library uses qr/\x0a\x0d|\x0d\x0a|\x0a|\x0d/ [1].
> >>Should we handle \n\r at end of line as well?
> >
> >"\n\r" can never happen with loca
Peter Münster wrote:
> On Sat, Jun 11 2016, Eric Wong wrote:
>
> > The git log after dcommit is tied to the SVN log,
> > so git-svn can only reflect changes which appear in SVN.
>
> You mean, it's impossible, to keep the original timestamps??
It might be; just not
Peter Münster wrote:
> On Tue, Jun 07 2016, Eric Wong wrote:
> > Peter Münster wrote:
> >> It would be nice, if timestamps could be preserved when rewriting the
> >> git-log.
> >
> > Unfortunately, last I checked (a long time ago!), explicitly
Samuel GROOT wrote:
> Email::Simple library uses qr/\x0a\x0d|\x0d\x0a|\x0a|\x0d/ [1].
> Should we handle \n\r at end of line as well?
"\n\r" can never happen with local $/ = "\n"
> [1] *
> http://cpansearch.perl.org/src/RJBS/Email-Simple-2.210/lib/Email/Simple.pm
--
To unsubscribe from this li
Samuel GROOT wrote:
> +++ b/perl/Git.pm
> +sub parse_email {
> + my %mail = ();
> + my $fh = shift;
> + my $last_header;
> +
> + # Unfold and parse multiline header fields
When you libify, I suggest you localize $/ since $/
may be set to something other than "\n" by a caller
and
Tom Russello wrote:
> Messages displayed by `send-email` should be shortened to avoid displaying
> unnecesseray informations.
unnecessary information.
In some of your other patches, the 'grep' can probably
be better replaced by 'fgrep' for fixed strings.
Otherwise, the '.' in the 'example.com' w
+Cc Alfred, David
Joseph Pecoraro wrote:
> `git help svn` does not mention `propset` but it does mention `proplist` and
> `propget`. This seems like an oversight.
>
>
> $ git help svn
> ...
> proplist
> Lists the properties stored in the Subversion repository about
Peter Münster wrote:
> It would be nice, if timestamps could be preserved when rewriting the
> git-log.
Unfortunately, last I checked (a long time ago!), explicitly
setting revprops might require SVN administrators to enable the
feature for the repo.
It's been a while and I'm not up-to-date with
Junio C Hamano wrote:
> This just makes me wonder if there is a practical reason why people
> would not want this always enabled. I just looked at output from
>
> $ git log --grep='>>*From '
Missing '^' ?
Auto-unescaping in mailsplit might throw off people on older
versions of git if reser
Combined with "git format-patch --pretty=mboxrd", this should
allow us to round-trip commit messages with embedded mbox
"From " lines without corruption.
Signed-off-by: Eric Wong
---
Documentation/git-am.txt | 3 ++-
builtin/am.c | 14 +++---
t/t4150-a
This will allow us to parse the output of --pretty=mboxrd
and the output of other mboxrd generators.
Signed-off-by: Eric Wong
---
Documentation/git-mailsplit.txt | 7 ++-
builtin/mailsplit.c | 18 ++
t/t5100-mailinfo.sh | 31
t's inherits the problems
of "mboxcl" while being completely incompatible with existing
tooling based around mailsplit.
ref:
http://homepage.ntlworld.com/jonathan.deboynepollard/FGA/mail-mbox-formats.html
Signed-off-by: Eric Wong
---
builtin/log.c | 2 +-
commit.
t --patch-format=mboxrd (2016-06-05 04:16:57 +)
----
Eric Wong (3):
pretty: support "mboxrd" output format
mailsplit: support unescaping mboxrd messages
am: support --patch-format=mboxrd
Documentation/git-am.t
Matteo Bertini wrote:
> Il 2016-05-31 20:12 Eric Wong ha scritto:
> >Matteo Bertini wrote:
> >>Sorry to all, but I missed a Checksum mismatch error, I'll have a
> >>look and submit an update.
>
> I've had a look, the problem is a missing smudge filter.
Samuel GROOT wrote:
> On 05/29/2016 01:33 AM, Eric Wong wrote:
> >Matthieu Moy wrote:
> >>Samuel GROOT writes:
> >>
> >>>Parsing and processing in send-email is done in the same loop.
> >>>
> >>>To make the code more maintainab
Eric Wong wrote:
> Eric Sunshine wrote:
> > On Tue, May 31, 2016 at 3:45 AM, Eric Wong wrote:
> > > Eric Sunshine wrote:
> > >> I wonder if hand-coding, rather than using a regex, could be an
> > >> improvement:
> > >>
> &
Eric Sunshine wrote:
> On Tue, May 31, 2016 at 3:45 AM, Eric Wong wrote:
> > Eric Sunshine wrote:
Ah thanks, I can see your point-of-view, now.
I always had the '^' in my mind since I've written the same
thing in Perl and Ruby.
> >> I wonder if hand-coding,
Matteo Bertini wrote:
> Sorry to all, but I missed a Checksum mismatch error, I'll have a
> look and submit an update.
Sure, when you reroll can you also ensure lines are wrapped at
80 cols or less? (at least for the git-svn code, but probably
for the rest of it, too).
As for the option name, th
Eric Sunshine wrote:
> On Mon, May 30, 2016 at 7:21 PM, Eric Wong wrote:
> > diff --git a/pretty.c b/pretty.c
> > @@ -1697,12 +1699,34 @@ static void pp_handle_indent(struct
> > pretty_print_context *pp,
> > +static regex_t *mboxrd_prepare(void)
> > +
Combined with "git format-patch --pretty=mboxrd", this should
allow us to round-trip commit messages with embedded mbox
"From " lines without corruption.
Signed-off-by: Eric Wong
---
Documentation/git-am.txt | 3 ++-
builtin/am.c | 14 +++---
t/t4150-a
This will allow us to parse the output of --pretty=mboxrd
and the output of other mboxrd generators.
Signed-off-by: Eric Wong
---
Documentation/git-mailsplit.txt | 7 ++-
builtin/mailsplit.c | 23 +++
t/t5100-mailinfo.sh | 13 +
t
t's inherits the problems
of "mboxcl" while being completely incompatible with existing
tooling based around mailsplit.
ref:
http://homepage.ntlworld.com/jonathan.deboynepollard/FGA/mail-mbox-formats.html
Signed-off-by: Eric Wong
---
builtin/log.c | 2 +-
commit.
.0?), maybe mboxrd can become the
default mail format. IMHO, it should've been since 2005.
ref:
http://homepage.ntlworld.com/jonathan.deboynepollard/FGA/mail-mbox-formats.html
Eric Wong (3):
pretty: support "mboxrd" output format
mailsplit: support unescaping mboxrd
Matthieu Moy wrote:
> Samuel GROOT writes:
>
> > Parsing and processing in send-email is done in the same loop.
> >
> > To make the code more maintainable, we create two subroutines:
> > - `parse_email` to separate header and body
> > - `parse_header` to retrieve data from header
>
> These rout
Jeff King wrote:
> On Thu, May 26, 2016 at 08:02:36AM +0000, Eric Wong wrote:
>
> > > That's probably OK in practice, as I think the actual pack-write already
> > > does a linear walk of the object table to generate the pack index. So
> > > presumably nobody
Samuel GROOT wrote:
> While working on the new option `quote-email`, we needed to parse an
> email file. Since the work is already done, but the parsing and data
> processing are in the same loop, we wanted to refactor the parser, to
> make the code more maintainable.
Thank you for doing this wor
Jeff King wrote:
> On Wed, May 25, 2016 at 10:54:02PM +0000, Eric Wong wrote:
> > + for (h = 0; h < ARRAY_SIZE(object_table); h++) {
> > + struct object_entry *e;
> > +
> > + for (e = object_table[h]; e; e = e->next)
> > +
Junio C Hamano wrote:
> This makes sense as a follow-up to e47a8583 (enable SO_KEEPALIVE for
> connected TCP sockets, 2011-12-06), I think.
Yes, a15d069a19867 for http, too; hat trick :>
Anyways, it might've helped Savannah when they had networking
problems:
http://mid.gmane.org/2016052421410
they are also invalidated.
Signed-off-by: Eric Wong
---
I started writing a standalone test case; but testing with
original failing cases would be greatly appreciated.
Still learning my way around the fast-import code...
Thanks.
fast-import.c | 31 +++-
t
Jeff King wrote:
> On Tue, May 17, 2016 at 10:07:16AM +0200, Lars Schneider wrote:
>
> > I think that is pretty much the problem. Here is what is happening:
> >
> > 1. git-p4 imports all changelists for the "main" branch
> >
> > 2. git-p4 starts to import a second branch and creates a fast-im
tions.
Signed-off-by: Eric Wong
---
daemon.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/daemon.c b/daemon.c
index 8d45c33..46dddac 100644
--- a/daemon.c
+++ b/daemon.c
@@ -669,6 +669,15 @@ static void hostinfo_clear(struct hostinfo *hi)
strbuf_release(&hi-
Samuel GROOT wrote:
> On 05/23/2016 09:55 PM, Eric Wong wrote:
> >Cool! There should probably be some help text to encourage
> >trimming down the quoted text to only relevant portions.
>
> What kind of help text would you want to see?
>
> Maybe something like this:
401 - 500 of 840 matches
Mail list logo
