Apparent bug in credential tool running...

2018-03-28 Thread Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
Hi git Experts, I believe we've encountered a bug in git. I built the latest, git 2.16.3, and it still appears to be a problem. I'm not a git expert and my C is ridiculously rusty but I think a co-worker and I figured it out... apologies if we are incorrect in any assumptions (as I do not

Re: Apparent bug in credential tool running...

2018-03-28 Thread Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
Quick note: I did submit the patch, look for subject line " [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash". Thanks again Jeff, Erik 

Re: Apparent bug in credential tool running...

2018-03-28 Thread Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
so I can submit that as-is). Thanks for the quick response! Erik On 3/28/18, 11:46 AM, "Jeff King" <p...@peff.net> wrote: On Wed, Mar 28, 2018 at 06:26:08PM +0000, Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco) wrote: > The loca

Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash

2018-03-29 Thread Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
Thanks Jeff. OK, will retry on the comment. I guess I misunderstood the guidelines a bit on the signoff as well (ie: non-optional), apologies. Will resubmit via 'git send-email' after adjusting the comment and recommitting with the -s option. First time for everything I suppose, doh. As to

Re: [PATCH] credential: ignore SIGPIPE when writing to credential helpers

2018-03-29 Thread Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
Thanks Jeff. I appreciate your time. Quick Q... is there a way to track the patch through to release? If not I can just scan release notes/etc so no worries. Cheers, Erik On 3/29/18, 2:51 PM, "Jeff King" wrote: On Thu, Mar 29, 2018 at 11:00:56AM -0700, Erik E Brady