Lars Schneider writes:
> On 22 Apr 2016, at 11:07, Matthieu Moy wrote:
>
>> The ; or the newline is not needed either.
> Unfortunately it seems to be required. Travis CI generates a shell script
> out of the yml file and I think they don't respect newli
llow, but just a proof that you
understood the amount of work to be done and that you have an idea on
how to accomplish it.
I wouldn't be the first one to write "value [...] Responding to change
over following a plan" ;-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To un
.
> we do not see a semicolon before "pushd".
>
> case "${TRAVIS_OS_NAME:-linux}" in
> linux)
> mkdir --parents custom/p4
> pushd custom/p4
I'm tempted to think that these lines create directori
The changes are described in CHANGES.
Contributions-by: Matthieu Moy
Contributions-by: Stefan Tatschner
Contributions-by: Simon P
Contributions-by: Leander Hasty
Signed-off-by: Matthieu Moy
---
Not for inclusion, but tests and reviews welcome.
contrib/hooks/multimail/CHANGES
agree. My proposal to check for a handful of generated files was just
because this extra paranoia was almost free (just 3 lines of code that
won't need particular maintenance).
In this case, I'm afraid the maintenance cost is much bigger than the
expected benefits.
--
Matthieu Moy
in favor of ci/*
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Stefan Beller writes:
> On Fri, Apr 29, 2016 at 5:21 AM, Matthieu Moy
> wrote:
>> Jeff King writes:
>>
>>> On Fri, Apr 29, 2016 at 11:35:34AM +0200, larsxschnei...@gmail.com wrote:
>>>
>>>> +# The follow numbers need to be adjusted when new do
the patch looks good to me.
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
SET));
;-).
One obvious issue with the initial version was this big hard-to-parse
block, but another one is that the code did not make it easy to
understand what was changing depending on which branch of the if, and
depending on local/remote. It's getting much easier already.
--
Mat
Karthik Nayak writes:
> On Mon, Oct 5, 2015 at 2:19 PM, Matthieu Moy
> wrote:
>> Karthik Nayak writes:
>>> which does not play well with the implementation of --column as done
>>> in tag.c. Where, If I'm not wrong the --column option captures all
>>&
Karthik Nayak writes:
> On Wed, Oct 7, 2015 at 12:33 AM, Matthieu Moy
> wrote:
>
>> To go a bit further, you can pre-build a string or strbuf aligned_short
>> with value like "%%(align:20,left)%%(refname:short)%%(end)" and use it
>> where needed (it
"McAuley, Ben" writes:
> However when I run the same command again, this time using the
> GIT_INDEX env variable to provide the index I previously saved on master,
> I don't see file2 like I'd expect...
The variable name is GIT_INDEX_FILE (read 'man git'
8,11 +58,11 @@ test_expect_success 'branch -v' '
> '
>
> cat >expect <<\EOF
> -b1 [origin/master] [ahead 1, behind 1] d
> -b2 [origin/master] [ahead 1, behind 1] d
> -b3 [origin/master] [behind 1] b
> -b4 [origin/master] [ahead 2] f
> -b5 [bro
Karthik Nayak writes:
> On Thu, Oct 8, 2015 at 5:57 PM, Matthieu Moy
> wrote:
>>> + unsigned int nobracket = 0;
>>> +
>>> + if (!strcmp(valp, ",nobracket"))
>>> +
Karthik Nayak writes:
> On Thu, Oct 8, 2015 at 10:40 PM, Matthieu Moy
> wrote:
>
>> This particular piece of code is so important and I won't fight for a
>> better factored one, but in general "there are only two instances" is a
>> dubious argument to
sly
translated in "branch" and you are removing this translation (well, not
here, but when 09/10 starts using this code).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@
die(_("format: %%(then) atom used after %%(else)"));
here, just in case (adding the two corresponding test_must_fail wouldn't
harm of course).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
om = 1;
> +
> /*
Useless new blank line.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> MINIMUM_ABBREV' '
> + git for-each-ref --format="%(objectname:short=1)" refs/heads >actual &&
> + test_cmp expected actual
> +'
> +
> +cat >expected < +$(git rev-parse --short=10 HEAD)
> +EOF
Likewise.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
re going to add one anyway.
Code movement is more "git blame" friendly than code copy, and as a
reviewer I'd rather see the code movement here and not hear about it
later in the series.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the li
num_theirs);
> + else
> + sprintf(buf, "[ahead %d, behind
> %d]",
> num_ours, num_theirs);
> v->s = xstrdup(b
Oops, sorry, I sent the wrong message, this one is empty. Please ignore.
Matthieu Moy writes:
> Karthik Nayak writes:
>
>> Add support for %(upstream:track,nobracket) which will print the
>> tracking information without the brackets (i.e. "ahead N, behind M").
>
> +struct if_then_else {
> + unsigned int then_atom : 1,
> + else_atom : 1,
Maybe "then_atom_seen" and "else_atom_seen" would be better names. Or
maybe they'd be too long, I leave it up to you.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from t
} *used_atom;
Just a thought, I'm not sure how useful this would be, and this may be
too much change for this series (so it may deserve a separate topic).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
old style do not mix well, prepend a "modernize
style" patch to the series, and adopt the new style in the patch
itself.
* If you're too lazy to do a "modernize style", adopt the old style for
consistency.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Karthik Nayak writes:
> On Fri, Oct 9, 2015 at 12:10 AM, Matthieu Moy
> wrote:
>> Karthik Nayak writes:
>>
>>> --- a/ref-filter.c
>>> +++ b/ref-filter.c
>>> @@ -1118,8 +1118,10 @@ static void populate_value(struct ref_array_item
>>&g
Signed-off-by: Matthieu Moy
---
builtin/branch.c | 2 ++
builtin/tag.c| 2 ++
2 files changed, 4 insertions(+)
diff --git a/builtin/branch.c b/builtin/branch.c
index 9d6c062..041c649 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -531,6 +531,8 @@ int cmd_branch(int argc, const char
fmt("[%s]", v->s);
free(to_free);
}
so we don't have to worry about brackets anywhere else in the code.
Signed-off-by: Matthieu Moy
---
ref-filter.c | 28
ref-filter.h | 3 +++
2 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/ref-fil
The char buf[40] is safe (at least while the strings are not
translated), but I'd rather avoid magic numbers like this 40 in the
code, and use a construct that does not have this size limitation.
Especially if it makes the code shorter.
Signed-off-by: Matthieu Moy
---
ref-filter.c
series starts getting close to finished, so you should not try
to add to much to it (at least for me: I spend some time reviewing v2
and I have an idea of what the interdiff should look like, I'd rather
avoid having new distraction in the v2->v3 interdiff).
--
Matthieu Moy
http://www-verima
will always get the same result regardless of the current locale.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The changes are described in CHANGES.
Contributions-by: Matthieu Moy
Contributions-by: Elijah Newren
Contributions-by: Edward d'Auvergne
Contributions-by: Vadim Zeitlin
Contributions-by: Paul Sokolovsky
Contributions-by: Michael Haggerty
Contributions-by: Elijah Newren
Contributio
Karthik Nayak writes:
> On Sun, Oct 11, 2015 at 9:51 PM, Matthieu Moy
> wrote:
>> Karthik Nayak writes:
>>
>>> Also does it make sense to integrate these changes here? Or would you like
>>> to
>>> have another series on this?
>>
>> To
top of
>> which everything in flight that is not yet in 'next' is rebased."
>
> Ah, but I might take a while to get there, So I'd rather push code which
> is almost ready and work on that slowly, if that's ok?
That's OK to me. The "most preferable wa
more instance of sub-optimal code,
it isn't hard to review. Inserting new code before them would make the
interdiff far bigger.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord..
time. We'd miss issues with perl but no pthread or so, but
this should catch most issues.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo
rating-from-legacy/?utm_source=legacy-notice&utm_medium=banner&utm_campaign=legacy-upgrade
No big deal, but getting rid of sudo would be cool, and documenting why
it can't easily be done in commit message and/or comments would be nice
otherwise.
Thanks for working on that!
"Update test output for "
> become
> "Update test output for 777..."
>
> Is it possible currently? And if yes how?
AFAIK, it's not possible other than by editing the message by hand.
--
Matthieu Moy
http://www-verimag.
d have the detection done up where we
> locat "upstream" / "push", what would be a nice way to go around this?
You mean, below
else if (starts_with(name, "upstream")) {
within populate_value()?
I think it would, yes.
> What I could think of:
> 1.
ithub.com/git/git-scm.com/issues/605
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
John Keeping writes:
> On Wed, Oct 14, 2015 at 09:37:05AM +0200, Matthieu Moy wrote:
>> Xue Fuqiao writes:
>>
>> > Hi list,
>> >
>> > In https://git-scm.com/docs/user-manual.html , all links to the
>> > glossary[1] are broken.
>>
>&g
*documented* behavior, and an easy way to corrupt
a repo should be very explicitly documented as very dangerous, and the
precautions to take when using it should be explained clearly.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubs
lines.
That said, a "split hunk line by line" option for "git add -p" could be
nice.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ood to me. I think the same should be added to git-prune.txt
under --expire.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ition.
This looks like a race between deleting objects/05/ and creating
objects/05/cdb51bb0ea3e229734a4b1bddd5ec70fbc65ed.
I don't understand how this is possible, since the temporary file and
the final one are in the same directory, so deleting the directory
should fail.
What am I missing?
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> This looks like a race between deleting objects/05/ and creating
>> objects/05/cdb51bb0ea3e229734a4b1bddd5ec70fbc65ed.
>>
>> I don't understand how this is possible, since the temporary file and
>> th
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> Looks good to me. I think the same should be added to git-prune.txt
>> under --expire.
>
> I thought about it, but decided against it, as the command is not
> even recommended to end users.
Even non-"end users&q
ses to amend an already-pushed commit, so you can't break
the flow of people using this. It must 1) be configurable, and 2) unless
you have a really good reason, backward-compatible by default.
Also, it lacks tests.
Actually, the idea you have is far, far more difficult than what you
prob
at what other tests are doing in t/ (there's a README file there
too). Start with
cd t/
ls t*push*.sh
to get examples.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...
he commit message, but I won't
insist on that.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in 20sec:
> https://travis-ci.org/larsxschneider/git/jobs/85432398
Since the tests are essentially IO-bound and not CPU-bound, it may even
make sense to use -j3 here.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscrib
move and rename the function, and 2) change the
callsites to strbuf_stripspace. This way 2) would be absolutely trivial
to review.
OTOH, this patch is already easy to review, so you may consider it's OK
like this.
Reviewed-by: Matthieu Moy
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
ay forever, while the SmallProjectsIdeas entries are meant to be
deleted when they are completed.
(Same in other patches)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.o
+|5$
> +-
In the examples above, I read the | as part of the input (unlike $ which
is used only to show the end of line). So the | should not be here. I
don't think you need the $ either, the --count-lines option is no longer
about trailing whitespaces.
> +static const char * cons
Johannes Schindelin writes:
> On Thu, 15 Oct 2015, Matthieu Moy wrote:
>
>> Since the tests are essentially IO-bound and not CPU-bound, it may even
>> make sense to use -j3 here.
>
> I would like to caution against overloading Travis. They are really nice
> to us,
han
performance.
Cheers,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tobias Klauser writes:
> On 2015-10-15 at 18:52:54 +0200, Matthieu Moy
> wrote:
>> Tobias Klauser writes:
>> > +static const char * const usage_msg[] = {
>>
>> Stick the * to usage_msg please.
>
> Just noticed while looking at how other sub-comman
the whole series is now
Reviewed-by: Matthieu Moy
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
y review and/or benchmark).
Sorry we didn't, and thanks to Jerry for the report.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vg
Junio C Hamano writes:
> I personally would suggest whichever order you feel more comfortable
> and less error-prone.
This is a good summary, and I fully agree with it.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe
hat introducing test-strbuf
would be even better.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
etopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
> 470 #endif
> 471 }
>
> And it works:
>
> $ git --version
> git version 2.6.1
> $ git pull
> Already up-to-date.
>
>
>
> Greetings,
>
> Johan
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To
x27;
> -'
> +'"$(printf '\r')"
While we're there, it may be better to have a single "printf ' \t\n\r'"
to avoid the whitespace magic in the source code.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from thi
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> Johannes Schindelin writes:
>>
>>> This is the correct thing to do, really: we already specify LF as
>>> field separator.
>>
>> I'm almost convinced that this is the right thing to do i
locale/XX.po
I would spell the first "in" or "idx" (for "index"), not "ca" (for
"cache"). I think we avoid talking about "the cache" these days even
though the doc sometimes says "cached in the index" (i.e. use "cache" as
to the repository, play
with "git add", "dos2unix" and friends.
4) check that it's OK
5) "git commit"
At stage 4), you really want to see the content of the index, because
your HEAD is still broken.
--
Matthieu Moy
http://www-verimag.imag.fr/~m
Junio C Hamano writes:
> i/ and w/ have been used to denote the "i"ndex and "w"orktree
> versions for the past 7 years with diff.mnemonicprefix option,
> which you may want to match.
Indeed.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe
in this case is to use a
case:
case "$opt" in
-l*)
# ...
;;
*)
# ...
;;
esac
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
corate[=...] decorate options
-L Process line range n,m in file, counting from 1
There are far more options than this...
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; is important, but redundant with the
body of the message.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
"Rainer M. Canavan" writes:
> configure.ac | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Looks all right to me. Thanks for you contribution and for your
patience!
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the l
vileges, please re-run as
> root via sudo.
>
> Is Apple in violation of git’s license by imposing this restriction?
AFAICT, no, see explanations here:
http://permalink.gmane.org/gmane.comp.version-control.git/254890
or search "apple git gpl license violation" in your favorit
ot;$rest"
> - ${SHELL:-@SHELL_PATH@} -c "$rest" # Actual execution
> + "${SHELL:-@SHELL_PATH@}" -c "$rest" # Actual execution
Looks good to me. Don't know why I didn't add these double quotes when I
introduced this line. Tha
Michael J Gruber writes:
> git tip of the day:
>
> git diff --color-words='.'
> git show --color-words='.'
Probably my main usage of --color-words indeed (except I omit the single
quotes ;-) ).
I think this deserves an explicit mention in the doc.
--
Matthie
: Giuseppe Bilotta
Signed-off-by: Paul Mackerras
I'm not fluent enough in Tcl to fix this myself, sorry ;-).
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ot; accept a --bare option, with a different meaning
(read "man git" to find what the first does).
So, I wouldn't call the current behavior a really good one, but it's the
documented behavior.
It would be nice to warn in this case though: I don't see any use for
"git --b
Indeed. I should obviously have started by updating my master branch,
sorry for the noise.
Thanks,
Dennis Kaarsemaker writes:
> Hi Matthieu,
>
> This has been reported quite a few times before. A fix is in master,
> see 482456a^2 and children.
>
> On wo, 2015-11-18 at 19:31 +
Jeff King writes:
> On Wed, Nov 18, 2015 at 10:29:20PM +0100, Matthieu Moy wrote:
>
>> But as you say, options before the command word apply to "git", not to
>> the particular command. The case of --bare is a bit unfortunate: both
>> "git" and "gi
Michael J Gruber writes:
> It's just so useful.
Confirmed-by: Matthieu Moy
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More major
a1, DEFAULT_ABBREV));
>> return 1;
>> }
>
> Yeah, I think parsing left-to-right like this makes things much more
> obvious.
Agreed.
>> +for (end = target; *end && *end != '\n'; end++)
>> +;
>
> This loop (w
>buf,
> find_unique_abbrev(nsha1, DEFAULT_ABBREV));
> - return 1;
> }
> - strbuf_add(&cb->buf, target, end - target);
> return 1;
> }
Indeed, the code is much simpler like this than with the previous
attempts. Loo
ing
.PHONY for targets that are not meant to generate files, and depend on
FORCE where the rule actually generate a file named after its target,
but needs to be re-ran every time it's called.
If you disagree with this, then you need to justify the change in the
commit message.
--
Matthieu Mo
Elia Pinto writes:
> This is the second version of this patch.
> Added the corrections suggested by Matthieu Moy ($gmane/282221)
Sorry, but my main concern was that the patch could not be reviewed in
good conditions as-is, and I think it still cannot be. It's very hard to
spot w
Elia Pinto writes:
> 2015-12-11 15:40 GMT+01:00 Matthieu Moy :
>> Elia Pinto writes:
>>
>>> This is the second version of this patch.
>>> Added the corrections suggested by Matthieu Moy ($gmane/282221)
>>
>> Sorry, but my main concern was th
Elia Pinto writes:
> Add some missing phony target to Makefile.
>
> Signed-off-by: Elia Pinto
> Helped-by: Matthieu Moy
> ---
> This is the third version of this patch.
Thanks. I double-checked with
grep .PHONY Makefile | sed 's/.PHONY: //; s/#.*//' | tr ' &
9ee555 (Check and document the
options to prevent mistakes., 2006-06-21).
The check was _removed_ in Git 2.6.0, which happily accepts your
command. IOW, the bug is already fixed :-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe
ng to save an alias with "Dub O." "Q"
> in the From: header, mutt shortens it to the expected \"Dub O. Q\"
> without extra quotes.
I wouldn't worry too much about corner-cases, but perhaps some people do
use escaped quotes inside escaped quotes. I'd say
Changes are described in CHANGES.
Contributions-by: Matthieu Moy
Contributions-by: William Stewart
Contributions-by: Ville Skyttä
Contributions-by: Dirk Olmes
Contributions-by: Björn Kautler
Contributions-by: Konstantin Ryabitsev
Contributions-by: Gareth Pye
Contributions-by: David Lazar
expect more than just
microprojects).
You may suggest ideas by editting the wiki page, or just by replying to
this email (I'll point my students to the thread). Don't hesitate to
remove entries (or ask me to do so) on the wiki page if you think they
are not relevant anymore.
Thanks in advance,
--
Matthieu Moy
https://matthieu-moy.fr/
format = CMIT_FMT_ONELINE;
> - rev.use_terminator = 1;
> + if (cfg_have_pretty != 0) {
I'd write just "if (cfg_have_pretty)".
> rev.always_show_header = 1;
> +
> cmd_log_init_finish(argc, argv, prefix, &rev, &opt);
Avoid adding unrelated whitespace changes like this one.
Regards,
--
Matthieu Moy
https://matthieu-moy.fr/
x27;
> +
> +
Style: you sometimes leave 2 blank lines, sometimes 1 between tests. Try
to be consistent.
> +test_expect_success 'pull --set-upstream upstream other sets branch other' '
Test title and content say the opposite of each other.
> + git pull --set-upstream
to say "It is OK for the variable to be missing, and
> it also is OK for the variable to have an empty string as its value;
> all other cases are unacceptable",
Actually, I don't think the "present but empty" case makes sense here,
so just test_must_fail git config "$1" should do the trick.
I agree with all other remarks.
--
Matthieu Moy
https://matthieu-moy.fr/
quot;You need to specify excatly one branch with
the set-upstream option."));
?
--
Matthieu Moy
https://matthieu-moy.fr/
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> -u::
>> --set-upstream::
>> For every branch that is up to date or successfully pushed, add
>> upstream (tracking) reference, used by argument-less
>> linkgit:git-pull[1] and other command
not depend on what has
been executed previously. There are several places where you really need
it. It probably makes sense to use it at the start of every tests for
consistency and future-proof-ness.
> +test_expect_success 'fetch --set-upstream http://nosuchdomain.example.com
> fails with the bad url' '
> + test_must_fail git fetch --set-upstream http://nosuchdomain.example.com
> &&
> + check_config master upstream refs/heads/other &&
> + check_config_empty other &&
> + check_config_empty other2
> +'
It would probably make sense to check what happens when running
git fetch --set-upstream
i.e. use a URL instead of a named remote.
--
Matthieu Moy
https://matthieu-moy.fr/
verwrite it.
* If you don't know about precious files, just keep the default setting and
the worse that can happen is to get your file overwritten with a bakup
of the old version kept around.
This would probably play better with a notion of "precious" files than with
a notion of "trashable" files.
--
Matthieu Moy
https://matthieu-moy.fr/
is IMHO less common. It may confuse users.
Or users may learn it and be happy thanks to your message. I don't know.
--
Matthieu Moy
https://matthieu-moy.fr/
push.default, but it
does say so and it's the actual behavior.
> already and widely known?
https://stackoverflow.com/questions/14031970/git-push-current-branch-shortcut
458 votes for the answer suggesting it.
--
Matthieu Moy
https://matthieu-moy.fr/
t;works with
dash" as a heuristic for "should word on any shell", but it doesn't
always work).
If -x doesn't work in some setups, it may be a good reason to wait a bit
before trashing test_path_is_*, but if it's clear enough that the vast
majority of platforms get -x, then why not trash these wrappers indeed.
--
Matthieu Moy
https://matthieu-moy.fr/
ely un-interested way, but
once you start getting the benefits of your own patches in the way _you_
use Git, it's really rewarding !
Cheers,
--
Matthieu Moy
https://matthieu-moy.fr/
801 - 900 of 2167 matches
Mail list logo
