[RFC PATCH 2/3] home_config_path: allow NULL xdg parameter

2014-07-25 Thread Matthieu Moy
This allows a caller to requst the global config file without requesting the XDG one. Signed-off-by: Matthieu Moy matthieu@imag.fr --- This is actually not needed, but I wrote this for a previous version, and it seems sensible anyway. path.c | 10 ++ 1 file changed, 6 insertions

Re: [PATCH v2 3/6] rewrite git_config() to use the config-set API

2014-07-25 Thread Matthieu Moy
this change belong to PATCH 2/6 ? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 5/6] config: add `git_die_config()` to the config-set API

2014-07-25 Thread Matthieu Moy
return config_error_nonbool(key); *dest = xstrdup(value); return 0; - } - else + } else return 1; Useless churn. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git

Re: [RFC PATCH 1/3] config --global --edit: create a template file if needed

2014-07-25 Thread Matthieu Moy
) + die_errno(_(Cannot create configuration file %s), config_file); Other error messages in this file (including those just above this block) begin with a lowercase letter. Applied. Thanks, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from

Re: [PATCH 5/7] enforce `xfuncname` precedence over `funcname`

2014-07-25 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@grenoble-inp.fr writes: Tanay Abhra tanay...@gmail.com writes: On 7/25/2014 2:52 AM, Ramsay Jones wrote: However, I think it you could create a list of pointer to hash-table entry, string-list index pairs in the config_set

Re: [RFC PATCH 1/3] config --global --edit: create a template file if needed

2014-07-25 Thread Matthieu Moy
it. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/3] home_config_path: allow NULL xdg parameter

2014-07-25 Thread Matthieu Moy
This allows a caller to request the global config file without requesting the XDG one. Signed-off-by: Matthieu Moy matthieu@imag.fr --- path.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/path.c b/path.c index 3afcdb4..f68df0c 100644 --- a/path.c +++ b

[PATCH v2 1/3] config --global --edit: create a template file if needed

2014-07-25 Thread Matthieu Moy
contact with Git. Signed-off-by: Matthieu Moy matthieu@imag.fr --- Hopefully, all remarks applied. I went for Git's user configuration, but I can change it to whatever native speakers think is better. builtin/config.c | 31 --- cache.h | 1 + ident.c

[PATCH v2 3/3] commit: advertise config --global --edit on guessed identity

2014-07-25 Thread Matthieu Moy
not trigger in this case. Signed-off-by: Matthieu Moy matthieu@imag.fr --- builtin/commit.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 5ed6036..7502b0e 100644 --- a/builtin/commit.c +++ b

Re: [RFC PATCH 2/3] home_config_path: allow NULL xdg parameter

2014-07-25 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@imag.fr writes: This allows a caller to requst the global config file without requesting the XDG one. Signed-off-by: Matthieu Moy matthieu@imag.fr --- This is actually not needed, but I wrote this for a previous

[PATCH v3 1/3] config --global --edit: create a template file if needed

2014-07-25 Thread Matthieu Moy
contact with Git. Signed-off-by: Matthieu Moy matthieu@imag.fr --- I am not native but I have a slight worry that a template that lists only core.{user,email} and marked as Git's user configuration will easily mislead the reader that the file is only about these two Good point, here's

[PATCH v3 2/3] home_config_paths(): let the caller ignore xdg path

2014-07-25 Thread Matthieu Moy
location. Commit-message-by: Junio C Hamano gits...@pobox.com Signed-off-by: Matthieu Moy matthieu@imag.fr --- path.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/path.c b/path.c index 3afcdb4..f68df0c 100644 --- a/path.c +++ b/path.c @@ -148,10 +148,12 @@ void

[PATCH v3 3/3] commit: advertise config --global --edit on guessed identity

2014-07-25 Thread Matthieu Moy
not trigger in this case. Signed-off-by: Matthieu Moy matthieu@imag.fr --- builtin/commit.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 5ed6036..7502b0e 100644 --- a/builtin/commit.c +++ b

Re: [PATCH v13 0/2] git config cache special querying api utilizing the cache

2014-07-28 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: [v13]: v12 was rejected because of redundant implementation of the new functions, hope this one is okay. It is to me at least. Thanks, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 5/6] config: add `git_die_config()` to the config-set API

2014-07-28 Thread Matthieu Moy
) + die(unable to parse command-line config); + else + die(bad config file line %d in %s,kv_info-linenr, kv_info-filename); Missing space after ,. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: [PATCH v3 5/6] config: add `git_die_config()` to the config-set API

2014-07-28 Thread Matthieu Moy
be straightforward enough. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 4/6] add a test for semantic errors in config files

2014-07-28 Thread Matthieu Moy
and change test_expect_failure to test_expect_success Or putting both in the same patch. I think the series is OK like this, my comment is just to be read as next time, here's how to do better. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line

Re: [PATCH v3 0/6] Rewrite `git_config()` using config-set API

2014-07-28 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: [PATCH V3]:All the suggestions in [3] applied. Built on top of [1]. Except for the minor style fix in PATCH 5, the series looks OK to me. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git

Re: [PATCH v3 4/6] add a test for semantic errors in config files

2014-07-28 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/28/2014 4:52 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: +test_expect_success 'check line errors for malformed values' ' + mv .git/config .git/config.old + test_when_finished mv .git/config.old .git/config + cat .git

Re: [PATCH v2] add documentation for writing config files

2014-07-29 Thread Matthieu Moy
++- Sounds good to me, thanks. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] use a hashmap to make remotes faster

2014-07-29 Thread Matthieu Moy
of remotes? (not an objection, it's a good thing anyway) +static inline void init_remotes_hash() static inline void init_remotes_hash(void) Not a detailed review, but the patch sounds good other than that. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send

Re: [PATCH v4 3/6] rewrite git_config() to use the config-set API

2014-07-29 Thread Matthieu Moy
a changed word, so I didn't flip it and fix after in the series as you said yesterday. Dunno if it's alright. You did right. It's not a new test, but an existing one that needs update together with your code update. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send

Re: [PATCH v4 3/6] rewrite git_config() to use the config-set API

2014-07-29 Thread Matthieu Moy
-value_index = e-value_list.nr; cs-list.nr++; to avoid having to wonder why the - 1 is needed. But I'm OK with the current code. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org

Re: [RFC] GSoC status update (config API improvements)

2014-07-29 Thread Matthieu Moy
:-). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 3/6] rewrite git_config() to use the config-set API

2014-07-29 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/29/2014 6:10 PM, Matthieu Moy wrote: So, I think it's time to make it official that git_config() does not return an error code, and make it return void. I would do that in a patch before the git_config() - git_config_raw() rewrite. My preference

Re: [PATCH v4 0/5] git_config callers rewritten with the new config cache API

2014-07-30 Thread Matthieu Moy
in pu (ta/config-set). I think it semantically needs your other WIP series, that makes git_config_get_* die in case of error. Otherwise, there's an unexpected behavior change in case of error. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line

Re: [PATCH v4 2/5] notes.c: replace `git_config()` with `git_config_get_value_multi()`

2014-07-30 Thread Matthieu Moy
string_list *git_config_get_value_multi_nonbool(const char *key) { git_config_check_init(); return git_configset_get_value_multi_nonbool(the_config_set, key); } (totally untested) BTW, is it intentional that you call config_error_nonbool() without die-ing? -- Matthieu Moy

Re: [PATCH v4 4/5] branch.c: replace `git_config()` with `git_config_get_string()

2014-07-30 Thread Matthieu Moy
void. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/5] notes.c: replace `git_config()` with `git_config_get_value_multi()`

2014-07-30 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/30/2014 7:43 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: - git_config(notes_display_config, load_config_refs); + if (load_config_refs) { + values = git_config_get_value_multi(notes.displayref

Re: [PATCH v4 0/5] git_config callers rewritten with the new config cache API

2014-07-30 Thread Matthieu Moy
a workaround, and to me the point of your GSoC is to make the code cleaner, hence avoid workaraounds ... -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v5 3/7] change `git_config()` return value to void

2014-07-31 Thread Matthieu Moy
that the message can be translated. Not really serious since it's not really meant to be seen by the user, though. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v5 4/7] rewrite git_config() to use the config-set API

2014-07-31 Thread Matthieu Moy
two missing _(...) here. Note that there are missing _(...) in config.c before your patch too. I'll send a patch to fix this regardless of your series. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message

Re: [PATCH 6/7] config: add `git_die_config()` to the config-set API

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: + if (!kv_info-linenr) + die(unable to parse '%s' from command-line config, key); + else + die(bad config variable '%s' at file line %d in %s, And two more missing _(...). -- Matthieu Moy http://www-verimag.imag.fr/~moy

[PATCH] config.c: mark error and warnings strings for translation

2014-07-31 Thread Matthieu Moy
Signed-off-by: Matthieu Moy matthieu@imag.fr --- Noticed while reviewing Tanay's patches, but this one is independant from his series, both syntactically and semantically. config.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/config.c b/config.c

Re: [PATCH v5 3/7] change `git_config()` return value to void

2014-07-31 Thread Matthieu Moy
Matthieu Moy matthieu@grenoble-inp.fr writes: Tanay Abhra tanay...@gmail.com writes: Signed-off-by: Tanay Abhra tanay...@gmail.com I think I deserve a bit of credit here ;-). { -return git_config_with_options(fn, data, NULL, 1); +if (git_config_with_options(fn, data, NULL, 1

Re: [PATCH v4 2/5] notes.c: replace `git_config()` with `git_config_get_value_multi()`

2014-07-31 Thread Matthieu Moy
Matthieu Moy matthieu@grenoble-inp.fr writes: Tanay Abhra tanay...@gmail.com writes: On 7/30/2014 7:43 PM, Matthieu Moy wrote: * if (!values-items[i].string) config_error_nonbool( = This check could be done once and for all in a function, say

Re: [PATCH v5 3/7] change `git_config()` return value to void

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/31/2014 4:52 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: Signed-off-by: Tanay Abhra tanay...@gmail.com I think I deserve a bit of credit here ;-). Yes, but to show credit would I have to write from you or signed-off

Re: [PATCH] config.c: mark error and warnings strings for translation

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/31/2014 5:01 PM, Matthieu Moy wrote: Signed-off-by: Matthieu Moy matthieu@imag.fr --- Noticed while reviewing Tanay's patches, but this one is independant from his series, both syntactically and semantically. config.c | 20

Re: [PATCH v2 1/2] config.c: mark error and warnings strings for translation

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: From: Matthieu Moy matthieu@imag.fr Signed-off-by: Matthieu Moy matthieu@imag.fr --- v2: error messages now start with a small letter. Thanks. Ack on both patches. Is there any reason not to include these two patches in the larger series

Re: [PATCH v6 6/7] config: add `git_die_config()` to the config-set API

2014-07-31 Thread Matthieu Moy
, didn't we agree that it was a good thing to factor this if/then/else into a helper function? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v6 0/7] Rewrite `git_config()` using config-set API

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: [Patch v6]: Added _() to error messages. Diff between v6 and v4 at the bottom. Except for the tiny style issue in PATCH 6, the series is now Reviewed-by: Matthieu Moy matthieu@imag.fr -- Matthieu Moy http://www-verimag.imag.fr/~moy

Re: [PATCH v6 6/7] config: add `git_die_config()` to the config-set API

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/31/2014 9:25 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: +void git_die_config(const char *key) +{ + const struct string_list *values; + struct key_value_info *kv_info; + values = git_config_get_value_multi(key

Re: [PATCH v6 6/7] config: add `git_die_config()` to the config-set API

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/31/2014 10:22 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: On 7/31/2014 9:25 PM, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: +void git_die_config(const char *key) +{ + const struct string_list *values

Re: [PATCH v6 6/7] config: add `git_die_config()` to the config-set API

2014-07-31 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: On 7/31/2014 11:39 PM, Matthieu Moy wrote: This is the part I find weird. You're calling git_die_config_exact() on the first boggus value, and git_die_config_exact() will notify an error at the line of the last boggus value. Hmn, we may have some

Re: [PATCH v6 6/7] config: add `git_die_config()` to the config-set API

2014-08-01 Thread Matthieu Moy
, it could show all the errors, but it's also reasonable to die() at the first one. The simplest behavior to implement is to die() at the first error. (currently, git _segfaults_ at the first NULL value for notes.displayref, so it can't be much worse) -- Matthieu Moy http://www-verimag.imag.fr/~moy

Re: [PATCH v6 6/7] config: add `git_die_config()` to the config-set API

2014-08-01 Thread Matthieu Moy
].string); } The same helper could at least be used for branch.remote.merge. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v7 2/8] config.c: fix accuracy of line number in errors

2014-08-04 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: From: Matthieu Moy matthieu@grenoble-inp.fr I usually use my @imag.fr, not @grenoble-inp.fr address as Git author (even though my mailer has @grenoble-inp.fr as From: field). Both addresses are equivalent so it's no big deal. -- Matthieu Moy http

Re: [PATCH v7 0/8] Rewrite `git_config()` using config-set API

2014-08-04 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: [Patch v7]: style nit corrected. (1/8) is Matthieu's translation patch. git_die_config_linenr() helper function added. Diff between v6 and v7 appended for review. This series is now Reviewed-by: Matthieu Moy matthieu@imag.fr Thanks

Re: [PATCH RFC v2 05/19] rebase -i: Implement reword in terms of do_pick

2014-08-04 Thread Matthieu Moy
patch. My reaction reading the previous patch was Uh, why duplicate code?, and reading this one Ah, that's OK. A single patch doing both would have avoided the confusion. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: [PATCH] pretty.c: make git_pretty_formats_config return -1 on git_config_string failure

2014-08-04 Thread Matthieu Moy
-name = xstrdup(name); commit_format-format = CMIT_FMT_USERFORMAT; - git_config_string(fmt, var, value); + if (git_config_string(fmt, var, value)) + return -1; + Ack-ed-by: Matthieu Moy matthieu@imag.fr My first thought reading this was why not rewrite using non

Re: [PATCH] pretty.c: make git_pretty_formats_config return -1 on git_config_string failure

2014-08-04 Thread Matthieu Moy
Eric Sunshine sunsh...@sunshineco.com writes: On Mon, Aug 4, 2014 at 11:45 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Tanay Abhra tanay...@gmail.com writes: `git_pretty_formats_config()` continues without checking git_config_string's return value which can lead to a SEGFAULT

Re: [PATCH v7 5/8] config: add `git_die_config()` to the config-set API

2014-08-04 Thread Matthieu Moy
good quality messages is not a high priority IMHO, but having a good API that as a side effect can produce good error messages is important. If changing the error messages requires rewritting all callers later, then we've missed the point doing the refactoring now. -- Matthieu Moy http://www

Re: [PATCH 01/11] daemon.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-04 Thread Matthieu Moy
whitespace-only change like this one. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/11] pager.c: replace `git_config()` with `git_config_get_value()`

2014-08-04 Thread Matthieu Moy
); + } + } + strbuf_release(key); + return want; } I first wondered why you were not using git_config_get_maybe_bool(), but you want to interpret non-boolean values as command-names, so you do need this two-steps get_value - maybe_bool. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe

Re: [PATCH 07/11] builtin/gc.c: replace `git_config()` with `git_config_get_*()` family

2014-08-04 Thread Matthieu Moy
where the API looks suboptimal, see Junio's remark in the other thread. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 00/11] git_config callers rewritten with the new config-set API

2014-08-04 Thread Matthieu Moy
probably need a second look to double check. Tanay: I suggest you keep this as one 11-patches series. If you rewrite more callsites, I'd find it easier to review as a second, independant series rather than an ever-growing single series. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe

Re: [PATCH] pretty.c: make git_pretty_formats_config return -1 on git_config_string failure

2014-08-04 Thread Matthieu Moy
Jeff King p...@peff.net writes: On Mon, Aug 04, 2014 at 05:45:44PM +0200, Matthieu Moy wrote: Tanay Abhra tanay...@gmail.com writes: `git_pretty_formats_config()` continues without checking git_config_string's return value which can lead to a SEGFAULT. Indeed, without the patch

Re: [PATCH v7 5/8] config: add `git_die_config()` to the config-set API

2014-08-05 Thread Matthieu Moy
'core.frotz' at file line 15 in .git/config That seems to be a good step forward. I think we would also want to improve the error message, but that shouldn't block your series from inclusion: we can do that later without API change. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe

Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API

2014-08-06 Thread Matthieu Moy
config.c? Or is it a leftover from a previous experiment? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 8/8] add tests for `git_config_get_string_const()`

2014-08-06 Thread Matthieu Moy
). I don't think you need these two alternatives OTOH. BTW, Junio, I don't understand your remark This test is too tight (the full string) in the previous iteration. Can you elaborate? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git

Re: [PATCH 02/11] http-backend.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-06 Thread Matthieu Moy
to the right element of rpc_service[i]. So in both cases, you'll assign rpc_service[index of service].enabled = last occurence of variable http.service even though the order of assignments will change. Eric, am I interpreting right? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe

Re: Doing a git add '' will add more files then expected

2014-11-17 Thread Matthieu Moy
Andreas Schwab sch...@linux-m68k.org writes: The argument to git add is a pathspec, and the empty pathspec matches all files. Err, why does the empty pathspec match all files? Isn't that a bug? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line

Re: Our cumbersome mailing list workflow

2014-11-27 Thread Matthieu Moy
only another ... -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] introduce git root

2014-11-30 Thread Matthieu Moy
. Also, there are other options of git rev-parse which should be dealt with: at least --show-cdup (could be eg. git root --relative) and --show-prefix, but probably also others from the Options for Files in the man of git-rev-parse. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe

Re: [PATCH] introduce git root

2014-12-04 Thread Matthieu Moy
. Not sure it's worth the trouble of changing the existing git --*-path, but I think git var should be the place for new things. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/1] Documentation: config: typo fixed

2014-12-18 Thread Matthieu Moy
are both correct. The convention used elsewhere in the documentation is CamelCasing, so the old version seems better to me. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: Fwd: [BUG] dos2unix converts french accents to NULL char

2015-02-04 Thread Matthieu Moy
(which includes Git plus some programs from MinGW). You have better chance of getting an answer on the mailing list of this distribution: http://groups.google.com/group/msysgit -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: Advice on edits to git-rebase man page

2015-02-05 Thread Matthieu Moy
does not technically have to be a branch. But both are far better than what we have IMHO. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Advice on edits to git-rebase man page

2015-02-05 Thread Matthieu Moy
bar, and now want to rebase my work on top of origin/boz. My 2 cents, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Matthieu Moy
everything if you want to report a bug. I understand that for a few users, the size of executable matters. But this category of users should be able to find the strip target or something equivalent. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line

Re: Gmail Message rejection

2015-02-10 Thread Matthieu Moy
Stefan Beller stefanbel...@gmail.com writes: If you want email to send via gmail, you can do so by enabling text only mode for sending mails. Unfortunately, it is also a known bug that the Android Gmail client doesn't have this option (or didn't last time I checked). -- Matthieu Moy http

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-18 Thread Matthieu Moy
one having the issue? Can you give more info on your system (OS version client and server side, ...)? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-16 Thread Matthieu Moy
in the binary. This is the kind of thing I meant by investigate alternate solutions. I have no AFP share to test, so it would help if you answered the question I asked in my previous message: On Feb 17, 2015, at 2:23 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Fairuzan Roslan fairuzan.ros

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-16 Thread Matthieu Moy
think the problem shouldn't be fixed, but I'd rather investigate alternate solutions before using this mode = 0644. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info

Re: Git GSoC 2015

2015-02-18 Thread Matthieu Moy
dropping non-spammy candidates: selecting on the quality of interaction during microproject is better than judging only on resume+proposal. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-18 Thread Matthieu Moy
. essentially everywhere. That way, people on well behaving systems do not have to worry about clobbering errno and stuff, perhaps? With my solution, unlink() is always the last call in the function, so it should behave correctly right? Or did I miss anything? -- Matthieu Moy http://www

Re: [RFH] GSoC 2015 application

2015-02-19 Thread Matthieu Moy
: Matthieu Moy matthieu@imag.fr Date: Thu, 19 Feb 2015 10:48:06 +0100 Subject: [PATCH] 2015 microproject ideas --- SoC-2015-Microprojects.md | 42 ++ 1 file changed, 42 insertions(+) diff --git a/SoC-2015-Microprojects.md b/SoC-2015-Microprojects.md index

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-17 Thread Matthieu Moy
?. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] Documentation/git-am.txt: mention mailinfo.scissors config variable

2015-02-20 Thread Matthieu Moy
It was already documented, but the user had to follow the link to git-mailinfo.txt to find it. Signed-off-by: Matthieu Moy matthieu@imag.fr --- Documentation/git-am.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt

[PATCH v2 1/2] Documentation/config.txt: document mailinfo.scissor

2015-02-20 Thread Matthieu Moy
it). Signed-off-by: Matthieu Moy matthieu@imag.fr --- Changes since v1 for both patches : typos noted by Peff. Documentation/config.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index ae6791d..15f8695 100644 --- a/Documentation

[PATCH 2/3] GSoC ideas: git bisect fixed/unfixed

2015-02-20 Thread Matthieu Moy
Signed-off-by: Matthieu Moy matthieu@imag.fr --- SoC-2015-Ideas.md | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/SoC-2015-Ideas.md b/SoC-2015-Ideas.md index a3e988e..4641800 100644 --- a/SoC-2015-Ideas.md +++ b/SoC-2015

[PATCH 3/3] idea: Be nicer to the user on tracked/untracked merge conflicts

2015-02-20 Thread Matthieu Moy
Signed-off-by: Matthieu Moy matthieu@imag.fr --- SoC-2015-Ideas.md | 27 +++ 1 file changed, 27 insertions(+) diff --git a/SoC-2015-Ideas.md b/SoC-2015-Ideas.md index 4641800..86de476 100644 --- a/SoC-2015-Ideas.md +++ b/SoC-2015-Ideas.md @@ -117,3 +117,30 @@ Cf

[PATCH 1/3] microprojects: tweaks after discussion with Peff

2015-02-20 Thread Matthieu Moy
Signed-off-by: Matthieu Moy matthieu@imag.fr --- SoC-2015-Microprojects.md | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/SoC-2015-Microprojects.md b/SoC-2015-Microprojects.md index e49cb07..c6123bb 100644 --- a/SoC-2015-Microprojects.md +++ b/SoC-2015

Re: [RFH] GSoC 2015 application

2015-02-20 Thread Matthieu Moy
not just one answer to the question. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-20 Thread Matthieu Moy
brian m. carlson sand...@crustytoothpaste.net writes: On Tue, Feb 17, 2015 at 09:51:38AM +0100, Matthieu Moy wrote: This should be fixable from Git itself, by replacing the calls to unlink with something like int unlink_or_chmod(...) { if (unlink(...)) { chmod

Re: [RFH] GSoC 2015 application

2015-02-20 Thread Matthieu Moy
so explicitely in http://git.github.io/SoC-2015-Ideas.html so that students looking for organization know that we'll have very few slots. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [RFH] GSoC 2015 application

2015-02-20 Thread Matthieu Moy
for them ;-). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] Documentation/config.txt: document mailinfo.scissor

2015-02-20 Thread Matthieu Moy
it). Signed-off-by: Matthieu Moy matthieu@imag.fr --- Documentation/config.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index ae6791d..4a2a078 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -1740,6

[PATCH 2/2] Documentation/git-am.txt: mention mailinfo.scissor config variable

2015-02-20 Thread Matthieu Moy
It was already documented, but the user had to follow the link to git-mailinfo.txt to find it. Signed-off-by: Matthieu Moy matthieu@imag.fr --- This one may be more controversial. I think it makes sense to apply it, but I won't fight for it if you think it adds too much noise to the doc

Re: [ANNOUNCE] Git Merge, April 8-9, Paris

2015-02-20 Thread Matthieu Moy
Yi EungJun semtlen...@gmail.com writes: I heard Git Contributors Summit is scheduled on April 8th at Git Merge 2015. Does anyone know the agenda of the summit? I am considering to attend the summit. It's all online now: http://git-merge.com/ -- Matthieu Moy http://www-verimag.imag.fr

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-18 Thread Matthieu Moy
is not a Mac OS, it doesn't have the uchg flag, and maps it to the w bit in the POSIX permission system (this is pure speculation from me). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: How to prevent empty git commit --amend

2015-01-14 Thread Matthieu Moy
commit --amend should do it. You can alias it like [alias] amend = !git diff --staged --quiet || git commit --amend and then use git amend. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH v2] standardize usage info string format

2015-01-14 Thread Matthieu Moy
-in-the-blank parameters - Putting dashes in multiword parameter names - Adding spaces to [-f|--foobar] to make [-f | --foobar] - Replacing foobar* with [foobar...] I had a closer look and found it all good. Reviewed-by: Matthieu Moy matthieu@imag.fr Thanks! -- Matthieu Moy http://www

Re: How to prevent empty git commit --amend

2015-01-14 Thread Matthieu Moy
Ivo Anjo ivo.a...@ist.utl.pt writes: Hello, On Wed, Jan 14, 2015 at 10:00 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: [alias] amend = !git diff --staged --quiet || git commit --amend and then use git amend. Genius! This is exactly what I wanted, thanks! You probably

Re: Gmail Message rejection

2015-02-11 Thread Matthieu Moy
Stefan Beller stefanbel...@gmail.com writes: Trying to send from an Android Gmail client. Though the option was called answer inline. ... and still sends multipart text/html message, sorry. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line

Re: [ANNOUNCE] Git Merge, April 8-9, Paris

2015-02-16 Thread Matthieu Moy
) developers to meet and talk to each other. A naive question: will there be subscription fees? If so, can you give an order of magnitude? Thanks, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

[PATCH] git-completion: add --autostash for 'git rebase'

2015-01-07 Thread Matthieu Moy
This option was added in 587947750bd73544 (not to be confused with --autosquash). Signed-off-by: Matthieu Moy matthieu@imag.fr --- contrib/completion/git-completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git

Re: [PATCH] standardize usage info string format

2015-01-08 Thread Matthieu Moy
having one patch per item in this list (not sure splitting the series now is worth the trouble though). I went quickly through the patch and didn't find any issue. I do support the style standardization effort. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send

Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

2015-03-18 Thread Matthieu Moy
they document. Paul Tan pyoka...@gmail.com writes: +Credential storage will per default Not a native, but per default sounds weird and by default seems far more common. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: [PATCH v4 4/4] t0302: test credential-store support for XDG_CONFIG_HOME

2015-03-18 Thread Matthieu Moy
and home files' ' Double blank line. On overall, except the broken -chain above, the whole series looks good. Feel free to ignore my other nitpicks if you prefer. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body

<    5   6   7   8   9   10   11   12   13   14   >