GSoC Project | Improvise git bisect

Hey everyone! I am Pranit Bauva. I am studying Mining Engineering at IIT Kharagpur. I am interested in participating in Google Summer of Code under Git organization. I have attempted a micro-project to add configuration to commonly used command line options `git commit -v` ($gmane/288820). I am

Re: [PATCH] read-cache: increase write buffer size

On Sat, Mar 19, 2016 at 1:35 PM, Torsten Bögershausen wrote: > On 2016-03-19 02.19, David Turner wrote: >> Each write() has syscall overhead, and writing a large index entails >> many such calls. A larger write buffer reduces the overhead, >> leading to increased performance. >>

Re: [PATCH v8 1/2] parse-options.c: make OPTION__COUNTUP consider negative values

On Sat, Mar 19, 2016 at 4:29 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> The reason to make it consider negative values or more specifically >> "unspecified" values is to give the ability to diff

[PATCH v8 1/2] parse-options.c: make OPTION__COUNTUP consider negative values

v -v` => verbose = 2 `git commit --no-verbose` => verbose = 0 Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The discussion about this patch: [1] : http://thread.gmane.org/gmane.comp.version-control.git/289027 Previous version of the patch: [v1] : http://thread.gmane.org/gm

Re: parse-options does not recognize "unspecified" behavior

On Thu, Mar 17, 2016 at 2:19 AM, Jeff King <p...@peff.net> wrote: > On Thu, Mar 17, 2016 at 01:21:49AM +0530, Pranit Bauva wrote: > >> I noticed that parse-options does not recognize the variable which is >> set to -1 so as to denote the "unspecified" value. >

parse-options does not recognize "unspecified" behavior

Hey! I noticed that parse-options does not recognize the variable which is set to -1 so as to denote the "unspecified" value. I did the following changes in builtin/commit.c (in master branch not the patch I am working on) : - static int verbose = -1 - introduced a printf statement after

Re: [PATCH v7] commit: add a commit.verbose config variable

will react as this cannot be known by intuition. This would complicate things for the user who is reading the man pages. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] t/t7502 : drop duplicate test

The older version of this patch : - [v1] http://thread.gmane.org/gmane.comp.version-control.git/288662 The changes between the patches : - Improved the language construct of the commit message - Provided more details about the cited commit in the commit message Regards, Pranit Bauva IIT

Re: Feature request: config option for default git commit -v

t maintainer. The latest revision of the patch is at http://thread.gmane.org/gmane.comp.version-control.git/288820 Thanks, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v12 3/5] parse-options.c: make OPTION_COUNTUP respect "unspecified" values

On Mon, Apr 4, 2016 at 4:40 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> The reason to make it respect "unspecified" values is to give the >> ability to differentia

Re: [PATCH v12 2/5] test-parse-options: print quiet as integer

[+cc:Duy Nguyen, Jonathan Nieder] On Mon, Apr 4, 2016 at 3:00 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Current implementation of parse-options.c treats OPT__QUIET() as integer >&g

Re: [PATCH v12 4/5] t7507-commit-verbose: improve test coverage by testing number of diffs

On Mon, Apr 4, 2016 at 5:32 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Make the fake "editor" store output of grep in a file so that we can >> see how many diffs were

Re: [PATCH v12 5/5] commit: add a commit.verbose config variable

On Tue, Apr 5, 2016 at 4:59 AM, Eric Sunshine wrote: > On Sun, Apr 3, 2016 at 8:58 PM, Eric Sunshine wrote: >> The fact that the 32 new tests are nearly identical suggests strongly >> that the testing should instead either be table-driven or be

Re: [PATCH v14 6/6] commit: add a commit.verbose config variable

On Wed, Apr 13, 2016 at 11:44 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > >> +test_expect_success 'status does not verbose without --verbose' ' >> + git status >actual

Re: [PATCH v14 4/6] parse-options.c: make OPTION_COUNTUP respect "unspecified" values

On Wed, Apr 13, 2016 at 11:26 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> OPT_COUNTUP() merely increments the counter upon --option, and resets it >> to 0 up

Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

On Wed, Apr 13, 2016 at 10:56 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Include tests to check for multiple levels of quiet and to check if the >> '--no-quiet' option set

Re: [PATCH v14 5/6] t7507-commit-verbose: improve test coverage by testing number of diffs

On Wed, Apr 13, 2016 at 11:33 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Make the fake "editor" store output of grep in a file so that we can >> see how many diffs were

Re: [PATCH v13 6/6] commit: add a commit.verbose config variable

On Wed, Apr 13, 2016 at 2:54 AM, Junio C Hamano wrote: > Hmph, isn't this already in 'next', hence we cannot accept a > replacement patch? Yes, this is already in 'next'. This was going to be merged in the third cycle after 2.8 but on my request, you delayed it. So this is an

Re: [PATCH v13 2/6] test-parse-options: print quiet as integer

On Wed, Apr 13, 2016 at 3:03 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> Current implementation of parse-options.c treats OPT__QUIET() as integer >> and not boolean and thus it is more appropriate to print it as

[PATCH v14 1/6] t0040-test-parse-options.sh: fix style issues

Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Changes wrt previous version (v12): - Use '\' when interpolation isn't required --- t/t0040-parse-options.sh | 76 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/t

[PATCH v14 5/6] t7507-commit-verbose: improve test coverage by testing number of diffs

and also helps in maintaining the consistency. Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Previous version of this patch: - [v12] : $gmane/288820 - [v11] : $gmane/288820 - [v10]: $gmane/288820 Changes this version w

[PATCH v14 3/6] t0040-parse-options: improve test coverage

Include tests to check for multiple levels of quiet and to check if the '--no-quiet' option sets it to 0. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- t/t0040-parse-options.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/t/t0040

Re: [PATCH v13 6/6] commit: add a commit.verbose config variable

On Wed, Apr 13, 2016 at 3:48 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Junio C Hamano writes: >> >>> Hmph, isn't this already in 'next', hence we cannot accept a >>> replacement patch? >> >> As a one-time measure, I'll

[PATCH v14 6/6] commit: add a commit.verbose config variable

Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The previous ve

[PATCH v14 4/6] parse-options.c: make OPTION_COUNTUP respect "unspecified" values

will test the new behavior with all sets of values. Helped-by: Jeff King <p...@peff.net> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Junio C Hamano <gits...@pobox.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The discussion about this patch: [1]

[PATCH v14 2/6] test-parse-options: print quiet as integer

We would want to see how multiple --quiet options affect the value of the underlying variable (we may want "--quiet --quiet" to still be 1, or we may want to see the value incremented to 2). Show the value as integer to allow us to inspect it. Signed-off-by: Pranit Bauva <pranit.ba

[PATCH v13 3/6] t0040-parse-options: improve test coverage

Include tests to check for multiple levels of quiet and to check if the '--no-quiet' option sets it to 0. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- t/t0040-parse-options.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/t/t0040

[PATCH v13 6/6] commit: add a commit.verbose config variable

Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The previous ve

[PATCH v13 5/6] t7507-commit-verbose: improve test coverage by testing number of diffs

elped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Previous version of this patch: - [v12] : $gmane/288820 - [v11] : $gmane/288820 - [v10]: $gmane/288820 Changes this version wrt previous one: Change the commit message as suggested b

[PATCH v13 4/6] parse-options.c: make OPTION_COUNTUP respect "unspecified" values

will test the new behavior with all sets of values. Helped-by: Jeff King <p...@peff.net> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Junio C Hamano <gits...@pobox.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The discussion about this patch: [1]

[PATCH v13 1/6] t0040-test-parse-options.sh: fix style issues

Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Changes wrt previous version (v12): - Use '\' when interpolation isn't required --- t/t0040-parse-options.sh | 76 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/t

[PATCH v13 2/6] test-parse-options: print quiet as integer

Current implementation of parse-options.c treats OPT__QUIET() as integer and not boolean and thus it is more appropriate to print it as integer to avoid confusion. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- t/t0040-parse-options.sh | 26 +- test

Re: What's cooking in git.git (Apr 2016, #03; Thu, 7)

On Fri, Apr 8, 2016 at 12:31 AM, Junio C Hamano wrote: > Here are the topics that have been cooking. Commits prefixed with > '-' are only in 'pu' (proposed updates) while commits prefixed with > '+' are in 'next'. The ones marked with '.' do not appear in any of > the

Re: [PATCH/RFC] parse-options.c: make OPTION__COUNTUP consider negative values

Sorry for a little late reply. I was under the impression that I had replied before. On Thu, Mar 17, 2016 at 7:20 AM, Jeff King wrote: > That aside, this patch does mean that one can no longer use > OPT_COUNTUP() for negative values (i.e., the caller must start it at > either 0

Re: parse-options does not recognize "unspecified" behavior

On Thu, Mar 17, 2016 at 2:53 AM, Jeff King wrote: > I don't think that would produce the wrong behavior, but it seems like a > very complicated solution to a problem that can easily be solved by just > following the usual conventions (that verbose starts at 0, options make > it go

Re: GSoC Project | Improvise git bisect

^^^^ >> >> "Improve" I guess. >> >> Pranit Bauva <pranit.ba...@gmail.com> writes: >> >>> Hey everyone! >> >> Hi, >> >>> What I understood is that let's say the repository is like : >>> >

Re: parse-options does not recognize "unspecified" behavior

te '--verbose'), but I don't want to > squeeze even more into a GSOC micro project. Its perfectly fine. It hardly a half an hour job. Though I like the idea that we should use both "-v|--verbose" and "--show-diff" instead of deprecating it. Plus, this edit would not be requ

Re: "git tag --contains " is too chatty, if is invalid

On Sat, Mar 19, 2016 at 10:19 PM, Chirayu Desai wrote: > Hi, I want to work on this as my GSoC micro project. > >> On Mon, Jan 18, 2016 at 10:24:31PM +0100, Toralf Förster wrote: >> > very first line is "error: malformed object name " which tells all, or >> > ? >> Yeah,

Re: GSoC Project | Improvise git bisect

On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Pranit, > > On Sun, 20 Mar 2016, Pranit Bauva wrote: > >> I could first move individual functions to bisect--helper.c. > > My suggestion would be to give it a try already

Re: GSoC Project | Improvise git bisect

On Sun, Mar 20, 2016 at 3:35 AM, Stefan Beller wrote: > Once upon a time, a discussion produced this proposal[1], > which tries to split up the set as good as possible (50:50) instead > of inspecting the branch/merging structure of the underlying graph. > Thanks! This

Re: [PATCH/RFC] parse-options.c: make OPTION__COUNTUP consider negative values

bit painful, as almost nobody uses COUNTUP > directly, so we'd need OPT__VERBOSE_DEFAULT(). This is quite new to me. It took me some time to digest it. > Which in the end is the same as ignoring the problem in the first place, > but there is a big difference between not thinkin

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Fri, Mar 18, 2016 at 5:19 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. >&g

Re: GSoC Project | Improvise git bisect

The project Idea: Incremental Rewrite from shell to C of git-bisect.sh The plan: - Place bisect.c in builtin/ - Implement a skeletal cmd_bisect() which will redirect to git-bisect.sh (1e1ea69f) - Introduce a structure for parsing the command line flags. - Start converting individual

Re: [RFC] Code reorgnization

On Fri, Mar 18, 2016 at 12:40 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> For now I would just go with 3 directories: >> >> non-git/ (or util, helpers, or anything that could be ripped out and be >> useful >> e.g. strbufs, argv-array

Re: [PATCH 00/16] git bisect improvements

On Tue, Mar 22, 2016 at 3:52 AM, Stephan Beyer <s-be...@gmx.net> wrote: >> If it is okay with you then can I work more upon these >> patches in my GSoC project. > > I'm totally fine with that, of course. :) Thanks! :) I will try and fix the left over bug if time persists

[PATCH] bisect--helper: convert a function in shell to C

Convert the code literally without changing its design even though it seems that its obscure as to the use of comparing revision to different bisect arguments which seems like a problem in shell because of the way function arguments are handled. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.

Re: [PATCH] bisect--helper: convert a function in shell to C

On Tue, Mar 22, 2016 at 11:40 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Tue, Mar 22, 2016 at 1:28 AM, Stefan Beller <sbel...@google.com> wrote: >> On Mon, Mar 21, 2016 at 12:00 PM, Pranit Bauva <pranit.ba...@gmail.com> >> wrote: >>> C

Re: [PATCH] bisect--helper: convert a function in shell to C

On Tue, Mar 22, 2016 at 5:58 AM, Stefan Beller <sbel...@google.com> wrote: > On Mon, Mar 21, 2016 at 12:00 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Convert the code literally without changing its design even though it >> seems that its obscure as to th

[PATCH v2] bisect--helper: convert a function in shell to C

now because it is not really be meant to be used like this and this is just for testing purposes whether this new method is as functional as its counter part. The shell counter part of the method has been retained for historical purposes. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.

Re: [PATCH v2] bisect--helper: convert a function in shell to C

On Tue, Mar 22, 2016 at 9:33 PM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> static int one_of(const char *term, ...) >> { >> va_list matches; >> const char *match; >> >> va_start(matches, term); >> while ((match

Re: [PATCH v2] bisect--helper: convert a function in shell to C

On Tue, Mar 22, 2016 at 8:39 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi, > > On Tue, 22 Mar 2016, Pranit Bauva wrote: > >> Convert the code literally without changing its design even though it >> seems that its obscure as to the use of compari

Re: [PATCH v2] bisect--helper: convert a function in shell to C

On Tue, Mar 22, 2016 at 8:41 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi, > > On Tue, 22 Mar 2016, Johannes Schindelin wrote: > >> On Tue, 22 Mar 2016, Pranit Bauva wrote: >> >> > + if (!strcmp(term, "bad") || !strcmp(term,

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

On Thu, Mar 24, 2016 at 12:49 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >> ... >>> Alternatively

Re: [PATCH v3] bisect--helper: convert a function in shell to C

On Wed, Mar 23, 2016 at 9:54 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> On Wed, Mar 23, 2016 at 5:27 PM, Johannes Schindelin >> <johannes.schinde...@gmx.de> wrote: >>> Hi Pranit, &g

Re: [PATCH v3] bisect--helper: convert a function in shell to C

On Wed, Mar 23, 2016 at 9:45 PM, Junio C Hamano wrote: > Johannes Schindelin writes: > >>> +if (one_of(term, "help", "start", "skip", "next", "reset", "visualize", >>> +"replay", "log", "run", NULL)) >> >> If I understood Junio

GSoC 2016 | Proposal | Incremental Rewrite of git bisect

: --- Incremental rewrite of Git bisect About Me Basic Information Name Pranit Bauva University IIT Kharagpur MajorMining Engineering Emailpranit.ba...@gmail.com IRC pungi-man

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

which reinitialises it to 0 or positive depending on the situation will solve the problem. On Thu, Mar 24, 2016 at 3:52 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > On Thu, Mar 24, 2016 at 3:34 PM, SZEDER Gábor <sze...@ira.uka.de> wrote: >>> Add commit.verbos

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

ne <sunsh...@sunshineco.com> >> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> >> >> --- >> The previous version of the patch are: >> - [v8] $gmane/288820 >> - [v7] $gmane/288820 >> - [v6] $gmane/288728 >> - [v5] $gmane/2887

Re: [PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

> >> Eg. : >> initialize verbose = -1 >> `git commit` => verbose = -1 >> `git commit -v` => verbose = 1 >> `git commit -v -v` => verbose = 2 >> `git commit --no-verbose` => verbose = 0 >> >> Signed-off-by: Pranit Bauva <

Re: [PATCH v9 2/3] t7507-commit-verbose: make test suite use write_script

On Fri, Mar 25, 2016 at 11:54 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Fri, Mar 25, 2016 at 2:06 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Fri, Mar 25, 2016 at 5:27 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>> A

Re: [GSoC] Proposal

Some developers are already working on that[1]. [1]: http://thread.gmane.org/gmane.comp.version-control.git/288306 On Fri, Mar 25, 2016 at 10:12 AM, 惠轶群 wrote: > There is an interesting idea as an idea for GSoC of 2008, is it still > proposable? > >

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

On Fri, Mar 25, 2016 at 5:35 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Thu, Mar 24, 2016 at 4:25 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. &

Re: [PATCH v9 2/3] t7507-commit-verbose: make test suite use write_script

On Fri, Mar 25, 2016 at 5:27 AM, Eric Sunshine wrote: > On Thu, Mar 24, 2016 at 7:00 AM, SZEDER Gábor wrote: >>> Also remove test_set_editor from global scope and use it in whichever >>> test it is required. >> >> Why? >> >> test_set_editor sets and

Re: GSoC 2016 | Proposal | Incremental Rewrite of git bisect

On Fri, Mar 25, 2016 at 2:45 PM, Matthieu Moy <matthieu@grenoble-inp.fr> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> On Thu, Mar 24, 2016 at 12:27 AM, Pranit Bauva <pranit.ba...@gmail.com> >> wrote: >> >&g

Re: GSoC 2016 | Proposal | Incremental Rewrite of git bisect

On Fri, Mar 25, 2016 at 2:32 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Mar 24, 2016 at 12:27 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Hey! >> >> I have prepared a proposal for Google Summer of Code 2016. I know this >> is

Re: GSoC 2016 | Proposal | Incremental Rewrite of git bisect

On Fri, Mar 25, 2016 at 5:10 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Fri, Mar 25, 2016 at 11:15 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >>> - you will add an option to "git bisect--helper" to perform what the >>> git-bisect

Re: GSoC 2016 | Proposal | Incremental Rewrite of git bisect

out that it would be much better to use the existing test suite rather than creating one which can lead to less coverage. Thanks, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] api-parse-options.txt: document OPT_CMDMODE()

On Thu, Mar 24, 2016 at 9:37 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> OPT_CMDMODE() was introduced in the release of 1.8.5 which makes the use >> of subcommands in the form of arguments a lot cleaner a

Re: [PATCH/GSoC 3/3] Nousage message in error

On Thu, Mar 24, 2016 at 9:53 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> A general convention followed by git users it to write the commit >> message as "What he did to the code?" rather tha

Re: [PATCH] api-parse-options.txt: document OPT_CMDMODE()

On Thu, Mar 24, 2016 at 10:46 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >>>> +`OPT_CMDMODE(short, long, _var, description, enum_val)`:: >>>> + Introduce an option for subcommand

Re: parse-options does not recognize "unspecified" behavior

> Deprecating doesn't mean "removing". It merely means that we add a note > to the documentation stating that the option in question is deprecated, > but we will keep supporting it for several years and releases to come. Okay. Didn't know. > This means that '--verbose' and '--show-diff' must

Re: [PATCH v9 2/3] t7507-commit-verbose: make test suite use write_script

On Fri, Mar 25, 2016 at 8:16 PM, SZEDER Gábor wrote: > By redirecting grep's output to a file in the editor script, like this > patch wanted to, we can count the lines in the test script itself after > 'git commit' finished. This way we could use test_line_count, with > all

Re: [PATCH v9 2/3] t7507-commit-verbose: make test suite use write_script

On Fri, Mar 25, 2016 at 10:34 PM, Eric Sunshine wrote: > That works too, simplifying the overall implementation, and > eliminating the need for the introductory patch which moves > 'test_set_editor' into each test. Wouldn't it be cleaner if the introductory patch

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sun, Mar 20, 2016 at 7:05 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>&

Re: [PATCH 00/16] git bisect improvements

this. Regards, Pranit Bauva On Fri, Feb 26, 2016 at 7:34 AM, Stephan Beyer <s-be...@gmx.net> wrote: > Hi, > > this set of patches provides improvements for git bisect. > > Quick summary of changes > - relevant for users: >- `git bisect next` is documented and

Re: GSoC Project | Improvise git bisect

I didn't mention it before, I was thinking to move directly everything from git-bisect.sh to bisect.c . But then I would have to redirect to a shell script. And ultimately remove bisect--helper.c Your suggestions is a lot better. I could first move individual functions to bisect--helper.c. This

Re: GSoC Project | Improvise git bisect

On Mon, Mar 21, 2016 at 11:23 PM, Christian Couder <christian.cou...@gmail.com> wrote: > Hi Pranit, > > On Mon, Mar 21, 2016 at 8:29 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin >> <johannes.sch

Re: [PATCH v2] api-parse-options.txt: document OPT_CMDMODE()

I have used bits from your email. I forgot to add "Helped-by: Junio C Hamano <gits...@pobox.com>" . Could you squash it in? On Sat, Mar 26, 2016 at 12:28 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > OPT_CMDMODE mechanism was introduced in the release of 1.8.5

[PATCH v3] api-parse-options.txt: document OPT_CMDMODE()

OPT_CMDMODE mechanism was introduced in the release of 1.8.5 to actively notice when multiple "operation mode" options that specify mutually incompatible operation modes are given. Helped-by: Junio C Hamano <gits...@pobox.com> Signed-off-by: Pranit Bauva <pra

Re: [GSoC] A late proposal: a modern send-email

On Sat, Mar 26, 2016 at 7:43 AM, 惠轶群 wrote: > 2016-03-26 2:16 GMT+08:00 Junio C Hamano : >> 惠轶群 writes: >> >>> # Purpose >>> The current implementation of send-email is based on perl and has only >>> a tui, it has two problems: >>> -

Re: [PATCH v10 3/3] commit: add a commit.verbose config variable

On Sun, Mar 27, 2016 at 5:21 PM, SZEDER Gábor wrote: >> +test_expect_success 'commit.verbose true and --no-verbose' ' >> + git -c commit.verbose=true commit --amend --no-verbose && >> + ! test -s out > > Please use the test_must_be_empty helper instead, because it has a

Re: [PATCH v10 3/3] commit: add a commit.verbose config variable

On Sun, Mar 27, 2016 at 5:37 PM, SZEDER Gábor wrote: > t/test-lib-functions.sh contains all our test helpers functions, that's > where you can look for a suitable helper, should it be necessary. Thanks. I will surely look into it. -- To unsubscribe from this list: send the line

Re: [PATCH v10 3/3] commit: add a commit.verbose config variable

On Sun, Mar 27, 2016 at 1:47 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sun, Mar 27, 2016 at 3:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Sun, Mar 27, 2016 at 9:04 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>> On

Re: [PATCH v10 2/3] t7507-commit-verbose: store output of grep in a file

On Sun, Mar 27, 2016 at 6:57 PM, SZEDER Gábor wrote: >> > +! test -s out || >> > +rm out && >> >> Why not just "rm -f out"? But, more importantly, why do you need to >> remove the file at all? The '>' redirection operator (used below) will >> overwrite the file, so no need to

[PATCH v10 2/3] t7507-commit-verbose: store output of grep in a file

So that we can see how many diffs were contained in the message and use them in individual tests where ever it is required. Also use write_script() to create the fake "editor". Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmai

[PATCH v10 1/3] parse-options.c: make OPTION__COUNTUP understand "unspecified" values

ine <sunsh...@sunshineco.com> Helped-by: Junio C Hamano <gits...@pobox.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The discussion about this patch: [1] : http://thread.gmane.org/gmane.comp.version-control.git/289027 Previous version of the patch: [v1] : http://

[PATCH v10 3/3] commit: add a commit.verbose config variable

Add commit.verbose configuration variable as a convenience for those who always prefer --verbose taking care of multiple levels of verbosity. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.

Re: [PATCH v10 2/3] t7507-commit-verbose: store output of grep in a file

On Sun, Mar 27, 2016 at 10:57 PM, Eric Sunshine wrote: > On Sun, Mar 27, 2016 at 03:27:25PM +0200, SZEDER Gábor wrote: >> > > +! test -s out || >> > > +rm out && >> > >> > Why not just "rm -f out"? But, more importantly, why do you need to >> > remove the file at all? The

Re: [PATCH v3] bisect--helper: convert a function in shell to C

On Wed, Mar 23, 2016 at 5:27 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Pranit, > > On Wed, 23 Mar 2016, Pranit Bauva wrote: > >> Convert the code literally without changing its design even though it >> seems that it is obscure as to the use of c

Re: [PATCH v2] bisect--helper: convert a function in shell to C

On Wed, Mar 23, 2016 at 4:52 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Pranit, > > On Tue, 22 Mar 2016, Pranit Bauva wrote: > >> I did run the tests. They produce the same results as they did before. >> To ease review I will next time include

Re: parse-options does not recognize "unspecified" behavior

On Thu, Mar 17, 2016 at 3:07 AM, Eric Sunshine wrote: > The goal comes from his GSoC microproject. Specifically, Pranit wants > an "unspecified" value. The reason is that he is adding a > commit.verbose= config variable to back the existing git-commit > --verbose option.

Re: [PATCH/GSoC 3/3] Nousage message in error

This is my first review. It can contain some mistakes. On Thu, Mar 24, 2016 at 7:33 AM, Diwas Joshi wrote: > Subject : [PATCH/GSoC 3/3] Nousage message in error Mention about GSoC in the notes section (the one followed by the 3 dashes ie. "---") rather than in the subject.

[PATCH] api-parse-options.txt: document OPT_CMDMODE()

OPT_CMDMODE() was introduced in the release of 1.8.5 which makes the use of subcommands in the form of arguments a lot cleaner and easier. --- Documentation/technical/api-parse-options.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/technical/api-parse-options.txt

[PATCH v9 2/3] t7507-commit-verbose: make test suite use write_script

Also remove test_set_editor from global scope and use it in whichever test it is required. --- t/t7507-commit-verbose.sh | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh index 2ddf28c..cf95efb 100755 ---

[PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

v -v` => verbose = 2 `git commit --no-verbose` => verbose = 0 Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The discussion about this patch: [1] : http://thread.gmane.org/gmane.comp.version-control.git/289027 Previous version of the patch: [v1] : http://thread.gmane.org/gm

[PATCH v9 3/3] commit: add a commit.verbose config variable

Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The previous ve

Re: [PATCH/GSoC 3/3] Nousage message in error

On Thu, Mar 24, 2016 at 7:33 AM, Diwas Joshi wrote: > - To show only error text instead of full usage message > - Adds exits to callback function in parse-options-cb.c instead of returning > -1 which results in display of usage message. I forgot to mention that this

[PATCH v2] api-parse-options.txt: document OPT_CMDMODE()

OPT_CMDMODE mechanism was introduced in the release of 1.8.5 to actively notice when multiple "operation mode" options that specify mutually incompatible operation modes are given. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Documentation/technical/api-parse

Re: [PATCH v10 1/3] parse-options.c: make OPTION__COUNTUP understand "unspecified" values

On Sun, Mar 27, 2016 at 8:15 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Mar 26, 2016 at 3:48 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> parse-options.c: make OPTION__COUNTUP understand "unspecified" values > > A bit clearer: s/unde

Re: [PATCH v10 3/3] commit: add a commit.verbose config variable

On Sun, Mar 27, 2016 at 9:04 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Mar 26, 2016 at 3:48 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose tak

<    1   2   3   4   5   6   >