[GSoC][PATCH v4] t2027: avoid using pipes

f both commands as a failure exit code in any command will stop the && chain. Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- Hi, I am Prathamesh Chavan. This is my microproject which I have attempted for Google Summer of Code for 2017. Also in this new version of patch I have ch

[GSoC][PATCH v4] t2027: avoid using pipes

command is able to stop the && chain. Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- Hi, I am Prathamesh Chavan. This is my microproject which I have attempted for Google Summer of Code for 2017. Also in this new version of patch I have changed sendemail.name

GSoC Project | Submodules related work

Hey everyone, I am Prathamesh. I am studying Computer Science and Engineering at IIT Kharagpur. I am interested to participate in Google Summer of Code 2017 under Git organization. I attempted "Avoid pipes in git related commands for test suite" as my microproject[1]. As a part of GSoC, I would

[GSoC][PATCH v5] t2027: avoid using pipes

command is able to stop the && chain. Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version of the patch, I resolved the grammar mistakes from the commit message. Thanks for pointing it out. t/t2027-worktree-list.sh | 35 +-- 1 fi

Re: [GSoC][PATCH v1] Disallow git commands from within unpopulated submodules

ecking the active_cache list and checking if it prefix is present in active_cache[i]->name, using binary search. Also is there some other way which is more quicker than searching for the prefix in the cache? 2. Individually call this in each command after the git environment is set and options are parsed. 3. Apply this change for appropriate options only, as suggested above for the status command. This will ensure more accuracy. I have also mentioned to work on this BUG in my git proposal as well, but I kept it in my wishlist section. Hence, I'll continue to work on this as my time permits. Currently, I'm also working on converting the git-submodule subcommand 'foreach' from script to builtin, by first converting it to a function in submodule--helper.c and then later converting it to builtin. Thanks, Prathamesh Chavan

[GSoC][PATCH v1] Disallow git commands from within unpopulated submodules

ory to the submodule or superproject. Hence we’ll prefer to error out in these case. Eventually, we use a check_prefix_inside_submodule to see check if the path is inside an unpopulated submodule. If it is, then we report the user about the unpopulated submodule. Signed-off-by: Prathamesh Chavan <pc44..

[GSoC][PATCH v1] Disallow git commands from within unpopulated submodules

ory to the submodule or superproject. Hence we’ll prefer to error out in these case. Eventually, we use a check_prefix_inside_submodule to see check if the path is inside an unpopulated submodule. If it is, then we report the user about the unpopulated submodule. Signed-off-by: Prathamesh Chavan <pc44..

[GSoC][RFC/PATCH] submodule: port subcommand foreach from shell to C

uper-prefix displaypath", and other required arguments to the structure and then appending the input of submodule-foreach to the argument's array. Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- The build report of this patch is available at: https://travis-ci.org/pratham-p

[GSoC][RFC/PATCH v2] submodule: port subcommand foreach from shell to C

r-prefix displaypath", to the args argv_array structure. Other required arguments and the input of submodule-foreach is also appended to this argv_array. Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version of patch following changes have been added: module_l

[Patch v2] t2027: avoid using pipes

From: Prathamesh Whenever a git command is present in the upstream of a pipe, its failure gets masked by piping and hence it should be avoided for testing the upstream git command. By writing out the output of the git command to a file, we can test the exit codes of both the

[PATCH] t2027: avoid using pipes

From: Prathamesh Whenever a git command is present in the upstream of a pipe, its failure gets masked by piping and hence it should be avoided for testing the upstream git command. By writing out the output of the git command to a file, we can test the exit codes of both the

[PATCH] t2027: avoid using pipes

From: Prathamesh Whenever a git command is present in the upstream of a pipe, its failure gets masked by piping and hence it should be avoided for testing the upstream git command. By writing out the output of the git command to a file, we can test the exit codes of both the

Re: [PATCH] t*: avoid using pipes

On Wed, Mar 8, 2017 at 11:33 AM, Jeff King wrote: > On Tue, Mar 07, 2017 at 12:52:49PM -0800, Stefan Beller wrote: > >> On Tue, Mar 7, 2017 at 12:39 PM, Johannes Sixt wrote: >> >> > Welcome to the Git community! >> >> > >> > Actually, being a *micro* project, it

[PATCH v2] t2027: avoid using pipes

The exit code of the upstream of a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Prathamesh --- t/t2027-worktree-list.sh | 14 +++--- 1 file

Re: [PATCH] t2027: avoid using pipes

On Thu, Mar 9, 2017 at 1:38 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Wed, Mar 8, 2017 at 4:13 PM, Prathamesh Chavan <pc44...@gmail.com> wrote: >> The exit code of the upstream of a pipe is ignored thus we should avoid >> using it. > > You mi

[PATCH v2] t2027: avoid using pipes

Whenever a git command is present in the upstream of a pipe, its failure gets masked by piping and hence it should be avoided for testing the upstream git command. By writing out the output of the git command to a file, we can test the exit codes of both the commands as a failure exit code in any

Re: [PATCH] t*: avoid using pipes

, Prathamesh Chavan <pc44...@gmail.com> wrote: > On Wed, Mar 8, 2017 at 11:33 AM, Jeff King <p...@peff.net> wrote: >> On Tue, Mar 07, 2017 at 12:52:49PM -0800, Stefan Beller wrote: >> >>> On Tue, Mar 7, 2017 at 12:39 PM, Johannes Sixt <j...@kdbg.org> wro

Re: [PATCH v2] t2027: avoid using pipes

On Thu, Mar 9, 2017 at 6:00 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Mar 9, 2017 at 10:53 AM, Prathamesh Chavan <pc44...@gmail.com> wrote: >> Whenever a git command is present in the upstream of a pipe, its failure >> gets masked by piping and

Re: [PATCH] t2027: avoid using pipes

PM, Jon Loeliger <j...@jdl.com> wrote: > So, like, Prathamesh Chavan said: >> The exit code of the upstream of a pipe is ignored thus we should avoid >> using it. By writing out the output of the git command to a file, we >> can test the exit codes of both the

Re: [PATCH] t2027: avoid using pipes

But when I read the function carefully, it only removes the trash files created when test_failure is equal to zero. But as far as I know, I can see the files being removed even when a test_failure is non-zero for some test script. On Thu, Mar 9, 2017 at 3:08 AM, Prathamesh Chavan <p

Re: Reg : GSoC 2017 Microproject

On Tue, Mar 7, 2017 at 3:52 PM, Vedant Bassi wrote: > Hi, > > I would like to participate in GSoC 2017 and I have chosen the Use > unsigned integral type for collection of bits , idea from the Micro > projects list. > > I request the help of the community for clarifying a

[PATCH] t*: avoid using pipes

Hi, I'm Prathamesh Chavan. As a part of my micropraoject I have been working on "Avoid pipes for git related commands in test suites". I tried sending the patch, but it got blocked since the mail contained more than 100 000 characters. Hence I'll like to attach the link to my branch '

[PATCH] t*: avoid using pipes

Hi, I'm Prathamesh Chavan. As a part of my micropraoject I have been working on "Avoid pipes for git related commands in test suites". I tried sending the patch, but it got blocked since the mail contained more than 100 000 characters. Hence, I have made the required changes in branch &

[RFC] [GSoC] Proposal Draft for GSoC 2017 : Incremental Rewrite of git-submodules

. It would be great to have your suggestion, so that I can improve it futher. Thanks, Prathamesh Chavan --- Incremental Rewrite of git-submodules 01.04.2017 About Me Name Prathamesh Chavan UniversityIndian Institute of Technology, Kharagpur Major Computer Science

[GSoC][PATCH v2 04/13] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * parameters passed to the function print_status() have been changed. Instead of passing char *sub_sha1, instead the object_id is being pass

[GSoC][PATCH v2 01/13] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/builtin/submodule--helper.c b

[GSoC][PATCH v2 06/13] submodule: port submodule subcommand 'deinit' from shell to C

<christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * In the function deinit_submodule, since the test is_git_directory() adds an additional

[GSoC][PATCH v2 02/13] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 7af4de09b..e41572f7a 10

[GSoC][PATCH v2 03/13] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * The variable namerev from print_name_rev is now freed at the end of the function.

[GSoC][PATCH v2 00/13] Update: Week 10

patch itself. Complete build report of this work is available at: [1] Branch: week-10 Build #142 Also, I have push the work on github as well and can be checked out at: [2] [1]: https://travis-ci.org/pratham-pc/git/builds [2]: https://github.com/pratham-pc/git/commits/week-10 Prathamesh Chav

[GSoC][PATCH v2 07/13] diff: change scope of the function count_lines()

Change the scope of function count_lines for allowing the function to be reused in other parts of the code as well. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g

[GSoC][PATCH v2 05/13] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new vers

[GSoC][PATCH 00/13] Update: Week-11

SUMMARY OF MY PROJECT: Git submodule subcommands are currently implemented by using shell script 'git-submodule.sh'. There are several reasons why we'll prefer not to use the shell script. My project intends to convert the subcommands into C code, thus making them builtins. This will increase

[GSoC][PATCH 01/13] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/builtin/submodule--helper.c b

[GSoC][PATCH 09/13] submodule foreach: correct '$path' in nested submodules from a subdirectory

some automation that can break silently. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> Signed-off-by: Stefan Beller <sbel...@google.com> --- git-submodule.sh | 1 - t/t7407-submodule-foreach.sh | 36

[GSoC][PATCH 02/13] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 7af4de09b..e41572f7a 10

[GSoC][PATCH 04/13] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * parameters passed to the function print_status() have been changed. Instead of passing char *sub_sha1, instead the object_id is being passe

[GSoC][PATCH 07/13] diff: change scope of the function count_lines()

Change the scope of function count_lines for allowing the function to be reused in other parts of the code as well. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g

[GSoC][PATCH 06/13] submodule: port submodule subcommand 'deinit' from shell to C

<christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * In the function deinit_submodule, since the test is_git_directory() adds an additional

[GSoC][PATCH 13/13] submodule: port submodule subcommand 'foreach' from shell to C

y: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * Comment style is improved in the function runcommand_in_submodule() * Comment

Re: [GSoC][PATCH 06/13] submodule: port submodule subcommand 'deinit' from shell to C

On Tue, Aug 1, 2017 at 3:12 AM, Stefan Beller <sbel...@google.com> wrote: > On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan <pc44...@gmail.com> wrote: >> The same mechanism is used even for porting this submodule >> subcommand, as used in the ported subcommand

Re: [GSoC][PATCH 04/13] submodule: port submodule subcommand 'status' from shell to C

On Tue, Aug 1, 2017 at 2:42 AM, Stefan Beller <sbel...@google.com> wrote: > On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan <pc44...@gmail.com> wrote: >> This aims to make git-submodule 'status' a built-in. Hence, the function >> cmd_status() is ported fr

[GSoC] Update: Week-13

SUMMARY OF MY PROJECT: Git submodule subcommands are currently implemented by using shell script 'git-submodule.sh'. There are several reasons why we'll prefer not to use the shell script. My project intends to convert the subcommands into C code, thus making them builtins. This will increase

[GSoC][PATCH 4/5 v4] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version of patch: Instead of using cmd_diff_files(), the process is optimized by using ce_match_stat(). Also, the child_process running the command 'rev-parse --verify HEAD' is removed for op

[GSoC][PATCH 5/5 v4] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodu

[GSoC][PATCH 2/5 v4] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 7af4de09b..e41572f7a 10

[GSoC][PATCH 1/5 v4] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/builtin/submodule--helper.c b

[GSoC][PATCH 3/5 v4] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 63 + git-submodule.sh| 16 ++-- 2 files chan

[GSoC][PATCH 7/8] diff: change scope of the function count_lines()

Change the scope of function count_lines for allowing the function to be reused in other parts of the code as well. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g

[GSoC][PATCH 5/8] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodu

[GSoC][PATCH 3/8] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 63 + git-submodule.sh| 16 ++-- 2 files chan

[GSoC] Update: Week 8

y hacks. [1]: https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/ Thanks, Prathamesh Chavan

[GSoC][PATCH 8/8] submodule: port submodule subcommand 'summary' from shell to C

the print_submodule_summary() function. Finally, the print_submodule_summary() takes care of generating and printing the summary for each submodule. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc

[GSoC][PATCH 6/8] submodule: port submodule subcommand 'deinit' from shell to C

<christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 143 git-submodule.sh| 55 + 2 files changed, 144

[GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 154 git-submodule.sh| 49 +- 2 files changed, 155 insertions(+), 48 deletions(-) diff --git a/builtin/sub

[GSoC][PATCH 1/8] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/builtin/submodule--helper.c b

[GSoC][PATCH 2/8] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 7af4de09b..e41572f7a 10

[GSoC][PATCH 0/8] Update: Week 9

nbox.org/git/20170713200538.25806-4-pc44...@gmail.com/ [3]: https://public-inbox.org/git/20170713200538.25806-5-pc44...@gmail.com/ [4]: https://public-inbox.org/git/20170603003710.5558-1-sbel...@google.com/ Prathamesh Chavan (8): submodule--helper: introduce get_submodule_displaypath() submo

[GSoC][PATCH 2/8] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 7af4de09b..e41572f7a 10

[GSoC][PATCH 3/8] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 63 + git-submodule.sh| 16 ++-- 2 files chan

[GSoC][PATCH 1/8] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/builtin/submodule--helper.c b

[GSoC][PATCH 5/8] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodu

[GSoC][PATCH 6/8] submodule: port submodule subcommand 'deinit' from shell to C

<christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 143 git-submodule.sh| 55 + 2 files changed, 144

[GSoC][PATCH 8/8] submodule: port submodule subcommand 'summary' from shell to C

the print_submodule_summary() function. Finally, the print_submodule_summary() takes care of generating and printing the summary for each submodule. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc

[GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 146 git-submodule.sh| 49 +-- 2 files changed, 147 insertions(+), 48 deletions(-) diff --git a/builtin/sub

[GSoC][PATCH 7/8] diff: change scope of the function count_lines()

Change the scope of function count_lines for allowing the function to be reused in other parts of the code as well. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g

[GSoC][PATCH 04/13] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version of patch, following changes were made: * instead of using the ce_match_stat(), cmd_diff_files is used. * currently, no comment about future scope of optimization wrt the cmd_diff_files

[GSoC][PATCH 01/13] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/builtin/submodule--helper.c b

[GSoC][PATCH 03/13] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 63 + git-submodule.sh| 16 ++-- 2 files chan

[GSoC][PATCH 02/13] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 7af4de09b..e41572f7a 10

[GSoC][PATCH 05/13] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this ne

[GSoC][PATCH 06/13] submodule: port submodule subcommand 'deinit' from shell to C

<christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 141 git-submodule.sh| 55 + 2 files changed, 142

[GSoC][PATCH 00/13] Update: Week 10

.com/ [3]: https://travis-ci.org/pratham-pc/git/builds/ [4]: https://github.com/pratham-pc/git/commits/week-10 Prathamesh Chavan (13): submodule--helper: introduce get_submodule_displaypath() submodule--helper: introduce for_each_submodule_list() submodule: port set_name_rev() from shell to C

[GSoC][PATCH 07/13] diff: change scope of the function count_lines()

Change the scope of function count_lines for allowing the function to be reused in other parts of the code as well. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g

[GSoC][PATCH 09/13] submodule foreach: correct '$path' in nested submodules from a subdirectory

some automation that can break silently. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> Signed-off-by: Stefan Beller <sbel...@google.com> --- git-submodule.sh | 1 - t/t7407-submodule-foreach.sh | 36

[GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C

the print_submodule_summary() function. Finally, the print_submodule_summary() takes care of generating and printing the summary for each submodule. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc

[GSoC][PATCH 12/13] submodule foreach: document variable '$displaypath'

It was observer that the variable '$displaypath' was accessible but undocumented. Hence, document it. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> ---

[GSoC][PATCH 13/13] submodule: port submodule subcommand 'foreach' from shell to C

y: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 129 git-submodule.sh| 39 +- 2 files cha

[GSoC][PATCH 11/13] submodule foreach: clarify the '$toplevel' variable documentation

; Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- Documentation/git-submodule.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt index a23baef62..8e7930ebc 100644 --- a/Documentation/git-s

[GSoC][PATCH 10/13] submodule foreach: document '$sm_path' instead of '$path'

' variable available and document it as a deprecated synonym of 'sm_path'. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- Documentation/git-submodule.txt | 10 ++--

Re: [GSoC][PATCH 5/8] submodule: port submodule subcommand 'sync' from shell to C

tem->name); > > While it is a strict conversion from the shell script, we could also > try to do this in-process: > 1) we'd find out the submodules git dir using submodule_to_gitdir > 2) construct the path the the config file as "%s/.gitconfig" > 3) using git_config_set_in_file (which presumably takes file name, > key and value) the value can be set Thanks for pointing that out. That surely reduced a child_process. Although the path of the config file for the case of submodules would be constructed by "%s/config". Thanks, Prathamesh Chavan

[GSoC][PATCH 1/5 v3] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- The patch series is updated, and is based on 'master' branch. This patch series contains updates patches about Introduction of the function: get_submodule_displaypath()

[GSoC][PATCH 4/5 v3] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 152 git-submodule.sh| 49 +- 2 files changed, 153 insertions(+), 48 deletions(-) diff --git a/builtin/sub

[GSoC][PATCH 2/5 v3] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 1bfc91bca..c4286aac5 10

[GSoC][PATCH 3/5 v3] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 69 + git-submodule.sh| 16 ++- 2 files changed, 71

[GSoC][PATCH 5/5 v3] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodu

[GSoC] Update: Week 7

d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/ Thanks, Prathamesh Chavan

[GSoC][PATCH 2/5 v4] submodule--helper: introduce for_each_submodule_list()

m> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodule--helper.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 1bfc91bca..c4286aac5 10

[GSoC][PATCH 5/5 v4] submodule: port submodule subcommand 'sync' from shell to C

(). The function print_default_remote() is introduced for getting the default remote as stdout. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- builtin/submodu

[GSoC][PATCH 4/5 v4] submodule: port submodule subcommand 'status' from shell to C

<sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- A NEEDSWORK tag was added at the two places where optimization for future. builtin/submodule--helper.c | 154 git-submodule.sh| 49 +- 2

[GSoC][PATCH 1/5 v4] submodule--helper: introduce get_submodule_displaypath()

cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- This series of patches are build over the 'mater' branch. Complete build report is available at: https://travis-ci.org/pratham-pc/git/builds Branch: setnamerev Bu

[GSoC][PATCH 3/5 v4] submodule: port set_name_rev() from shell to C

Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- As suggested the unnecessary enum present was removed. builtin/submodule--helper.c | 63 +

Re: [GSoC][PATCH 1/6 v2] submodule--helper: introduce for_each_submodule_list

ic on 'master', and then in addition to testing the > topic by itself, also make a trial merge of your topic into 'next' > and test the result as well. > Thanks for making me aware about this as well. And will be following this before sending out the updated patch-series. Thanks, Prathamesh Chavan

Re: [GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C

On Sat, Aug 5, 2017 at 10:25 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Sat, Aug 5, 2017 at 12:28 PM, Prathamesh Chavan <pc44...@gmail.com> wrote: >> On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder >> <christian.cou...@gmail.com> wrote: >

[GSoC][PATCH v2 08/13] submodule: port submodule subcommand 'summary' from shell to C

the print_submodule_summary() function. Finally, the print_submodule_summary() takes care of generating and printing the summary for each submodule. Mentored-by: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc

[GSoC][PATCH v2 12/13] submodule foreach: document variable '$displaypath'

It was observed that the variable '$displaypath' was accessible but undocumented. Hence, document it. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- I

[GSoC][PATCH v2 13/13] submodule: port submodule subcommand 'foreach' from shell to C

y: Christian Couder <christian.cou...@gmail.com> Mentored-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- In this new version, the following changes have been made: * Comment style is improved in the function runcommand_in_submodule() * Comment

[GSoC][PATCH v2 10/13] submodule foreach: document '$sm_path' instead of '$path'

' variable available and document it as a deprecated synonym of 'sm_path'. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Stefan Beller <sbel...@google.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- This patch is same as its previous version.

[GSoC][PATCH v2 11/13] submodule foreach: clarify the '$toplevel' variable documentation

; Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> --- Documentation/git-submodule.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt index a23baef62..8e7930ebc 100644 --- a/Documentation/git-s

[GSoC][PATCH v2 09/13] submodule foreach: correct '$path' in nested submodules from a subdirectory

some automation that can break silently. Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com> Signed-off-by: Prathamesh Chavan <pc44...@gmail.com> Signed-off-by: Stefan Beller <sbel...@google.com> --- git-submodule.sh | 1 - t/t7407-submodule-foreach.sh | 36

  1   2   3   >