on APFS when inode numbers are still
> below 2^32.
>
> Or we just to to reduce the odds of matching a wrong file by checking
> more attributes, counting mostly on st_size because st_xtime is likely
> the same. This patch goes with this direction, hoping that false
> positive chances ar
On 19/11/2018 23:29, Ramsay Jones wrote:
>
>
> On 19/11/2018 21:03, Duy Nguyen wrote:
>> First of all, Ramsay, it would be great if you could test the below
>> patch and see if it works on Cygwin. I assume since Cygwin shares the
>> underlying filesystem, it will
352
uid: 1001 gid: 513
size: 0 flags: 0
x
ctime: 1542667201:665026800
mtime: 1542667201:665026800
dev: 2378432 ino: 324352
uid: 1001 gid: 513
size: 0 flags: 0
$
So, both X and x are in the index with the same inode number.
Does that help?
ATB,
Ramsay Jones
colliding file detection (missing !CYGWIN of
!MINGW,!CYGWIN,CASE_INSENSITIVE_FS)
ok 100 - partial clone
ok 101 - partial clone: warn if server does not support object filtering
ok 102 - batch missing blob request during checkout
ok 103 - batch missing blob request does not inadvertently try to fetch
gitlinks
# passed all 103 test(s)
# SKIP no web server found at '/usr/sbin/apache2'
1..103
$
ATB,
Ramsay Jones
On 14/11/2018 02:11, brian m. carlson wrote:
> On Wed, Nov 14, 2018 at 12:11:07AM +0000, Ramsay Jones wrote:
>>
>>
>> On 13/11/2018 18:42, Derrick Stolee wrote:
>>> On 11/4/2018 6:44 PM, brian m. carlson wrote:
>>>> +int hash_algo_by_name
On 14/11/2018 00:11, Ramsay Jones wrote:
>
>
> On 13/11/2018 18:42, Derrick Stolee wrote:
>> On 11/4/2018 6:44 PM, brian m. carlson wrote:
>>> +int hash_algo_by_name(const char *name)
>>> +{
>>> + int i;
>>> + if (!name)
>>&
he symbols from hex.o and sha1-file.o being the 4 symbols from
this branch.
I suspect that upcoming patches will make use of them. ;-)
ATB,
Ramsay Jones
in stone. I also like that "odb" is the same short
> length as "alt", which helps with conversion.
While reading the patch, I keep thinking it should be 'obd' for
OBject Directory. ;-)
[Given my track record in naming things, please take with a _huge_
pinch of salt!]
ATB,
Ramsay Jones
On 10/11/2018 04:55, Duy Nguyen wrote:
> On Tue, Nov 6, 2018 at 3:07 PM Ramsay Jones
> wrote:
>> Also, this patch does not replace opterror() calls outside of
>> the 'parse-options.c' file with optname(). This tickles my
>> static-check.pl script, since optname()
hing like this (make paths specified e.g. via
http.sslCAInfo relative to the runtime prefix) is potentially useful
also in the non-Windows context, as long as Git was built with the
runtime prefix feature.
... so I thought you meant to add this code for POSIX systems as well.
My mistake. :(
ATB,
Ramsay Jones
On 06/11/2018 15:54, Ramsay Jones wrote:
>
>
> On 06/11/2018 14:53, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin
>>
>> On Windows, an absolute POSIX path needs to be turned into a Windows
>> one.
>>
>> Signed-off-b
es?
I am pretty sure that I would not want the absolute paths
in my config file(s) magically 'moved' depending on whether
git has been compiled with 'runtime prefix' support or not!
ATB,
Ramsay Jones
> if (path[0] == '~') {
> const char *first_slash = strchrnul(path, '/');
> const char *username = path + 1;
>
-options.c'.
So, at present, optname() could be marked as a local 'static'
symbol. However, I could also imagine it being used by new callers
outside of 'parse-options.c' in the future. (maybe) Your call. ;-)
ATB,
Ramsay Jones
On 29/10/2018 01:13, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> ...
>>24 clear_contains_cache
>> $
>>
>> you will find 24 copies of the commit-slab routines for the contains_cache.
>> Of course, when you enable optimizations again, t
e actually called, so the trade-off
seems to favour letting the compiler inline the commit-slab functions.
Signed-off-by: Ramsay Jones
---
commit-reach.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/commit-reach.h b/commit-reach.h
index 7d313e2975..f41d8f6ba3 100644
--
object files. Despite this, add the missing 'inline'
keyword to better describe the intended behaviour.
Signed-off-by: Ramsay Jones
---
ewah/ewok_rlw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ewah/ewok_rlw.h b/ewah/ewok_rlw.h
index d487966935..bafa24f4c3 100644
Signed-off-by: Ramsay Jones
---
fetch-object.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fetch-object.h b/fetch-object.h
index d2f996d4e8..d6444caa5a 100644
--- a/fetch-object.h
+++ b/fetch-object.h
@@ -1,6 +1,8 @@
#ifndef FETCH_OBJECT_H
#define FETCH_OBJECT_H
+struct object_id
t to 'next' and with a 'minor' conflict on 'pu'.
Ramsay Jones (3):
fetch-object.h: add missing declaration (hdr-check)
ewok_rlw.h: add missing 'inline' to function definition
commit-reach.h: add missing declarations (hdr-check)
commit-reach.h | 5 +++--
ewah/ewok_rlw.h | 2 +-
fetch-object.h | 2 +
On 26/10/2018 04:15, Carlo Arenas wrote:
> On Thu, Oct 25, 2018 at 2:09 PM Ramsay Jones
> wrote:
>> Yes, this will 'fix' the 'commit-reach.h' header (not surprising),
>> but I prefer my patch. ;-)
>
> I apologize, I joined the list recently and so might had misse
On 25/10/2018 19:54, Ramsay Jones wrote:
>
>
> On 25/10/2018 12:04, Carlo Marcelo Arenas Belón wrote:
>> struct commmit needs to be defined before commit-slab can generate
>> working code, object_id should be at least known through a forward
>> declaration
>>
Hmm, sorry, I don't see how this patch has anything to do
with the other two patches! ;-)
Also, I have a patch to fix up the 'commit-reach.h' header
(it was part of my original series, just had to update the
commit message), which adds these very #includes and forward
declarations when _using_ the commit-slab.
I haven't tried applying your patches yet, which may answer
my questions, so I am a little puzzled.
ATB,
Ramsay Jones
d leave further refinements to incremental updates as
> needed?
Yeah, the first version gave me a 'huh?' moment (hence the
comment), the last version was better and, as you can see,
I am no great shakes at wordsmith-ing documentation! ;-)
Thanks!
ATB,
Ramsay Jones
through the exact sequence in your paragraph when writing
> my other message. That's probably a good sign that we should probably
> not pursue this further unless we see the use case come up again a few
> more times (and if we do, then consider "config" the least-bad place to
> do it).
I was thinking:
$ git var -e GIT_WHATEVER_ENV
[-e for environment].
... but that is really no different than git-config. ;-)
ATB,
Ramsay Jones
configured
default.
Hmm, I am not sure that is any better! :-D
Also, note that the --no-option is often described separately to
the --option (in a separate paragraph). I don't know if that would
help here.
[The default behaviour is _not_ set by the configuration, if no
configuration is speci
vior respects the
> + `reset.quiet` config option, or `--no-quiet` if that is not set.
Sorry, I can't quite parse this; -q,--quiet and --no-quiet on the
command line (should) trump whatever rest.quiet is set to in the
configuration. Is that not the case?
ATB,
Ramsay Jones
>
>
&g
to be caused by
Junio's commit 42c89ea70a ("SQUASH??? - convert the other user of
string-list as db", 2018-10-17) which removes a call to the
add_existing() function - the subject of the warning.
[BTW there is another 'static add_existing()' in builtin/show_ref.c]
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Junio,
Since I didn't get any adverse comments, this version has the RFC
label removed. Also, given that it seems the vcs-svn directory is
not going away soon, I have included those headers this time as well.
[Note: my email client (thunderbird) was updated
On 15/10/18 01:01, Jeff King wrote:
> On Sun, Oct 14, 2018 at 04:03:48PM +0100, Ramsay Jones wrote:
>
>>> So I kind of wonder if a comment would be better than xsize_t here.
>>> Something like:
>>>
>>> if (avail > len) {
>>> /*
>&
On 15/10/18 00:59, Jeff King wrote:
> On Sun, Oct 14, 2018 at 09:13:09PM +0100, Ramsay Jones wrote:
>
>> This patch is marked RFC because I am not aware of any policy with
>> regard to header guard spelling. Having said that, apart from the
>> fetch-negotiator.h head
Signed-off-by: Ramsay Jones
---
Hi Junio,
This patch is marked RFC because I am not aware of any policy with
regard to header guard spelling. Having said that, apart from the
fetch-negotiator.h header, all of these headers are using a reserved
identifier (see C99 Standard 7.1.3
On 14/10/18 03:52, Jeff King wrote:
> On Sun, Oct 14, 2018 at 03:16:36AM +0100, Ramsay Jones wrote:
>
>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
>> index b059b86aee..3b5f2c38b3 100644
>> --- a/builtin/pack-objects.c
>> +++ b/builtin/pack-o
On 14/10/18 03:16, Ramsay Jones wrote:
>
>
> On 13/10/18 06:00, Torsten Bögershausen wrote:
>> []
>>> Neither v1 nor v2 of this patch compiles on 32 bit Linux; see
>>>
>>> https://travis-ci.org/git/git/jobs/440514375#L628
>>>
>>> T
light
manual testing (the test suite has never passed on Msys2 for me).
This is not the same as testing on Gfw, of course.
ATB,
Ramsay Jones
-- >8 --
From: Martin Koegler
Subject: [PATCH v3 1/1] zlib.c: use size_t for size
Signed-off-by: Martin Koegler
Signed-off-by: Junio C Hamano
Signed
reason was that
>> nobody tried to dust it off and reignite the topic so far---which I
>> am trying to correct, but as I said, this is just minimally adjusted
>> to today's codebase, without any attempt to improve relative to the
>> original patch.
>>
>> I think we
rse private/branch expect &&
s/expect/>expect/ ?
ATB,
Ramsay Jones
> + printf "" | git receive-pack fork >actual &&
> + extract_haves actual.haves &&
> + test_cmp expect actual.haves
> +'
> +
> test_done
> diff --git a/t
THREAD_COST;
> - if (ieot_blocks < 1)
> - ieot_blocks = 1;
> cpus = online_cpus();
> if (ieot_blocks > cpus - 1)
> ieot_blocks = cpus - 1;
So,
On 28/09/18 02:20, Ben Peart wrote:
>
>
> On 9/27/2018 6:24 PM, Ramsay Jones wrote:
>>
>> commit 225df8a468 ("ieot: add Index Entry Offset Table (IEOT)
>> extension", 2018-09-26) added a 'DIV_ROUND_UP(entries, ieot_blocks)
>> expression, where i
until test t4056-diff-order.sh, which
then went into an infinite loop!
Signed-off-by: Ramsay Jones
---
Hi Ben,
Could you please squash this into the relevant commits on your
'bp/read-cache-parallel' branch. (The first hunk fixes a sparse
warning about using an integer as a NULL pointer).
Th
commit 440fc7c0729 ("fetch: replace string-list used as a look-up
table with a hashmap", 2018-09-25) renamed a string-list variable
(while adding a hashmap of the same name) and forgot to rename the
string-list variable in a call to string_list_clear().
Signed-off-by: Ramsay Jone
On 21/09/18 17:21, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Junio,
>>
>> This is the patch I needed for the current 'next' branch to get
>> a clean 'hdr-check'
>
> Which means that th
On 20/09/18 15:26, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Commit ef3ca95475 ("Add missing includes and forward declarations",
>> 2018-08-15) resulted from the author employing a manual method to
>> create a C file consisting of a pair of pre-pro
On 20/09/18 00:38, Derrick Stolee wrote:
> On 9/18/2018 8:15 PM, Ramsay Jones wrote:
>> Signed-off-by: Ramsay Jones
>> ---
>> commit-reach.h | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/commit-reach.h b/commit-
On 19/09/18 18:49, Martin Ågren wrote:
> Hi Ramsay,
>
> On Wed, 19 Sep 2018 at 02:07, Ramsay Jones
> wrote:
>> @@ -2675,6 +2676,17 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE
>> .PHONY: sparse $(SP_OBJ)
>> sparse: $(SP_OBJ)
>>
>> +GEN_HDRS :
Signed-off-by: Ramsay Jones
---
Hi Junio,
... and this is the patch I needed for the current 'pu' branch.
ATB,
Ramsay Jones
userdiff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/userdiff.h b/userdiff.h
index dad3fc03c1..b072bfe89a 100644
--- a/userdiff.h
+++ b/userdiff.h
@@ -3,6
Signed-off-by: Ramsay Jones
---
Hi Junio,
This is the patch I needed for the current 'next' branch to get
a clean 'hdr-check'
ATB,
Ramsay Jones
fetch-object.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fetch-object.h b/fetch-object.h
index d2f996d4e8..d6444caa5a 100644
Signed-off-by: Ramsay Jones
---
commit-reach.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/commit-reach.h b/commit-reach.h
index 7d313e2975..f41d8f6ba3 100644
--- a/commit-reach.h
+++ b/commit-reach.h
@@ -1,12 +1,13 @@
#ifndef __COMMIT_REACH_H__
#define
Signed-off-by: Ramsay Jones
---
delta-islands.h | 4
1 file changed, 4 insertions(+)
diff --git a/delta-islands.h b/delta-islands.h
index f9725730f4..b635cd07d8 100644
--- a/delta-islands.h
+++ b/delta-islands.h
@@ -1,6 +1,10 @@
#ifndef DELTA_ISLANDS_H
#define DELTA_ISLANDS_H
+struct
Signed-off-by: Ramsay Jones
---
midx.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/midx.h b/midx.h
index a210f1af2a..622ddac472 100644
--- a/midx.h
+++ b/midx.h
@@ -3,6 +3,9 @@
#include "repository.h"
+struct object_id;
+struct pack_entry;
+
struct multi_
Signed-off-by: Ramsay Jones
---
refs/refs-internal.h | 4
1 file changed, 4 insertions(+)
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 04425d6d1e..44d53672c7 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -1,8 +1,12 @@
#ifndef REFS_REFS_INTERNAL_H
Signed-off-by: Ramsay Jones
---
refs/packed-backend.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/refs/packed-backend.h b/refs/packed-backend.h
index 640245d3b9..a01a0aff9c 100644
--- a/refs/packed-backend.h
+++ b/refs/packed-backend.h
@@ -1,6 +1,8 @@
#ifndef REFS_PACKED_BACKEND_H
Signed-off-by: Ramsay Jones
---
refs/ref-cache.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/refs/ref-cache.h b/refs/ref-cache.h
index eda65e73ed..3bfb89d2b3 100644
--- a/refs/ref-cache.h
+++ b/refs/ref-cache.h
@@ -1,7 +1,10 @@
#ifndef REFS_REF_CACHE_H
#define REFS_REF_CACHE_H
Signed-off-by: Ramsay Jones
---
ewah/ewok_rlw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ewah/ewok_rlw.h b/ewah/ewok_rlw.h
index 7cdfdd0c02..d487966935 100644
--- a/ewah/ewok_rlw.h
+++ b/ewah/ewok_rlw.h
@@ -19,6 +19,8 @@
#ifndef __EWOK_RLW_H__
#define __EWOK_RLW_H__
+#include
Signed-off-by: Ramsay Jones
---
json-writer.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/json-writer.h b/json-writer.h
index fc18acc7d9..83906b09c1 100644
--- a/json-writer.h
+++ b/json-writer.h
@@ -42,6 +42,8 @@
* of the given strings.
*/
+#include "strbuf.h"
(read: Hdr-Check Object)
like so:
$ make config.hco
HDR config.h
$
Signed-off-by: Ramsay Jones
---
Makefile | 12
1 file changed, 12 insertions(+)
diff --git a/Makefile b/Makefile
index b567ccca45..835030e22b 100644
--- a/Makefile
+++ b/Makefile
@@ -1793,6 +1793,7 @
jones.plus.com/
ATB,
Ramsay Jones
Ramsay Jones (9):
Makefile: add a hdr-check target
json-writer.h: add missing include (hdr-check)
ewah/ewok_rlw.h: add missing include (hdr-check)
refs/ref-cache.h: add missing declarations (hdr-check)
refs/packed-backend.h: add missing declaration (hd
On 17/09/18 17:27, Ramsay Jones wrote:
>
>
> On 17/09/18 15:15, Ben Peart wrote:
>>
>>
>> On 9/16/2018 3:17 AM, Eric Sunshine wrote:
>>> On Fri, Sep 14, 2018 at 7:29 PM Ramsay Jones
>>> wrote:
>>>> At one time, the POSIX standard
On 17/09/18 15:15, Ben Peart wrote:
>
>
> On 9/16/2018 3:17 AM, Eric Sunshine wrote:
>> On Fri, Sep 14, 2018 at 7:29 PM Ramsay Jones
>> wrote:
>>> At one time, the POSIX standard required the type used to represent
>>> a thread handle (pthread_t) b
to fix the warning, move the (conditional) pthread field to
the end of the struct and change the initialiser to use a NULL, since
the new (unconditional) first field is a pointer type.
Signed-off-by: Ramsay Jones
---
Hi Ben,
If you need to re-roll your 'bp/read-cache-parallel' branch, could you
Signed-off-by: Ramsay Jones
---
Hi Derrick,
If you need to re-roll your 'ds/multi-pack-verify' branch, could you
please squash this into the relevant patch (commit 64cbf3df21,
"multi-pack-index: add 'verify' verb", 2018-09-13).
[noticed by sparse].
Thanks.
ATB,
Ramsay Jones
erwards
> using string_list_remove_empty_items.
>
> By doin so we'll have access to the util pointer for longer that
s/doin/doing/
ATB,
Ramsay Jones
work_on(item);
> string_list_pop();
string_list_pop() takes a second int parameter (free_util).
ATB,
Ramsay Jones
= ...
I was going to suggest, inspired by Makefile syntax, that
[-include] would not complain if the file was missing ...
except, of course, it's too late for that! ;-)
I suppose [+include] could complain if the file is missing
instead, ... dunno.
ATB,
Ramsay Jones
On 31/08/18 01:54, Jeff King wrote:
> On Fri, Aug 31, 2018 at 12:49:39AM +0100, Ramsay Jones wrote:
>
>> On 30/08/18 21:14, Junio C Hamano wrote:
>>> Jeff King writes:
>>>
>>>> I suppose so. I don't think I've _ever_ used distclean, and I only
&
ne"
> sometimes before running "git clean -x" ;-)
>
'git clean -x' always removes _way_ more than I want it
to - in particular, I lost my config.mak more than once.
So, no I don't trust it. ;-)
ATB,
Ramsay Jones
ag to the skiplist file:
$ echo d6602ec5194c87b0fc87103ca4d67251c76f233a >.git/skip
Hope this helps.
ATB,
Ramsay Jones
ich flags did you pass to the compiler?
Well, it killed 15min. before bed! ;-)
ATB,
Ramsay Jones
-- >8 --
Subject: [PATCH] Makefile: add a hdr-check target
Signed-off-by: Ramsay Jones
---
Makefile | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Makefile b/Makefile
index 9923
On 13/08/18 04:33, Christian Couder wrote:
> On Mon, Aug 13, 2018 at 3:14 AM, Ramsay Jones
[snip]
>> And neither the sha1 or str hash-maps are destroyed here.
>> (That is not necessarily a problem, of course! ;-) )
>
> The instances are declared as static:
>
ct commit_list *p;
> + struct island_bitmap *root_marks = kh_value(island_marks, pos);
> +
> + parse_commit(commit);
> + set_island_marks(_commit_tree(commit)->object, root_marks);
> + for (p = commit->parents; p; p = p->next)
> + set_island_marks(>item->object, root_marks);
> + }
> +}
> +
> +int compute_pack_layers(struct packing_data *to_pack)
> +{
> + uint32_t i;
> +
> + if (!core_island_name || !island_marks)
> + return 1;
> +
> + for (i = 0; i < to_pack->nr_objects; ++i) {
> + struct object_entry *entry = _pack->objects[i];
> + khiter_t pos = kh_get_sha1(island_marks, entry->idx.oid.hash);
> +
> + entry->layer = 1;
> +
> + if (pos < kh_end(island_marks)) {
> + struct island_bitmap *bitmap = kh_value(island_marks,
> pos);
> +
> + if (island_bitmap_get(bitmap, island_counter_core))
> + entry->layer = 0;
> + }
> + }
> +
> + return 2;
> +}
> diff --git a/delta-islands.h b/delta-islands.h
> new file mode 100644
> index 00..f9725730f4
> --- /dev/null
> +++ b/delta-islands.h
> @@ -0,0 +1,11 @@
> +#ifndef DELTA_ISLANDS_H
> +#define DELTA_ISLANDS_H
> +
> +int island_delta_cmp(const struct object_id *a, const struct object_id *b);
> +int in_same_island(const struct object_id *, const struct object_id *);
> +void resolve_tree_islands(int progress, struct packing_data *to_pack);
> +void load_delta_islands(void);
> +void propagate_island_marks(struct commit *commit);
> +int compute_pack_layers(struct packing_data *to_pack);
> +
> +#endif /* DELTA_ISLANDS_H */
> diff --git a/pack-objects.h b/pack-objects.h
> index edf74dabdd..8eecd67991 100644
> --- a/pack-objects.h
> +++ b/pack-objects.h
> @@ -100,6 +100,10 @@ struct object_entry {
> unsigned type_:TYPE_BITS;
> unsigned no_try_delta:1;
> unsigned in_pack_type:TYPE_BITS; /* could be delta */
> +
> + unsigned int tree_depth; /* should be repositioned for packing? */
> + unsigned char layer;
> +
> unsigned preferred_base:1; /*
> * we do not pack this, but is available
> * to be used as the base object to delta
>
Sorry, I spent so long reading this patch, I have run out of
time tonight (and I am busy tomorrow) to read the rest of the
series.
ATB,
Ramsay Jones
any such call.
Do you have plans to extend that series with additional patches which
will add such calls?
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Pratik,
If you need to re-roll your 'pk/rebase-in-c-4-opts' branch, could
you please squash this into the relevant patch (commit b0721e7b48,
"builtin rebase: support `-C` and `--whitespace=`", 2018-08-08).
Thanks!
ATB,
Ramsay Jones
builtin/re
... after here.
> #include "config.h"
> #include "repository.h"
> diff --git a/environment.c b/environment.c
> index 6cf0079389..920362900c 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -7,6 +7,7 @@
> * even if you might want to know where the git directory etc
> * are.
> */
> +#include "branch.h"
ditto
> #include "cache.h"
> #include "repository.h"
> #include "config.h"
>
ATB,
Ramsay Jones
et skiplist;
> struct decoration *object_names;
> };
>
> -#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL }
> -#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL }
> +#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL,
> OIDSET_INIT }
> +#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL,
> OIDSET_INIT }
Note that a NULL initialiser, for the object_names field, is missing
(not introduced by this patch). Since you have bumped into the 80th
column, you may not want to add that NULL to the end of these macros
(it is not _necessary_ after all). However, ... :-D
Otherwise, LGTM.
Thanks!
ATB,
Ramsay Jones
>
> /* descend in all linked child objects
> * the return value is:
)),
> OPT_BOOL( 0 , "ignore-missing", _missing, N_("check if - even
> missing - files are ignored in dry run")),
> - OPT_STRING( 0 , "chmod", _arg, N_("(+/-)x"), N_("override the
> executable bit of the listed files&
On 01/08/18 20:34, Stefan Beller wrote:
> A use reported a submodule issue regarding strange case indentation
s/use/user/ ?
ATB,
Ramsay Jones
Commit 94d4e2fb88 ("rebase -i: move rebase--helper modes to
rebase--interactive", 2018-07-24) removed the definition of the
'cmd_rebase__helper' symbol, but forgot to remove the corresponding
declaration in the 'builtin.h' header file.
Signed-off-by: Ramsay Jones
---
Hi Alban,
I
On 29/07/18 04:13, Eric Sunshine wrote:
> On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones
> wrote:
>> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
>> receive-pack", 2018-07-27) adds a test which uses the non-portable
>> export construct. Repl
Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
receive-pack", 2018-07-27) adds a test which uses the non-portable
export construct. Replace it with "FOO=bar && export FOO" instead.
Signed-off-by: Ramsay Jones
---
Hi Junio,
Could you please put
y (I hate it), be even with
that turned on, the patches still appear in the above order
under the cover letter (but at least all together).
Annoyed.
ATB,
Ramsay Jones
ot redundant if you're into black-box
> testing, but our current tests are usually written with an assumption of
> where the module boundaries are, and what is likely to be a problem).
I don't mind either way. I will let you and Junio decide.
Thanks!
ATB,
Ramsay Jones
On 11/07/18 20:31, Ramsay Jones wrote:
> On 07/07/18 02:32, Jeff King wrote:
[snip]
>> Hmm, we seem to have "info" these days, so maybe that would do what I
>> want. I.e., I wonder if the patch below does everything we'd want. It's
>> late here and I probably won'
Signed-off-by: Ramsay Jones
---
Hi Olga,
If you need to re-roll your 'ot/ref-filter-object-info' branch,
could you please squash this into the relevant patch (commit c5d9a471d6,
"ref-filter: use oid_object_info() to get object", 2018-07-09).
[Both sparse and my static-check
Signed-off-by: Ramsay Jones
---
Hi Junio,
I had a test failure on 'pu' today - Eric's chain-lint series
found another broken chain in one of Elijah's new tests (on the
'en/t6036-recursive-corner-cases' branch).
ATB,
Ramsay Jones
t/t6036-recursive-corner-cases.sh | 2 +-
1 file changed, 1
FUNC(BAD_TAG_NAME, INFO) \
> + FUNC(GITMODULES_PARSE, INFO) \
> FUNC(MISSING_TAGGER_ENTRY, INFO)
>
> #define MSG_ID(id, msg_type) FSCK_MSG_##id,
>
So, just squinting at this in my email client, if this allowed
a push/fetch to succeed (along with an 'info' message), while
providing an admin the means to configure it to loudly deny
the push/fetch - then I think we have a winner! ;-)
Sorry for not testing the patch.
ATB,
Ramsay Jones
On 03/07/18 15:34, Jeff King wrote:
> On Fri, Jun 29, 2018 at 02:10:59AM +0100, Ramsay Jones wrote:
>
>> On 28/06/18 23:03, Jeff King wrote:
>>> On Thu, Jun 28, 2018 at 07:53:27PM +0100, Ramsay Jones wrote:
>> [snip]
>>> Yes, it can go in quickly. But I
ems even more far-fetched. And it _is_ dangerous to leave,
> because I think existing vulnerable clients will try to load a 500MB
> .gitmodules file in memory and parse it.
I also applied and tested the patch below. I think this patch
must be included in the series.
ATB,
Ramsay Jones
> --
On 28/06/18 23:03, Jeff King wrote:
> On Thu, Jun 28, 2018 at 07:53:27PM +0100, Ramsay Jones wrote:
[snip]
> Yes, it can go in quickly. But I'd prefer not to keep it in the long
> term if it's literally doing nothing.
Hmm, I don't think you can say its doing nothing!
"Yeah,
On 28/06/18 18:45, Jeff King wrote:
> On Thu, Jun 28, 2018 at 05:56:18PM +0100, Ramsay Jones wrote:
[snip]
>>> One thing we could do is turn the parse failure into a noop. The main
>>> point of the check is to protect people against the malicious
>>> .gitmodules bu
On 28/06/18 12:49, Jeff King wrote:
> On Wed, Jun 27, 2018 at 07:39:53PM +0100, Ramsay Jones wrote:
>
>> Since commit ed8b10f631 ("fsck: check .gitmodules content", 2018-05-02),
>> fsck will issue an error message for '.gitmodules' content that cannot
>> be
ch is to just not
call the config parser if the object is to be skipped. Add a check to
the 'fsck_blob()' processing function, to determine if the object is
on the skiplist and, if so, exit the function early.
Signed-off-by: Ramsay Jones
---
Hi Junio,
I noticed recently that the 'cgit.git' repo wa
Signed-off-by: Ramsay Jones
---
Hi Stefan,
If you need to re-roll your 'sb/diff-color-move-more' branch, could
you please squash this into the relevant patch (commit f2d78d2c67,
"diff.c: add white space mode to move detection that allows indent
changes", 2018-06-21).
Thanks!
A
From: Junio C Hamano
Complete the removal of unused 'ewah bitmap' code by removing the now
unused 'rlwit_discharge_empty()' function. Also, the 'ewah_clear()'
function can now be made a file-scope static symbol.
Signed-off-by: Ramsay Jones
---
Hi Junio,
Can you please add this to the 'ds
On 15/06/18 15:30, Derrick Stolee wrote:
> Reported-by: Ramsay Jones
> Signed-off-by: Derrick Stolee
> ---
> ewah/bitmap.c | 24
> 1 file changed, 24 deletions(-)
>
> diff --git a/ewah/bitmap.c b/ewah/bitmap.c
> index d61dc6114a..52f117
On 15/06/18 15:30, Derrick Stolee wrote:
> Signed-off-by: Derrick Stolee
> ---
> ewah/ewah_io.c | 26 --
> ewah/ewok.h| 1 -
> 2 files changed, 27 deletions(-)
This duplicates Jeff's patch #3.
ATB,
Ramsay Jones
On 15/06/18 15:30, Derrick Stolee wrote:
> Reported-by: Ramsay Jones
> Signed-off-by: Derrick Stolee
> ---
> ewah/bitmap.c | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/ewah/bitmap.c b/ewah/bitmap.c
> index 756bdd050e..d61dc6114a 100644
> --- a
On 15/06/18 14:56, Ramsay Jones wrote:
>
>
> On 15/06/18 04:32, Jeff King wrote:
>> We don't call this function, and never have. The on-disk
>> bitmap format uses network-byte-order integers, meaning that
>> we cannot use the native-byte-order format wri
*(de)serialize* functions. ;-)
ATB,
Ramsay Jones
On 07/06/18 03:23, Jeff King wrote:
> On Thu, Jun 07, 2018 at 01:16:14AM +0100, Ramsay Jones wrote:
>
>>> Probably. We may want to go the same route as we did for perl in
>>> a0e0ec9f7d (t: provide a perl() function which uses $PERL_PATH,
>>> 2013-10-28
rub" &&
t/t9810-git-p4-rcs.sh: "$PYTHON_PATH" "$TRASH_DIRECTORY/scrub_ko.py"
<"$git/$file" >"$scrub" &&
$
I don't run the p4 or svn tests, so ... :-D
> really the only user in the whole code base outside of a few fringe
> commands). Leaving aside any perl vs python flame-war, I think there's
> value in keeping the number of languages limited when there's not a
> compelling reason to do otherwise.
I agree that fewer languages is (generally) a good idea.
ATB,
Ramsay Jones
se the right index instead of the_index.
>
> There is one ugly temporary workaround added in attr.c that needs some
> more explanation.
>
> Commit c24f3abace (apply: file commited * with CRLF should roundtrip
s/commited * with/commited with/
ATB,
Ramsay Jones
(flush-pkt | delim-pkt)
>
> acknowledgments = PKT-LINE("acknowledgments" LF)
> @@ -319,6 +328,10 @@ header.
> shallow = "shallow" SP obj-id
> unshallow = "unshallow" SP obj-id
>
> +wanted-refs = PKT-LINE("wanted-refs" LF)
> + *PKT-Line(wanted-ref LF)
s/PKT-Line/PKT-LINE/
ATB,
Ramsay Jones
1 - 100 of 940 matches
Mail list logo
