Re: [PATCH 2/6] http: always update the base URL for redirects

2016-12-01 Thread Ramsay Jones
follows up by asking > the server for one or more sha1 objects. But who is the > server? > > If it is still Mallory's server, then Alice will leak the > existence of those sha1s to her. ------^^^ ... to _him_ ? (again Mallory) ATB, Ramsay Jones

Re: [PATCH 4/6] http: make redirects more obvious

2016-12-01 Thread Ramsay Jones
on Bob's server. Mallory runs her own server and Ahem, so Mallory is female? (-blush-) :( ATB, Ramsay Jones

Re: [PATCH] difftool.c: mark a file-local symbol with static

2016-11-30 Thread Ramsay Jones
e of that conversation, we should be doing: >> >> warning("%s", ""); >> >> here. > > I forgot too. Thanks for digging up that thread. Yes, I blamed wt-status.c:227 and came up with commit 7d7d68022 as well. So, by the same rationale, we should remove -Wno-format-zero-length from DEVELOPER_CFLAGS. yes? ATB, Ramsay Jones

Re: [PATCH] difftool.c: mark a file-local symbol with static

2016-11-30 Thread Ramsay Jones
On 30/11/16 21:25, Jeff King wrote: > On Wed, Nov 30, 2016 at 12:40:25PM -0800, Junio C Hamano wrote: > >> Ramsay Jones <ram...@ramsayjones.plus.com> writes: >> >>> [I have fixed my config.mak file now, so I don't see the warning >>> anymore! Having -

Re: [PATCH] difftool.c: mark a file-local symbol with static

2016-11-30 Thread Ramsay Jones
On 30/11/16 11:07, Johannes Schindelin wrote: > Hi Ramsay, > > On Tue, 29 Nov 2016, Ramsay Jones wrote: >> Also, due to a problem in my config.mak file on Linux (a commented >> out line that had a line continuation '\', gr!), gcc issued a >> warning, thus:

[PATCH] difftool.c: mark a file-local symbol with static

2016-11-29 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Johannes, If you need to re-roll your 'js/difftool-builtin' branch, could you please squash this into the relevant patch. Thanks! Also, due to a problem in my config.mak file on Linux (a commented out line that had

Re: [PATCH] worktree: fix a sparse 'Using plain integer as NULL pointer' warning

2016-11-15 Thread Ramsay Jones
On 15/11/16 20:28, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> > --- > > Hi Duy, > > If you need to re-roll your 'nd/worktree-move' branch, could you > please squash this into the relevant patch [commit c49e92f5c >

[PATCH] worktree: fix a sparse 'Using plain integer as NULL pointer' warning

2016-11-15 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Duy, If you need to re-roll your 'nd/worktree-move' branch, could you please squash this into the relevant patch [commit c49e92f5c ("worktree move: refuse to move worktrees with submodules", 12-11-2016)]. Also

Re: [PATCH] t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables

2016-11-14 Thread Ramsay Jones
ashed as appropriate. No patch this time, but it simply requires those variables to be initialised to NULL in their declarations. :-D >I know that Ramsay Jones does this, for > example, with some of his sparse-related checks, and I'm pretty sure > from the

[PATCH] attr: mark a file-local symbol as static

2016-11-13 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Stefan, If you need to re-roll your 'sb/attr' branch, could you please squash this into the relevant patch. Alternatively, since there is only a single call site for git_attr() (on line #1005), you could perhaps remove gi

Re: [PATCHv2 00/36] Revamp the attr subsystem!

2016-10-28 Thread Ramsay Jones
D_MUTEX_INITIALIZER, since it causes sparse to issue some warnings, but I see that you have decided not to use it. So, phew! ;-) ATB, Ramsay Jones

Re: [PATCH] Allow stashes to be referenced by index only

2016-10-25 Thread Ramsay Jones
r. > > Perhaps > > Instead of referencing "stash@{n}" explicitly, make it possible to > simply reference as "n". Most users only reference stashes by their > position in the stash stask (what I refer to as the "index" here). s/stask/stack/ ATB, Ramsay Jones

Re: [PATCH v1 10/19] read-cache: regenerate shared index if necessary

2016-10-23 Thread Ramsay Jones
e.c > @@ -2216,6 +2216,36 @@ static int write_shared_index(struct index_state > *istate, > return ret; > } > > +static const int default_max_percent_split_change = 20; > + > +int too_many_not_shared_entries(struct index_state *istate) This function is a file-loacal symbol; could you please make it a static function. Thanks. ATB, Ramsay Jones

Re: [PATCH 28/36] attr: keep attr stack for each check

2016-10-23 Thread Ramsay Jones
t attr_stack *prev; > char *origin; > size_t originlen; > unsigned num_matches; > unsigned alloc; > struct match_attr **attrs; > -} *attr_stack; > +}; > + > +struct hashmap all_attr_stacks; > +int all_attr_stacks_init; Mark symbols 'all

Re: [PATCH 17/36] attr: expose validity check for attribute names

2016-10-23 Thread Ramsay Jones
and it certainly seems like it should be part of the public interface, but ...) In contrast, the 'invalid_attr_name_message()' function is called from code in pathspec.c, which relies on 'git_attr_counted()' to call 'attr_name_valid()' internally to check for validity. :-D ATB, Ramsay Jones

Re: [PATCH 1/2] t9000-addresses: update expected results after fix

2016-10-21 Thread Ramsay Jones
a consequence, some tests comparing it to >> Mail::Address now pass, but e3fdbcc8e1 forgot to update the test. >> >> Signed-off-by: Matthieu Moy <matthieu@imag.fr> >> --- > > Thanks. Yep, thanks for looking into this Matthieu. I applied these cleanly (to both

t9000-addresses.sh: unexpected pases

2016-10-20 Thread Ramsay Jones
simply requires a change from expect_fail to expect_success, since your commit has 'fixed' these tests ... would you mind taking a quick look? Thanks! ATB, Ramsay Jones

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Ramsay Jones
On 17/10/16 21:07, Junio C Hamano wrote: > Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> Heh, I actually have the following in my config.mak already: >> >> extra-clean: clean >> find . -iname '*.o' -exec rm {} \; >> >>

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Ramsay Jones
y config.mak already: extra-clean: clean find . -iname '*.o' -exec rm {} \; But for some reason I _always_ type 'make clean' and then, to top it off, I _always_ type the 'find' command by hand (I have no idea why) :-D ATB, Ramsay Jones

Re: [PATCH] convert: mark a file-local symbol static

2016-10-17 Thread Ramsay Jones
On 17/10/16 03:18, Jeff King wrote: > On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote: > >> Hmm, well, you have to remember that 'make clean' sometimes >> doesn't make clean. Ever since the Makefile was changed to only >> remove $(OBJECTS), rather than *.o

Re: [PATCH] convert: mark a file-local symbol static

2016-10-16 Thread Ramsay Jones
On 16/10/16 01:15, Lars Schneider wrote: >> On 15 Oct 2016, at 14:01, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: >> On 15/10/16 16:05, Lars Schneider wrote: >>>> On 11 Oct 2016, at 16:46, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: >> [snip

Re: [PATCH] convert: mark a file-local symbol static

2016-10-15 Thread Ramsay Jones
On 15/10/16 16:05, Lars Schneider wrote: >> On 11 Oct 2016, at 16:46, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: [snip] >> -void stop_multi_file_filter(struct child_process *process) >> +static void stop_multi_file_filter(struct child_process *process) > &g

[PATCH] trailer: mark file-local symbol 'conf_head' static

2016-10-15 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Jonathan, If you need to re-roll your 'jt/trailer-with-cruft' branch, could you please squash this into the relevant patch. [commit 3fb120de ("trailer: use list.h for doubly-linked list", 14-10-2016)] Thanks! A

[PATCH] sequencer: mark a file-local symbol static

2016-10-11 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Johannes, If you need to re-roll your 'js/prepare-sequencer' branch, could you please squash this into commit 53f8024e ("sequencer: completely revamp the "todo" script parsing", 10-10-2016).

[PATCH] convert: mark a file-local symbol static

2016-10-11 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Lars, If you need to re-roll your 'ls/filter-process' branch, could you please squash this into commit 85290197 ("convert: add filter..process option", 08-10-2016). Thanks. ATB, Ramsay Jones convert.c | 2 +- 1

Re: Regression: git no longer works with musl libc's regex impl

2016-10-06 Thread Ramsay Jones
008-grep-binary.sh, where the cygwin native regex library matches '.' in a pattern with the NUL character. ie the test_expect_failure test passes.] ATB, Ramsay Jones

[PATCH] run-command: fix build on cygwin (stdin is a macro)

2016-10-05 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Lars, Commit 6007c69e ("run-command: add wait_on_exit", 04-10-2016), which is part of your 'ls/filter-process' branch, causes the build to fail on cygwin, since 'stdin' is defined as a macro thus: #define

[PATCH] tmp-objdir: mark some file local symbols static

2016-10-01 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Jeff, If you need to re-roll your 'jk/quarantine-received-objects' branch, could you please squash this into the relevant patches. [I also note that tmp_objdir_destroy(), declared to be part of the public int

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-28 Thread Ramsay Jones
ignature that has expired, or a good signature made with an expired key, [Although that is still a bit cumbersome.] ATB, Ramsay Jones

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-28 Thread Ramsay Jones
or a bad signature, > - "U" for a good signature with unknown validity and "N" for no signature > +- '%G?': show "G" for a good (valid) signature, > + "B" for a bad signature, > + "U" for a good signature with unknown validity, > + "X" for a good expired signature, or good signature made by an expired key, Hmm, this looks odd. Would the following: "X" for a good signature made with an expired key, mean something different? ATB, Ramsay Jones

Re: [RFC PATCH v2] revision: new rev^-n shorthand for rev^n..rev

2016-09-25 Thread Ramsay Jones
gt; +static int try_parent_exclusion(const char *arg) > +{ > + int ret = 0; > + char *to_rev = NULL; > + char *from_rev = NULL; > + unsigned char to_sha1[20]; > + unsigned char from_sha1[20]; As Matthieu already mentioned, maybe use 'struct object_id' here. > + > + if (parse_parent_exclusion(arg, _rev, _rev)) > + goto out; > + if (get_sha1_committish(to_rev, to_sha1)) ... then 'to_sha1.hash' here, etc ... ATB, Ramsay Jones

Re: [PATCH] run-command: async_exit no longer needs to be public

2016-09-23 Thread Ramsay Jones
m the result of the above from me first and then start your >>> work from it, though, if we go that route. >> >> Sounds good to me! > > OK, here is what I queued, then. This looks good to me. Thanks! ATB, Ramsay Jones

[PATCH] run-command: async_exit no longer needs to be public

2016-09-22 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Lars, If you need to re-roll your 'ls/filter-process' branch, could you please squash this into the relevant commit c42a4cbc ("run-command: move check_pipe() from write_or_die to run_command", 20-09-2016). [

[PATCH] pkt-line: mark a file-local symbol static

2016-09-14 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Lars, If you need to re-roll your 'ls/filter-process' branch, could you please squash this into the relevant patch; commit 2afd9b22 ("pkt-line: add packet_write_gently()", 08-09-2016). [If you think the symbol sho

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Ramsay Jones
s set up earlier by: echo 'binaryQfile' | q_to_nul >a] commit f96e5673 ("grep: use REG_STARTEND for all matching if available", 22-05-2010) introduced this test and expects ".. NUL characters themselves are not matched in any way". With the native library on cygwin they are matched, with the compat/regex they are not. Indeed, if you use the system 'grep' command (rather than 'git grep'), then it will also not match ... :-D Slightly off topic, but ... ATB, Ramsay Jones

Re: [PATCH 2/3] diff_flush_patch_id: stop returning error result

2016-09-07 Thread Ramsay Jones
ability to two diff blobs, ^ Huh? ... to diff two blobs? ATB, Ramsay Jones

Re: [PATCHv4] diff.c: emit moved lines with a different color

2016-09-06 Thread Ramsay Jones
_entry *b, > + const void *unused) > +{ > + return strcmp(a->line, b->line) && > +a->hash_prev_line == b->hash_prev_line; I doubt it would make much difference, but my knee-jerk reaction to this was to suggest swapping the order of the expression, thus: return a->hash_prev_line == b->hash_prev_line && strcmp(a->line, b->line); ... but perhaps it doesn't read quite so well, and probably wouldn't affect performance much (except in strange edge cases), so it may not be worth it. ATB, Ramsay Jones

Re: [PATCH v13 10/14] apply: change error_routine when silent

2016-09-04 Thread Ramsay Jones
... >> >> Ok to do that. > > Actually I get the following error when doing that: > > apply.c: In function ‘mute_routine’: > apply.c:115:1: error: parameter name omitted > static void mute_routine(const char *, va_list) > ^ > apply.c:115:1: error: parameter name omitted > make: *** [apply.o] Error 1 Yes, this is not C++. ;-) > So I will leave it as is. I think I would prefer to see: static void mute_routine(const char *msg, va_list params) given that it would either be an error-msg or a warning-msg. ATB, Ramsay Jones

[PATCH] diff: mark a file-local symbol static

2016-08-24 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Michael, If you need to re-roll your 'mh/diff-indent-heuristic' branch, could you please squash this into the relevant patch (commit 8f5cc189, "diff: improve positioning of add/delete blocks in diffs", 22-08-2016

[PATCH] submodule: mark a file-local symbol as static

2016-08-14 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Stefan, If you need to re-roll your 'sb/submodule-clone-rr' branch, could you please squash this into the relevant patch (commit 7bcd1d17, "clone: recursive and reference option triggers submodule alternates", 11-0

[PATCH] submodule: mark a file-local symbol as static

2016-08-11 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Stefan, If you need to re-roll your 'sb/submodule-clone-rr' branch, could you please squash this into the relevant patch (commit 336c21d, "submodule: try alternates when superproject has an alternate", 08-08-2016

Re: Forward declaration of enum iterator_selection?

2016-08-08 Thread Ramsay Jones
On 08/08/16 19:28, Ramsay Jones wrote: > > > On 08/08/16 17:30, Johannes Sixt wrote: >> Am 07.08.2016 um 22:34 schrieb Ramsay Jones: >>> On 05/08/16 23:26, Johannes Sixt wrote: > [snip] >>> At this point 'enum iterator_selection' is an incomplete ty

Re: Forward declaration of enum iterator_selection?

2016-08-08 Thread Ramsay Jones
On 08/08/16 17:30, Johannes Sixt wrote: > Am 07.08.2016 um 22:34 schrieb Ramsay Jones: >> On 05/08/16 23:26, Johannes Sixt wrote: [snip] >> At this point 'enum iterator_selection' is an incomplete type and may >> be used when the size of the object is not requi

Re: Forward declaration of enum iterator_selection?

2016-08-07 Thread Ramsay Jones
tion. One solution could be to #include "iterator.h" prior to _all_ #include "refs/refs-internal.h" in all compilation units (Note it is in the opposite order in refs/iterator.c). Alternatively, you could put the #include "../iterator.h" into refs/refs-inter

[PATCH] xdiffi.c: mark some file-local symbols as static

2016-08-05 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Michael, If you need to re-roll your 'mh/diff-indent-heuristic' branch, could you please squash this into the relevant patch (e199b6e2, "diff: improve positioning of add/delete blocks in diffs", 04-08-2016). Than

[PATCH] wt-status.c: mark a file-local symbol as static

2016-08-05 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Jeff, If you need to re-roll your 'jh/status-v2-porcelain' branch, could you please squash this into the relevant patch (37f7104f, "status: print per-file porcelain v2 status data", 02-08-2016). Thanks! ATB, R

Re: [PATCH] apply: mark some file-local symbols static

2016-08-03 Thread Ramsay Jones
On 03/08/16 10:47, Christian Couder wrote: > Hi Ramsay, > > On Wed, Aug 3, 2016 at 12:44 AM, Junio C Hamano <gits...@pobox.com> wrote: >> On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones >> <ram...@ramsayjones.plus.com> wrote: >>> >>> Signe

[PATCH] apply: mark some file-local symbols static

2016-08-02 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Christian, I had intended to ask you to squash this into your 'cc/apply-am' branch, specifically commit 4d18b33a (apply: move libified code from builtin/apply.c to apply.{c,h}, 30-07-2016). However, having read that

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-24 Thread Ramsay Jones
On 24/07/16 18:16, Lars Schneider wrote: > > On 23 Jul 2016, at 01:19, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > >> On 22/07/16 16:49, larsxschnei...@gmail.com wrote: >>> From: Lars Schneider <larsxschnei...@gmail.com> >>> >>> G

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-22 Thread Ramsay Jones
Hi Lars, On 23/07/16 00:19, Ramsay Jones wrote: > > > On 22/07/16 16:49, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git's clean/smudge mechanism invokes an external filter process for every >> single bl

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-22 Thread Ramsay Jones
y_fd(fd, process->in) == 0; > + else > + ret &= 0; > + } > + > + strbuf_reset(); > + while (xread(process->out, , 1) == 1 && c != '\n') > + strbuf_addchars(, c, 1); > + nbuf_len = (size_t)strtol(nbuf.buf, _end, 10); > + ret &= (strtol_end != nbuf.buf && errno != ERANGE); > + strbuf_reset(); > + if (nbuf_len > 0) > + ret &= strbuf_read_once(, process->out, > nbuf_len) == nbuf_len; Again, how many bytes will be read? Note, that in the default configuration, a _maximum_ of MAX_IO_SIZE (8MB or SSIZE_MAX, whichever is smaller) bytes will be read. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] builtin/apply: include declaration of cmd_apply()

2016-06-29 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Christian, If you need to re-roll your 'cc/apply-am' branch, could you please squash this into the relevant patch. Commit 95a3b0ba ("apply: move libified code from builtin/apply.c to apply.{c,h}", 22-

Re: What's cooking in git.git (Jun 2016, #10; Wed, 29)

2016-06-29 Thread Ramsay Jones
to store references. > > Is everybody happy with this version? > If so, will merge to 'next'. A small fixup required for this one. see http://thread.gmane.org/gmane.comp.version-control.git/298137 ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] refs/files-backend: mark a file-local symbol static

2016-06-24 Thread Ramsay Jones
Commit 6d41edc6 ("refs: add methods for reflog", 24-02-2016), moved the reflog handling into the ref-storage backend. In particular, the files_reflog_iterator_begin() API was removed from internal refs API header, resulting in sparse warnings. Signed-off-by: Ramsay

Re: [PATCH] archive-tar: add UL type suffix to unsigned long constant

2016-06-17 Thread Ramsay Jones
On 18/06/16 00:40, Jeff King wrote: > On Fri, Jun 17, 2016 at 10:06:14PM +0100, Ramsay Jones wrote: > >> If you need to re-roll your 'jk/big-and-old-archive-tar' branch, could >> you please squash this into the relevant patch (commit 8035a1e3, >> "archive-tar: w

Re: [PATCH] run-command: mark file-local symbols static

2016-06-17 Thread Ramsay Jones
On 18/06/16 00:33, Jeff King wrote: > On Fri, Jun 17, 2016 at 10:01:24PM +0100, Ramsay Jones wrote: > >> If you need to re-roll your 'jk/gpg-interface-cleanup' branch, could >> you please squash this into the relevant patch (commit 74287e34, >> "run-command: add pip

[PATCH] archive-tar: add UL type suffix to unsigned long constant

2016-06-17 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Jeff, If you need to re-roll your 'jk/big-and-old-archive-tar' branch, could you please squash this into the relevant patch (commit 8035a1e3, "archive-tar: write extended headers for far-future mtime", 16-06-2016

[PATCH] run-command: mark file-local symbols static

2016-06-17 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Jeff, If you need to re-roll your 'jk/gpg-interface-cleanup' branch, could you please squash this into the relevant patch (commit 74287e34, "run-command: add pipe_command helper", 16-06-2016). BTW, also on tha

[PATCH] write_or_die: remove the unused write_or_whine() function

2016-06-09 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Junio, Commit f0bca72d ("send-pack: use buffered I/O to talk to pack-objects", 08-06-2016) removed the last use of write_or_whine(). I had intended to include this 'commit citation' in the commit message, but

Re: [PATCH] send-pack: use buffered I/O to talk to pack-objects

2016-06-09 Thread Ramsay Jones
On 09/06/16 18:12, Jeff King wrote: > On Thu, Jun 09, 2016 at 03:34:59PM +0100, Ramsay Jones wrote: > >> Just FYI, this patch removes the last use of write_or_whine() - should it >> be removed? > > That sounds reasonable. Want to do a patch on top? OK, wil

Re: [PATCH] send-pack: use buffered I/O to talk to pack-objects

2016-06-09 Thread Ramsay Jones
and that you don't > need write_or_whine anymore, but don't understand how you get rid of the > "return 1" here. Just FYI, this patch removes the last use of write_or_whine() - should it be removed? ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] refs: mark the file-local vtable symbols as static

2016-06-08 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Michael, Junio, I would normally ask you to squash this into the relevant patch when you next re-roll your 'mh/ref-iterators' branch, but this has already been merged into next. (I normally have a bit more time ...

[PATCH v2] regex: fix a SIZE_MAX macro redefinition warning

2016-06-06 Thread Ramsay Jones
which do not have the header (the HAVE_STDINT_H macro is not defined). In order to suppress the warning, we move the #include of from regcomp.c to the start of the compilation unit, close to the top of regex.c, prior to the #include of the regex_internal.h header. Signed-off-by: Ramsay Jones <ram...@ramsa

Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning

2016-06-05 Thread Ramsay Jones
On 05/06/16 08:15, Johannes Schindelin wrote: > Hi Ramsay, > > thanks for working on this! > > On Sat, 4 Jun 2016, Ramsay Jones wrote: > >> diff --git a/Makefile b/Makefile >> index 0d59718..3f6c70a 100644 >> --- a/Makefile >> +++ b/Makefile >

[PATCH] regex: fix a SIZE_MAX macro redefinition warning

2016-06-03 Thread Ramsay Jones
which do not have the header (the HAVE_STDINT_H macro is not defined). In order to suppress the warning, we remove the #include of from regcomp.c and set the HAVE_STDINT_H macro, using the regex.o build rule within the Makefile, to ensure that is #included from the regex_internal.h header. Si

Re: [PATCH 03/10] builtin/tag.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Ramsay Jones
r of my "type 2" cases. I'd argue it should be using a > heap buffer to handle tag and tagger names of arbitrary size. Yep. As it stands, the code following this hunk: if (header_len > sizeof(header_buf) - 1) die(_("tag header too big."));

Re: [PATCH 02/10] builtin/index-pack.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Ramsay Jones
read the whole function, because "report" is always a 4-char string). > Yuck. At least there should be a comment explaining why 48 is big > enough. Agreed, again I would use something like: char buf[GIT_SHA1_HEXSZ + 7]; /* 40 (sha1) + 4 (report) + 3 (\t\n\0) */

Re: [PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

2016-06-03 Thread Ramsay Jones
et the hook know that no editor will be launched. >*/ > if (!editor_is_used) > - hook_env[1] = "GIT_EDITOR=:"; > + argv_array_push(_env, "GIT_EDITOR=:"); > > va_start(args, name); > ret = run_hook_ve(hook_env, name, args); > va_end(args); > > + argv_array_clear(_env); > return ret; > } Indeed. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/6] worktree.c: add find_worktree()

2016-06-03 Thread Ramsay Jones
> + if (!fspathcmp(path, real_path((*list)->path))) The results of the call to real_path() should probably be cached in the worktree structure, since real_path() is relatively expensive (it calls chdir(), lstat(), readlink() etc.), so you don't want to re-compute the same result time-afte

Re: [RFC/PATCH] pathspec: allow escaped query values

2016-06-02 Thread Ramsay Jones
On 02/06/16 20:46, Junio C Hamano wrote: > Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> I think Junio wants to go with just " quoting (see other thread). > > No. I meant just \ quoting. Yes, sorry, I only just read your last email on the oth

Re: [RFC/PATCH] pathspec: allow escaped query values

2016-06-02 Thread Ramsay Jones
On 02/06/16 20:29, Junio C Hamano wrote: > Junio C Hamano <gits...@pobox.com> writes: > >> On Thu, Jun 2, 2016 at 11:42 AM, Ramsay Jones >> <ram...@ramsayjones.plus.com> wrote: >>>> >>>> That would be workable, I would think. Before attr

Re: [RFC/PATCH] pathspec: allow escaped query values

2016-06-02 Thread Ramsay Jones
On 02/06/16 20:04, Stefan Beller wrote: > On Thu, Jun 2, 2016 at 11:42 AM, Ramsay Jones > <ram...@ramsayjones.plus.com> wrote: >> >> >> On 02/06/16 17:10, Junio C Hamano wrote: >>> Ramsay Jones <ram...@ramsayjones.plus.com> writes: >>> &

Re: [RFC/PATCH] pathspec: allow escaped query values

2016-06-02 Thread Ramsay Jones
On 02/06/16 17:10, Junio C Hamano wrote: > Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> So, at risk of annoying you, let me continue in my ignorance a little >> longer and ask: even if you have to protect all of this 'magic' from >> the shell with

Re: [RFC/PATCH] pathspec: allow escaped query values

2016-06-02 Thread Ramsay Jones
On 02/06/16 06:46, Junio C Hamano wrote: > Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> Not having given this much thought at all, but the question which comes >> to mind is: can you use some other separator for the -s rather than >> a comma? That wa

Re: [RFC/PATCH] pathspec: allow escaped query values

2016-06-01 Thread Ramsay Jones
e them in the part of the -spec. (I dunno, maybe use ; or : instead?) ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] t4014: shell portability fix

2016-05-31 Thread Ramsay Jones
t exotic && > + (export GIT_AUTHOR_NAME="éxötìc"; test_commit exotic) && Isn't 'export VAR=VAL' non-portable? So, maybe: (GIT_AUTHOR_NAME="éxötìc"; export GIT_AUTHOR_NAME; test_commit exotic) && > test_when_finished "git

Re: [PATCH 09/13] refs: introduce an iterator interface

2016-05-30 Thread Ramsay Jones
On 30/05/16 16:22, Ramsay Jones wrote: > > > On 30/05/16 08:55, Michael Haggerty wrote: > [snip] > >> /* Reference is a symbolic reference. */ >> diff --git a/refs/files-backend.c b/refs/files-backend.c >> index 8ab4d5f..dbf1587 100644 >> --- a/r

Re: [PATCH 09/13] refs: introduce an iterator interface

2016-05-30 Thread Ramsay Jones
_nr + 1, > +iter->levels_alloc); > + > + level = >levels[iter->levels_nr++]; > + level->dir = get_ref_dir(entry); > + sort_ref_dir(level->dir); ... given that you sort here? >

[PATCH] log: document the --decorate=auto option

2016-05-27 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Junio, While reading an email from Linus earlier (RFC: dynamic "auto" date formats), I noticed that log.decorate was being set to 'auto'. Since I didn't recall that setting (even if it's easy to guess)

Re: [PATCH] clone: don't use an integer as a NULL pointer

2016-05-25 Thread Ramsay Jones
On 26/05/16 00:30, Stefan Beller wrote: > On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones > <ram...@ramsayjones.plus.com> wrote: >> >> Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> >> --- >> >> Hi Stefan, >> >> If you nee

[PATCH] xemit.c: fix a [-Wchar-subscripts] compiler warning

2016-05-25 Thread Ramsay Jones
*' pointer, prior to passing the dereferenced pointer to the isspace() macro. Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi René, If you need to re-roll your 'rs/xdiff-hunk-with-func-line' branch, could you please squash this (or something like it) into the relevant p

[PATCH] clone: don't use an integer as a NULL pointer

2016-05-25 Thread Ramsay Jones
Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> --- Hi Stefan, If you need to re-roll your 'sb/submodule-default-paths' branch, could you please squash this into the relevant patch. (commit 8efbe28b, "clone: add --init-submodule= switch", 23-05-2016). Thanks! A

Re: [PATCH] index-helper: use watchman to avoid refreshing index with lstat()

2016-05-13 Thread Ramsay Jones
untracked_cache(istate); > } > > +/* in ms */ > +#define WATCHMAN_TIMEOUT 1000 > + > +static int poke_and_wait_for_reply(int fd) > +{ > + int ret = -1; > + struct pollfd pollfd; > + int bytes_read; > + char reply_buf[4096]; > + const cha

Re: [PATCH v10 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-05-12 Thread Ramsay Jones
Why are you sending a flush packet - doesn't the index-helper simply ignore it? I haven't tried this yet BTW, just reading patches as they float on past... ;-) ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v9 00/19] index-helper/watchman

2016-05-10 Thread Ramsay Jones
On 10/05/16 21:30, Junio C Hamano wrote: > Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> On 10/05/16 12:52, Dennis Kaarsemaker wrote: >>> On ma, 2016-05-09 at 15:22 -0700, Junio C Hamano wrote: >>>> It passes on one box and fails on another. T

Re: [PATCH v9 00/19] index-helper/watchman

2016-05-10 Thread Ramsay Jones
e here, except ext4 instead of ext3. Failing on a virtual machine, > not failing on a physical one. I can confirm the trend: Linux Mint 17.3, ext4 - bare-metal pass, (Virtual Box) VM fail. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git&

Re: [PATCH v9 00/19] index-helper/watchman

2016-05-09 Thread Ramsay Jones
in the test. I haven't been able to debug it too much, but I can tell you that it is not failing at exactly the same place every time (so it may be time sensitive). However, it often fails in poke_and_wait_for_reply() at the first packet_flush() (which in turn calls write_or_die() which ca

Re: t6044 broken on pu

2016-05-07 Thread Ramsay Jones
On 07/05/16 14:15, Ramsay Jones wrote: > > > On 07/05/16 13:19, Andreas Schwab wrote: >> Torsten Bögershausen <tbo...@web.de> writes: >> >>> The "seq" is not understood by all shells, >>> using printf fixes this, >>> >>&

Re: t6044 broken on pu

2016-05-07 Thread Ramsay Jones
eq 1 10 >a && >> + printf 1 2 3 4 5 7 8 9 10 >a && > > $ printf 1 2 3 4 5 7 8 9 10 > 1 yep, I think: printf "%d\n" 1 2 3 4 5 6 7 8 9 10 >a && would be equivalent. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: /* compiler workaround */ - what was the issue?

2016-05-06 Thread Ramsay Jones
On 06/05/16 21:21, Ramsay Jones wrote: > On 06/05/16 19:54, Junio C Hamano wrote: >> Ramsay Jones <ram...@ramsayjones.plus.com> writes: >> [snip] > I still can't get gcc to complain, e.g. (on top of above): > > $ git diff > diff --git a/builtin/rev-list

Re: /* compiler workaround */ - what was the issue?

2016-05-06 Thread Ramsay Jones
On 06/05/16 19:54, Junio C Hamano wrote: > Ramsay Jones <ram...@ramsayjones.plus.com> writes: > >> The patch below applies to master (I haven't checked for any more >> additions). >> >> if (bisect_list) { >> -int reaches = reaches,

Re: /* compiler workaround */ - what was the issue?

2016-05-06 Thread Ramsay Jones
; = NULL" back. So we probably just do "int saved_namelen = >> 0;" in this case. >> -- > Thanks, > > I'll try and work up a patch - probably next week as I'm away for the weekend. Yeah, I don't remember why these were left over from the previous attempt to clean t

Re: [PATCH] mingw: introduce the 'core.hideDotFiles' setting

2016-05-04 Thread Ramsay Jones
h (if I'm reading it correctly) and the commit message indicate that the default is 'dotGitOnly'. > + directories and files whose name starts with a dot as hidden. > + If 'dotGitOnly', only the .git/ directory is hidden, but no other > + files starting with a dot. > + ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/2] Documentation: fix linkgit references

2016-05-04 Thread Ramsay Jones
;> b/Documentation/git-check-ignore.txt >> index e94367a..9a85998 100644 >> --- a/Documentation/git-check-ignore.txt >> +++ b/Documentation/git-check-ignore.txt >> @@ -112,7 +112,7 @@ EXIT STATUS >> SEE ALSO >> >> linkgit:gitignore[5] >> -link

t7900-*.sh tesr #5 failure

2016-05-03 Thread Ramsay Jones
t symbols? - is index-helper any use/help without watchman support? - is '! grep -q . err' meant to determine if the err file is empty (ie git status did not issue an error message)? [if yes, maybe 'test_must_be_empty err &&' would read better!] Unfortunately, I have

Re: [PATCHv5 1/2] http.c: implement the GIT_TRACE_CURL environment variable

2016-05-02 Thread Ramsay Jones
be a public symbol. (I would also re-order the function definitions, so that setup_curl_trace() comes after curl_trace(), but that is a minor point). ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] config doc: improve exit code listing

2016-04-26 Thread Ramsay Jones
On 26/04/16 20:18, Stefan Beller wrote: > On Tue, Apr 26, 2016 at 12:11 PM, Ramsay Jones > <ram...@ramsayjones.plus.com> wrote: >> >> >> On 26/04/16 19:10, Stefan Beller wrote: >>> The possible reasons for exiting are now ordered by the exit code v

Re: [PATCH] config doc: improve exit code listing

2016-04-26 Thread Ramsay Jones
(ret=1), > +- the config file is invalid (ret=3), > +- the config file cannot be written (ret=4), > - you try to unset an option which does not exist (ret=5), > - you try to unset/set an option for which multiple lines match (ret=5), or > - you try to use an invalid regexp (ret=6).

Re: [PATCH] remote.c: spell __attribute__ correctly

2016-04-25 Thread Ramsay Jones
ers which don't know about it. Is >>> VS (or another file) setting __GNUC__? >> >> Of course it helps if we spell the name right... Indeed! ;-) Not that it matters, but the above #define in git-compat-util.h is not the relevant definition - msvc will not see it. However, it does see the #

Re: [PATCH 00/83] libify apply and use lib in am

2016-04-24 Thread Ramsay Jones
On 24/04/16 17:56, Christian Couder wrote: > On Sun, Apr 24, 2016 at 6:27 PM, Christian Couder > <christian.cou...@gmail.com> wrote: >> On Sun, Apr 24, 2016 at 5:23 PM, Ramsay Jones >> <ram...@ramsayjones.plus.com> wrote: >>> >>&g

<    1   2   3   4   5   6   7   8   9   10   >