Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
read-cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/read-cache.c b/read-cache.c
index b69dd05..211b971 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1204,9 +1204,11 @@ static int index_changed(struct stat st_old
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Thomas,
Passing the 'struct stat' parameters by value, while not *wrong*, looks
somewhat odd to my eyes. As I said before, feel free to ignore this one.
ATB,
Ramsay Jones
read-cache.c | 20 ++--
1 file changed, 10
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Thomas,
I note that index_changed(), which has no side effects, is called with
unchanged parameters twice each time around the loop. I was about to
suggest saving the result of a single call and using it in both places ...
However
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
The current implementation of git_path() is essentially the same as
that of vsnpath(), with two minor differences. First, git_path()
currently insists that the git directory path is no longer than
PATH_MAX-100 characters
did so by accident. (That's a guess, of course)
However, I much prefer git_snpath(), git_pathdup() and git_path()
return the same result string given the same inputs! :D
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
Could you please squash this into commit 1784d096 (test-generation:
compute generation numbers and clock skews, 04-09-2012).
Thanks!
ATB,
Ramsay Jones
test-generation.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/test-generation.c b/test
In particular, sparse complains that ... 'dump_grep_expression'
was not declared. Should it be static?. In order to suppress
the warning, since this function does not need more than file
scope, we simply include the static modifier in it's declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
Heh, so I obviously didn't see this before sending the patch yesterday! :-D
Yes, this solves the problem addressed by yesterday's patch, so please
ignore that. However, this tickles sparse to complain as well
Sparse issues a warning for all six external symbols defined in this
file. In order to suppress the warnings, we include the 'pathspec.h'
header file, which contains the relevant extern declarations for these
symbols.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Adam,
When you
.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Nguyen,
If you need to re-roll your 'nd/pretty-placeholder-with-color-option'
branch, could you please squash this (or something like it) into the
relevant commit. [commit f1da75df (pretty: support padding placeholders,
% % and %, 23-09
directive.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
Now that the malloc checks have been enabled, running the tests has
become somewhat noisy with malloc: using debugging hooks messages
spewing continuously to the terminal. [I usually run the tests like
so:
ramsay$ time
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
variable, either from the environment or command line of an
'make test' invocation. In order to allow the malloc checks to be
disabled from the 'config.mak
Elia Pinto wrote:
2012/10/6 Junio C Hamano gits...@pobox.com:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
Elia, you brought the MALLOC_CHECK_ up. Did you hear about this
issue elsewhere before, and if you did, do you know how other
projects solves it?
Ok. I have found. For me
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
This test in the current pu branch (commit bb0e6bf Merge branch
'aw/rebase-am-failure-detection' into pu, 11-10-2012) overwrites
the contents of t/.gitattributes. Note that the merge of the two
branches 'nd/wildmatch' and 'nd
Sparse issues a warning for all six external symbols defined in this
file. In order to suppress the warnings, we include the 'pathspec.h'
header file, which contains the relevant extern declarations for these
symbols.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Nguyen,
I
the declaration to
the top level of the header.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
Now that v1.8.3 is out, I note that this patch seems to have been
dropped (or did I miss something?).
This used to be
[PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file
;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the declaration to
the top level of the header.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
As promised, this fixes the build on cygwin. (tested on cygwin
and MinGW. I have not tested on Linux, because I would have to
re-boot twice, and I wanted to send this out tonight
to GIT_WINDOWS_NATIVE
I stopped keeping track of the discussion and my vague recollection
was that it is OK for 1.5 but not verified on 1.7 or something?
The tests I did under cygwin 1.7 did not show any regression.
Thank you for testing this.
ATB,
Ramsay Jones
--
To unsubscribe from
Sparse issues an 'object_array_slopbuf' not declared. Should it be
static? warning. In order to suppress the warning, since this
symbol does not need more than file visibility, we simply add the
static modifier to its declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi
At present, 'git show-ref' ignores any attempt to set config
variables (e.g. core.checkstat) from the command line using
the -c option to git. In order to enable such usage, add the
missing call to git_config() from cmd_show_ref().
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
At present, 'git pack-refs' ignores any attempt to set config
variables (e.g. core.checkstat) from the command line using
the -c option to git. In order to enable such usage, add the
missing call to git_config() from cmd_pack_refs().
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
processing? *dunno*.]
ATB,
Ramsay Jones
Ramsay Jones (2):
show-ref.c: Add missing call to git_config()
pack-refs.c: Add missing call to git_config()
builtin/pack-refs.c | 3 +++
builtin/show-ref.c | 2 ++
2 files changed, 5 insertions(+)
--
1.8.3
--
To unsubscribe from this list: send
, but ...), but this failure
is clearly a cygwin specific issue.
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Michael Haggerty wrote:
Thanks for all of the information.
On 06/15/2013 10:13 PM, Ramsay Jones wrote:
Michael Haggerty wrote:
*This patch series must be built on top of mh/reflife.*
[ ... ]
You may be wondering why clear_packed_ref_cache() is called? Well, that
is because
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
At present, 'git show-ref' ignores any attempt to set config
variables (e.g. core.checkstat) from the command line using
the -c option to git.
I think what you really want to see is not giving -c and have it
honored
the special cygwin functions.
(And have a look how to improve the core.filemode)
I don't understand this (parenthetical) comment; could you
elaborate on this.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
Michael Haggerty and Jeff King have been re-vamping the reference
handling code. The failures noted above were provoked by patches
in the 'mh/ref-races' branch. At the time I wrote this patch, that
branch was only
Michael Haggerty wrote:
On 06/25/2013 07:07 AM, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
Michael Haggerty and Jeff King have been re-vamping the reference
handling code. The failures noted above were provoked by patches
in the 'mh/ref-races' branch. At the time I
Jeff King wrote:
On Wed, Jun 26, 2013 at 10:45:48PM +0100, Ramsay Jones wrote:
[ ... ]
I think Michael's assessment above is missing one thing. It is true that
a false positive is just a performance problem in most cases, as we
unnecessarily reload the file, thinking it has changed.
However
, and here occasional
mistakes might be considered acceptable. So for this purpose the
unreliable stat() might be used.
I have already written the first pass at this patch, but I'm having
difficulty with naming (get_cached_stat_data, get_index_stat_data,
get_stat_data, ... ;-)
ATB,
Ramsay Jones
test shows that core.filemode=true.
Hmm, it shouldn't - confused!
Sorry for confusion.
ATB
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the UNRELIABLE_FSTAT build variable set.
HTH
ATB,
Ramsay Jones
-- 8 --
Subject: [PATCH] cygwin: Add an Win32 fstat implementation
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
compat/cygwin.c | 41 +
compat/cygwin.h | 3 +++
2 files changed, 44 insertions
Ramsay Jones wrote:
Michael Haggerty wrote:
On 06/27/2013 12:35 AM, Jeff King wrote:
[ ... ]
I think Michael's assessment above is missing one thing.
Peff is absolutely right; for some unknown reason I was thinking of the
consistency check as having been already fixed.
Well, the cygwin
what effect this
would have on performance. (I noticed that the test suite ran about 2%
slower with the above applied).
A simple pass-though fast_fstat(), including on cygwin, is probably the
way to go.
Sorry for being a bit slow on this - I'm very busy at the moment. :(
ATB,
Ramsay Jones
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
Yes, I will send a v2 (soon-ish, I hope).
Ping?
No need to hurry, but just to make sure this didn't disappear from
everybody's radar.
Yep, this is still on my TODO list.
Sorry for being tardy on these patches
);
string_list_clear(ceiling_dirs, 0);
+ free(path);
printf(%d\n, len);
return 0;
}
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More
the problem).
Also: Note that the first test calls git-cvsimport twice, first *with*
TZ set then again without; I suspect a cut/paste editing error.
I have added the output of ./t9604-cvsimport-timestamps.sh -v below.
ATB,
Ramsay Jones
ramsay@ramsay-laptop:$ ./t9604-cvsimport-timestamps.sh -v
to document a difference in
behaviour to GNU grep).
So, if we use the GNU interface to the regex routines in compat, then we may
specify the grep syntax for use in git-grep. (Well that's the theory, I've
not actually tried to code it up, so take this with a pinch of salt! :-P ).
ATB,
Ramsay Jones
?
This patch fixes the test for me.
Thanks!
ATB,
Ramsay Jones
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index ceb119d..4c44050 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -24,11 +24,12 @@ use File::Basename qw(basename dirname);
use Time::Local;
use IO::Socket;
use
Jeff King wrote:
On Fri, Nov 02, 2012 at 09:33:14PM +, Ramsay Jones wrote:
(Linux is my main platform, but I like to keep cygwin working because it has
kept me sane on Windows ever since (about) 1995 ...)
Stranger in a strange land ;-)
I used a different trick around the same time
, in order to suppress the warning, we simply initialize the
variable to zero in it's declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
Could you please squash this into commit df126e108 (remote-curl: hoist
gzip buffer size to top of post_rpc, 31-10-2012), which is part
Jeff King wrote:
On Sat, Nov 10, 2012 at 06:33:38PM +, Ramsay Jones wrote:
We should probably wrap it. I'm planning to queue this on top of Chris's
patch:
Unfortunately, I haven't had time yet to test this patch. (Early this week, I
went into hospital for a minor surgical procedure - I
which platform you are on, but maybe you also have a
thread-unsafe pread()? Could you try re-building git with the
NO_THREAD_SAFE_PREAD build variable set?
HTH.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
system to determine if your pread() is thread-safe
or not. (gcc -I. -o test-pread test-pread.c; ./test-pread)
Also, what is the output of uname -a.
ATB,
Ramsay Jones
-- 8 --
#include git-compat-util.h
#include thread-utils.h
#define DATA_FILE junk.data
#define MAX_DATA 256 * 1024
#define
can achieve to compile git both under old and new
cygwin 1.7 ?
Or is this not worth the effort?
Did the cygwin project not bump an api version number somewhere?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
Torsten Bögershausen wrote:
On 13.11.12 19:55, Ramsay Jones wrote:
Douglas Mencken wrote:
*Any* git clone fails with:
fatal: premature end of pack file, 106 bytes missing
fatal: index-pack failed
At first, I tried 1.8.0, and it failed. Then I tried to build 1.7.10.5
then, and it worked
in the POSIXy form
/c/cygwin/tmp/commit or /tmp/commit.
I would argue precisely this! :-D
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
This is on top of next. (commit df126e108: remote-curl: hoist gzip
buffer size to top of post_rpc, 31-10-2012).
Thanks!
ATB,
Ramsay Jones
remote-curl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
', while t/t0007-ignores.sh is added by branch 'as/check-ignore'.
Also:
$ make test-lint-executable
non-executable tests: t5801-remote-helpers.sh
make: *** [test-lint-executable] Error 1
$
(added in branch 'fc/fast-export-fixes').
HTH
ATB,
Ramsay Jones
--
To unsubscribe from
the v1.8.1-rc0
tag. Is this just an oversight (the above list suggests not), or should I not
be using kernel.org?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that the GIT_TEST_PRINT variable is used in the --color version
of say_color(), and does not provide the line termination character.
In contrast, the GIT_TEST_PRINT_LN variable is used by the --no-color
version of say_color() and does provide the line termination.
Signed-off-by: Ramsay Jones ram
-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
This is against next (branch 'nd/wildmatch'). As an alternative solution,
I could build with NO_FNMATCH, since the compat version does support the
POSIX charater classes.
ATB,
Ramsay Jones
t/t3070-wildmatch.sh | 6 +++---
1 file changed
constant instead.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Antoine,
When you re-roll your mailmap patches (branch 'ap/log-mailmap') could
you please squash this into commit a09b6cd9 (mailmap: Remove buffer
length limit in map_user, 11-12-2012).
Thanks!
ATB,
Ramsay Jones
Nguyen Thai Ngoc Duy wrote:
On Sun, Dec 16, 2012 at 2:19 AM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
The failing tests make use of a POSIX character class, '[:xdigit:]'
in this case, which some versions of the fnmatch() library function
do not support. In the spirit of commit f1cf7b79
relates to an expression, as part of an if
conditional, using the equality operator to compare the 'dir'
variable to zero. In order to suppress the warning, we replace
the 'dir == 0' expression with the more idiomatic '!dir'.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Zoltan,
If you
In particular, sparse issues an symbol not declared. Should it be
static? warning for the 'parse_args' function. Since this function
does not require greater than file visibility, we suppress this
warning by simply adding the static modifier to it's decalaration.
Signed-off-by: Ramsay Jones ram
for me), but it seems to work to that extent.
(I also tried a few simple commands: status, diff, branch; seems to work OK.)
If you would like me to test something else, just let me know.
HTH
ATB,
Ramsay Jones
-- 8 --
diff --git a/Makefile b/Makefile
index 1b30d7b..1c84f68 100644
--- a/Makefile
+++ b
there would be many idiots^H^H^H^H^H^H pioneers like me! :-D
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Commit fa2364ec (Which merge_file() function do you mean?, 06-12-2012)
renamed the files merge-file.[ch] to merge-blobs.[ch], but forgot to
rename the header file in the definition of the LIB_H macro.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Makefile | 2 +-
1 file changed, 1
Jonathan Nieder wrote:
Ramsay Jones wrote:
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -85,12 +85,6 @@
#define _NETBSD_SOURCE 1
#define _SGI_SOURCE 1
-#ifdef WIN32 /* Both MinGW and MSVC */
-#define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
-#include
for confusion.
Yes, I compiled the last patch on MinGW before I sent it to the list.
I didn't bother with MSVC, since that build is already broken.
I have a patch which fixed the MSVC build, but it already needs to
be updated, since current master fails to build on MSVC.
ATB,
Ramsay Jones
GIT_WIN32.
(Yeah, I'm not good at choosing names!)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
with commits in
their repository.
HTH
ATB,
Ramsay Jones
Ramsay Jones (5):
msvc: Fix compilation errors caused by poll.h emulation
msvc: git-daemon: Fix linker unresolved external errors
msvc: Fix build by adding missing symbol defines
msvc: test-svn-fe: Fix linker unresolved external error
msvc
, since
it is now redundant and it's presence may cause some confusion.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
compat/vcbuild/include/sys/poll.h | 1 -
git-compat-util.h | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
delete mode 100644 compat/vcbuild
the linker errors, we also configure the MSVC build
to use the internal compat versions of these functions by setting
the NO_INET_{PTON,NTOP} build variables.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
config.mak.uname | 2 ++
1 file changed, 2 insertions(+)
diff --git
.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
compat/vcbuild/include/unistd.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/compat/vcbuild/include/unistd.h b/compat/vcbuild/include/unistd.h
index b14fcf9..c65c2cd 100644
--- a/compat/vcbuild/include/unistd.h
+++ b/compat/vcbuild
() and _strtoi64(). This allows us to
remove NO_STRTOULL for MSVC.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
compat/msvc.h| 2 ++
config.mak.uname | 1 -
test-svn-fe.c| 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/compat/msvc.h b/compat/msvc.h
index
to perform an MSVC build, which is usually
executed using MinGW tools, we can also benefit from this capability.
In order to reap the above benefits, we set the ETAGS_TARGET build
variable to ETAGS in the MSVC config block.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
config.mak.uname | 1
) in
test_set_prereq SED_STRIPS_CR
;;
*CYGWIN*)
- test_set_prereq POSIXPERM
test_set_prereq EXECKEEPSPID
test_set_prereq NOT_MINGW
test_set_prereq SED_STRIPS_CR
So, I'm not in favour of this, FWIW.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send
simply remove the 0 from
the while loop controlling expression.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
When you next re-roll your 'jk/pkt-line-cleanup' patches, could you
please squash this (or something like it) into commit 17243606
(pkt-line: share buffer/descriptor
that - I'm currently stuck on 32bits!]
ATB,
Ramsay Jones
[1] git://git.kernel.org/pub/scm/devel/sparse/sparse.git (which had been
dormant for quite some time, but sprang to life again last week).
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
Jeff King wrote:
On Sat, Feb 23, 2013 at 05:31:34PM -0500, Jeff King wrote:
On Sat, Feb 23, 2013 at 06:44:04PM +, Ramsay Jones wrote:
Sparse issues the following error and warnings:
pkt-line.c:209:51: warning: Using plain integer as NULL pointer
sideband.c:41:52: warning
Johannes Sixt wrote:
Am 2/25/2013 7:54, schrieb Junio C Hamano:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
As I mentioned recently, while discussing a cygwin specific patch
(see Version 1.8.1 does not compile on Cygwin 1.7.14 thread), the
MSVC build is broken for me.
The first 4
more than file scope.
In order to suppress the NULL pointer warnings, we simply replace
the use of the integer constant zero as a representation of the null
pointer with the NULL symbol.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Thomas,
If you need to re-roll the patches
advice.pushnonffdefault config variable
(including it's documentation).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
Commit 27f76a2b is in next, but you are about to re-build next, right?
Could you please squash this (or something like it) into commit 27f76a2b.
Note
' used
c:\msysgit\msysgit\home\ramsay\git\merge-recursive.c(1886) : warning C4700:\
uninitialized local variable 'mrtree' used
ATB,
Ramsay Jones
[1] In case you are puzzled by this, the warning is coming from
the linker, since the msvc build is using link-time code-gen/optimisation
) in the
note_change_n() function, we adopt the same solution used by commit
3aa99df8.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
fast-import.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fast-import.c b/fast-import.c
index a0c2c2f..5f539d7 100644
--- a/fast-import.c
+++ b/fast
.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
An alternative solution may look like this (note: *untested*):
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index ad29000..e50b20f 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -193,7 +193,6 @@ static
mildly surprised at the lack
of complaints from cygwin users, but it would be nice to be able to point
them to a release if they start flooding in :-P ).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More
secs ( 0.02 usr 0.03 sys + \
0.84 cusr 0.41 csys = 1.29 CPU)
Result: NOTESTS
$
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jonathan,
This is an RFC because I suspect some people may prefer the much
simpler patch:
diff --git a/t/t3300-funny-names.sh b/t
=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.03 sys + \
0.84 cusr 0.41 csys = 1.29 CPU)
Result: NOTESTS
$
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jonathan,
This version of the patch only moves code to determine the test
prerequisite to the outer level
a v2 patch soon.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to it
immediately; I need to set aside *at least* one full evening to running the
testsuite on cygwin! ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
: NOTESTS
$
So why did I abandon this patch? Well, I didn't really; I just decided
that I needed *much* more time to polish[1] 'test_fixture'. I wanted to
fix the TAP parse error problem before v1.7.12-rc0! :(
HTH
ATB,
Ramsay Jones
[1] For example, what should/will happen if someone uses
files that require
the TABS_IN_FILENAME prerequisite?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tests.
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, it seems to me to be a stale (redundant)
test. So, patch #2 removes that test! :-D [I wish I could reproduce the
failure because I don't like not knowing why it failed, but ...]
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
' at the start
of the test.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/t1100-commit-tree-options.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh
index a3b7723..f8457f9 100755
--- a/t/t1100-commit-tree-options.sh
of the test,
it creates and adds 1024 files to the index, which is now wasted
effort.
Remove test 59, since it is now redundant.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/t7810-grep.sh | 11 ---
1 file changed, 11 deletions(-)
diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh
René Scharfe wrote:
Am 28.07.2012 20:46, schrieb Ramsay Jones:
Unfortunately, I was unable to reproduce the final failure in t7810-grep.sh.
I tried, among other things, to provoke a failure thus:
$ for i in $(seq 100); do
if ! ./t7810-grep.sh -i -v; then
break
Jeff King wrote:
On Tue, Mar 26, 2013 at 07:09:44PM +, Ramsay Jones wrote:
Commit cbfd5e1c (drop some obsolete x = x compiler warning hacks,
21-03-2013) removed a gcc hack that suppressed an might be used
uninitialized warning issued by older versions of gcc.
However, commit 3aa99df8
Jeff King wrote:
On Tue, Mar 26, 2013 at 07:20:11PM +, Ramsay Jones wrote:
After commit cbfd5e1c (drop some obsolete x = x compiler warning
hacks, 21-03-2013) removed a gcc specific hack, older versions of
gcc now issue an 'contents' might be used uninitialized warning.
In order
thought they would not be accepted since they
have 'upstream's. However, given the recent patches fixing up
spelling mistakes, I decided it was worth a try ... ;-)
The final patch was a direct result of testing patch 5 on linux.
ATB,
Ramsay Jones
Ramsay Jones (6):
clone: Make the 'junk_mode
Sparse issues an 'junk_mode' not declared. Should it be static?
warning. In order to suppress the warning, since this symbol does
not need more than file visibility, we simply add the static
modifier to it's declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
builtin/clone.c
the declaration to the top level of the header.)
In order to suppress the warning, since this symbol does not need
more than file visibility, we simply remove the declaration from
the header and add the static modifier to the function definition.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
with NULL and add the static modifier to the function
definitions.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
compat/regex/regexec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/compat/regex/regexec.c b/compat/regex/regexec.c
index 0194965..0cd6e0e 100644
include the stddef.h header
which provides an appropriate definition of the NULL macro, rather
than using the (inappropriate) default definition at fnmatch.c:132.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
compat/fnmatch/fnmatch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
simply include the missing 'empty parameter list' prototype (void)
in the function declarations.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Makefile | 1 +
compat/nedmalloc/malloc.c.h | 2 +-
compat/nedmalloc/nedmalloc.c | 4 ++--
3 files changed, 4 insertions(+), 3
101 - 200 of 940 matches
Mail list logo
