Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
branch.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/branch.c b/branch.c
index 660097b..8dc0d49 100644
--- a/branch.c
+++ b/branch.c
@@ -184,9 +184,9 @@ int validate_new_branchname(const char
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/commit.c | 2 +-
builtin/fsck.c | 4 ++--
cache-tree.c | 30 +++---
cache-tree.h | 3 ++-
merge-recursive.c | 2 +-
reachable.c| 2
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
bundle.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/bundle.c b/bundle.c
index 1222952..798ba28 100644
--- a/bundle.c
+++ b/bundle.c
@@ -11,11 +11,11 @@
static
specifically did not choose sha1 since it
looks weird to have sha1-sha1 and I didn't want to rename lots of
variables.
Comments?
brian m. carlson (9):
Define a structure for object IDs.
bisect.c: convert to use struct object_id
archive.c: convert to use struct object_id
zip: use GIT_OID_HEXSZ
On Sat, May 03, 2014 at 08:12:13PM +, brian m. carlson wrote:
This is a preliminary RFC patch series to move all the relevant uses of
unsigned char [20] to struct object_id. It should not be applied to any
branch yet.
The goal of this series to improve type-checking in the codebase
plenty of aggravation
with code that makes unportable alignment assumptions. I don't want to
make that mistake myself.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994
On Sun, May 04, 2014 at 08:35:00AM +0200, Michael Haggerty wrote:
On 05/03/2014 10:12 PM, brian m. carlson wrote:
I called the structure member oid because it was easily grepable and
distinct from the rest of the codebase. It, too, can be changed if we
decide on a better name. I
pass -Wno-format-zero-length, but it seems compiler-specific
flags are frowned upon, so let's just avoid the warning altogether.
I believe these warnings existed before GCC 4.9 as well, but I'm not
opposed to the change.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791
, INDEX } *modes;
- struct stat st;
+ struct stat src_st,dst_st;
Extremely minor nit: we generally put a space after the comma.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC
this, but if it is
working reasonably well for people (as it appears to be), I don't see a
reason to remove it.
I don't feel I need a CC if a reply is made to this message.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
it myself if it were available.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
On Sat, May 10, 2014 at 10:32:26AM -0700, milki wrote:
On 17:23 Sat 10 May , brian m. carlson wrote:
I don't believe this is possible. There has been some discussion on
related matters at least fairly recently, though.
Part of the reason nobody has implemented this is because
credentials in this case (how to do that is unknown).
* Provide some way of forcing git to use a particular authentication
protocol.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2
On Mon, May 12, 2014 at 04:21:53PM -0400, Jeff King wrote:
On Sat, May 10, 2014 at 09:01:32PM +, brian m. carlson wrote:
* Make git understand that it really needs to try again with different
credentials in this case (how to do that is unknown).
It should be pretty straightforward
server's error message on RPC failure
The server might provide a custom error message that is useful to the user.
Provide this message to the user if HTTP RPC fails.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
remote-curl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
),
+ OPT_BIT(0, signed, flags, N_(GPG sign the push),
TRANSPORT_PUSH_CERT),
OPT_END()
};
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196
with just plus signs here? I'm not
aware of anywhere else in the Documentation where we do that.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223
git binary is not linked with libcurl, only the HTTP and FTP
programs. You'd want to check git-remote-http, for instance.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B
::Spec-abs2rel or File::Spec-rel2abs, and then go from there.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description
on display).
I wonder if git send-email should do what mutt does in this case, which
is use quoted-printable encoding and encode the first F as =46 (as well
as any equals signs as =3D). It looks like mailinfo.c already is
capable of handling that, and that would avoid the entire issue.
--
brian m
, so any options would have to be implemented in Git.
We'd probably want to make such a change effective in the zip format as
well.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2
. Are you using a proxy? Can you try
using a git, ssh, or https (without MITM) URL? Sometimes broken proxies
can end up corrupting data.
Also, what version of git are you using on the client and the server?
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
there's any
good way around it, though.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
the pretty formats documentation to use matching pairs to prevent
a misrendering where the remainder of the document was rendered as a
listing block.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/pretty-formats.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion
in getting git's documentation to work better with
Asciidoctor out of the box, so you may see some patches along that line
sometime soon.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC
a
patch, which should be forthcoming in a future release of Git.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description
by users wishing to use Asciidoctor instead of Asciidoc.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/Makefile | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index cea0e7a
The documentation for git-imap-send uses block delimiters with
mismatched lengths, which Asciidoctor doesn't support. As a result, the
page is misrendered. Adjust the delimiters so that they are of the same
length.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation
to improve compatibility.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-prune-packed.txt | 2 +-
Documentation/git-quiltimport.txt | 2 +-
Documentation/git-stage.txt| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/git
AsciiDoc uses a configuration file to implement macros like linkgit,
while Asciidoctor uses Ruby extensions. Implement a Ruby extension that
implements the linkgit macro for Asciidoctor in the same way that
asciidoc.conf does for AsciiDoc.
Signed-off-by: brian m. carlson sand
m. carlson (4):
Documentation: adjust document title underlining
Documentation: fix mismatched delimiters in git-imap-send
Documentation: move some AsciiDoc parameters into variables
Documentation: implement linkgit macro for Asciidoctor
Documentation/Makefile | 18
On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
The second two patches implement some basic support for building with
Asciidoctor. The first of these moves some items into variables due to
some differences between
On Tue, Oct 14, 2014 at 12:07:51PM +0200, Jakub Narębski wrote:
brian m. carlson wrote:
On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote:
What I do not understand is that 3/4 lets you drop inclusion of
asciidoc.conf which contains a lot more than just linkgit:
definition
On Tue, Oct 14, 2014 at 10:08:19AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
On Sat, Oct 11, 2014 at 11:37:32PM +, brian m. carlson wrote:
Specifically I'm not excited about getting into a state where we have to
maintain both an asciidoc.conf file _and_ ruby
with both would therefore be my choice.
That's my goal. I simply wanted the ability to support both AsciiDoc
and Asciidoctor without making major changes to the codebase. Hence,
moving the calls into variables.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
variants and exceptions to make such an
approach infeasible?
I'm on board with the $(ASCIIDOC_COMMON) idea, but to minimize the
number of variables, I think we should leave the -d out of the macro
itself. I'll re-roll over the next couple of days.
--
brian m. carlson / brian with sandals: Houston
to improve compatibility.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-prune-packed.txt | 2 +-
Documentation/git-quiltimport.txt | 2 +-
Documentation/git-stage.txt| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/git
the
following command line:
make doc ASCIIDOC=asciidoctor ASCIIDOC_HTML=html5 \
ASCIIDOC_DOCBOOK=docbook45 ASCIIDOC_EXTRA='-alitdd=#45;#45;' \
ASCIIDOC_CONF=
This resulted in a total build time (documentation only) of 3:17 versus
5:43 for AsciiDoc (a 42% improvement).
brian m. carlson (3
by users wishing to use Asciidoctor instead of Asciidoc,
and simplify several redundant rules.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/Makefile | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/Documentation
The documentation for git-imap-send uses block delimiters with
mismatched lengths, which Asciidoctor doesn't support. As a result, the
page is misrendered. Adjust the delimiters so that they are of the same
length.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation
and all Linux pax
implementations extract the pax headers into the working directory, and
that's often /tmp.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552
.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
). While the contents probably aren't sensitive, a malicious
user might fill someone's quota by helpfully appending /dev/zero to
the file. And yes, users do these things.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My
/git/blob/master/Documentation/howto/maintain-git.txt
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital
:
[remote origin]
fetch = refs/heads/*:refs/heads/*
You won't be able to fetch if you would overwrite the current branch,
though.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2
On Sun, Oct 26, 2014 at 07:59:55PM +0100, René Scharfe wrote:
Am 23.10.2014 um 03:09 schrieb brian m. carlson:
The pax format is an extension of the tar format. All of the pax
implementations I've seen on Linux (OpenBSD's and MirBSD's) don't
actually understand the pax headers and emit them
The Makefile performs several very similar tasks to convert AsciiDoc
files into either HTML or DocBook. Move these items into variables to
reduce the duplication.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/Makefile | 22 +++---
1 file changed
Asciidoctor provides an extension implementing a backend-independent
macro for dealing with manpage links just like the linkgit macro. As
this is more likely to be up-to-date with future changes in Asciidoctor,
prefer using it over reimplementing in Git.
This reverts commit
to enable the use of
Asciidoctor, but I want to defer that until a later point. There isn't
a released version of Asciidoctor with the necessary changes and I'd
like to avoid confusing users by making them think it will work when it
probably won't.
brian m. carlson (2):
Documentation: refactor
directory, it would
probably be welcome.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
(or file system).
meet this requirement, untracked cache is not for you. Most file
systems on *nix should be fine. On Windows, NTFS is fine while FAT may
be not [1] even though FAT on Linux seems to be fine.
Tiny nit: may be not should probably be may not be.
--
brian m. carlson / brian
clone
creates an entirely new copy of the original repository.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description
. This is very useful.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
different here.
}
I didn't stick the require in the eval because git-send-email will fail
in this case anyway if you don't have it, since Net::SMTP::SSL requires
it. Let me know if you want a patch for this on top of the existing two
in this series and I'll provide one.
--
brian m. carlson / brian
; in this case,
print a warning and inform the user of this fact.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
This is completely untested. I used perl -c, but that's it.
git-send-email.perl | 50 --
1 file changed, 36 insertions
. Perhaps Convert comments to American English is
more accurate?
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description
There are configuration options for each submodule that specify under what
circumstances git status should display output for that submodule.
Unfortunately, these settings were not being respected, and as such the tests
were marked TODO.
This patch series consists of two patches: the first is a
git status prints information for submodules, but it should ignore the status of
those which have submodule.name.ignore set to all. Fix it so that it does
properly ignore those which have that setting either in .git/config or in
.gitmodules.
Signed-off-by: brian m. carlson sand
which ones I can fix, and I generally just CC the last three or
four people who touched the files in question.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My
more familiar with the code.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
=.vim/bundle/ctrlp,
destination=.vim/bundle/ctrlq
Can you provide me a set of steps to reproduce that operation so I can
test it effectively?
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b
at an upper bound of 0xfffeU, so hsize contains a maximum
value of 0x3fff, which is smaller than (1u31), so i will never
be larger than 31.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b
On Sun, Aug 11, 2013 at 04:03:17PM +, brian m. carlson wrote:
On Sat, Aug 03, 2013 at 11:24:20AM -0700, Jonathan Nieder wrote:
If I just renamed a submodule, will 'module_name $path' do the right
thing with the old path?
module_name uses whatever's in .gitmodules. I'm not sure what
modules which are to be
deleted.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
git-submodule.sh | 7 +++
t/t7508-status.sh | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 38520db..c1ba0f8 100755
--- a/git
.
brian m. carlson (2):
submodule: fix confusing variable name
submodule: don't print status output with ignore=all
git-submodule.sh | 15 +++
t/t7508-status.sh | 4 ++--
2 files changed, 13 insertions(+), 6 deletions(-)
--
1.8.4.rc2.564.g10ce5ae
--
To unsubscribe from this list
cmd_summary reads the output of git diff, but reads in the submodule path into a
variable called name. Since this variable does not contain the name of the
submodule, but the path, rename it to be clearer what data it actually holds.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
When git submodule summary is run and there is a deleted submodule, there is an
warning from git rev-parse:
fatal: Not a git repository: '.vim/pathogen/.git'
Silence this warning, since it is fully expected that a deleted submodule will
not be a git repository.
Signed-off-by: brian m. carlson
When git submodule summary is run and there is a deleted submodule, there is an
warning from git rev-parse:
fatal: Not a git repository: '.vim/pathogen/.git'
Silence this warning, since it is fully expected that a deleted submodule will
not be a git repository.
Signed-off-by: brian m. carlson
not do it anyway, but at what point do
we say you were warned?
It already has changed. At cPanel, we had code that broke with a new
version of git because the output of git status changed between 1.7.11
and 1.8.3. We fixed it to use --porcelain and had no problems.
--
brian m. carlson / brian
never honor the ignore settings.
How do we want to handle this? I can send a reroll and include some
new tests, but if this code is going away, then there's no point.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion
is given.
Changes from v2:
* Add tests to ensure that git submodule summary is not affected.
* Fix bug that caused git submodule summary to be affected.
Changes from v1:
* Handle moved submodules by not ignoring them.
* Use sm_path instead of path.
* Only ignore when --for-status is given.
brian m
cmd_summary reads the output of git diff, but reads in the submodule path into a
variable called name. Since this variable does not contain the name of the
submodule, but the path, rename it to be clearer what data it actually holds.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
modules which are to be
deleted.
Tests are included which verify that this change has no effect on git submodule
summary without the --for-status option.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
git-submodule.sh | 7 +++
t/t7401-submodule-summary.sh | 30
On Thu, Sep 05, 2013 at 08:30:53AM +0200, Matthieu Moy wrote:
Jens Lehmann jens.lehm...@web.de writes:
Am 04.09.2013 08:31, schrieb Matthieu Moy:
brian m. carlson sand...@crustytoothpaste.net writes:
Tests are included which verify that this change has no effect on git
submodule
the main release branches (including other projects), so history is
going to be very messy otherwise.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C
The HTTP 1.1 standard requires an Allow header for 405 Method Not Allowed:
The response MUST include an Allow header containing a list of valid methods
for the requested resource.
So provide such a header when we return a 405 to the user agent.
Signed-off-by: brian m. carlson sand
-by: brian m. carlson sand...@crustytoothpaste.net
---
git-send-email.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 2162478..3782c3b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1234,7 +1234,7 @@ X-Mailer: git-send
, not a flag day; your patches don't do that.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital
actually implement it.
I'll do that soon.
I still wouldn't be crazy about the change, but if there's a warning, I
could live with it. I think that's probably the best course of action
if there's going to be a change here.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623
On Mon, Sep 09, 2013 at 09:45:10AM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion
if ($smtp-code == 220
and the version
would be rewritten to use ~ anyway. Fedora rawhide might.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
on doing a reroll tomorrow.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
The HTTP 1.1 standard requires an Allow header for 405 Method Not Allowed:
The response MUST include an Allow header containing a list of valid methods
for the requested resource.
So provide such a header when we return a 405 to the user agent.
Signed-off-by: brian m. carlson sand
This series contains a pair of patches that improve the validation of
the UTF-8 used in commit messages. Invalid codepoints, such as
surrogates and guaranteed non-characters, are rejected, along with
overlong UTF-8 sequences.
brian m. carlson (2):
commit: reject invalid UTF-8 codepoints
The commit code already contains code for validating UTF-8, but it does not
check for invalid values, such as guaranteed non-characters and surrogates. Fix
this by explicitly checking for and rejecting such characters.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
commit.c
The commit code accepts pseudo-UTF-8 sequences that encode a character with more
bytes than necessary. Reject such sequences, since they are not valid UTF-8.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
commit.c | 14 --
t/t3900-i18n-commit.sh
On Sat, Jun 29, 2013 at 07:13:40PM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
Does this correspond to the following comment in the same file, and
if so, shouldn't this part of your patch?
Yes, yes, it should.
We used to allow te original up-to-6 form
On Sat, Jun 29, 2013 at 07:13:40PM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
diff --git a/t/t3900/UTF-8-invalid.txt b/t/t3900/UTF-8-invalid.txt
new file mode 100644
index 000..343684d
--- /dev/null
+++ b/t/t3900/UTF-8-invalid.txt
@@ -0,0
with Unicode.
* Generated test files using printf as part of the test.
* Removed FIXME comments for things that have been fixed.
* Use a shorter form for detecting surrogate pairs.
brian m. carlson (2):
commit: reject invalid UTF-8 codepoints
commit: reject overlong UTF-8 sequences
commit.c
The commit code already contains code for validating UTF-8, but it does not
check for invalid values, such as guaranteed non-characters and surrogates. Fix
this by explicitly checking for and rejecting such characters.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
commit.c
The commit code accepts pseudo-UTF-8 sequences that encode a character with more
bytes than necessary. Reject such sequences, since they are not valid UTF-8.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
commit.c | 17 +++--
t/t3900-i18n-commit.sh
On Thu, Jul 04, 2013 at 09:58:08PM +0200, Torsten Bögershausen wrote:
On 2013-07-04 19.19, brian m. carlson wrote:
The commit code already contains code for validating UTF-8, but it does not
check for invalid values, such as guaranteed non-characters and surrogates.
Fix
s/guaranteed non
From: brian m. carlson sand...@crustytoothpaste.net
If the SMTP port is provided as part of the hostname to Net::SMTP, it passes
the combined string to the SASL provider; this causes GSSAPI authentication to
fail since Kerberos does not want the port information. Instead, pass the port
please set
SSL_verify_mode explicitly to SSL_VERIFY_NONE in your application.
***
at /home/artagnon/src/git/git-send-email line 1200.
You need to explicitly specify an SSL_verify_mode argument to start_SSL.
--
brian m. carlson
;
+ }
You've covered the STARTTLS case, but not the SSL one right above it.
Someone using smtps on port 465 will still see the warning. You can
pass SSL_verify_mode to Net::SMTP::SSL-new just like you pass it to
start_SSL.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623
looking for the source of a module, use perldoc -lm Net::SMTP::SSL;
that will print the .pm file for the module.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552
.
Otherwise, it looks fine.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
().
Helped-by: brian m. carlson sand...@crustytoothpaste.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
git-send-email.perl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index ecbf56f..758100d 100755
meant may be here. ^
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
101 - 200 of 2261 matches
Mail list logo
