Re: weaning distributions off tarballs: extended verification of git tags

to another, creating a different key, but with the same fingerprint (hash value). -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

, it addresses my concern. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature

Re: Git Scaling: What factors most affect Git performance for a large repo?

reflogs in the same place.) Then you'll need to ensure that git gc runs periodically so that bitmaps are generated. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994

Re: [PATCH v2 02/10] Define utility functions for object IDs.

On Sun, Mar 08, 2015 at 04:57:36PM +0700, Duy Nguyen wrote: On Sun, Mar 8, 2015 at 6:23 AM, brian m. carlson sand...@crustytoothpaste.net wrote: I'm not very excited about having to put the #include in the middle of cache.h. The alternative, of course, is to move enum object_type up, which I

Re: git 2.3.4, ssh: Could not resolve hostname

, but forgotten. I've done similar things before. I generally prefer being a bit stricter and giving helpful error messages rather than trying to intuit what the user meant. The user is always going to come up with a new way to break the code. -- brian m. carlson / brian with sandals: Houston, Texas, US

Re: [PATCH] reduce progress updates in background

in_progress_fd as much as possible is a good idea, since system calls can be expensive on some systems. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223

[PATCH v3 3/3] connect: improve check for plink to reduce false positives

be recognized, but the increased robustness is likely worth it. Add tests to cover these cases to avoid regressions. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- connect.c| 18 +++--- t/t5601-clone.sh | 33 + 2 files changed, 48

[PATCH v3 0/3] Improve robustness of putty detection

This series improves detection of plink (the putty utility). While I was adding tests, I noticed that we had a broken test due to the use of single quotes within a test, which resulted in the test always being skipped. Therefore, nobody noticed that the test was actually broken. brian m

[PATCH v3 2/3] t5601: fix quotation error leading to skipped tests

that are passed to ssh. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- t/t5601-clone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index 1befc45..aae2324 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -332,7

[PATCH v3 1/3] connect: simplify SSH connection code path

The code path used in git_connect pushed the majority of the SSH connection code into an else block, even though the if block returns. Simplify the code by eliminating the else block, as it is unneeded. Signed-off-by: Jeff King p...@peff.net Signed-off-by: brian m. carlson sand

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

. - What about adding test-cases in t5601, this will ease the documentation later. f:/util/plink /c/util/plink.exe f:/util/tortoiseplink /c/util/tortoiseplink.exe /usr/local/uplink/sshwrapper.sh It looks like there's already a framework for that, so sure, I can add some tests. -- brian m

Re: git's directory is _prepended_ to PATH when called with an absolute path

, or select from multiple different options. [0] http://rosettacode.org/wiki/Multiline_shebang -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Re: [PATCH v2 01/16] refs: convert struct ref_entry to use struct object_id

involve text or documentation at this point, if only for maintainability reasons. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

[PATCH v2 1/2] connect: simplify SSH connection code path

The code path used in git_connect pushed the majority of the SSH connection code into an else block, even though the if block returns. Simplify the code by eliminating the else block, as it is unneeded. Signed-off-by: Jeff King p...@peff.net Signed-off-by: brian m. carlson sand

[PATCH v2 2/2] connect: improve check for plink to reduce false positives

the check by looking for plink or tortoiseplink (or those names suffixed with .exe) in the final component of the path. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- connect.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/connect.c b

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

On Fri, Apr 24, 2015 at 03:46:30PM -0700, Pete Harlan wrote: On Fri, Apr 24, 2015 at 3:28 PM, brian m. carlson sand...@crustytoothpaste.net wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH

Re: [PATCH v2 02/16] refs: convert for_each_tag_ref to struct object_id

. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature

[PATCH 1/2] connect: simplify SSH connection code path

The code path used in git_connect pushed the majority of the SSH connection code into an else block, even though the if block returns. Simplify the code by eliminating the else block, as it is unneeded. Signed-off-by: Jeff King p...@peff.net Signed-off-by: brian m. carlson sand

[PATCH 2/2] connect: improve check for plink to reduce false positives

the check by looking for plink or tortoiseplink only at the beginning of the string or immediately after a directory separator. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- This is essentially just a deindentation. connect.c | 15 --- 1 file changed, 12 insertions

Re: [BUG] having 'plink' anywhere in the GIT_SSH environment variables sets putty = true

])) || + tplink == ssh || (tplink is_dir_sep(tplink[-1])); } argv_array_push(conn-args, ssh); -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only

Re: [BUG] having 'plink' anywhere in the GIT_SSH environment variables sets putty = true

. Perhaps it would be worthwhile to check instead if the text plink is the beginning of string or is preceded by a path separator. That would give us a bit more confidence that the user is looking for plink, but would still allow people to use plink-0.63 if they like. -- brian m. carlson / brian

Re: [BUG] having 'plink' anywhere in the GIT_SSH environment variables sets putty = true

*/ conn-env = local_repo_env; I can drop this in as a preparatory patch if I can have your sign-off. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C

[PATCH v2 02/16] refs: convert for_each_tag_ref to struct object_id

suffix these new entries with _oid to distinguish them. Convert for_each_tag_ref and its callers to use the new _oid functions, introducing temporary wrapper functions to avoid type mismatches. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/pack-objects.c | 4

[PATCH v2 01/16] refs: convert struct ref_entry to use struct object_id

Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/refs.c b/refs.c index 81a455b..522d15d 100644 --- a/refs.c +++ b/refs.c @@ -156,7 +156,7 @@ struct ref_value

[PATCH v2 07/16] revision: remove unused _oid helper.

Now that all the callers of handle_refs are gone, rename handle_refs_oid to handle_refs and update the callers accordingly. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- revision.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git

[PATCH v2 03/16] refs: convert remaining users of for_each_ref_in to object_id

Remove the temporary for_each_ref_in_oid function and update the users of it. Convert the users of for_each_branch_ref and for_each_remote_ref (which use for_each_ref_in under the hood) as well. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- bisect.c| 8

[PATCH v2 10/16] refs: convert namespaced ref iteration functions to object_id

Convert head_ref_namespaced and for_each_namespaced_ref to use struct object_id. Update the various callbacks to use struct object_id internally as well. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- http-backend.c | 14 +++--- refs.c | 12 ++-- refs.h

[PATCH v2 08/16] refs: convert for_each_ref to struct object_id

, convert modified functions to use struct object_id instead of unsigned char [20]. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/checkout.c | 4 ++-- builtin/fetch.c| 6 +++--- builtin/name-rev.c | 6 +++--- builtin/pack-objects.c | 10 +- builtin

[PATCH v2 12/16] refs: rename do_for_each_ref_oid to do_for_each_ref

do_for_each_ref was unused due to previous patches, so rename do_for_each_ref_oid to do_for_each_ref. Similarly, remove the unused fn member from struct ref_entry in favor of renaming the fn_oid member. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 43

[PATCH v2 15/16] Remove unneeded *_oid functions.

. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/rev-parse.c | 27 +++ builtin/show-ref.c | 23 +-- log-tree.c | 19 +++ reachable.c | 13 - shallow.c | 33

[PATCH v2 09/16] refs: convert for_each_replace_ref to struct object_id

Update callbacks to take the proper parameters and use struct object_id elsewhere in the callbacks. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/replace.c | 14 +++--- refs.c| 4 ++-- refs.h| 2 +- replace_object.c | 4 ++-- 4 files

[PATCH v2 05/16] refs: convert head_ref to struct object_id

Convert head_ref and head_ref_submodule to use struct object_id. Introduce some wrappers in some of the callers to handle incompatibilities between each_ref_fn and each_ref_fn_oid. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/show-ref.c | 7 ++- log-tree.c

[PATCH v2 14/16] refs: rename each_ref_fn_oid to each_ref_fn

each_ref_fn is no longer used, so rename each_ref_fn_oid to each_ref_fn. Update the documentation to note the change in function signature. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- Documentation/technical/api-ref-iteration.txt | 2 +- refs.c

[PATCH v2 13/16] refs: convert for_each_reflog to struct object_id

Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/fsck.c | 2 +- builtin/reflog.c | 4 ++-- refs.c | 10 +- refs.h | 2 +- revision.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/builtin/fsck.c b/builtin

[PATCH v2 11/16] refs: convert for_each_rawref to struct object_id.

Convert callbacks to use struct object_id internally as well. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/branch.c | 4 ++-- builtin/describe.c | 12 ++-- builtin/for-each-ref.c | 4 ++-- builtin/fsck.c | 16 refs.c

[PATCH v2 16/16] refs: convert struct ref_lock to struct object_id

Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/refs.c b/refs.c index 9e61b32..6c04189 100644 --- a/refs.c +++ b/refs.c @@ -10,7 +10,7 @@ struct ref_lock { char *ref_name

[PATCH v2 04/16] refs: convert for_each_ref_in_submodule to object_id

Convert for_each_ref_in_submodule and all of its caller. Introduce two temporary wrappers in revision.c to handle the incompatibilities between each_ref_fn and each_ref_fn_oid. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 10 +- refs.h | 8

[PATCH v2 00/16] Convert parts of refs.c to struct object_id

next to pick up the first set of object_id patches. * Fix a series of nasty conflicts that occurred due to other topics in flight to promote easier testing and integration. Comments and reviews on this series would be greatly appreciated. brian m. carlson (16): refs: convert struct ref_entry

[PATCH v2 06/16] refs: convert for_each_ref_submodule to struct object_id

Convert the callers as well. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 4 ++-- refs.h | 2 +- revision.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/refs.c b/refs.c index 7a8b579..68d0af8 100644 --- a/refs.c +++ b/refs.c

Re: [BUG] git pull will regress between 'master' and 'pu'

break some use cases, such as non-interactive applications. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description

Re: [PATCH 2/2] connect: improve check for plink to reduce false positives

to use the stricter format. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature

Re: [PATCH v3 0/3] Improve robustness of putty detection

. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc Description: Digital signature

Re: [PATCH/RFC] blame: CRLF in the working tree and LF in the repo

Yet, even if they were unmodified. Don't attempt to convert the line endings when creating the fake commit so that blame works correctly regardless of the autocrlf setting. Reported-by: Ephrim Khong dr.kh...@gmail.com Signed-off-by: brian m. carlson sand

C99 (Was: Re: Freeing struct lock_file?)

be possible. So it isn't as much of a we don't want to move to C99 as much as we aren't yet willing to drop support for older versions of MSVC. I don't use Windows, so I'm happy to drop support for MSVC 2012 and older, but others may have different opinions. -- brian m. carlson / brian with sandals

Re: C99

On Sat, Apr 04, 2015 at 01:06:43PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: So it isn't as much of a we don't want to move to C99 as much as we aren't yet willing to drop support for older versions of MSVC. I do not particularly like that 'we

Pack files, standards compliance, and efficiency

: brian m. carlson sand...@crustytoothpaste.net Date: Thu, 4 Jun 2015 01:26:10 + Subject: [PATCH] Convert nth_packed_object_sha1 to object_id. nth_packed_object_sha1 returned a pointer directly into the mmap'd memory of the pack in question, but the C standard does not allow converting a pointer

Re: Pack files, standards compliance, and efficiency

-256: 144 MiB/s, SHA-512/256: 242 MiB/s) for messages ≥ 55 bytes, and most systems these days are 64 bit. That's what I've been thinking, at least, but if people have better ideas, I'm open to hearing them. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http

Re: Pack files, standards compliance, and efficiency

was opposed to doing *dest = *src. So I don't think this ends up being an issue. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc

Re: On undoing a forced push

of GIT_SHA1_HEXSZ, as it will be more obvious that this depends on that value. If you don't now, I will later. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA

[PATCH 3/8] Convert struct ref to use object_id.

Use struct object_id in three fields in struct ref and convert all the necessary places that use it. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/clone.c| 16 +++--- builtin/fetch-pack.c | 4 ++-- builtin/fetch.c| 50

[PATCH 2/8] sha1_file: introduce has_object_file helper.

Add has_object_file, which is a wrapper around has_sha1_file, but for struct object_id. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- cache.h | 3 +++ sha1_file.c | 5 + 2 files changed, 8 insertions(+) diff --git a/cache.h b/cache.h index 571c98f..fa1f067 100644

[PATCH 7/8] ref_newer: convert to use struct object_id

Convert ref_newer and its caller to use struct object_id instead of unsigned char *. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/remote.c | 2 +- http-push.c | 4 ++-- remote.c | 8 remote.h | 2 +- 4 files changed, 8 insertions(+), 8

[PATCH 0/8] object_id part 2

m. carlson (8): refs: convert some internal functions to use object_id sha1_file: introduce has_object_file helper. Convert struct ref to use object_id. Add a utility function to make parsing hex values easier. add_sought_entry_mem: convert to struct object_id parse_fetch: convert

[PATCH 1/8] refs: convert some internal functions to use object_id

Convert several internal functions in refs.c to use struct object_id, and use the GIT_SHA1_HEXSZ constants in parse_ref_line. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 104 - 1 file changed, 52

[PATCH 6/8] parse_fetch: convert to use struct object_id

Convert the parse_fetch function to use struct object_id. Switch from get_sha1_hex to parse_oid_hex to avoid hard-coding constants. Remove the strlen check as parse_oid_hex will fail safely on receiving a too-short NUL-terminated string. Signed-off-by: brian m. carlson sand

[PATCH 4/8] Add a utility function to make parsing hex values easier.

it easier for code not to assume fixed values when parsing, and to move to larger hash functions in the future. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- cache.h | 9 + hex.c | 7 +++ 2 files changed, 16 insertions(+) diff --git a/cache.h b/cache.h index fa1f067

[PATCH 5/8] add_sought_entry_mem: convert to struct object_id

Convert this function to use struct object_id. Use parse_oid_hex to avoid having to hard-code the number of bytes to be parsed. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/fetch-pack.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

Re: On undoing a forced push

On Wed, Jun 10, 2015 at 09:43:34AM +0700, Duy Nguyen wrote: On Tue, Jun 9, 2015 at 10:00 PM, brian m. carlson sand...@crustytoothpaste.net wrote: You've increased this by 20, but you're adding 40 characters to the strcpy. Are you sure that's enough? Also, you might consider writing

Re: [PATCH 2/8] sha1_file: introduce has_object_file helper.

On Wed, Jun 10, 2015 at 04:59:58PM +0700, Duy Nguyen wrote: On Tue, Jun 9, 2015 at 11:28 PM, brian m. carlson sand...@crustytoothpaste.net wrote: diff --git a/sha1_file.c b/sha1_file.c index 7e38148..09f7f03 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -3173,6 +3173,11 @@ int

[PATCH v2 5/7] gpg: centralize printing signature buffers

The code to handle printing of signature data from a struct signature_check is very similar between verify-commit and verify-tag. Place this in a single function. verify-tag retains its special case behavior of printing the tag even when no valid signature is found. Signed-off-by: brian m

[PATCH v2 4/7] gpg: centralize signature check

. This behavior is more logical anyway, as the signature is in fact valid, whether or not there's a path of trust to the author. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/verify-commit.c | 5 +++-- builtin/verify-tag.c | 5 +++-- commit.c | 8

[PATCH v2 6/7] verify-commit: add option to print raw gpg status information

status information on standard error instead of the human-readable format. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- Documentation/git-verify-commit.txt | 4 builtin/verify-commit.c | 15 ++- gpg-interface.c | 7 +-- gpg

[PATCH v2 2/7] verify-tag: share code with verify-commit

the signature text, as we now call verify_signed_buffer with strbufs to catch the output, which prevents it from being printed automatically. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/verify-tag.c | 9 - commit.c | 15 +-- gpg-interface.c

[PATCH v2 3/7] verify-commit: add test for exit status on untrusted signature

-by: brian m. carlson sand...@crustytoothpaste.net --- t/t7510-signed-commit.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh index 13331e5..4fc376e 100755 --- a/t/t7510-signed-commit.sh +++ b/t/t7510-signed-commit.sh @@ -81,6 +81,13

[PATCH v2 0/7] Raw gpg output support for verify-commit and verify-tag

the patches to ensure that verify-tag tests came before refactors, to avoid regressing functionality. * Changed verify-commit to succeed if a signature is good, regardless of whether it is trusted, at Michael J Gruber's suggestion. brian m. carlson (7): verify-tag: add tests verify-tag: share

[PATCH v2 1/7] verify-tag: add tests

verify-tag was lacking tests. Add some, mirroring those used for verify-commit. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- t/t7030-verify-tag.sh | 84 +++ 1 file changed, 84 insertions(+) create mode 100755 t/t7030-verify

[PATCH v2 7/7] verify-tag: add option to print raw gpg status information

information on standard error instead of the human-readable format. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- Documentation/git-verify-tag.txt | 4 builtin/verify-tag.c | 17 +++-- t/t7030-verify-tag.sh| 31

Re: RFC/Pull Request: Refs db backend

., berkeley db)? Berkeley DB has switched to the AGPLv3 for new versions. Besides being unpalatable for many people, it's also incompatible with the GPLv2. I do otherwise like Berkeley DB: it performs reasonably well and is available on most systems. -- brian m. carlson / brian with sandals: Houston

Re: [PATCH v3 3/3] connect: improve check for plink to reduce false positives

On Fri, Jun 26, 2015 at 09:15:24AM -0400, Jeff King wrote: On Sun, Apr 26, 2015 at 08:30:12PM +, brian m. carlson wrote: Improve the check by looking for plink or tortoiseplink (or those names suffixed with .exe) only in the final component of the path. This has the downside

Re: [PATCH 0/8] object_id part 2

On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: While I did run the tests between each commit, I hadn't noticed they were failing because I don't have Apache installed on my laptop, so they were silently skipped. I'll

[PATCH 1/3] verify-commit: add option to print raw gpg status information

status information on standard error instead of the human-readable format. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- Documentation/git-verify-commit.txt | 4 builtin/verify-commit.c | 13 +++-- t/t7510-signed-commit.sh| 32

[PATCH 0/3] Raw gpg output support for verify-commit and verify-tag

signature is made with an untrusted key, verify-commit will exit 1, but verify-tag will exit 0. I'm unclear on what we can do about this now, short of adding another option. This is because the two commands share little common code. brian m. carlson (3): verify-commit: add option to print raw

[PATCH 3/3] verify-tag: add option to print raw gpg status information

information on standard error instead of the human-readable format. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- Documentation/git-verify-tag.txt | 4 builtin/verify-tag.c | 21 +++-- t/t7030-verify-tag.sh| 31

[PATCH 2/3] verify-tag: add tests

verify-tag was lacking tests. Add some, mirroring those used for verify-commit. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- t/t7030-verify-tag.sh | 85 +++ 1 file changed, 85 insertions(+) create mode 100755 t/t7030-verify

Re: [PATCH 0/3] Raw gpg output support for verify-commit and verify-tag

each of which signals a single bit. I'll wait for other responses (if any) and then reroll. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Re: [PATCH 0/8] object_id part 2

: 3, 7-16, 19 Non-zero exit status: 1 While I did run the tests between each commit, I hadn't noticed they were failing because I don't have Apache installed on my laptop, so they were silently skipped. I'll resubmit with that fixed. -- brian m. carlson / brian with sandals: Houston, Texas

Re: [PATCH 0/8] object_id part 2

in the branch I'm working on as well, or the area for that code is lacking tests, since I don't think the tests are failing there. In the latter case, I'll send a testsuite patch as part of my next series. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http

Re: [PATCH 0/8] object_id part 2

On Wed, Jun 10, 2015 at 11:51:14PM +, brian m. carlson wrote: On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: Convert struct object to object_id It seems that the last one didn't make it... It appears

Re: [PATCH 0/8] object_id part 2

On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: Convert struct object to object_id It seems that the last one didn't make it... It appears the mail was too large for vger. Unfortunately for bisectability reasons

[PATCH v2 04/10] add_sought_entry_mem: convert to struct object_id

Convert this function to use struct object_id. Express several hardcoded constants in terms of GIT_SHA1_HEXSZ. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/fetch-pack.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/builtin/fetch

[PATCH v2 07/10] push_refs_with_export: convert to struct object_id

Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- transport-helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index 4ca3e80..1f28b82 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -877,13

[PATCH v2 06/10] get_remote_heads: convert to struct object_id

Replace an unsigned char array with struct object_id and express several hard-coded constants in terms of GIT_SHA1_HEXSZ. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- connect.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git

[PATCH v2 03/10] Convert struct ref to use object_id.

Use struct object_id in three fields in struct ref and convert all the necessary places that use it. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/clone.c| 16 +++--- builtin/fetch-pack.c | 4 ++-- builtin/fetch.c| 50

[PATCH v2 02/10] sha1_file: introduce has_object_file helper.

Add has_object_file, which is a wrapper around has_sha1_file, but for struct object_id. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- cache.h | 3 +++ sha1_file.c | 5 + 2 files changed, 8 insertions(+) diff --git a/cache.h b/cache.h index 571c98f..fa1f067 100644

[PATCH v2 05/10] parse_fetch: convert to use struct object_id

Convert the parse_fetch function to use struct object_id. Remove the strlen check as get_oid_hex will fail safely on receiving a too-short NUL-terminated string. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- remote-curl.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v2 01/10] refs: convert some internal functions to use object_id

Convert several internal functions in refs.c to use struct object_id, and use the GIT_SHA1_HEXSZ constants in parse_ref_line. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 104 - 1 file changed, 52

[PATCH v2 00/10] object_id part 2

this. :-) brian m. carlson (10): refs: convert some internal functions to use object_id sha1_file: introduce has_object_file helper. Convert struct ref to use object_id. add_sought_entry_mem: convert to struct object_id parse_fetch: convert to use struct object_id get_remote_heads

[PATCH v2 08/10] ref_newer: convert to use struct object_id

Convert ref_newer and its caller to use struct object_id instead of unsigned char *. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/remote.c | 2 +- http-push.c | 4 ++-- remote.c | 8 remote.h | 2 +- 4 files changed, 8 insertions(+), 8

Re: [PATCH 0/8] object_id part 2

On Wed, Jun 10, 2015 at 05:21:33PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: [0] https://github.com/bk2204/git.git object-id-part2 No approach other than just letting reviewers fetch from there and taking a look is reasonable, I would think. Did

[PATCH] format-patch: dereference tags with --ignore-if-in-upstream

the necessary flags. Reported-by: Bruce Korb bruce.k...@gmail.com Diagnosed-by: Christian Couder christian.cou...@gmail.com Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/log.c | 6 ++ t/t4014-format-patch.sh | 10 ++ 2 files changed, 16 insertions(+) diff

Re: [PATCH] format-patch: dereference tags with --ignore-if-in-upstream

wasn't aware of test_line_count. I'll reroll the patch later today. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 signature.asc

Re: [PATCH] format-patch: dereference tags with --ignore-if-in-upstream

machinery, but dereferencing. Otherwise, looks exactly like what I would have written in my reroll had you not gotten to it before me. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

On Tue, May 26, 2015 at 10:37:29AM -0700, Stefan Beller wrote: On Mon, May 25, 2015 at 12:40 PM, brian m. carlson sand...@crustytoothpaste.net wrote: On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: [PATCH 01/56] was authored by you but has Michael's sign-off, which looked

[PATCH v3 35/56] remote: rewrite functions to take object_id arguments

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- remote.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/remote.c b/remote.c index 6d66ec1

[PATCH v3 44/56] find_symref(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- upload-pack.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index 52fab23

[PATCH v3 55/56] warn_if_dangling_symref(): convert local variable junk to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- refs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/refs.c b/refs.c index 162760c..7515c2e 100644

[PATCH v3 37/56] handle_one_reflog(): rewrite to take an object_id argument

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- revision.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/revision.c b/revision.c index cfe3876..1d903cf

[PATCH v3 50/56] mark_complete_oid(): new function, taking an object_oid

From: Michael Haggerty mhag...@alum.mit.edu This function can be used with for_each_ref() without having to be wrapped. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- fetch-pack.c | 11 +++ 1 file changed, 7

[PATCH v3 42/56] write_refs_to_temp_dir(): convert local variable sha1 to object_id

From: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- transport.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/transport.c b/transport.c index 58cb9ed

[PATCH v3 54/56] each_ref_fn_adapter(): remove adapter

From: Michael Haggerty mhag...@alum.mit.edu All of the callers of the for_each_ref family of functions have now been rewritten to work with object_ids, so this adapter is no longer needed. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: brian m. carlson sand

<    1   2   3   4   5   6   7   8   9   10   >