Re: [PATCH v2] userdiff: update Ada patterns

2014-02-05 Thread Adrian Johnson
On 04/02/14 06:30, Junio C Hamano wrote: > Adrian Johnson writes: > >> - Allow extra space in "is new" and "is separate" >> - Fix bug in word regex for numbers >> >> Signed-off-by: Adrian Johnson >> --- >> t/t4034/ada/expect

[PATCH v2] userdiff: update Ada patterns

2014-02-03 Thread Adrian Johnson
- Allow extra space in "is new" and "is separate" - Fix bug in word regex for numbers Signed-off-by: Adrian Johnson --- t/t4034/ada/expect | 2 +- userdiff.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t4034/ada/expect b/t/t4034/ada/

Re: [PATCH] userdiff: update Ada patterns

2014-02-03 Thread Adrian Johnson
On 03/02/14 10:05, Jeff King wrote: > On Sun, Feb 02, 2014 at 09:21:56PM +1030, Adrian Johnson wrote: >> - Fix bug in word regex for numbers >> - "|[0-9][-+0-9#_.eE]" >> + "|[-+0-9#_.eE]+" > > This makes "E" or "_" a

[PATCH] userdiff: update Ada patterns

2014-02-02 Thread Adrian Johnson
- Allow extra space in "is new" and "is separate" - Fix bug in word regex for numbers Signed-off-by: Adrian Johnson --- t/t4034/ada/expect | 2 +- userdiff.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t4034/ada/expect b/t/t4034/ada/

[PATCHv2] Add userdiff patterns for Ada

2012-09-17 Thread Adrian Johnson
Add Ada xfuncname and wordRegex patterns to the list of builtin patterns. Signed-off-by: Adrian Johnson --- On 17/09/12 14:29, Junio C Hamano wrote: > You could add test vectors to check if the built-in xfuncname > catches beginning of functions in Ada correctly if you wanted to, > bu

Re: [PATCH] Add userdiff patterns for Ada

2012-09-16 Thread Adrian Johnson
On 16/09/12 15:37, Junio C Hamano wrote: > Adrian Johnson writes: > >> Add Ada xfuncname and wordRegex patterns to the list of builtin >> patterns. >> >> Signed-off-by: Adrian Johnson >> --- > > Interesting. I do not read Ada, but in this "

[PATCH] Add userdiff patterns for Ada

2012-09-15 Thread Adrian Johnson
Add Ada xfuncname and wordRegex patterns to the list of builtin patterns. Signed-off-by: Adrian Johnson --- Documentation/gitattributes.txt | 2 ++ t/t4018-diff-funcname.sh| 2 +- t/t4034-diff-words.sh | 1 + t/t4034/ada/expect | 27