On Mon, Oct 21, 2019 at 9:04 PM Pratyush Yadav wrote:
>
> On 21/10/19 11:16AM, Bert Wesarg wrote:
> > Dear Pratyush,
> >
> > I just noticed that the 'Revert Last Hunk' menu entry is enabled in
> > the stage-list. But I think it should be disabled, like the
On Mon, Oct 21, 2019 at 9:35 PM Johannes Sixt wrote:
>
> Am 21.10.19 um 11:16 schrieb Bert Wesarg:
> > Dear Pratyush,
> >
> > I just noticed that the 'Revert Last Hunk' menu entry is enabled in
> > the stage-list. But I think it should be disabled, lik
As noted by Gábor in [1], the new tests in edefc31873 ("format-patch:
create leading components of output directory", 2019-10-11) cannot be
run independently. Fix this.
[1] https://public-inbox.org/git/20191011144650.gm29...@szeder.dev/
Signed-off-by: Bert Wesarg
---
Cc: Denton Liu
C
Please ignore this. Will rebase on 2.24-rc0 and will only include the
test changes.
Bert
On Mon, Oct 21, 2019 at 12:25 PM Bert Wesarg wrote:
>
> 'git format-patch -o ' did an equivalent of 'mkdir '
> not 'mkdir -p ', which is being corrected.
>
> A
The 'format.outputDirectory' configuration is only able to store constant
directory names. Though some may use
$ git format-patch -o $(createdir) …
to name the directory dynamically. Provide a new configuration to be able
to store such a command too.
Signed-off-by: Bert Wesarg
-
Repository' like 'git init' does.
Signed-off-by: Bert Wesarg
---
Changes in v2:
* squashed and base new tests on 'dl/format-patch-doc-test-cleanup'
Changes in v3:
* avoid applying adjust_shared_perm
Changes in v4:
* based on dl/format-patch-doc-test-cleanup and ado
Dear Pratyush,
I just noticed that the 'Revert Last Hunk' menu entry is enabled in
the stage-list. But I think it should be disabled, like the 'Revert
Hunk' and 'Revert Line' menu entry.
Can you confirm this?
Thanks.
Bert
On Wed, Aug 28, 2019 at 11:57 PM Pratyush Yadav wrote:
>
> Accidental
On Fri, Oct 11, 2019 at 11:35 PM Pratyush Yadav wrote:
>
> I'll take the silence to mean there are no further objections, and will
> merge this version in to 'master'.
correct. FWIW
Acked-by: Bert Wesarg
>
> On 08/10/19 05:47PM, Pratyush Yadav wrote:
> > I
On Fri, Oct 11, 2019 at 5:45 PM Bert Wesarg wrote:
>
> On Fri, Oct 11, 2019 at 4:46 PM SZEDER Gábor wrote:
> >
> > On Fri, Oct 11, 2019 at 10:36:41AM +0200, Bert Wesarg wrote:
> > > Changes in v4:
> > > * based on dl/format-patch-doc-test-cleanup and adopt
On Fri, Oct 11, 2019 at 4:46 PM SZEDER Gábor wrote:
>
> On Fri, Oct 11, 2019 at 10:36:41AM +0200, Bert Wesarg wrote:
> > Changes in v4:
> > * based on dl/format-patch-doc-test-cleanup and adopt it
>
> Thanks... but here I am nitpicking again, sorry :)
>
> > dif
Repository' like 'git init' does.
Signed-off-by: Bert Wesarg
---
Changes in v2:
* squashed and base new tests on 'dl/format-patch-doc-test-cleanup'
Changes in v3:
* avoid applying adjust_shared_perm
Changes in v4:
* based on dl/format-patch-doc-test-clea
The 'format.outputDirectory' configuration is only able to store constant
directory names. Though some may use
$ git format-patch -o $(createdir) …
to name the directory dynamically. Provide a new configuration to be able
to store such a command too.
Signed-off-by: Bert Wesarg
-
On Tue, Oct 8, 2019 at 2:21 PM Derrick Stolee wrote:
>
> On 10/5/2019 5:12 PM, brian m. carlson wrote:
> > Adjust the test so that it computes variables for object IDs instead of
> > using hard-coded hashes.
>
> [snip]
>
> > @@ -137,14 +141,17 @@ test_expect_success SYMLINKS 'setup symlinks with
On Mon, Oct 7, 2019 at 11:03 PM SZEDER Gábor wrote:
>
> On Sat, Oct 05, 2019 at 10:43:51AM +0200, Bert Wesarg wrote:
> > diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> > index 83f52614d3..2f2cd6fea6 100755
> > --- a/t/t4014-format-patch.sh
> >
On Sat, Oct 5, 2019 at 12:10 AM Pratyush Yadav wrote:
>
> It is a good idea to have a readme so people finding the project can
> know more about it, and know how they can get involved.
>
> Signed-off-by: Pratyush Yadav
> ---
>
> I don't have much experience writing this kind of readme or
> docume
The 'format.outputDirectory' configuration is only able to store constant
directory names. Though some may use
$ git format-patch -o $(createdir) …
to name the directory dynamically. Provide a new configuration to be able
to store such a command too.
Signed-off-by: B
Signed-off-by: Bert Wesarg
---
ChangeLog:
v2:
* squashed and base new tests on 'dl/format-patch-doc-test-cleanup'
Cc: Denton Liu
---
Documentation/config/format.txt| 2 +-
Documentation/git-format-patch.txt | 3 ++-
builtin/log.c | 8
t/t4
hink that it's necessary. Maybe
> it's just me but I assume that most tools create at most one directory
> deep. Even mkdir won't created nested dirs unless you pass `-p`. I
> dunno.
>
> On Wed, Oct 02, 2019 at 11:26:11PM +0200, Bert Wesarg wrote:
> > Signed
Signed-off-by: Bert Wesarg
---
Documentation/config/format.txt| 3 +--
Documentation/git-format-patch.txt | 5 ++---
builtin/log.c | 8
t/t4014-format-patch.sh| 5 +++--
4 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/Documentation
w unique
directory. Thus provide the new 'format.outputDirectoryCmd' configuration
to specify a command which does the job and puts the name to standard
output.
Signed-off-by: Bert Wesarg
---
Cc: Alexander Kuleshov
Cc: Eric Sunshine
---
Documentation/config/format.txt| 5 +
Documentati
Signed-off-by: Bert Wesarg
---
Documentation/config/format.txt| 3 ++-
Documentation/git-format-patch.txt | 4 +++-
t/t4014-format-patch.sh| 16
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/Documentation/config/format.txt b/Documentation
This adds highlight support for the diff3 conflict style.
The common pre-image will be reversed to --, because it has been removed
and replaced with ours or theirs side respectively.
Signed-off-by: Bert Wesarg
---
git-gui.sh | 3 +++
lib/diff.tcl | 17 -
2 files changed, 19
Pratyush,
On Tue, Oct 1, 2019 at 7:31 PM Pratyush Yadav wrote:
>
> On 01/10/19 05:22PM, Bert Wesarg wrote:
> > On Tue, Oct 1, 2019 at 4:24 PM Pratyush Yadav
> > wrote:
> > >
> > > Hi,
> > >
> > > I don't see any difference between
On Tue, Oct 1, 2019 at 4:24 PM Pratyush Yadav wrote:
>
> Hi,
>
> I don't see any difference between v3 and v2 of this patch. What changed
> in this version?
nothing, but 2/2 changed.
Bert
>
> On 30/09/19 09:54PM, Bert Wesarg wrote:
> > Replace the hand-coded
Hi,
On Tue, Oct 1, 2019 at 3:06 PM Matheus Tavares Bernardino
wrote:
>
> Hi,
>
> During Git Summit it was mentioned that git-grep searches outside
> sparsity pattern which is not aligned with user expectation. I took a
> quick look at it and it seems the reason is
> builtin/grep.c:grep_cache() (w
Wrapping filenames is an unexpected experience in UX design. Disable
wrapping and add a horizontal scrollbar to the files list to remove this.
Signed-off-by: Bert Wesarg
---
gitk | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/gitk b/gitk
index abe4805..bf2a061
Replace the hand-coded call to git check-attr with the already provided one.
Signed-off-by: Bert Wesarg
---
lib/diff.tcl | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/diff.tcl b/lib/diff.tcl
index 958a0fa..0fd4600 100644
--- a/lib/diff.tcl
+++ b/lib
This adds highlight support for the diff3 conflict style.
The common pre-image will be reversed to --, because it has been removed
and replaced with ours or theirs side respectively.
Signed-off-by: Bert Wesarg
---
git-gui.sh | 3 +++
lib/diff.tcl | 17 -
2 files changed, 19
Replace the hand-coded call to git check-attr with the already provided one.
Signed-off-by: Bert Wesarg
---
lib/diff.tcl | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/diff.tcl b/lib/diff.tcl
index 958a0fa..0fd4600 100644
--- a/lib/diff.tcl
+++ b/lib
tie porttitor.
Vivamus sed urna in risus molestie ultricies.
As you can see, there is not the usual 'I removed this, and added
that' experience, everything is 'added'. Thus I inverted the pre-image
to '--'. Here is how it looks in the gui:
https://kgab.selfhost.eu/s/
Signed-off-by: Bert Wesarg
---
builtin/submodule--helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 909e77e802..89d6f02969 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
On Fri, Sep 27, 2019 at 12:40 AM Pratyush Yadav wrote:
>
> Hi,
>
> On 26/09/19 02:17PM, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin
> >
> > Since v2.9.0, Git knows about the config variable core.hookspath
> > that allows overriding the path to the directory containin
On Thu, Sep 26, 2019 at 7:43 PM Johannes Schindelin via GitGitGadget
wrote:
>
> From: Johannes Schindelin
>
> When a 1-line file is augmented by a second line, and the user tries to
> stage that single line via the "Stage Line" context menu item, we do not
> want to see "apply: corrupt patch at l
This adds highlight support for the diff3 conflict style.
The common pre-image will be reversed to --, because it has been removed
and either replaced with ours or theirs side.
Signed-off-by: Bert Wesarg
---
git-gui.sh | 3 +++
lib/diff.tcl | 22 ++
2 files changed, 25
Replace the hand-coded call to git check-attr with the already provided one.
Signed-off-by: Bert Wesarg
---
lib/diff.tcl | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/diff.tcl b/lib/diff.tcl
index 958a0fa..0fd4600 100644
--- a/lib/diff.tcl
+++ b/lib
Pratyush,
once again, I had done this years ago. I may post an updated patch in
the evening:
https://github.com/bertwesarg/git-gui/commit/90ee4a8c260132a6b730040095929fd267cedd7b
Bert
On Wed, Sep 25, 2019 at 12:05 AM Philip Oakley wrote:
>
> Hi list,
> cc Pratyush,
>
> [resend without attached
On Fri, Sep 13, 2019 at 4:32 PM Pratyush Yadav wrote:
>
> On 13/09/19 12:24PM, Allan Ford wrote:
> > Dear Git Authors,
> >
> > Not a bug, but a suggestion consideration for “Git Gui”
> >
> > Can a double click on the file name in the “unstaged” area move the
> > item to “staged changes” .. (rather
x27;t know why this happened.
Best,
Bert
>
> Other than that, LGTM. Thanks, will queue.
>
> On 13/09/19 08:02AM, Bert Wesarg wrote:
> > Its a bi-state anyway and also saves one line in the menu.
> >
> > Signed-off-by: Bert Wesarg
>
> --
> Regards,
> Pratyush Yadav
version 8.6.8, which
does not update the horizontal scrollbar if one removes the whole
content at once.
Suggested-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
---
git-gui.sh | 6 ++
1 file changed, 6 insertions(+)
diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8..ad962d4 100755
--- a
moved both of then, but they still made it into the patch, sorry.
Will re-roll with v4 now.
Bert
>
> On 12/09/19 09:20PM, Bert Wesarg wrote:
> > While the commit message widget has a configurable fixed width, it
> > nevertheless allowed to write commit messages which exceeded th
Its a bi-state anyway and also saves one line in the menu.
Signed-off-by: Bert Wesarg
---
git-gui.sh | 36 +---
lib/checkout_op.tcl | 6 +++---
lib/commit.tcl | 4 ++--
lib/index.tcl | 8
4 files changed, 18 insertions(+), 36
Its a bi-state anyway and also safes one line in the menu.
Signed-off-by: Bert Wesarg
---
git-gui.sh | 36 +---
lib/checkout_op.tcl | 6 +++---
lib/commit.tcl | 4 ++--
lib/index.tcl | 8
4 files changed, 18 insertions(+), 36
On Wed, Sep 11, 2019 at 10:15 PM Pratyush Yadav wrote:
>
> Typo in the subject. s/checketton/checkbutton/\
Will re-roll and drop the actual keybinding patch, so that Birger can
resend his part,
Bert
>
> On 05/09/19 10:09PM, Bert Wesarg wrote:
> > Signed-off-by: Bert Wesarg
On Wed, Sep 11, 2019 at 10:15 PM Pratyush Yadav wrote:
>
> Typo in the subject. s/checketton/checkbutton/
>
> On 05/09/19 10:09PM, Bert Wesarg wrote:
> > Signed-off-by: Bert Wesarg
> > ---
> > git-gui.sh | 36 +---
On Tue, Sep 10, 2019 at 6:50 PM Johannes Sixt wrote:
>
> Am 04.09.19 um 22:10 schrieb Bert Wesarg:
> > The commit message widget does not wrap the next and has a configurable
> > fixed width to avoid creating too wide commit messages. Though this was
> > only enforced
version 8.6.8, which
does not update the horizontal scrollbar if one removes the whole
content at once.
Suggested-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
---
git-gui.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8
On Tue, Sep 10, 2019 at 10:35 PM Pratyush Yadav wrote:
>
> On 04/09/19 10:10PM, Bert Wesarg wrote:
> > The commit message widget does not wrap the next and has a configurable
> > fixed width to avoid creating too wide commit messages. Though this was
> > only enforced
On Tue, Sep 10, 2019 at 10:28 PM Pratyush Yadav wrote:
>
> On 04/09/19 10:10PM, Bert Wesarg wrote:
> > While the commit message widget has a configurable fixed width, it
> > nevertheless allows to write commit messages which exceed this limit.
> > Though it does not s
On Tue, Sep 10, 2019 at 10:26 PM Johannes Sixt wrote:
>
> Am 10.09.19 um 21:21 schrieb Pratyush Yadav:
> > If there are no further objections with the series, I will merge it in.
>
> No objections. I use it in production.
yep, Since 2012 ;-)
>
> -- Hannes
by: Birger Skogeng Pedersen
> Signed-off-by: Bert Wesarg
> ---
> git-gui.sh | 40 +++-
> 1 file changed, 35 insertions(+), 5 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 5bc21b8..47c5db0 100755
> --- a/gi
From: Birger Skogeng Pedersen
Selecting whether to "Amend Last Commit" or not does not have a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
Rebased-by: Bert Wesarg
---
git-gui.sh | 8
1 file
Signed-off-by: Bert Wesarg
---
git-gui.sh | 36 +---
lib/checkout_op.tcl | 6 +++---
lib/commit.tcl | 4 ++--
lib/index.tcl | 8
4 files changed, 18 insertions(+), 36 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8
On Thu, Sep 5, 2019 at 8:50 AM Birger Skogeng Pedersen
wrote:
>
> On Thu, Sep 5, 2019 at 12:48 AM Pratyush Yadav wrote:
> > I'll chime in with what I think would be a great solution: auto word
> > wrapping. This way, the users can set the text width, and not have to
> > worry about manually forma
On Thu, Sep 5, 2019 at 8:22 AM Johannes Sixt wrote:
>
> Am 04.09.19 um 22:43 schrieb Bert Wesarg:
> > these people did not saw the entered text anyway. they would have
> > needed to change the option (default to 75 characters) to see what
> > they have typed. which co
On Wed, Sep 4, 2019 at 10:31 PM Eric Sunshine wrote:
>
> On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote:
> > While the commit message widget has a configurable fixed width, it
> > nevertheless allows to write commit messages which exceed this limit.
> > Though it do
On Wed, Sep 4, 2019 at 10:30 PM Eric Sunshine wrote:
>
> On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote:
> > The commit message widget does not wrap the next and has a configurable
>
> s/next/text/
fixed
>
> > fixed width to avoid creating too wide commit message
configured line length.
Needs Tcl 8.6 because of `lmap`.
Signed-off-by: Bert Wesarg
---
git-gui.sh | 4 ++--
lib/commit.tcl | 10 ++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8..a491085 100755
--- a/git-gui.sh
+++ b/git-gui.sh
does not
update the horizontal scrollbar if one removes the whole content at once.
Suggested-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
---
git-gui.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index a491085..fa9c0d2 100755
Dear Hannes,
On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
>
> Am 04.09.19 um 16:30 schrieb Birger Skogeng Pedersen:
> > The user cannot change focus between the list of files, the diff view and
> > the commit message widgets without using the mouse (clicking either of
> > the four widgets)
On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav wrote:
>
> On 02/09/19 09:13PM, Bert Wesarg wrote:
> > On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg
> > wrote:
> > >
> [snip]
> > > > On second thought, wouldn't it make more sense to expand the
> >
On Wed, Sep 4, 2019 at 8:52 PM Johannes Sixt wrote:
>
> Am 04.09.19 um 19:46 schrieb Pratyush Yadav:
> > On 04/09/19 08:24AM, Johannes Sixt wrote:
> >> That is worth a try. The check box title offers a natural hotkey then:
> >> "_A_mend last commit", Alt-a.
> >
> > Right now, the binding proposed
On Wed, Sep 4, 2019 at 7:36 PM Pratyush Yadav wrote:
>
> On 04/09/19 07:58AM, Birger Skogeng Pedersen wrote:
> > Hi Pratyush,
> >
> >
> > So how does this work? Should I email the patch that Bert has created?
> > Or is it okay that it just remains on Github. (Considering the git
> > mail archives)
Birger,
On Tue, Sep 3, 2019 at 10:52 AM Bert Wesarg wrote:
>
> Birger,
>
> On Mon, Sep 2, 2019 at 9:56 PM Birger Skogeng Pedersen
> wrote:
> >
> > Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> > a hotkey.
>
On Tue, Sep 3, 2019 at 4:22 PM Pratyush Yadav wrote:
>
> On 02/09/19 09:42PM, Bert Wesarg wrote:
> > On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen
> > wrote:
> > >
> > > The user cannot change focus between the list of files, the diff view and
>
David,
On Tue, Sep 3, 2019 at 10:52 AM Bert Wesarg wrote:
>
> Birger,
>
> On Mon, Sep 2, 2019 at 9:56 PM Birger Skogeng Pedersen
> wrote:
> >
> > Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> > a hotkey.
>
Birger,
On Mon, Sep 2, 2019 at 9:56 PM Birger Skogeng Pedersen
wrote:
>
> Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
> a hotkey.
>
> With this patch, the user may toggle between the two options with
> CTRL/CMD+e.
David A. (in Cc from git-cola) suggested, that we
David,
On Tue, Sep 3, 2019 at 3:01 AM David wrote:
>
> On Tue, 3 Sep 2019 at 04:11, Bert Wesarg wrote:
> > On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen
> > wrote:
> > > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen
> > > wrote:
>
On Mon, Sep 2, 2019 at 10:12 PM Bert Wesarg wrote:
>
> On Mon, Sep 2, 2019 at 9:49 PM Birger Skogeng Pedersen
> wrote:
> >
> > Hi Bert,
> >
> >
> > On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg
> > wrote:
> > > I think with your "
On Mon, Sep 2, 2019 at 9:49 PM Birger Skogeng Pedersen
wrote:
>
> Hi Bert,
>
>
> On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg wrote:
> > I think with your "focus" patch, this is not needed anymore:
> >
> > After focusing the commit message widget, you can
On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen
wrote:
>
> The user cannot change focus between the list of files, the diff view and
> the commit message widgets without using the mouse (clicking either of
> the four widgets).
>
> With this patch, the user may set ui focus to the previously
On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg wrote:
>
> On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote:
> >
> > On 03/09/19 12:14AM, Pratyush Yadav wrote:
> > > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote:
> > > > On Mon, Sep 2, 2019 at 8:05 PM B
On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote:
>
> On 03/09/19 12:14AM, Pratyush Yadav wrote:
> > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote:
> > > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg
> > > wrote:
> > > > I cannot test windows
Birger,
On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen
wrote:
>
> I just now realized what a terrible suggestion CTRL+Z was.
> I propose CTRL/CMD+E to toggle between amend/new commit.
>
> On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen
> wrote:
> >
> > In my pursuit to fully uti
On Mon, Sep 2, 2019 at 7:35 PM Junio C Hamano wrote:
>
> Bert Wesarg writes:
>
> > the old reasoning was, that you should not create commit messages
> > which are too wide.
>
> True, and that reasoning would justify hiding scrollbar when not
> necessary to gain v
te the scrollbuffer commit below.
Best,
Bert
Author: Bert Wesarg
Date: Mon Sep 2 13:57:24 2019 +0200
git-gui: add horizontal scrollbar to commit buffer
Sugestted-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
diff --git a/git-gui.sh b/git-gui.sh
index a491085..919d1e9 1
On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote:
> > +
> > +proc select_first_unstaged_changes_path {} {
> > + global ui_workdir
> > + select_first_path $ui_workdir
> > +}
> > +
> > +proc select_first_staged_changes_path {} {
> > + global ui_index
> > + select_first_path $ui_in
Hi Birger,
On Sat, Aug 31, 2019 at 2:23 PM Birger Skogeng Pedersen
wrote:
>
> The user cannot change focus between the list of files, the diff view and
> the commit message widgets without using the mouse (clicking either of
> the four widgets ).
that bugged me two, but never come up with a good
On Sat, Aug 24, 2019 at 1:43 AM David Aguilar wrote:
>
> I have a very strong opinion about the confirmation dialog, so I'll just
> mention that here since Hannes is on this thread.
>
> In cola we do have a confirmation dialog, and I strongly believe this is
> the correct behavior because it's an
On Sat, Aug 24, 2019 at 1:43 AM David Aguilar wrote:
>
> On Fri, Aug 23, 2019 at 03:31:03AM +0530, Pratyush Yadav wrote:
> > Hi,
> >
> > This series adds the ability to revert selected lines and hunks in
> > git-gui. Partially based on the patch by Bert Wesarg [
On Fri, Aug 23, 2019 at 12:01 AM Pratyush Yadav wrote:
>
> Just like the user can select lines to stage or unstage, add the
> ability to revert selected lines.
>
> Signed-off-by: Pratyush Yadav
> ---
> git-gui.sh | 25 -
> lib/diff.tcl | 31 ++---
On Fri, Aug 23, 2019 at 12:51 AM Pratyush Yadav wrote:
>
> On 22/08/19 03:34PM, Junio C Hamano wrote:
> > Pratyush Yadav writes:
> >
> > > This series adds the ability to revert selected lines and hunks in
> > > git-gui. Partially based on the patch by Bert
on the patch by Bert Wesarg [0].
>
> The commits can be found in the topic branch 'py/git-gui-revert-lines'
> at https://github.com/prati0100/git/tree/py/git-gui-revert-lines
>
> Once reviewed, pull the commits from
> 832064f93d3ad432616e96ca70f682a7cfdcc3e0 till
> 72eed2
On Sun, Mar 31, 2019 at 9:48 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote:
>
> On Sun, 31 Mar 2019 at 21:15, Bert Wesarg wrote:
> >
> > Hi Jan,
> >
> > On Sun, Mar 31, 2019 at 8:45 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote:
> > >
> >
Hi Jan,
On Sun, Mar 31, 2019 at 8:45 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote:
>
> Hello
>
> After performing "Unstage Line From Commit" action, the "Unstaged
> Changes" windowpane is reset. The reset does not happen with "Unstage
> Hunk From Commit" action.
because its not necessary when sta
On Sun, Nov 11, 2018 at 10:53 AM Nguyễn Thái Ngọc Duy wrote:
>
> Also while "precious" is a fun name, but it does not sound serious.
> Any suggestions? Perhaps "valuable"?
"precious" is also used by POSIX make:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html
Bert
On Wed, Apr 11, 2018 at 12:50 AM, Junio C Hamano wrote:
> Chris Maes writes:
>
>> Is there any hope from here that anyone will pick up this / these
>> changes? Will anyone else be assigned the main responsible for this
>> git-gui repository?
>>
>> Just hoping to revive the discussion here, since
the full listing without restarting
> gitk.
> ---
>
> Bert Wesarg, Wed, May 09, 2018 09:19:55 +0200:
>> > Frankly, this listing limited to just a sub-directory confuses me a bit. Is
>> > there anyway to get to display full repository without changing to the top
>> > l
On Tue, May 8, 2018 at 3:39 PM, Alex Riesen
wrote:
> Bert Wesarg, Tue, May 08, 2018 15:17:03 +0200:
>> On Tue, May 8, 2018 at 2:22 PM, Alex Riesen
>> wrote:
>> > +proc flist_gitk {} {
>> > +global flist_menu_file findstring gdttype
>> > +
&g
On Tue, May 8, 2018 at 2:22 PM, Alex Riesen
wrote:
> From: Alex Riesen
>
> Similar to a git gui feature which visualizes history in a submodule,
> the submodules cause the gitk be started inside the submodule.
>
> Signed-off-by: Alex Riesen
> ---
> gitk | 12
> 1 file changed, 12 i
Dear Duy,
heaving an includeIf in a git config file breaks calling external git
commands, most prominently git-gui.
$ git --version
git version 2.12.2.599.gcf11a6797
$ git rev-parse --is-inside-work-tree
true
$ git echo
git: 'echo' is not a git command. See 'git --help'.
Did you mean this?
f
HI,
the reason why it is fixed, is because commit messages should be
wrapped at 76 characters to be used in mails. So it helps you with the
wrapping.
Bert
On Wed, Feb 22, 2017 at 10:27 AM, Jessie Hernandez
wrote:
> Hi all,
>
> I have been using git for a few years now and really like the softw
On Fri, Dec 12, 2014 at 9:27 AM, Christoph Grüninger wrote:
> Hi Bert,
> your commit is more than half a year old. Do you intent to include that
> into Git master? If not, what's the reason?
Thats a really odd question to a person who posted this patch to the
mailling list the fist place, isn't i
On Tue, Dec 9, 2014 at 9:21 PM, Johannes Sixt wrote:
> Am 09.12.2014 um 20:49 schrieb Christoph Grüninger:
>> While browsing the changes, it is very easy to add (or remove) lines or
>> hunks for commit via the context menu. I would like to revert the
>> changes of a line or a hunk in a similar way
On Wed, Aug 20, 2014 at 12:06 AM, Junio C Hamano wrote:
> The basic flow based on this mechanism goes like this:
>
> 1. You push out your work with "git push -s".
>
> 2. The sending side learns where the remote refs are as usual,
> together with what protocol extension the receiving end
>
On Sun, Jul 6, 2014 at 6:15 PM, Andi Kleen wrote:
>> a justification why the geometric mean is used here would increase my
>> confident significantly.
>
> It's just a standard way to summarize sets of benchmarks. For example SPEC
> uses the same approach.
No, SPEC would have calculated the geomet
Hi,
On Sat, Jul 5, 2014 at 1:43 AM, Andi Kleen wrote:
> From: Andi Kleen
>
> Signed-off-by: Andi Kleen
> ---
> diff-res | 26 ++
> 1 file changed, 26 insertions(+)
> create mode 100755 diff-res
>
> diff --git a/diff-res b/diff-res
> new file mode 100755
> index 000
On Tue, Jul 9, 2013 at 7:18 AM, Junio C Hamano wrote:
> Instead of using a hand-managed argument array, use argv-array API
> to manage dynamically formulated command line.
>
> Signed-off-by: Junio C Hamano
> ---
> remote-curl.c | 31 +++
> 1 file changed, 15 insertion
tions - to indicate to its caller
> that the input fails to match the trailing part of the format string.
> In other words, AFAICS, the scanf() family of function will only verify
> matching input up to and including the last format specifier in the
> format string.
On Tue, Sep 18, 2012 at 4:52 AM, Mischa POSLAWSKY wrote:
> Junio C Hamano skribis 2012-9-16 22:22 (-0700):
>
>> Mischa POSLAWSKY writes:
>>
>> > Subject: [PATCH/RFC] format-patch: force default file prefixes in diff
>> >
>> > Override user configuration (eg. diff.noprefix) in patches intended for
verywhere.
>
> Signed-off-by: Vitaly _Vi Shukela
> ---
> Sending the patch the third time (haven't got any replies to previous two
> attempts).
For what its worth:
Acked-by: Bert Wesarg
But unless Pat reacts this is useless.
Bert
>
> git-gui/git-gui.sh |4
&
100 matches
Mail list logo
