Oomph, how embarrassing. Thanks for pointing that out!
Would it be better if I rerolled the patches?
- Brian Gesiak
On Tue, May 27, 2014 at 12:25 PM, Eric Sunshine sunsh...@sunshineco.com wrote:
On Mon, May 26, 2014 at 11:33 AM, Brian Gesiak modoca...@gmail.com wrote:
xcalloc takes two
what to branch off of
in the future.
On Wed, May 28, 2014 at 6:35 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
Etiquette on this list is to avoid top-posting [1].
...
If you do re-roll, perhaps consider simplifying the commit messages.
Thank you for the tips; very much appreciated.
- Brian
xcalloc takes two arguments: the number of elements and their size.
The vast majority of the Git codebase passes these arguments in the
correct order, but there are some exceptions. This patch series
corrects those exceptions.
Brian Gesiak (15):
builtin/add.c: rearrange xcalloc arguments
xcalloc takes two arguments: the number of elements and their size.
diffstat_add passes the arguments in reverse order, passing the
size of a diffstat_file*, followed by the number of diffstat_file* to
be allocated. Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak
xcalloc takes two arguments: the number of elements and their size.
run_add_interactive passes the arguments in reverse order, passing the
size of a char*, followed by the number of char* to be allocated.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca
xcalloc takes two arguments: the number of elements and their size.
prellocate_hash passes the arguments in reverse order, passing the
size of a hash table entry, followed by the number of entries.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
xcalloc takes two arguments: the number of elements and their size.
init_pack_revindex passes the arguments in reverse order, passing the
size of a pack_revindex, followed by the number to allocate.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
xcalloc takes two arguments: the number of elements and their size.
builtin/remote.c includes several calls to xcalloc that pass the
arguments in reverse order. Rearrgange them so they are in the
correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
builtin/remote.c | 8
1
xcalloc takes two arguments: the number of elements and their size.
reflog-walk.c includes several calls to xcalloc that pass the arguments
in reverse order. Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
reflog-walk.c | 8
1 file
xcalloc takes two arguments: the number of elements and their size.
reduce_heads passes the arguments in reverse order, passing the
size of a commit*, followed by the number of commit* to be allocated.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca
xcalloc takes two arguments: the number of elements and their size.
grow_hash_table passes the arguments in reverse order, passing the
size of a hash table entry, followed by the number of entries.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
xcalloc takes two arguments: the number of elements and their size.
parse_refspec_internal passes the arguments in reverse order, passing the
size of a refspec, followed by the number to allocate. Rearrgange them
so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
xcalloc takes two arguments: the number of elements and their size.
notes.c includes several calls to xcalloc that pass the arguments in
reverse order. Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
notes.c | 6 +++---
1 file changed, 3
xcalloc takes two arguments: the number of elements and their size.
http-push passes the arguments in reverse order, passing the size
of a repo, followed by the number to allocate. Rearrgange them so
they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
http-push.c
xcalloc takes two arguments: the number of elements and their size.
config.c includes several calls to xcalloc that pass the arguments
in reverse order: the size of a struct lock_file*, followed by the
number to allocate. Rearrgange them so they are in the correct order.
Signed-off-by: Brian
xcalloc takes two arguments: the number of elements and their size.
imap_open_store passes the arguments in reverse order, passing the
size of an imap_store*, followed by the number to allocate.
Rearrgange them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca...@gmail.com
xcalloc takes two arguments: the number of elements and their size.
transport_helper_init passes the arguments in reverse order, passing the
size of a helper_data*, followed by the number to allocate. Rearrgange
them so they are in the correct order.
Signed-off-by: Brian Gesiak modoca
based on master?
- Brian Gesiak
[1]
https://github.com/git/git/blob/4a28f169ad29ba452e0e7bea2583914c10c58322/Documentation/SubmittingPatches#L9
On Tue, May 27, 2014 at 8:11 AM, Jeremiah Mahler jmmah...@gmail.com wrote:
Brian,
On Tue, May 27, 2014 at 12:33:42AM +0900, Brian Gesiak wrote
strbuf_trim strips whitespace from the end, then the beginning of a
strbuf. Those operations are duplicated in strbuf_rtrim and
strbuf_ltrim.
Replace strbuf_trim implementation with calls to strbuf_rtrim,
then strbuf_ltrim.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
This is tangential
API documentation for strbuf does not document strbuf_trim or
strbuf_ltrim. Add documentation for these two functions.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
Documentation/technical/api-strbuf.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/technical
] and
Twitter[2].
[1] https://github.com/modocache
[2] https://twitter.com/modocache
- Brian Gesiak
On Tue, Apr 22, 2014 at 10:06 AM, Andrew Ardill andrew.ard...@gmail.com wrote:
Congrats everyone who was successful in being picked for this year's GSoC.
Fabian with Line options for git rebase
,
but then only translating @{-1} would seem inconsistent.
From that point of view I'd prefer to simply translate -,
not @{-1}.
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
.
Requested-by: John Keeping j...@keeping.me.uk
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
git-rebase.sh | 8 +++-
t/t3400-rebase.sh | 4 +---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/git-rebase.sh b/git-rebase.sh
index 2c75e9f..42d34a6 100755
--- a/git
://github.com/modocache/git-po-ja
Thanks!
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-roll this patch to include symbolic names for @{-n}.
As usual, thanks for the feedback!
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Requested-by: John Keeping j...@keeping.me.uk
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
Previous discussion on this issue:
http://article.gmane.org/gmane.comp.version-control.git/244340
git-rebase.sh | 2 +-
t/t3400-rebase.sh | 4 +---
2 files changed, 2 insertions(+), 4 deletions
Inline comment had incorrect grammar. Fix grammatical mistakes and
reflect actual behavior of the function.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
builtin/checkout.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index
Teach rebase the same shorthand as checkout and merge; that is, that -
means the branch we were previously on.
Reported-by: Tim Chase g...@tim.thechases.com
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
git-rebase.sh | 4
t/t3400-rebase.sh | 11 +++
2 files changed, 15
of which branch they have switched
to when using the - shorthand: Switched to branch 'master'.
Should I submit a new patch, or reroll this one?
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Teach rebase the same shorthand as checkout and merge; that is, that -
means the branch we were previously on.
Reported-by: Tim Chase g...@tim.thechases.com
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
git-rebase.sh | 4
t/t3400-rebase.sh | 6 ++
2 files changed, 10
think it's
impossible.
I'll add some more details on this to my proposal[1]. Thank you!
- Brian Gesiak
[1]
https://www.google-melange.com/gsoc/proposal/review/student/google/gsoc2014/modocache/5629499534213120
--
To unsubscribe from this list: send the line unsubscribe git in
the body
Gesiak
PS: I'm maintaining a working draft of my proposal here, in case
anyone wants to offer any feedback prior to its submission:
https://gist.github.com/modocache/9434914
On Tue, Mar 4, 2014 at 7:42 AM, Jeff King p...@peff.net wrote:
On Sun, Mar 02, 2014 at 06:04:39AM +0900, Brian Gesiak wrote
No test asserts that git branch -u refs/heads/my-branch my-branch
emits a warning. Add a test that does so.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
t/t3200-branch.sh | 10 ++
1 file changed, 10 insertions(+)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index fcdb867
, an exit code
of 0 is misleading. Instead, exit with a status code indicating failure
by using the die function.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
branch.c | 9 ++---
t/t3200-branch.sh | 6 +++---
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/branch.c
. Instead, exit with a status code indicating failure
by using the die function.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
branch.c | 9 ++---
t/t3200-branch.sh | 6 +++---
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/branch.c b/branch.c
index e163f3c..9bac8b5
the feedback so far!
- Brian Gesiak
On Sat, Mar 1, 2014 at 9:23 PM, Brian Gesiak modoca...@gmail.com wrote:
Branch set as own upstream using one of the following commands returns
immediately with an exit code of 0:
- `git branch --set-upstream-to foo refs/heads/foo`
- `git branch --force --track
Hello all,
My name is Brian Gesiak. I'm a research student at the University of
Tokyo, and I'm hoping to participate in this year's Google Summer of
Code by contributing to Git. I'm a longtime user, first-time
contributor--some of you may have noticed my microproject
patches.[1][2]
I'd like
/foo? Perhaps I'm missing some insight on how --track is
used.
The tests appear to already cover all instances in which
install_branch_config is called, and bumping the warning to an error
does not cause any test failures.
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git
be
included in.
In any case, if the jury's out on this one, I suppose the two patches
I submitted are good to merge? Part of me thinks the bump from warning
to error belongs in its own patch anyway.
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message
From: modocache modoca...@gmail.com
No test asserts that git branch -u refs/heads/my-branch my-branch
emits a warning. Add a test that does so.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
t/t3200-branch.sh | 8
1 file changed, 8 insertions(+)
diff --git a/t/t3200-branch.sh b/t
From: modocache modoca...@gmail.com
The install_branch_config function reimplemented the skip_prefix
function inline. Use skip_prefix function instead for brevity.
Signed-off-by: Brian Gesiak modoca...@gmail.com
Reported-by: Michael Haggerty mhag...@alum.mit.edu
---
branch.c | 18
! Also, sorry if it's in the Makefile somewhere, but is there
an easy way
to run just a single test file in the t directory?
- Brian Gesiak
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
No test asserts that git branch -u refs/heads/my-branch my-branch
emits a warning. Add a test that does so.
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
t/t3200-branch.sh | 8
1 file changed, 8 insertions(+)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index fcdb867
The install_branch_config function reimplemented the skip_prefix
function inline. Use skip_prefix function instead for brevity.
Reported-by: Michael Haggerty mhag...@alum.mit.edu
Signed-off-by: Brian Gesiak modoca...@gmail.com
---
branch.c | 18 +-
1 file changed, 9 insertions
it will be a large diff.
- Brian Gesiak
On Fri, Feb 28, 2014 at 4:26 PM, Jeff King p...@peff.net wrote:
On Fri, Feb 28, 2014 at 02:14:01AM -0500, Jeff King wrote:
I didn't think we bothered to make sh -x work robustly. I don't mind
if we do, but git grep -E 'test_(i18n)?cmp .*err shows many potential
45 matches
Mail list logo
