FWIW this patch doesn't have any other siblings and subject should had
been just [PATCH]; apologize for the confusion and the spam (including
that other duplicated email, and most likely this one)
Carlo
On Tue, Nov 27, 2018 at 2:53 AM Eric Sunshine wrote:
> On Tue, Nov 27, 2018 at 5:06 AM Carlo Marcelo Arenas Belón
> > +ifneq ($(filter clang10,$(COMPILER_FEATURES)),)
> > +CFLAGS += -Wpedantic
> > +endif
>
> Should this condition be tightened to match only for OSX since there
> is no such clang
Signed-off-by: Carlo Marcelo Arenas Belón
clang with -Wpedantic also catch this (at least with Apple LLVM
version 10.0.0); recent versions of gcc also include that flag and at
least 8.2.0 shows a warning for it, so it might be worth adding it to
developer mode (maybe under the pedantic DEVOPTS),
Tested-by: Carlo Marcelo Arenas Belón
IMHO leaving the shebang might be better if only for consistency but
could go eitherway
Carlo
On Thu, Nov 22, 2018 at 3:43 PM Max Kirillov wrote:
> also edited the test to include only push_plain case,
> and repeat it several times, to avoid running irrelevant
> cases, the failure never happened again.
as I explained previously[1] and as odd as it might seem the
push_plain case ONLY
On Wed, Nov 21, 2018 at 10:37 PM Max Kirillov wrote:
>
> On Wed, Nov 21, 2018 at 05:04:25PM -0800, Carlo Arenas wrote:
> > the last child of its children long gone with an error as shown by :
> >
> > 9255 1 git-http-backend CALL close(1)
> ...
> >
On Wed, Nov 21, 2018 at 2:49 PM Max Kirillov wrote:
>
> On Wed, Nov 21, 2018 at 04:02:04AM -0800, Carlo Arenas wrote:
> > for some tracing, it would seem that it gets 0 when
> > trying to read 4 bytes from what I think is a pipe that connects to a
> > child that has been
On Wed, Nov 21, 2018 at 2:49 PM Max Kirillov wrote:
>
> Should I install bash for it to work? I cannot say I understand what the
> message is about.
yes, you need to install bash and use SHELL_PATH=/usr/pkg/bin/bash;
PERL_PATH=/usr/pkg/bin/perl for the perl script
Carlo
FWIW the issue goes away when more than 1 CPU is used in NetBSD 8,0
(32-bit) and for some tracing, it would seem that it gets 0 when
trying to read 4 bytes from what I think is a pipe that connects to a
child that has been gone already for a while.
Carlo
Tested-by: Carlo Marcelo Arenas Belón
the C version prepends: "fatal: " unlike the shell version for both
error messages
Carlo
Tested-by: Carlo Marcelo Arenas Belón
in macOS 10.14.1 with APFS
in Linux using VFAT (for the lulz)
IMHO it would be ideal if test would be enabled/validated for windows
(native, not only cygwin) as it might even work without the override
and if we are to see conflicts, that is probably where
ok 99 - colliding file detection
as well in macOS with APFS
Carlo
On Mon, Nov 19, 2018 at 9:23 AM Ramsay Jones
wrote:
> ok 99 # skip colliding file detection (missing !CYGWIN of
> !MINGW,!CYGWIN,CASE_INSENSITIVE_FS)
you need to enable this specific test first (removing !CYGWIN) so it
doesn't get skipped
Carlo
On Mon, Nov 19, 2018 at 10:40 AM Max Kirillov wrote:
>
> On Mon, Nov 19, 2018 at 02:15:35AM -0800, Carlo Marcelo Arenas Belón wrote:
> > 6c213e863a ("http-backend: respect CONTENT_LENGTH for receive-pack",
> > 2018-07-27)
> > introduced all tests but without a check for CURL support from git.
>
On Mon, Nov 19, 2018 at 4:28 AM Torsten Bögershausen wrote:
>
> Did you test it on Mac ?
macOS 10.14.1 but only using APFS, did you test my patch with HFS+?
> So what exactly are you trying to fix ?
I get
not ok 99 - colliding file detection
#
# grep X icasefs/warning &&
# grep x
On Tue, Nov 13, 2018 at 12:49 AM Johannes Schindelin
wrote:
> On Mon, 12 Nov 2018, Carlo Marcelo Arenas Belón wrote:
>>
> > if time_t can't represent a valid time keep the indexes for failsafe
>
> Is this sentence incomplete? What are those "indexes"?
the indexes that are created when
On Thu, Nov 1, 2018 at 10:24 PM Jeff King wrote:
>
> static void date_yesterday(struct tm *tm, struct tm *now, int *num)
> {
> + *num = 0;
the only caller (date_time) for this sends num = NULL, so this
triggers a segfault.
the only reference I could find to that apparently unused
On Fri, Nov 2, 2018 at 9:44 AM Johannes Sixt wrote:
>
> + timeout = elapsed >= orig_timeout ? 0 : (int)(orig_timeout - elapsed);
nitpick: cast to DWORD instead of int
Carlo
On Thu, Oct 25, 2018 at 2:09 PM Ramsay Jones
wrote:
> Yes, this will 'fix' the 'commit-reach.h' header (not surprising),
> but I prefer my patch. ;-)
I apologize, I joined the list recently and so might had missed a
reroll; the merged series in pu doesn't seem to include it and the
error was
On Thu, Oct 25, 2018 at 1:08 AM Junio C Hamano wrote:
> For a single-use, not using the macro and just using "%s", "" should
> suffice.
OK, will send it as v2 then but would think it will be better if
applied as a "fixup" on top of the original branch:
34b47315d9 ("rebase -i: move rebase--helper
On Wed, Oct 24, 2018 at 11:22 PM Junio C Hamano wrote:
> and they would read naturally. But may be it is a bit too cute an
> idea? I dunno.
my first idea was to replace it with a helper called touch_file, since
I was expecting it will be a popular operation as flag files are
common in shell
On Wed, Oct 24, 2018 at 7:41 PM brian m. carlson
wrote:
> diff --git a/sha256/block/sha256.h b/sha256/block/sha256.h
> new file mode 100644
> index 00..38f02f7e6c
> --- /dev/null
> +++ b/sha256/block/sha256.h
> @@ -0,0 +1,26 @@
> +#ifndef SHA256_BLOCK_SHA256_H
> +#define
On Tue, Oct 23, 2018 at 3:00 PM Jeff King wrote:
> On Tue, Oct 23, 2018 at 02:50:19PM -0700, Carlo Marcelo Arenas Belón wrote:
> > #define implement_static_commit_slab(slabname, elemtype) \
> > - implement_commit_slab(slabname, elemtype, static MAYBE_UNUSED)
> > +
On Tue, Oct 23, 2018 at 9:19 AM René Scharfe wrote:
> With Clang 6 and GCC 8 on Debian I don't get any warnings on master or
> 36da893114.
I see it with Clang 7 on Fedora (at least Rawhide but suspect also to
affect the next release, now in beta: 29)
> With Clang 6 on OpenBSD I get warnings
On Tue, Oct 23, 2018 at 2:40 AM Junio C Hamano wrote:
>
> The tip of 'pu' has trouble with -Wunused on Apple around the
> delta-islands series.
FWIW the "problem" is actually with -Wunused-function and is AFAIK not
related to the semantic changes or Apple (AKA macOS)
Indeed, I saw this issue
I agree with you; dropped
On Sat, Oct 20, 2018 at 9:45 AM Torsten Bögershausen wrote:
>
> The motivation feels a little bit weak, at least to me.
I have to admit, I was sitting on this patch for a while for the same reason
but I should had made a more compelling commit message either way and
will definitely fix that with
On Thu, Oct 18, 2018 at 12:36 PM Derrick Stolee wrote:
>
> Is there a tool that reports a wasted
> initialization that you used to find this?
I'd used clang's analyzer recently to track a similar issue before in a
different codebase, but not for this specific case.
Carlo
28 matches
Mail list logo
