Re: [PATCH 0/2] Log pretty format alignment improvements

2016-06-17 Thread Josef Kufner
Junio C Hamano wrote, on 16.6.2016 20:25: > "as long as >(N) can be used as Duy claims as a workaround to > get the original behaviour, it is good to allow using >|(N) > for this new output format; I didn't check if >(N) does behave > that way, though" Yes, it can be used in such way. Example:

[PATCH] Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"

2015-09-11 Thread Josef Kufner
--- t/t4205-log-pretty-formats.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh index 7398605..3358837 100755 --- a/t/t4205-log-pretty-formats.sh +++ b/t/t4205-log-pretty-formats.sh @@ -319,6 +319,18 @@

Re: [PATCH] Pass graph width to pretty formatting, so '%>|' can work properly

2015-09-11 Thread Josef Kufner
Ok, there are the two tests (see the second e-mail). It should cover two cases where something may go wrong. Junio C Hamano wrote, on 11.9.2015 18:54: > This "feels" correct ;-), but let me summon Duy who did the %>< > padding at around a5752342 (pretty: support padding placeholders, %< > %> and

Re: [PATCH] Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"

2015-09-11 Thread Josef Kufner
Eric Sunshine wrote, on 11.9.2015 21:37: > On Fri, Sep 11, 2015 at 1:50 PM, Josef Kufner <jo...@kufner.cz> wrote: >> --- > > Missing sign-off. Or is this intended to be concatenated with the > patch you sent earlier? Just forgot to add it. Fixed patch on the way. >

[PATCH] Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"

2015-09-11 Thread Josef Kufner
Signed-off-by: Josef Kufner <jo...@kufner.cz> --- t/t4205-log-pretty-formats.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh index 7398605..3358837 100755 --- a/t/t4205-log-pretty-formats.sh +

[PATCH 2/3] Add tests for "pretty: Pass graph width to pretty formatting for use in '%>|(N)'"

2015-09-11 Thread Josef Kufner
Signed-off-by: Josef Kufner <jo...@kufner.cz> --- t/t4205-log-pretty-formats.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh index 7398605..3358837 100755 --- a/t/t4205-log-pretty-formats.sh +

[PATCH 1/3] pretty: Pass graph width to pretty formatting for use in '%>|(N)'

2015-09-11 Thread Josef Kufner
t from the edge of the graph. Signed-off-by: Josef Kufner <jo...@kufner.cz> --- commit.h | 1 + graph.c| 7 +++ graph.h| 5 + log-tree.c | 2 ++ pretty.c | 1 + 5 files changed, 16 insertions(+) diff --git a/commit.h b/commit.h index 5d58be0..0a9a707 100644 --- a/commit.h ++

[PATCH 3/3] t4205: remove unnecessary use of qz_to_tab_space

2015-09-11 Thread Josef Kufner
Many existing tests in this script pipes the result thru qz_to_tab_space, but the payload does not need any Q or Z to be replaced to tab or space. Redirect the input directly into iconv or use cat instead. Signed-off-by: Josef Kufner <jo...@kufner.cz> --- t/t4205-log-pretty-formats.

[PATCH] Pass graph width to pretty formatting, so '%>|' can work properly

2015-09-11 Thread Josef Kufner
e edge of the graph. Signed-off-by: Josef Kufner <jo...@kufner.cz> --- commit.h | 1 + graph.c| 7 +++ graph.h| 5 + log-tree.c | 2 ++ pretty.c | 1 + 5 files changed, 16 insertions(+) diff --git a/commit.h b/commit.h index 5d58be0..0a9a707 100644 --- a/commit.h +++ b/commit