Re: Git on Windows maps creation time onto changed time

2018-02-02 Thread Keith Goldfarb
> On Feb 2, 2018, at 1:18 PM, Johannes Schindelin > wrote: > > You cannot assume that the inode numbers are identical between file > systems/operating systems. That's simply not going to work. Yes, I agree with you, I cannot assume this, so I checked. In my case,

Re: Git on Windows maps creation time onto changed time

2018-02-02 Thread Keith Goldfarb
> The purpose of these values is to allow to notice a change on the file system > without going through the actual file data. Duplicating st_mtime would be > pointless. Well, I agree with the first statement. I disagree with the 2nd. It’s not pointless to fix a problem, and in theory the

Git on Windows maps creation time onto changed time

2018-02-01 Thread Keith Goldfarb
Dear git, While tracking down a problem with a filesystem shared by Windows and Ubuntu, I came across the following code in compat/mingw.c (ming_fstat(), also in do_lstat()): if (GetFileInformationByHandle(fh, )) { buf->st_ino = 0; buf->st_gid = 0;

Re: [PATCH v3 5/5] archive-zip: support files bigger than 4GB

2017-04-24 Thread Keith Goldfarb
This set of patches works for my test case. Thanks, K.

Git archive doesn't fully support zip64

2017-04-21 Thread Keith Goldfarb
Dear git, git archive, when writing a zip file, has a silent 4GB file size limit (on the inputs as well as the output), as it doesn’t fully support zip64. Although a zip archive written by git which is larger than 4GB can be often still be unzipped, it won’t be fully useable and some tools