[PATCH 5/4 v3] wincred: port to generic credential helper

2012-09-01 Thread Philipp A. Hartmann
From: Philipp A. Hartmann p...@qo.cx In addition to porting the helper to the generic API, this patch clears up all passwords from memory, which reduces the total amount to saved lines. This version will now pass t0303 if you do GIT_TEST_CREDENTIAL_HELPER=wincred \ ./t0303-credential

Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-26 Thread Philipp A. Hartmann
n 26/08/12 19:46, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Jeff King p...@peff.net writes: However, the shared bits are simple enough that maybe that is not a concern. An interesting test would be to add a 5/4 porting Erik's win32 credential helper, since that is the

[PATCH 5/4 v2] wincred: port to generic credential helper (UNTESTED)

2012-08-26 Thread Philipp A. Hartmann
From: Philipp A. Hartmann p...@qo.cx This patch is an experiment to port the wincred helper to the generic implementation. As of know, it is completely untested. In addition to porting the helper to the generic API, this patch clears up all passwords from memory, which reduces the total amount

[PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-23 Thread Philipp A. Hartmann
All, the following patch series proposes enhancements to the credential helper implementations in the contrib section. The detailed development history can be found at GitHub [1]. The first patch adds a GnomeKeyring credential backend. The GnomeKeyring specific parts are based on the work by

[PATCH 1/4] contrib: add credential helper for GnomeKeyring

2012-08-23 Thread Philipp A. Hartmann
From: Philipp A. Hartmann p...@qo.cx With this installed in your $PATH, you can store git-over-http passwords in your keyring by doing: git config credential.helper gnome-keyring The code is based in large part on the work of John Szakmeister who wrote the helper originally for the initial

[PATCH 3/4] gnome-keyring: port to generic helper implementation

2012-08-23 Thread Philipp A. Hartmann
From: Philipp A. Hartmann p...@qo.cx Use generic credential helper implementation in the GnomeKeyring credential helper. The GnomeKeyring helper has been using the generic implementation internally already and therefore only drops the duplicate code. Signed-off-by: Philipp A. Hartmann p

[PATCH 4/4] osxkeychain: port to generic credential helper implementation

2012-08-23 Thread Philipp A. Hartmann
From: Philipp A. Hartmann p...@qo.cx This reduces code duplication in the osxkeychain helper by basing the implementation on the generic helper implementation. Alongside, the return codes of the helper are tightened to be more consistent in corner cases and the memory containing cleartext

[PATCH 2/4] contrib: add generic credential helper

2012-08-23 Thread Philipp A. Hartmann
From: Philipp A. Hartmann p...@qo.cx This adds a generic implementation for credential helpers. It provides a header file credential_helper.h containing a simplified credential API and common helper functions. The implementation in credential_helper.c already provides a main() function