124 ++-
> t/t3206/history.export | 84 ++-
> 7 files changed, 409 insertions(+), 163 deletions(-)
Yes, the patch I just sent related to the previous version of
this series. However, I believe it still applies to this version
(looking at the range-diff below
Signed-off-by: Ramsay Jones
---
Hi Thomas,
If you need to re-roll your 'tg/range-diff-output-update' branch, could
you please squash (parts) of this into the relevant patches.
The first hunk fixes a couple of 'hdr-check' warnings:
$ diff nhcout phcout | head
4a5,1
Signed-off-by: Ramsay Jones
---
Hi Junio,
It seems Ævar didn't have a need to re-roll his patches [1], before
the 'ab/test-env' branch was merged to next. This version of the
patch is based on current 'next'.
Thanks!
ATB,
Ramsay Jones
[1]
https://public-inbox.o
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/multi-promisor' branch, could you please
squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
implement promisor_remote_get_direct()", 2019-06-25).
[No, this is not the sam
Signed-off-by: Ramsay Jones
---
Hi Ævar,
If you need to re-roll your 'ab/test-env' branch, could you please
squash this into the relevant patch (commit b4f207f339, "env--helper:
new undocumented builtin wrapping git_env_*()", 2019-06-21).
Thanks!
ATB,
Ramsay Jones
b
g something, but the above is usually
sufficient for my uses. (Having said that, I have not
had the need to debug extensions [yet!]).
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/index-dump-in-json' branch, could
you please squash this into the relevant patch (commit 53f1666b3a,
'split-index.c: dump "link" extension as json', 2019-06-19).
Thanks!
ATB,
Ramsay Jones
On 20/06/2019 08:41, Jeff King wrote:
> There are no callers left of lookup_object() that aren't just passing us
s/lookup_object/create_object/
ATB,
Ramsay Jones
On 14/06/2019 21:30, Ramsay Jones wrote:
>
>
> On 14/06/2019 11:00, SZEDER Gábor wrote:
>> Update 'compat/obstack.{c,h}' from upstream, because they already use
>> 'size_t' instead of 'long' in places that might eventually end up as
>>
; compat/obstack.c:331:5:expected void ( *[addressable] [toplevel]
obstack_alloc_failed_handler )( ... )
> compat/obstack.c:331:5: got void ( [noreturn] * )( ... )
$
So, yes you did catch all "using plain integer as NULL pointer"
warnings! :-D
Thanks.
ATB,
Ramsay Jones
ot;git commit-graph write [--object-dir ] [--append|--split]
> [--reachable|--stdin-packs|--stdin-commits]"),
> + N_("git commit-graph write [--object-dir ] [--append|--split]
> [--reachable|--stdin-packs|--stdin-commits] "),
> NULL
> };
>
> @@ -135,6 +135,7 @@ static int graph_read(int argc, const char **argv)
> }
>
> extern int read_replace_refs;
> +struct split_commit_graph_opts split_opts;
This 'split_opts' variable needs to be marked 'static'.
Thanks.
ATB,
Ramsay Jones
uld be cleaned up or simplified. If we want to
> shut up the warning completely (so we can pay attention to it), we'll
> then have to annotate probably a couple hundred spots, and keep those
> annotations up to date. But I feel better doing that knowing that it's
> shown real-world value.
OK, I will drop this branch then.
Thanks all.
ATB,
Ramsay Jones
On 24/05/2019 23:30, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, May 24 2019, Ramsay Jones wrote:
>
>> [No, I won't be sending 52 patches to the list!]
>> [...]
>> This series does not fix any problems or add any new features, so it
>> is not important (
e
merge to 'next' went without problem, and 'pu' only required a fixup
to the builtin/commit patch).
[The 'warn-v2.21' branch shows the previous version of the series.]
What do you think?
Thanks!
ATB,
Ramsay Jones
Ramsay Jones (52):
parse-options: reformat th
On 22/05/2019 01:11, Duy Nguyen wrote:
> On Wed, May 22, 2019 at 2:56 AM Ramsay Jones
> wrote:
>>
>> Hi Duy,
>>
>> I am in the middle of rebasing a long running branch onto
>> current master (v2.22.0-rc1) and noticed something odd with
>> commit af
_NONEG, NULL, 0, diff_opt_output },
Note that the 'option type' is given as OPTION_CALLBACK, not
as OPTION_LOWLEVEL_CALLBACK. Is this intended?
ATB,
Ramsay Jones
[1] Yes, the reason my branch is long running is because
we keep changing the same files! We have both defined new
OPT_() macros, some with the same name ... ;-)
only
> one small merge conflict.
... not forgetting the second hunk of [1], of course. ;-)
[1]
https://public-inbox.org/git/5f0c12d5-6714-1516-3579-33d839ad7...@ramsayjones.plus.com/
ATB,
Ramsay Jones
d44b5af6e3292c837ceda003f9 0 b
100644 a296d0bb611188cabb256919f36bc30117cca005 0 c
100644 a296d0bb611188cabb256919f36bc30117cca005 0 c
$
Er, ... well, I obviously don't have a clue how it is supposed
to work. This just looks broken to me. :(
> So the patch itself looks good to me (though I agree that Eric's
> suggestion to de-dup inside "make" is better still).
Agreed.
ATB,
Ramsay Jones
ject_crc;
> +int do_check_packed_object_crc;
... removing this 'extern' on an int variable sends 'sparse'
into a frenzy of warnings! :-D
[You didn't use a global s/extern// by any chance?]
ATB,
Ramsay Jones
On 05/04/2019 00:22, Jeff King wrote:
> There's no such argument as "--unordered"; it's spelled "--unsorted".
Err, isn't this back-to-front? (i.e. cat-file has the _option_
"--unordered" but not "--unsorted").
I suspect that I am not reading that right! :-D
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/multi-promisor' branch, could you
please squash this into the relevant patch (commit e52d417b57
("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
[I had a deja-vu mome
On 25/03/2019 12:02, Ævar Arnfjörð Bjarmason wrote:
>
> On Sat, Mar 23 2019, Ramsay Jones wrote:
>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Ævar,
>>
>> If you need to re-roll your 'ab/commit-graph-fixes' branch, could you
>>
Signed-off-by: Ramsay Jones
---
Hi Ævar,
If you need to re-roll your 'ab/commit-graph-fixes' branch, could you
please squash this into the relevant patch (commit aeb244adbc
("commit-graph: don't early exit(1) on e.g. \"git status\"", 2019-02-21).
This sa
ed-by: ",
> stating satisfaction that the patch seems worthy of inclusion in the
> project. If he sees fit, Junio may then pick up that Reviewed-by: at
> the time he queues the patch in his tree.
>
>> Signed-off-by: Ramsay Jones
I was similarly surprised to see this SO
On 14/03/2019 00:19, Jeff King wrote:
> On Wed, Mar 13, 2019 at 09:49:58PM +0000, Ramsay Jones wrote:
>
>> From: Jeff King
>> [...]
>> Signed-off-by: Ramsay Jones
>
> Signed-off-by: Jeff King
>
> Naturally. :)
>
>> As promised, I am forwarding
On 13/03/2019 21:49, Ramsay Jones wrote:
> From: Jeff King
>
> We use the "offset" variable for two purposes. It's the offset into
> the packfile that the caller provides us (which is rightly an off_t,
> since we might have a packfile much larger than memory).
thin the pack window), but using a separate variable of the
right type makes that much more obvious.
Signed-off-by: Ramsay Jones
---
Hi Junio,
As promised, I am forwarding a 'saved' patch from Jeff, which was
a by-product of a long-ago discussion regarding commit 5efde212fc
("zlib
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/multi-promisor' branch, could you
please squash this into the relevant patch (commit 9e8a7cf4be
("promisor-remote: implement promisor_remote_get_direct()", 2019-03-12)).
Also, I note that the
On 12/03/2019 20:26, Jeff King wrote:
> On Tue, Mar 12, 2019 at 05:39:13PM +0000, Ramsay Jones wrote:
>
>> On 12/03/2019 16:55, Ramsay Jones wrote:
>>> From: Jeff King
>>>
>>> Signed-off-by: Ramsay Jones
>
> Could definitely use a commit messag
On 12/03/2019 16:55, Ramsay Jones wrote:
> From: Jeff King
>
> Signed-off-by: Ramsay Jones
> ---
>
> Hi Jeff,
>
> I recently tried (yet again) to tidy up some old branches. When I get
> around to doing a 'git gc; git fsck' I always take a quick look at
From: Jeff King
Signed-off-by: Ramsay Jones
---
Hi Jeff,
I recently tried (yet again) to tidy up some old branches. When I get
around to doing a 'git gc; git fsck' I always take a quick look at
the 'dangling' commits, just before a 'git gc --prune=now'.
I had
Signed-off-by: Ramsay Jones
---
Hi Denton,
If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,
could you please squash this into the relevant patch (commit 9bcdf520cb
("sequencer.c: define get_config_from_cleanup", 2019-03-10)).
I note also, that the get
Signed-off-by: Ramsay Jones
---
Hi Jonathan,
If you need to re-roll your 'jt/fetch-cdn-offload' branch, could
you please squash this into the relevant patches. (The first hunk
into commit a8d662e3da4 ("upload-pack: refactor reading of pack-objects
out", 2019-03-08) and
Signed-off-by: Ramsay Jones
---
Hi Jonathan,
If you need to re-roll your 'jt/fetch-cdn-offload' branch, could you
please squash this into the relevant patch (commit 0e821b4427
("upload-pack: send part of packfile response as uri", 2019-02-23)).
Thanks!
ATB,
Ramsay Jones
but why? Is '--[no-]overwrite-ignore' thought to
be harder to read? What about the rest of the man-pages?
ATB,
Ramsay Jones
ts ...
I deleted that email (it's not in my drafts folder anyway)
because, in the end, it is not up to me to say how people should
spend their time.
So I won't! :-D
ATB,
Ramsay Jones
with 'xdiff/%' (and similarly for the compat pattern) since
the original pattern inadvertently excluded the 'xdiff-interface.h'
header.
Signed-off-by: Ramsay Jones
---
Hi Junio,
In my local 'hdr-check-fixup' branch, the gcrypt failure is fixed
almost by default. How
On 04/03/2019 20:38, Ramsay Jones wrote:
>
>
> On 04/03/2019 13:47, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin
>>
>> In d85b0dff72 (Makefile: use `find` to determine static header
>> dependencies, 2014-08-25), we switched from a
#x27;command-list.h' header is _sometimes_ not included in the LIB_H
variable - it simply depends on whether it has been generated by the
time the $(FIND) is called.
Obviously, not worth a re-roll. Otherwise, this LGTM.
Thanks!
ATB,
Ramsay Jones
> easily worked around. Of the three si
back to your wildcard idea if
> `ls-files` fails for some reason (typically because `.git/` is missing,
> e.g. in case of an unpacked source .tar).
Yes, I think an 'git ls-files' approach is the way to go. (I am not
sure that the 'hdr-check' target would be of any use 'offline' at
all, but I suppose we could use a generated file in that case).
>> Anyway, for now, since I seem to be the only person using this
>> target, I think we should just remove it while I think again.
>> (I can put it in my config.mak, so there will be no loss for me).
>
> As I said above, I would rather keep it, with the `ls-files` and `:=`
> fixup.
I would be happy with that, if you are. :-D
ATB,
Ramsay Jones
Makefile: add a hdr-check target", 2018-09-19).
Signed-off-by: Ramsay Jones
---
Makefile | 12
1 file changed, 12 deletions(-)
diff --git a/Makefile b/Makefile
index c5240942f2..dd3e38dc1f 100644
--- a/Makefile
+++ b/Makefile
@@ -1852,7 +1852,6 @@ ifndef V
QUIET_MSGFMT
for some
unrelated headers in your worktree, then we can only use a
static list, or a 'git ls-files' approach.
Anyway, for now, since I seem to be the only person using this
target, I think we should just remove it while I think again.
(I can put it in my config.mak, so there will be no loss for me).
ATB,
Ramsay Jones
origin command line
$
So does the environment:
$ CC=env make
CC is env, origin environment
$
But that conditional assignment:
$ make
CC is cc, origin default
$
... not so much! :-D
ATB,
Ramsay Jones
(i < name->len - 1 && name->buf[i + 1] == '-')))
> + strbuf_remove(name, i, 1);
> + }
> +
> + /*
> + * a worktree name of only special chars would be reduced to
> + * an empty string
> + */> + if (name->len == 0)
> + strbuf_addstr(name, "worktree");
If you didn't 'collapse' the name above, you could check for
an empty name at the top and wouldn't need this (presumably
an empty name would not be valid).
ATB,
Ramsay Jones
err = lstat(fullname.buf, &st);
> if (show_deleted && err)
To be pedantic, this should probably check for (err == ENOENT), since
lstat() can fail for several reasons which don't imply that the path
has been deleted. However, that is
t
> the outcome of git commands that trigger the index write.
>
> The hook is passed a flag to indicate whether the working directory was
> updated or not and a flag indicating if a skip-worktree bit could have
> changed. These flags enable the hook to optmize its response to the
Signed-off-by: Ramsay Jones
---
Hi Junio,
Another 'old find' (from feb 2017), but this time I don't seem to have
sent this one to the list before. It is possible that I didn't think
it was up to scratch ... dunno. ;-)
ATB,
Ramsay Jones
builtin/prune-packed.c | 5
static keyword.
Signed-off-by: Ramsay Jones
---
Hi Junio,
This has been hanging around for a while. I sent it to the list last
time in [1], but it seems to have been dropped. (Found while attempting
to rebase loads of old branches to a newer base!)
ATB,
Ramsay Jones
[1]
https://public-inbox.o
On 10/02/2019 19:05, Ramsay Jones wrote:
>
>
> On 10/02/2019 16:02, Florian Steenbuck wrote:
>> Hello to all,
>>
>> I try to understand the git protocol only on the server site. So I
>> start without reading any docs and which turns to be fine until I got
&g
#x27; ...
We can use git-verify-pack to confirm the details here:
$ git verify-pack -v
.git/objects/pack/pack-d554e6d8335601c2525b40487faf36493094ab50.idx | head -n 1
878e2cd30e1656909c5073043d32fe9d02204daa commit 317 216 12
$
So the object 878e2cd30e, at offset 12 in the file, is a commit object
with size 317 (which has an in-pack size of 216).
Hope this helps.
ATB,
Ramsay Jones
onditional assignment (?=). This allows SPARSE_FLAGS
to be set from the environment as well as from the command-line.
Signed-off-by: Ramsay Jones
---
Makefile | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index 6e8d017e8e..fcb7575e1b 10
. Since 'sparse' does not currently
support the MinGW platform, nobody on that platform can be relying
on this setting today. Remove this use of the SPARSE_FLAGS variable.
Signed-off-by: Ramsay Jones
---
config.mak.uname | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.m
ndex.sp
SP pack-revindex.c
$ echo $?
0
$
$ SPARSE_FLAGS=-Wsparse-error make pack-revindex.sp
SP pack-revindex.c
$ echo $?
0
$
Now, we should be able to run the sparse Makefile target in a CI job, and
still find all sparse errors and warnings (now marked as err
On 04/02/2019 20:15, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> On 04/02/2019 18:12, Junio C Hamano wrote:
>>> Ramsay Jones writes:
>>>
>>>>> Thanks for a detailed and clear explanation here and in the cover
>>>>> letter.
On 30/01/2019 12:29, Jeff Hostetler wrote:
>
>
> On 1/26/2019 4:07 PM, Ramsay Jones wrote:
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Jeff,
>>
>> If you need to re-roll your 'jh/trace2' branch, could you please
>> sq
On 04/02/2019 18:12, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>>> Thanks for a detailed and clear explanation here and in the cover
>>> letter. I agree with the motivation and most of the things I see in
>>> this patch, but one thing that stands out
On 03/02/2019 12:12, SZEDER Gábor wrote:
> On Sun, Feb 03, 2019 at 01:49:37AM +0000, Ramsay Jones wrote:
>> On 02/02/2019 00:41, SZEDER Gábor wrote:
>>> On Fri, Feb 01, 2019 at 09:01:20PM +, Ramsay Jones wrote:
>>>> At the moment, on Linux, the sp-out file
On 01/02/2019 22:40, Luc Van Oostenryck wrote:
> On Fri, Feb 01, 2019 at 09:01:20PM +0000, Ramsay Jones wrote:
>>
>> I suspect that the Makefile sparse target is not easy to use in a CI
>> job, since the 'sparse' program (via cgcc -no-compile) does not exit
>
On 02/02/2019 00:41, SZEDER Gábor wrote:
> On Fri, Feb 01, 2019 at 09:01:20PM +0000, Ramsay Jones wrote:
[snip]
>> At the moment, on Linux, the sp-out file is free from any sparse errors
>> or warnings. So are next and pu:
>>
>> $ grep error sp-out
>>
On 01/02/2019 21:46, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> In order to enable greater user customisation of the SPARSE_FLAGS
>> variable, we introduce a new SP_EXTRA_FLAGS variable to use for
>> target specific settings. Without using the new variable, set
t-specific rules in the Makefile (effectively
making them useless). In addition, we initialise the SPARSE_FLAGS
to the default (empty) value using a conditional assignment (?=).
This allows the SPARSE_FLAGS to be set from the environment as
well as from the command-line.
Signed-off-by: Ra
.c
$ echo $?
0
$
$ SPARSE_FLAGS=-Wsparse-error make pack-revindex.sp
SP pack-revindex.c
$ echo $?
0
$
Now, we should be able to run the sparse Makefile target in a CI job, and
still find all sparse errors and warnings (now marked as errors also),
using something like this:
$
b19c3bf..1c385e076e 100644
--- a/change-table.h
+++ b/change-table.h
@@ -50,10 +50,10 @@ struct change_head {
* That is the ref was deleted since the time this struct was created.
Such
* entries should be ignored.
*/
- int abandoned:1,
- hidden:1,
- remote:1,
- deleted:1;
+ unsigned int abandoned:1,
+ hidden:1,
+ remote:1,
+ deleted:1;
};
/*
-- >8 --
[Note: this diff was against the v3 series].
ATB,
Ramsay Jones
On 29/01/2019 01:52, Luc Van Oostenryck wrote:
> On Mon, Jan 28, 2019 at 08:13:03PM +0000, Ramsay Jones wrote:
>
> Hi
>
>> The dependencies for the 'sparse' package includes: libc6 (>= 2.14),
>> libllvm4.0 (>= 1:4.0~), libxml2 (>= 2.7.4), perl:any
&g
On 28/01/2019 22:34, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Mon, 28 Jan 2019, Ramsay Jones wrote:
>
>> Hmm, I've never built an Ubuntu package before, so I don't know
>> exactly what would be required (spec file etc.) to create a PPA.
>> But I
On 28/01/2019 16:10, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Sat, 26 Jan 2019, Ramsay Jones wrote:
>
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Johannes,
>>
>> If you need to re-roll your 'js/vsts-ci' branch,
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jh/trace2' branch, could you please
squash this into the relevant patches (sorry, I didn't look to
see which patches need to be modified).
Thanks!
ATB,
Ramsay Jones
trace2/tr2_tgt.h | 4
trace2/tr2_
Signed-off-by: Ramsay Jones
---
Hi Johannes,
If you need to re-roll your 'js/vsts-ci' branch, could you please
squash this into the relevant patch (commit af7747e7c7 ("tests: optionally
write results as JUnit-style .xml", 2019-01-23)).
Thanks!
ATB,
Ramsay Jones
t/help
workflow (pasting the report into
> Thunderbird and sending) than with the content itself.
Have you read Doucmentation/git-format-patch.txt (Thunderbird>
Approach #2 (configuration) - approx. line 487)?
ATB,
Ramsay Jones
On 22/01/2019 07:23, Jeff King wrote:
> On Fri, Jan 18, 2019 at 01:41:08AM +0000, Ramsay Jones wrote:
>
>> I don't do this "from time to time", but *every* build on all
>> platforms! :-D
>>
>> As I have mentioned before, I run the script on 'ma
> strbuf.o - strbuf_vinsertf
$
BTW, if my memory serves (and it may not), the symbols you
refer to came directly into 'master' (via 'maint') as a
result of security updates - so I would never have seen
them in 'pu' or 'next'. They are, indeed, currently noted
in the 'master' branch:
$ grep is_ntfs_ sc
path.o - is_ntfs_dotgitattributes
path.o - is_ntfs_dotgitignore
$ grep is_hfs_ sc
utf8.o - is_hfs_dotgitattributes
utf8.o - is_hfs_dotgitignore
$
ATB,
Ramsay Jones
On 17/01/2019 10:06, Duy Nguyen wrote:
> On Thu, Jan 17, 2019 at 8:21 AM Ramsay Jones
> wrote:
>>
>>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Duy,
>>
>> If you need to re-roll your 'nd/the-index-final' branch, could you
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/the-index-final' branch, could you
please squash this into the relevant patch (commit 4478671442,
"cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch", 2019-01-12).
[the warning is caused by th
rameters,
before the declaration of 'struct repository'. Move the struct
declaration to the top of the file.
Signed-off-by: Ramsay Jones
---
Hi Duy,
If you need to re-roll your 'nd/config-move-to' branch, could you please
squash this into the relevant patch (commit 8f7c7f).
Signed-off-by: Ramsay Jones
---
Hi Alban,
If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch,
could you please squash this into the relevant patch [commit c27b32f0ec4
("sequencer: refactor check_todo_list() to work on a todo_list",
2018-12-29)].
[Bot
Signed-off-by: Ramsay Jones
---
Hi Alban,
If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch,
could you please squash this into the relevant patch [commit 45f215c912
("rebase-interactive: use todo_list_write_to_file() in edit_todo_list()",
2018-12-2
Signed-off-by: Ramsay Jones
---
Hi Derrick,
If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
you please squash this into the relevant patch [commit 9949aaeef4
("revision: implement sparse algorithm", 2018-12-14)].
This commit caused both 'sparse
gt; + argv_array_clear(&argv);
> -+ return -1;
> ++ return error(_("could not check out original"
> ++ " HEAD '%s'. Try 'git bisect"
> ++ "reset '."), branch.buf);
... this 'branch.buf' will refer to the empty 'slopbuf', since
the call to 'strbuf_release(&branch)' now precedes this call
to error().
ATB,
Ramsay Jones
isables access to Cygwin's executable attribute,
> which Windows filesystems do not have at all.
>
> I wonder if this is still relevant these days (Cc'ed Ramsay for
> input).
Ah, no, the 'tricks we have to play with lstat' mentioned in that
commit message are long gone! ;-) If you remove that conditional,
then the test passes just fine.
ATB,
Ramsay Jones
or even on APFS when inode numbers are still
> below 2^32.
>
> Or we just to to reduce the odds of matching a wrong file by checking
> more attributes, counting mostly on st_size because st_xtime is likely
> the same. This patch goes with this direction, hoping that false
> positive
On 19/11/2018 23:29, Ramsay Jones wrote:
>
>
> On 19/11/2018 21:03, Duy Nguyen wrote:
>> First of all, Ramsay, it would be great if you could test the below
>> patch and see if it works on Cygwin. I assume since Cygwin shares the
>> underlying filesystem, it will
v: 2378432 ino: 324352
uid: 1001 gid: 513
size: 0 flags: 0
x
ctime: 1542667201:665026800
mtime: 1542667201:665026800
dev: 2378432 ino: 324352
uid: 1001 gid: 513
size: 0 flags: 0
$
So, both X and x are in the index with the same inode number.
Does that help?
ATB,
Ramsay Jones
ok 98 - clone on case-insensitive fs
ok 99 # skip colliding file detection (missing !CYGWIN of
!MINGW,!CYGWIN,CASE_INSENSITIVE_FS)
ok 100 - partial clone
ok 101 - partial clone: warn if server does not support object filtering
ok 102 - batch missing blob request during checkout
ok 103 - batch missing blob request does not inadvertently try to fetch
gitlinks
# passed all 103 test(s)
# SKIP no web server found at '/usr/sbin/apache2'
1..103
$
ATB,
Ramsay Jones
On 14/11/2018 02:11, brian m. carlson wrote:
> On Wed, Nov 14, 2018 at 12:11:07AM +0000, Ramsay Jones wrote:
>>
>>
>> On 13/11/2018 18:42, Derrick Stolee wrote:
>>> On 11/4/2018 6:44 PM, brian m. carlson wrote:
>>>> +int hash_algo_by_name(const char *n
On 14/11/2018 00:11, Ramsay Jones wrote:
>
>
> On 13/11/2018 18:42, Derrick Stolee wrote:
>> On 11/4/2018 6:44 PM, brian m. carlson wrote:
>>> +int hash_algo_by_name(const char *name)
>>> +{
>>> + int i;
>>> + if (!name)
>>&
a1-file.o - hash_algo_by_name
$
The symbols from hex.o and sha1-file.o being the 4 symbols from
this branch.
I suspect that upcoming patches will make use of them. ;-)
ATB,
Ramsay Jones
not set in stone. I also like that "odb" is the same short
> length as "alt", which helps with conversion.
While reading the patch, I keep thinking it should be 'obd' for
OBject Directory. ;-)
[Given my track record in naming things, please take with a _huge_
pinch of salt!]
ATB,
Ramsay Jones
On 10/11/2018 04:55, Duy Nguyen wrote:
> On Tue, Nov 6, 2018 at 3:07 PM Ramsay Jones
> wrote:
>> Also, this patch does not replace opterror() calls outside of
>> the 'parse-options.c' file with optname(). This tickles my
>> static-check.pl script, since
cover letter:
The reason is this: something like this (make paths specified e.g. via
http.sslCAInfo relative to the runtime prefix) is potentially useful
also in the non-Windows context, as long as Git was built with the
runtime prefix feature.
... so I thought you meant to add this code for POSIX systems as well.
My mistake. :(
ATB,
Ramsay Jones
On 06/11/2018 15:54, Ramsay Jones wrote:
>
>
> On 06/11/2018 14:53, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin
>>
>> On Windows, an absolute POSIX path needs to be turned into a Windows
>> one.
>>
>> Signed-off-b
all 'included config' files?
I am pretty sure that I would not want the absolute paths
in my config file(s) magically 'moved' depending on whether
git has been compiled with 'runtime prefix' support or not!
ATB,
Ramsay Jones
> if (path[0] == '~') {
> const char *first_slash = strchrnul(path, '/');
> const char *username = path + 1;
>
led from 'parse-options.c'.
So, at present, optname() could be marked as a local 'static'
symbol. However, I could also imagine it being used by new callers
outside of 'parse-options.c' in the future. (maybe) Your call. ;-)
ATB,
Ramsay Jones
On 29/10/2018 01:13, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> ...
>>24 clear_contains_cache
>> $
>>
>> you will find 24 copies of the commit-slab routines for the contains_cache.
>> Of course, when you enable optimizations again, t
nctions as external public functions in the git binary. At present,
only three of these functions are actually called, so the trade-off
seems to favour letting the compiler inline the commit-slab functions.
Signed-off-by: Ramsay Jones
---
commit-reach.h | 5 +++--
1 file changed, 3 insertions(+),
e ewah_bitmap.o
and ewah_rlw.o object files. Despite this, add the missing 'inline'
keyword to better describe the intended behaviour.
Signed-off-by: Ramsay Jones
---
ewah/ewok_rlw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ewah/ewok_rlw.h b/ewah/ewok_rlw.h
i
Signed-off-by: Ramsay Jones
---
fetch-object.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fetch-object.h b/fetch-object.h
index d2f996d4e8..d6444caa5a 100644
--- a/fetch-object.h
+++ b/fetch-object.h
@@ -1,6 +1,8 @@
#ifndef FETCH_OBJECT_H
#define FETCH_OBJECT_H
+struct object_id
aster (@c670b1f876) and merge
without conflict to 'next' and with a 'minor' conflict on 'pu'.
Ramsay Jones (3):
fetch-object.h: add missing declaration (hdr-check)
ewok_rlw.h: add missing 'inline' to function definition
commit-reach.h: add missing decl
On 26/10/2018 04:15, Carlo Arenas wrote:
> On Thu, Oct 25, 2018 at 2:09 PM Ramsay Jones
> wrote:
>> Yes, this will 'fix' the 'commit-reach.h' header (not surprising),
>> but I prefer my patch. ;-)
>
> I apologize, I joined the list recently an
On 25/10/2018 19:54, Ramsay Jones wrote:
>
>
> On 25/10/2018 12:04, Carlo Marcelo Arenas Belón wrote:
>> struct commmit needs to be defined before commit-slab can generate
>> working code, object_id should be at least known through a forward
>> declaration
>>
Hmm, sorry, I don't see how this patch has anything to do
with the other two patches! ;-)
Also, I have a patch to fix up the 'commit-reach.h' header
(it was part of my original series, just had to update the
commit message), which adds these very #includes and forward
declarations when _using_ the commit-slab.
I haven't tried applying your patches yet, which may answer
my questions, so I am a little puzzled.
ATB,
Ramsay Jones
1 - 100 of 1047 matches
Mail list logo
