Re: [PATCH] completion: correct zsh detection when run from git-completion.zsh (Re: [PATCH v2] completion: reduce overhead of clearing cached --options)

On 11 June 2018 at 20:20, Jonathan Nieder wrote: > SZEDER Gábor wrote: > >> Being in RC phase, I'm all for aiming for a minimal solution. >> However, I don't think that the better fix would be erm.. any "less >> minimal": > > Thanks again. May we have your sign-off? > >

Re: [PATCH v2] completion: reduce overhead of clearing cached --options

) >> +fi > > As discussed at [1], this fails catastrophically when sourced by > git-completion.zsh, which explicitly clears ZSH_VERSION. By > catastrophically, I mean that Rick van Hattem and Dave Borowitz report > that it segfaults. > > I can't reproduce it since I am having trouble

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

On 6 June 2018 at 13:41, SZEDER Gábor wrote: > >> On 4 June 2018 at 05:40, Junio C Hamano wrote: >> Rick van Hattem writes: >> >> > > The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this >> > > check moot. The result (a

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

On 4 June 2018 at 05:40, Junio C Hamano wrote: Rick van Hattem writes: > > The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check > > moot. The result (at least for me) is that zsh segfaults because of all the > > variables it's unsetting. > > ---

[PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check moot. The result (at least for me) is that zsh segfaults because of all the variables it's unsetting. --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git