Re: [PATCH 3/3] lockfile: LOCK_REPORT_ON_ERROR

2016-12-08 Thread Robbie Iannucci
Thanks all for taking a look at this, I didn't expect such a quick response :). No hard feelings re: breakage; I know how gnarly these sorts of refactors can be (and more libification is always better :)). Robbie On Thu, Dec 8, 2016 at 3:53 AM, Johannes Schindelin

Re: [BUG] Index.lock error message regression in git 2.11.0

2016-12-02 Thread Robbie Iannucci
t;index.lock" ; then echo OK exit 0 fi echo Message is missing exit 1 On Fri, Dec 2, 2016 at 5:44 PM, Robbie Iannucci <iannu...@google.com> wrote: > Hello, > > I just upgraded to 2.11.0 from 2.10.2, and I noticed that some > commands no longer print an error message when

[BUG] Index.lock error message regression in git 2.11.0

2016-12-02 Thread Robbie Iannucci
Hello, I just upgraded to 2.11.0 from 2.10.2, and I noticed that some commands no longer print an error message when the `index.lock` file exists (such as `git merge --ff-only`). It appears this bug was introduced in 55f5704da69d3e6836620f01bee0093ad5e331e8 (sequencer: lib'ify