Re: [PATCH v2 0/4] Port git-add--interactive.perl:status_cmd to C

Hi Daniel, On 16-May-17 6:00 AM, Daniel Ferreira wrote: This is the second version of a patch series to start porting git-add--interactive from Perl to C. Series: v1: https://public-inbox.org/git/1494009820-2090-1-git-send-email-bnm...@gmail.com/ Travis CI build:

[PATCH 1/1 v3] stash: tolerate missing user identity

repository. Helped-by: Junio C Hamano Signed-off-by: Slavica Djukic --- git-stash.sh | 17 + t/t3903-stash.sh | 28 2 files changed, 45 insertions(+) diff --git a/git-stash.sh b/git-stash.sh index 94793c1a9..789ce2f41 100755 --- a/git-stash.sh +++

[PATCH 0/1 v3] make stash work if user.name and user.email are not configured

Changes since v2: * squash patch 1/2 and patch 2/2 into a single patch * modify first part of test when there is valid ident present: create a stash, grab %an and %ae out of the resulting commit object and compare to original ident Slavica Djukic (1

Re: [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email

Hi Junio, On 16-Nov-18 11:12 AM, Junio C Hamano wrote: Slavica Djukic writes: + git var GIT_COMMITTER_IDENT >actual && + test_cmp expected actual && I am not sure what you are testing with this step. There is nothing that changed environment variables or con

Re: [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email

Hi Junio, On 16-Nov-18 6:55 AM, Junio C Hamano wrote: Slavica Djukic writes: +test_expect_failure 'stash works when user.name and user.email are not set' ' + git reset && + git var GIT_COMMITTER_IDENT >expected && All the other existing test pieces

[PATCH v2 2/2] [Outreachy] stash: tolerate missing user identity

the stashes in a more permanent history by committing, and they must do "git config user.{name,email}" at that point anyway, so arguably this change is only delaying a step that is necessary to work in the repository. Helped-by: Junio C Hamano Signed-off-by: Slavica Djukic --- git-stash.sh |

[PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email

Add test to document that stash fails if user.name and user.email are not configured. In the later commit, test will be updated to expect success. Signed-off-by: Slavica Djukic --- t/t3903-stash.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/t/t3903-stash.sh b/t

[PATCH v2 0/2] [Outreachy] make stash work if user.name and user.email are not configured

Changes since v1: *extend test to check whether git stash executes under valid ident (and not under fallback one) when there is such present *add prepare_fallback_ident() function to git-stash.sh to provide fallback identity Slavica Djukic (2

[PATCH 3/3] [Outreachy] stash: use set_fallback_ident() function

. There are also users who find this convinient. For example, in this thread: https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#ma4fb50903a54cbcdecd4ef05856bf8094bc3c323 user points out that he would find it useful if stash had --author option. Signed-off-by: Slavica Djukic --- builtin

[PATCH 2/3] [Outreachy] ident: introduce set_fallback_ident() function

ident(), which will pre-load the ident. In following commit, set_fallback_ident() function will be called in stash. Signed-off-by: Slavica Djukic --- cache.h | 1 + ident.c | 17 + 2 files changed, 18 insertions(+) diff --git a/cache.h b/cache.h index 681307f716..6b5b559a05 1

[PATCH 1/3][Outreachy] t3903-stash: test without configured user.name and user.email

Add test to assert that stash fails if user.name and user.email are not configured. In the final commit, test will be updated to expect success. Signed-off-by: Slavica Djukic --- t/t3903-stash.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/t/t3903-stash.sh b/t/t3903

[PATCH 0/3] [Outreachy] make stash work if user.name and user.email are not configured

Enhancement request that ask for 'git stash' to work even if 'user.name' and 'user.email' are not configured. Due to an implementation detail, git-stash undesirably requires 'user.name' and 'user.email' to be set, but shouldn't. Slavica Djukic(3): [Outreachy] t3903-stash: test without

Re: [PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

On 26-Oct-18 3:13 AM, Junio C Hamano wrote: Slavica Djukic writes: From: Slavica Please make sure this matches your sign-off below. This is part of enhancement request that ask for 'git stash' to work even if 'user.name' and 'user.email' are not configured. Due to an implementation

[PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. Signed-off-by: Slavica Djukic --- t/t3903-stash.sh | 14 ++ 1 file changed, 14 insertions(+) diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 9e06494ba0..ae2c905343 100755 --- a/t/t3903-stash.sh +++ b/t/t3903

[PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name

Changes since v1: *changed: test_must_fail git config user.email to: test_unconfig user.email && test_unconfig user.name This is done to make sure that user.email and user.name are not set, instead of asserting it with

[PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u. Signed-off-by: Slavica Djukic --- t/t3903-stash.sh | 13 + 1 file changed, 13 insertions(+) diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 9e06494ba0..048998d5ce 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh

[PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

Changes since v1: *changed test title *removed subshell and HOME override *fixed weird identation *unset() replaced with sane_unset() Slavica (1): [Outreachy] t3903-stash: test without configured user name t/t3903-stash.sh | 13 + 1 file changed, 13 insertions(+)