Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-04 Thread suzuki toshiya
Dear Junio, Could you tell me your thought about the way for me to go? Do you agree with his suggestion; "--uid etc is not the right solution, --include-untracked is better and generic" ? Or, should I work "--uid etc" further? Regards, mpsuzuki Junio C Hamano wrote: René Scharfe writes: I d

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-03 Thread suzuki toshiya
t find the existing class collecting the operands as an array (or linked list) from multiple "--xxx=yyy" options. Similar things might be the collecting the pathnames to pathspec structure. Should I write something with OPTION_CALLBACK? Regards, mpsuzuki suzuki toshiya wrote: Dear René ,

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-03 Thread suzuki toshiya
options? Regards, mpsuzuki René Scharfe wrote: Am 02.01.2018 um 07:58 schrieb suzuki toshiya: Dear René , René Scharfe wrote: Am 29.12.2017 um 15:05 schrieb suzuki toshiya: The ownership of files created by git-archive is always root:root. Add --owner and --group options which work like the GN

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

2018-01-01 Thread suzuki toshiya
Dear René , René Scharfe wrote: Am 29.12.2017 um 15:05 schrieb suzuki toshiya: The ownership of files created by git-archive is always root:root. Add --owner and --group options which work like the GNU tar equivalent to allow overriding these defaults. In which situations do you use the new

[PATCH] git-archive: accept --owner and --group like GNU tar

2017-12-29 Thread suzuki toshiya
The ownership of files created by git-archive is always root:root. Add --owner and --group options which work like the GNU tar equivalent to allow overriding these defaults. Signed-off-by: suzuki toshiya --- Documentation/git-archive.txt | 13 +++ archive-tar.c | 8

Re: [PATCH] git-archive: accepts --owner --group aslike GNU tar.

2017-12-29 Thread suzuki toshiya
in t/ directories. A helper written in Python is not welcomed? If so, I would rewrite the helper in C (perl's standard library does not have a parse of tarfile). So, please do not review parse-tar-file.py. Regards, mpsuzuki Junio C Hamano wrote: suzuki toshiya writes: Current tar outp

[PATCH] git-archive: accepts --owner --group aslike GNU tar.

2017-12-28 Thread suzuki toshiya
Current tar output by git-archive has always root:root. To generate tar output with non-root owner/group, the options like GNU tar are added. * archive.h: add members 'uid', 'gid', 'uname', 'gname' to struct archiver_args. * archive.c: add functions to reflect the operands of '--owner' and '-